Re: [gentoo-dev] [PATCH] metadata/install-qa-check.d: add 60tmpfiles-path QA check

2021-08-13 Thread Ulrich Mueller
> On Fri, 13 Aug 2021, David Seifert wrote: > On Mon, 2021-08-09 at 19:50 +0200, Thomas Deutschmann wrote: >> Interesting. You don't even now my view on this but you already have >> an opinion and are saying that I am the culprit. I think this is >> called "prejudiced". > To this day, we're

Re: [gentoo-dev] [PATCH] metadata/install-qa-check.d: add 60tmpfiles-path QA check

2021-08-13 Thread David Seifert
On Mon, 2021-08-09 at 19:50 +0200, Thomas Deutschmann wrote: > On 2021-08-08 13:17, David Seifert wrote: > > So you've created a big commotion... because you didn't get the > > initial > > point? Honestly, this seems to be a recurring theme at this point. > > Someone suggests some improved

Re: [gentoo-dev] [PATCH] metadata/install-qa-check.d: add 60tmpfiles-path QA check

2021-08-09 Thread Thomas Deutschmann
On 2021-08-08 13:17, David Seifert wrote: So you've created a big commotion... because you didn't get the initial point? Honestly, this seems to be a recurring theme at this point. Someone suggests some improved check/some change, and nowadays you can bet 50 quid that Whissi will pop up and

Re: [gentoo-dev] [PATCH] metadata/install-qa-check.d: add 60tmpfiles-path QA check

2021-08-08 Thread David Seifert
On Wed, 2021-08-04 at 14:35 +0200, Thomas Deutschmann wrote: > On 2021-08-04 04:56, Sam James wrote: > > Sure, thanks for the clarification. It's deprecated in the sense of > > ebuilds installing to it though, right? > > Well, it triggered me because saying it's deprecated implies two > things >

Re: [gentoo-dev] [PATCH] metadata/install-qa-check.d: add 60tmpfiles-path QA check

2021-08-06 Thread Matt Turner
On Wed, Aug 4, 2021 at 5:35 AM Thomas Deutschmann wrote: > > On 2021-08-04 04:56, Sam James wrote: > > Sure, thanks for the clarification. It's deprecated in the sense of > > ebuilds installing to it though, right? > > Well, it triggered me because saying it's deprecated implies two things > for

Re: [gentoo-dev] [PATCH] metadata/install-qa-check.d: add 60tmpfiles-path QA check

2021-08-04 Thread Alec Warner
On Tue, Aug 3, 2021 at 7:56 PM Sam James wrote: > > > > > On 4 Aug 2021, at 03:39, Thomas Deutschmann wrote: > > > > On 2021-08-01 01:56, Sam James wrote: > >> 1) Verify packages don't install tmpfiles to /etc/tmpfiles.d, which > >> is a deprecated location; > > > > This location is _not_

Re: [gentoo-dev] [PATCH] metadata/install-qa-check.d: add 60tmpfiles-path QA check

2021-08-04 Thread Thomas Deutschmann
On 2021-08-04 04:56, Sam James wrote: Sure, thanks for the clarification. It's deprecated in the sense of ebuilds installing to it though, right? Well, it triggered me because saying it's deprecated implies two things for me: 1) It was OK for packages to do that in the past 2) Something

Re: [gentoo-dev] [PATCH] metadata/install-qa-check.d: add 60tmpfiles-path QA check

2021-08-03 Thread Sam James
> On 4 Aug 2021, at 03:39, Thomas Deutschmann wrote: > > On 2021-08-01 01:56, Sam James wrote: >> 1) Verify packages don't install tmpfiles to /etc/tmpfiles.d, which >> is a deprecated location; > > This location is _not_ deprecated. > > This is the location for the local system

Re: [gentoo-dev] [PATCH] metadata/install-qa-check.d: add 60tmpfiles-path QA check

2021-08-03 Thread Thomas Deutschmann
On 2021-08-01 01:56, Sam James wrote: 1) Verify packages don't install tmpfiles to /etc/tmpfiles.d, which is a deprecated location; This location is _not_ deprecated. This is the location for the local system administrator to override tmpfiles.d specifications installed by packages which

Re: [gentoo-dev] [PATCH] metadata/install-qa-check.d: add 60tmpfiles-path QA check

2021-08-02 Thread Georgy Yakovlev
On Monday, August 2, 2021 1:30:07 AM PDT Michał Górny wrote: > On Mon, 2021-08-02 at 01:28 -0700, Georgy Yakovlev wrote: > > it can actually check if ebuild calls tmpfiles_process, not only > > inherit. > > something like: > > > > local pkg_postinst_body="$(declare -fp pkg_postinst)" > >

Re: [gentoo-dev] [PATCH] metadata/install-qa-check.d: add 60tmpfiles-path QA check

2021-08-02 Thread Michał Górny
On Mon, 2021-08-02 at 01:28 -0700, Georgy Yakovlev wrote: > it can actually check if ebuild calls tmpfiles_process, not only > inherit. > something like: > >     local pkg_postinst_body="$(declare -fp pkg_postinst)" >     if [[ ! ${pkg_postinst_body} == *tmpfiles_process* ]]; then >    

Re: [gentoo-dev] [PATCH] metadata/install-qa-check.d: add 60tmpfiles-path QA check

2021-08-02 Thread Georgy Yakovlev
On Saturday, July 31, 2021 4:56:34 PM PDT Sam James wrote: > This adds two tmpfiles related QA checks: > 1) Verify packages don't install tmpfiles to /etc/tmpfiles.d, which > is a deprecated location; > > 2) Check whether packages inherit tmpfiles.eclass if they're > installing files to

Re: [gentoo-dev] [PATCH] metadata/install-qa-check.d: add 60tmpfiles-path QA check

2021-08-01 Thread Mike Gilbert
On Sun, Aug 1, 2021 at 1:24 PM Sam James wrote: > > > > > On 1 Aug 2021, at 17:42, Mike Gilbert wrote: > > > > On Sat, Jul 31, 2021 at 7:56 PM Sam James wrote: > >> > >> This adds two tmpfiles related QA checks: > >> 1) Verify packages don't install tmpfiles to /etc/tmpfiles.d, which > >> is a

Re: [gentoo-dev] [PATCH] metadata/install-qa-check.d: add 60tmpfiles-path QA check

2021-08-01 Thread Sam James
> On 1 Aug 2021, at 17:42, Mike Gilbert wrote: > > On Sat, Jul 31, 2021 at 7:56 PM Sam James wrote: >> >> This adds two tmpfiles related QA checks: >> 1) Verify packages don't install tmpfiles to /etc/tmpfiles.d, which >> is a deprecated location; > > sys-apps/systemd calls keepdir

Re: [gentoo-dev] [PATCH] metadata/install-qa-check.d: add 60tmpfiles-path QA check

2021-08-01 Thread Mike Gilbert
On Sat, Jul 31, 2021 at 7:56 PM Sam James wrote: > > This adds two tmpfiles related QA checks: > 1) Verify packages don't install tmpfiles to /etc/tmpfiles.d, which > is a deprecated location; sys-apps/systemd calls keepdir /etc/tmpfiles.d so that users don't get confused by a missing directory.

Re: [gentoo-dev] [PATCH] metadata/install-qa-check.d: add 60tmpfiles-path QA check

2021-08-01 Thread Michał Górny
On Sun, 2021-08-01 at 00:56 +0100, Sam James wrote: > This adds two tmpfiles related QA checks: > 1) Verify packages don't install tmpfiles to /etc/tmpfiles.d, which > is a deprecated location; > > 2) Check whether packages inherit tmpfiles.eclass if they're > installing files to

[gentoo-dev] [PATCH] metadata/install-qa-check.d: add 60tmpfiles-path QA check

2021-07-31 Thread Sam James
This adds two tmpfiles related QA checks: 1) Verify packages don't install tmpfiles to /etc/tmpfiles.d, which is a deprecated location; 2) Check whether packages inherit tmpfiles.eclass if they're installing files to /usr/lib/tmpfiles.d. (This helps to catch packages not calling tmpfiles_process