Re: [gentoo-dev] RFC: media-sound/xmms2/xmms2-0.7.ebuild

2010-06-29 Thread Mike Frysinger
if [[ -z $1 ]]; then either lose the quotes or lose the double brackets. hint: the former. echo !!! xmms2_flag() called without a parameter. 2 echo !!! xmms2_flag() USEFLAG [xmms2_flagname] 2 use eerror or die if use $1; then USE

Re: [gentoo-dev] RFC: media-sound/xmms2/xmms2-0.7.ebuild

2010-06-29 Thread Łukasz Michalik
On 02:24 2010-06-29 -0400, Mike Frysinger wrote: --destdir=${D} \ you need to give the DESTDIR to configure ? no wonder xmms2 sucks It's not a need -- with waf destdir can be set at either configure or install time. -- Pozdrawiam, Łukasz P. Michalik

Re: [gentoo-dev] RFC: media-sound/xmms2/xmms2-0.7.ebuild (v2)

2010-06-29 Thread Sergei Trofimovich
--destdir=${D} \ you need to give the DESTDIR to configure ? no wonder xmms2 sucks Completely my fault. Moreover it ignores the option in configure phase (same with '--without-ldconfig') ${CTARGET:+--with-target-platform=${CTARGET}} i highly suspect

Re: [gentoo-dev] RFC: media-sound/xmms2/xmms2-0.7.ebuild (v2)

2010-06-29 Thread Mike Frysinger
return 0 nowhere do you check the return value of xmms2_flag, so not much point in returning a value (also, the eerror path no longer returns 1) ${CHOST:+--with-target-platform=${CHOST}} \ CHOST is guaranteed to always be set, so no need for the ${VAR:+} magic

Re: [gentoo-dev] RFC: media-sound/xmms2/xmms2-0.7.ebuild (v3)

2010-06-29 Thread Sergei Trofimovich
/me amends. Third one! Is there way to declare locals directly in 'for' loops? -- Sergei # Copyright 1999-2010 Gentoo Foundation # Distributed under the terms of the GNU General Public License v2 # $Header: $ EAPI=2 inherit base eutils python MY_P=${P}DrNo DESCRIPTION=X(cross)platform

Re: [gentoo-dev] RFC: media-sound/xmms2/xmms2-0.7.ebuild (v3)

2010-06-29 Thread Mike Frysinger
On Tuesday, June 29, 2010 15:44:56 Sergei Trofimovich wrote: Is there way to declare locals directly in 'for' loops? no -mike signature.asc Description: This is a digitally signed message part.

[gentoo-dev] RFC: media-sound/xmms2/xmms2-0.7.ebuild

2010-06-28 Thread Sergei Trofimovich
There is yet 'New Package' request: https://bugs.gentoo.org/show_bug.cgi?id=93583 I think I've hacked more or less maintainable ebuild (attached) and plan to maintain media-sound/xmms2 but one thing worries me: package (and ebuild) has ruby, python and perl bindings. I need help to check/fix