Re: [gentoo-dev] Re: New eclass: scons.eclass

2010-08-24 Thread Mike Frysinger
On Monday, August 23, 2010 11:42:49 Michał Górny wrote: On Sun, 22 Aug 2010 17:06:22 -0400 Mike Frysinger wrote: local varname=${2:-${flag}} should be stripping possible leading ! so that people can do `use_scons !foo moo` just like they can today with `use_with $foo moo` Could you

Re: [gentoo-dev] Re: New eclass: scons.eclass

2010-08-23 Thread Michał Górny
On Sun, 22 Aug 2010 23:03:44 +0200 Maciej Mrozowski reave...@gmail.com wrote: I'd suggest providing all src_* phases except src_unpack. Providing a blank src_configure() would be fine but... Even src_prepare that calls base_src_prepare - to get PATCHES and epatch_user support - for

Re: [gentoo-dev] Re: New eclass: scons.eclass

2010-08-23 Thread Maciej Mrozowski
On Monday 23 of August 2010 17:11:47 Michał Górny wrote: On Sun, 22 Aug 2010 23:03:44 +0200 Maciej Mrozowski reave...@gmail.com wrote: I'd suggest providing all src_* phases except src_unpack. Providing a blank src_configure() would be fine but... Even src_prepare that calls

[gentoo-dev] Re: New eclass: scons.eclass

2010-08-22 Thread Michał Górny
Here goes the second revision. A short changelog: 83678d1 Export a default pkg_setup() and src_compile(). 7f9b565 Introduce escons() function (similar to emake). 19b7e14 Use underscores instead of dashes in function names. Attaching both the new rev and a diff against the first one. -- Best

Re: [gentoo-dev] Re: New eclass: scons.eclass

2010-08-22 Thread Maciej Mrozowski
On Sunday 22 of August 2010 20:39:23 Michał Górny wrote: Here goes the second revision. A short changelog: 83678d1 Export a default pkg_setup() and src_compile(). 7f9b565 Introduce escons() function (similar to emake). 19b7e14 Use underscores instead of dashes in function names. Attaching

Re: [gentoo-dev] Re: New eclass: scons.eclass

2010-08-22 Thread Tomáš Chvátal
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Dne 22.8.2010 23:06, Mike Frysinger napsal(a): scons_use() keep the use_xxx style ... so rename it to use_scons() local varname=${2:-${flag}} should be stripping possible leading ! so that people can do `use_scons !foo moo` just

Re: [gentoo-dev] Re: New eclass: scons.eclass

2010-08-22 Thread Tomáš Chvátal
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Dne 22.8.2010 23:18, Mike Frysinger napsal(a): On Sunday, August 22, 2010 17:10:32 Tomáš Chvátal wrote: Dne 22.8.2010 23:06, Mike Frysinger napsal(a): scons_use() keep the use_xxx style ... so rename it to use_scons() Hmm we use

Re: [gentoo-dev] Re: New eclass: scons.eclass

2010-08-22 Thread Luca Barbato
On 08/22/2010 08:39 PM, Michał Górny wrote: Here goes the second revision. A short changelog: 83678d1 Export a default pkg_setup() and src_compile(). 7f9b565 Introduce escons() function (similar to emake). 19b7e14 Use underscores instead of dashes in function names. Attaching both the new

Re: [gentoo-dev] Re: New eclass: scons.eclass

2010-08-22 Thread Mike Frysinger
On Sunday, August 22, 2010 17:10:32 Tomáš Chvátal wrote: Dne 22.8.2010 23:06, Mike Frysinger napsal(a): scons_use() keep the use_xxx style ... so rename it to use_scons() Hmm we use cmake-utils_use_* i think use_cmake-utils-* also if renamed to cmake_use-* it would look more sane

Re: [gentoo-dev] Re: New eclass: scons.eclass

2010-08-22 Thread Mike Frysinger
# @CODE # Michał Górny gen...@mgorny.alt.pl # @CODE this is not what @code is designed for. punt it. : ${SCONS_MIN_VERSION} useless statement. punt it. : ${EXTRA_ESCONS:=} replace with @DEFAULT_UNSET scons ${MAKEOPTS} ${EXTRA_ESCONS} $...@} this should be echoed just like

Re: [gentoo-dev] Re: New eclass: scons.eclass

2010-08-22 Thread Mike Frysinger
On Sunday, August 22, 2010 17:32:11 Tomáš Chvátal wrote: Dne 22.8.2010 23:18, Mike Frysinger napsal(a): On Sunday, August 22, 2010 17:10:32 Tomáš Chvátal wrote: Dne 22.8.2010 23:06, Mike Frysinger napsal(a): scons_use() keep the use_xxx style ... so rename it to use_scons() Hmm we