Dnia 2013-08-20, o godz. 13:01:34
Michał Górny mgo...@gentoo.org napisał(a):
Due to the widespread breakage in the tree noted in bug #480892 [1],
and mis-design of multilib-minimal.eclass, we'd like to put some more
work into getting einstalldocs() ready for EAPI 6.
When it's mostly
Dnia 2013-08-21, o godz. 12:33:14
Ulrich Mueller u...@gentoo.org napisał(a):
On Wed, 21 Aug 2013, Michał Górny wrote:
Proposed implementation follows:
einstalldocs() {
if ! declare -p DOCS /dev/null ; then
local d
for d in README* ChangeLog AUTHORS NEWS TODO
Dnia 2013-08-21, o godz. 14:49:45
Pacho Ramos pa...@gentoo.org napisał(a):
El mié, 21-08-2013 a las 14:35 +0200, Ulrich Mueller escribió:
On Wed, 21 Aug 2013, Pacho Ramos wrote:
Could appending to DOCS be allowed? I have seen a lot of time of me
needing to install all docs manually
Second version:
einstalldocs() {
if ! declare -p DOCS /dev/null ; then
local d
for d in README* ChangeLog AUTHORS NEWS TODO CHANGES \
THANKS BUGS FAQ CREDITS CHANGELOG ; do
[[ -s ${d} ]] dodoc ${d}
done
elif [[ $(declare -p DOCS) ==
On Thu, 22 Aug 2013, Michał Górny wrote:
Second version:
Looks good to me.
One minor non-technical point: Could you use double quotes instead of
single quotes around declare -a, for better readability? Last time
we had single quotes they ended up as backquotes in the devmanual and
from there
Dnia 2013-08-20, o godz. 13:01:34
Michał Górny mgo...@gentoo.org napisał(a):
Hello,
Due to the widespread breakage in the tree noted in bug #480892 [1],
and mis-design of multilib-minimal.eclass, we'd like to put some more
work into getting einstalldocs() ready for EAPI 6.
When it's
On Wed, 21 Aug 2013, Michał Górny wrote:
Proposed implementation follows:
einstalldocs() {
if ! declare -p DOCS /dev/null ; then
local d
for d in README* ChangeLog AUTHORS NEWS TODO CHANGES \
THANKS BUGS FAQ CREDITS CHANGELOG ; do
[[ -s
On 08/20/2013 01:01 PM, Michał Górny wrote:
Hello,
Due to the widespread breakage in the tree noted in bug #480892 [1],
and mis-design of multilib-minimal.eclass, we'd like to put some more
work into getting einstalldocs() ready for EAPI 6.
What mis-design?
On Wed, 21 Aug 2013, Ulrich Mueller wrote:
On Wed, 21 Aug 2013, Michał Górny wrote:
Proposed implementation follows:
elif [[ $(declare -p DOCS) == declare -a * ]] ; then
I forgot about another issue pointed out by Arfrever some time ago.
We may want to change the above to declare -a*
El mié, 21-08-2013 a las 11:52 +0200, Michał Górny escribió:
Dnia 2013-08-20, o godz. 13:01:34
Michał Górny mgo...@gentoo.org napisał(a):
Hello,
Due to the widespread breakage in the tree noted in bug #480892 [1],
and mis-design of multilib-minimal.eclass, we'd like to put some more
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 08/20/2013 01:01 PM, Michał Górny wrote:
Hello,
Due to the widespread breakage in the tree noted in bug #480892
[1], and mis-design of multilib-minimal.eclass, we'd like to put
some more work into getting einstalldocs() ready for EAPI 6.
Ok,
El mié, 21-08-2013 a las 13:45 +0200, hasufell escribió:
On 08/20/2013 01:01 PM, Michał Górny wrote:
Hello,
Due to the widespread breakage in the tree noted in bug #480892
[1], and mis-design of multilib-minimal.eclass, we'd like to put
some more work into getting einstalldocs() ready
On Wed, 21 Aug 2013, Pacho Ramos wrote:
Could appending to DOCS be allowed? I have seen a lot of time of me
needing to install all docs manually only to add a doc file over
default DOCS. Would be interesting to simply do: DOCS+=( otherfile )
instead of needing to specify all files handled
El mié, 21-08-2013 a las 14:35 +0200, Ulrich Mueller escribió:
On Wed, 21 Aug 2013, Pacho Ramos wrote:
Could appending to DOCS be allowed? I have seen a lot of time of me
needing to install all docs manually only to add a doc file over
default DOCS. Would be interesting to simply do:
On Wed, 21 Aug 2013, Michał Górny wrote:
elif [[ $(declare -p DOCS) == declare -a * ]] ; then
Thinking about it again, the pattern matching (already present in
default_src_install of EAPI 4) is brittle and relies on the output
of declare -p whose exact format is undocumented.
Maybe we
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 21/08/13 07:45 AM, hasufell wrote:
On 08/20/2013 01:01 PM, Michał Górny wrote:
Hello,
Due to the widespread breakage in the tree noted in bug #480892
[1], and mis-design of multilib-minimal.eclass, we'd like to put
some more work into
20.08.2013 17:22, Sergey Popov пишет:
20.08.2013 17:02, Michał Górny пишет:
Is there a future-eapi bug open for it? If not, please open one.
I will, thanks
Here it is: https://bugs.gentoo.org/show_bug.cgi?id=481980
--
Best regards, Sergey Popov
Gentoo developer
Gentoo Desktop-effects
On Wed, 21 Aug 2013, I wrote:
Maybe we could change the test for an array to the following?
elif ! declare +a DOCS /dev/null; then
I retract this suggestion. It doesn't work because of issues with
local and global scope.
Sorry for the noise.
Ulrich
Hello,
Due to the widespread breakage in the tree noted in bug #480892 [1],
and mis-design of multilib-minimal.eclass, we'd like to put some more
work into getting einstalldocs() ready for EAPI 6.
When it's mostly defined, we'd like to backport it to eutils.eclass so
that we could use it to fix
On Tue, 20 Aug 2013, Michał Górny wrote:
1. Name
- einstalldocs
-- probably the least confusing one, consistent with emake
Go for it.
2. Support for HTML_DOCS
I've no strong opinion about this one.
But if you are going to add it, then please support both array and
whitespace
On 08/20/2013 01:54 PM, Ulrich Mueller wrote:
For example, hasufell has suggested checking ${DOCS// /} to support
DOCS=' ' as well.
Looks like over-engineering to me. Are there any use cases for it?
No, just caution, so we don't have to realize that our default
src_install is broken
20.08.2013 16:08, hasufell пишет:
I don't see how defining phases explicitly improves readability which
even increases chances of overwriting phases by accident and having
further complications especially in multilib eclasses.
DOCS=( foo* )
looks pretty readable to me
I am not for nor
Dnia 2013-08-20, o godz. 16:26:10
Sergey Popov pinkb...@gentoo.org napisał(a):
20.08.2013 16:08, hasufell пишет:
I don't see how defining phases explicitly improves readability which
even increases chances of overwriting phases by accident and having
further complications especially in
Dnia 2013-08-20, o godz. 14:08:51
hasufell hasuf...@gentoo.org napisał(a):
On 08/20/2013 01:54 PM, Ulrich Mueller wrote:
4. Globbing support in DOCS array
5. Appending to DOCS
Creeping featurism. Define an explicit src_install if you need any of
these, and I'm sure it will improve
20.08.2013 17:02, Michał Górny пишет:
Is there a future-eapi bug open for it? If not, please open one.
I will, thanks
I myself don't have anything against plain 'dodoc -r'. But I wonder if
this isn't going to end up with people considering 'what if my
directory has .svn/CVS in it?'
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 20/08/13 08:08 AM, hasufell wrote:
On 08/20/2013 01:54 PM, Ulrich Mueller wrote:
4. Globbing support in DOCS array 5. Appending to DOCS
Creeping featurism. Define an explicit src_install if you need
any of these, and I'm sure it will
On Tue, 20 Aug 2013 13:01:34 +0200
Michał Górny mgo...@gentoo.org wrote:
3. Support DOCS=() / DOCS='' to disable dodoc
https://bugs.gentoo.org/show_bug.cgi?id=463736
Well, this one is mostly what the bug is about. I think we should just
do it. Implementation could be discussed a bit
27 matches
Mail list logo
