Re: [gentoo-dev] [PATCH] .editorconfig: add

2023-03-24 Thread Maciej Barć
Finally, +1 from me. I think I had proposed either ".dir-locals.el" or ".editorconfig" for ::guru which was rejected because "users should configure this themselves". Reviewing the given configuration I think the only one variable that can be moved to top ("[*]" section) is "charset = utf-8".

Re: [gentoo-dev] [PATCH] .editorconfig: add

2023-03-24 Thread Ulrich Mueller
> On Fri, 24 Mar 2023, Adrian Schollmeyer wrote: >> Then again, it doesn't even say that they represent 4 spaces. > Is that really important? I don't think we should force a tab width > for the user if we don't have a good reason to do so. The good thing > about tabs is that the user can set

Re: [gentoo-dev] [PATCH] .editorconfig: add

2023-03-24 Thread Adrian Schollmeyer
Hi, Am Freitag, dem 24.03.2023 um 09:17 +0100 schrieb Ulrich Mueller: > But what does it do, effectively? Apart from the common-sense > settings (utf-8, no trailing whitespace, etc.) which should be the > default for every editor, *should*. And just because it's the default doesn't mean a user

Re: [gentoo-dev] [PATCH] .editorconfig: add

2023-03-24 Thread Sam James
Ulrich Mueller writes: > [[PGP Signed Part:Undecided]] >> On Fri, 24 Mar 2023, Florian Schmaus wrote: > >>> Then it looks wrong, conceptually. Or would it be o.k. if I committed >>> ebuild-mode.el to the top-level directory of the Gentoo repository? > >> I do not think the comparison with

Re: [gentoo-dev] [PATCH] .editorconfig: add

2023-03-24 Thread Ulrich Mueller
> On Fri, 24 Mar 2023, Florian Schmaus wrote: >> Then it looks wrong, conceptually. Or would it be o.k. if I committed >> ebuild-mode.el to the top-level directory of the Gentoo repository? > I do not think the comparison with ebuild-mode.el is sound: > ebuild-mode.el appears imperative,

Re: [gentoo-dev] [PATCH] .editorconfig: add

2023-03-24 Thread Florian Schmaus
On 24/03/2023 05.46, Ulrich Mueller wrote: On Fri, 24 Mar 2023, Sam James wrote: I'm slightly confused. What repository is this intended for? gentoo.git. Then it looks wrong, conceptually. Or would it be o.k. if I committed ebuild-mode.el to the top-level directory of the Gentoo

Re: [gentoo-dev] [PATCH] .editorconfig: add

2023-03-23 Thread Michał Górny
On Fri, 2023-03-24 at 02:14 +, Sam James wrote: > This allows conveniently editing ebuilds and eclasses in editors which don't > have a specific ebuild mode like Emacs and Vim do. > > For example, kde-apps/kate with kde-frameworks/ktexteditor[editorconfig] can > automatically read this file

Re: [gentoo-dev] [PATCH] .editorconfig: add

2023-03-23 Thread Sam James
Ulrich Mueller writes: > [[PGP Signed Part:Undecided]] >> On Fri, 24 Mar 2023, Sam James wrote: > >> The idea is to make other editors less-hostile when they don't have >> a dedicated mode (like I said in the commit message). The specific >> reason for doing this is because it's editor

Re: [gentoo-dev] [PATCH] .editorconfig: add

2023-03-23 Thread Ulrich Mueller
> On Fri, 24 Mar 2023, Sam James wrote: > The idea is to make other editors less-hostile when they don't have > a dedicated mode (like I said in the commit message). The specific > reason for doing this is because it's editor agnostic. But is it? Emacs and Vim don't seem to natively support

Re: [gentoo-dev] [PATCH] .editorconfig: add

2023-03-23 Thread Sam James
Ulrich Mueller writes: > [[PGP Signed Part:Undecided]] >> On Fri, 24 Mar 2023, Sam James wrote: > >>> I'm slightly confused. What repository is this intended for? > >> gentoo.git. > > Then it looks wrong, conceptually. Or would it be o.k. if I committed > ebuild-mode.el to the top-level

Re: [gentoo-dev] [PATCH] .editorconfig: add

2023-03-23 Thread Ulrich Mueller
> On Fri, 24 Mar 2023, Sam James wrote: >> I'm slightly confused. What repository is this intended for? > gentoo.git. Then it looks wrong, conceptually. Or would it be o.k. if I committed ebuild-mode.el to the top-level directory of the Gentoo repository? Seriously, these are generic

Re: [gentoo-dev] [PATCH] .editorconfig: add

2023-03-23 Thread Sam James
Ulrich Mueller writes: > [[PGP Signed Part:Undecided]] >> On Fri, 24 Mar 2023, Sam James wrote: > >> This allows conveniently editing ebuilds and eclasses in editors which don't >> have a specific ebuild mode like Emacs and Vim do. > > I'm slightly confused. What repository is this intended

Re: [gentoo-dev] [PATCH] .editorconfig: add

2023-03-23 Thread Ulrich Mueller
> On Fri, 24 Mar 2023, Sam James wrote: > This allows conveniently editing ebuilds and eclasses in editors which don't > have a specific ebuild mode like Emacs and Vim do. I'm slightly confused. What repository is this intended for? signature.asc Description: PGP signature