Re: [gentoo-dev] Lastrites: media-sound/seq24

[Alexis Ballier]

On Sat, 16 Jan 2016 11:13:44 +0100
Pacho Ramos  wrote:

> # Pacho Ramos  (16 Jan 2016)
> # Dead for years, not compatible with latest libsigc++ (#569514), it
> # requires either a lot of patching or move to a forked project that
> tries
> # to continue it. Removal in a month.
> media-sound/seq24

canceled: I've added a new (fixed) upstream release and removed the
pmask

Re: [gentoo-dev] Re: New packages up for grabs

[Hans de Graaff]

On Mon, 2016-01-25 at 01:43 -0600, »Q« wrote:

> If you've got enough cycles to spare, I'd love to see an ebuild for
> leafnode-2.  I realize that's asking a lot and that upstream's
> apparent position is that it will be in perpetual alpha. 
> 

Not likely given that my time for Gentoo is already too much overbooked
, and with upstream declaring perpetual alpha there is not much
incentive on my side, to be honest.

Hans

signature.asc
Description: This is a digitally signed message part

[gentoo-dev] Re: New Eclasses: postgres and postgres-multi

[Jonathan Callen]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

On 01/25/2016 07:29 AM, Aaron W. Swenson wrote:
> On 2016-01-24 18:44, Michael Orlitzky wrote:
>> On 01/24/2016 06:29 PM, Aaron W. Swenson wrote:
>>> Okay, provided that the new USE_EXPAND is okay for
>>> POSTGRES_TARGETS, attached are the eclasses that I'll commit to
>>> the tree.
>>> 
>> 
>>> case ${EAPI:-0} in 0|1|2|3|4) die "postgres-multi.eclass
>>> requires EAPI 5 or higher" ;; *) ;; esac
>> 
>> Does this really work with EAPI=6? I didn't try, but it looks
>> like it would need an eapply_user somewhere in src_prepare. And,
>> pedantry warning, there's no such thing as "EAPI 5 or higher."
>> The lawyers will tell you to do something like this instead
>> (stolen from git-r3):
>> 
>> case "${EAPI:-0}" in 5|6) ;; *) die "Unsupported EAPI=${EAPI}
>> (unknown) for ${ECLASS}" ;; esac
>> 
>> That will require an edit for every new EAPI, but prevents weird
>> crashes from things like a missing eapply_user.
>> 
>> 
> 
> Thank you.
> 
> I've added the eapply_user to postgres-multi and modified the case 
> condition to match the hot goods you're selling on the sly.
> 

You missed the fix for EAPI in postgres-multi.eclass (it looks okay in
the other eclass, though).

- -- 
Jonathan Callen
-BEGIN PGP SIGNATURE-
Version: GnuPG v2

iQIcBAEBCgAGBQJWpukoAAoJEEIQbvYRB3mgD/8P/iCbnkSZGcwnbQ7EsV55apJ+
+AqzVJVbgvNkrK23JysYfDcT9Qthld5W1CX66YBg38PBJbDHrQPZQiAYypybVxo8
Liv8P2O4smBdYhIdFfcMw6ARyOpfRec1kiYiZr0YI/sM1pQF/UV2RuG+zJJILMwJ
f3gNoRN0u58hMX5F1LZn0vRcrp9FqovNy1MMQ83u1qZp6SwK81IZFmHXoyyEWmaO
zh1plMRfs9iD7DK6CzHBvRyIyShzJGcNLOkNM7qKU5GhAXi7bWuwx5ZZpD1peWLI
Rn9xXfffyA62eU7EGvUQG/PuAU1PErT9+nFhH6qqSBnOpcR3kFO8a5zgfLHogzJT
cDQf4XU9MxDCjvSF2c/2tnt1tXqBO7CTjvsaIgaok8vzLsmh6wwJCiqGb80gRWX7
4HIAKqH1QbBLfPkb54NQp8ixw1b+LmtcbgJQrpXpxJTrUqtnJKDaaXKblFO8eOW2
LeLYYxdzEz3rh6RiqT7NZ3iKKP6cFy7S4qlfe4qsXD7mns1eIqcx9Hdt8LuwDMnC
zGLb7TBThrhBTt1gRdsXNDZUhkO5YohNqIgeUO1+bEnWS2UGZNf4Mv69HZTgipLO
vZ2vPFevEW5zAqj8kXgZQjuyrq59TlCY9l2q/etf4oxk6e2Sge1TZ8dcfLA9kJ/E
SIdeJ4XRl36+p1ANzG6c
=F4Y9
-END PGP SIGNATURE-

Re: [gentoo-dev] New packages up for grabs

[Daniel Campbell]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 01/24/2016 03:32 PM, Michał Górny wrote:
> Hello, everyone.
> 
> As a result of disbanding a few herds, we some new 
> maintainer-needed packages.
> 
> Here's the complete list:
> 
> app-cdr/bashburn dev-util/astyle
> 

I'll take those two. I use astyle to format code and rarely use
bashburn.  Looks like it's not had an update in almost 5 years; should
be easy to maintain.

Thanks for producing the list. Quite a handful of packages that are
worth holding onto, but I don't use them anymore so I wouldn't be doing
them a good service by taking them.

- -- 
Daniel Campbell - Gentoo Developer
OpenPGP Key: 0x1EA055D6 @ hkp://keys.gnupg.net
fpr: AE03 9064 AE00 053C 270C  1DE4 6F7A 9091 1EA0 55D6
-BEGIN PGP SIGNATURE-
Version: GnuPG v2

iQIcBAEBCAAGBQJWppDoAAoJEAEkDpRQOeFwidwQALb1qyP5KzKej3PTGJI+hPTJ
T3YfzKQOk7BvLxA/CIx9YKdctVvDNyKO3gXIRILuqSr9F69YsQ21Zr31WC9vELTD
nhXbgYfTuXM1hpZ8gvEKAI3aLMWy9XHEmS13Su4FznsGOpltK/CeNKZzSC9pXtIM
Q3n/jD/Unh8M3TRCESEnW6zRDDfh4TAbaHGSYfUP0LJnqP4ujHIMhrI2/ujP071r
ZW5lrxGrXxE/I3k2CruUUlJA6MWGgsExkZzdJnzUYkD2gZz0d5qgqDN/iRqAMp9O
2n9FOGQ0r4qBMVUmJ0OzT0pELU4iKuQiM72yTPq6c96SKjDV8jSo3962GrmqXk8S
ame1jrWBIved24A4reMr9491kjLBEbemgWnMSyKw4FlrwqH9rrkzuQnmhWvCgP23
jgr99Uo5Z0/Olu77eDA7Sn1Q/j89GLrPYK5riuJhnhbUwqLhA77ZKt249QDNp0Ew
OvmlMkuXp4pIZuBwNrZj9fZCUO5drlejEFrgURWcWcMpEfXZu19GCqy4w6eS3zNm
wKFpa0NaSQRJivyn1HwIjyXUyYOT90YVCh4p2UVogVYl7hiYtS/+kg+8ja3uuPov
sAg1Q4eoMXvxNECMYaIcnB5KOOHwS4ilZnCEsdHx6cFv9VElvei1QykUmTwLOe/4
ZVHTCSRQPg+OHJ5J67oE
=PF1m
-END PGP SIGNATURE-

[gentoo-dev] [PATCH 2/3] cmake-utils.eclass: Drop empty line

[Justin Lecher]

Signed-off-by: Justin Lecher 
---
 eclass/cmake-utils.eclass | 1 -
 1 file changed, 1 deletion(-)

diff --git a/eclass/cmake-utils.eclass b/eclass/cmake-utils.eclass
index fb7f5ca..01de9a5 100644
--- a/eclass/cmake-utils.eclass
+++ b/eclass/cmake-utils.eclass
@@ -20,7 +20,6 @@
 if [[ -z ${_CMAKE_UTILS_ECLASS} ]]; then
 _CMAKE_UTILS_ECLASS=1
 
-
 # @ECLASS-VARIABLE: BUILD_DIR
 # @DESCRIPTION:
 # Build directory where all cmake processed files should be generated.
-- 
2.7.0

[gentoo-dev] [PATCH 3/3] cmake-utils.eclass: Define default EAPI to 0

[Justin Lecher]

Signed-off-by: Justin Lecher 
---
 eclass/cmake-utils.eclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/eclass/cmake-utils.eclass b/eclass/cmake-utils.eclass
index 01de9a5..23339ab 100644
--- a/eclass/cmake-utils.eclass
+++ b/eclass/cmake-utils.eclass
@@ -112,7 +112,7 @@ _CMAKE_UTILS_ECLASS=1
 # for econf and is needed to pass TRY_RUN results when cross-compiling.
 # Should be set by user in a per-package basis in /etc/portage/package.env.
 
-case ${EAPI} in
+case ${EAPI:-0} in
2|3|4|5|6) : ;;
*) die "EAPI=${EAPI:-0} is not supported" ;;
 esac
-- 
2.7.0

[gentoo-dev] [PATCH 1/3] cmake-utils.eclass: Use bash internal testing instead of has()

[Justin Lecher]

Signed-off-by: Justin Lecher 
---
 eclass/cmake-utils.eclass | 18 +-
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/eclass/cmake-utils.eclass b/eclass/cmake-utils.eclass
index 9e8e71e..fb7f5ca 100644
--- a/eclass/cmake-utils.eclass
+++ b/eclass/cmake-utils.eclass
@@ -127,7 +127,7 @@ case ${WANT_CMAKE} in
always)
;;
*)
-   has "${EAPI:-0}" 2 3 4 5 || die "WANT_CMAKE is banned in EAPI 6 
and later"
+   [[ ${EAPI} == [2345] ]] || die "WANT_CMAKE is banned in EAPI 6 
and later"
IUSE+=" ${WANT_CMAKE}"
CMAKEDEPEND+="${WANT_CMAKE}? ( "
;;
@@ -164,7 +164,7 @@ _cmake_use_me_now() {
local arg=$2
[[ ! -z $3 ]] && arg=$3
 
-   has "${EAPI:-0}" 2 3 4 5 || die "${FUNCNAME[1]} is banned in EAPI 6 and 
later: use -D$1${arg}=\"\$(usex $2)\" instead"
+   [[ ${EAPI} == [2345] ]] || die "${FUNCNAME[1]} is banned in EAPI 6 and 
later: use -D$1${arg}=\"\$(usex $2)\" instead"
 
local uper capitalised x
[[ -z $2 ]] && die "cmake-utils_use-$1  []"
@@ -186,7 +186,7 @@ _cmake_use_me_now_inverted() {
local arg=$2
[[ ! -z $3 ]] && arg=$3
 
-   if ! has "${EAPI:-0}" 2 3 4 5 && [[ "${FUNCNAME[1]}" != 
cmake-utils_use_find_package ]] ; then
+   if [[ ${EAPI} != [2345] ]] && [[ "${FUNCNAME[1]}" != 
cmake-utils_use_find_package ]] ; then
die "${FUNCNAME[1]} is banned in EAPI 6 and later: use 
-D$1${arg}=\"\$(usex $2)\" insteadss"
fi
 
@@ -283,7 +283,7 @@ cmake_comment_add_subdirectory() {
 # Comment out an add_subdirectory call in CMakeLists.txt in the current 
directory
 # Banned in EAPI 6 and later - use cmake_comment_add_subdirectory instead.
 comment_add_subdirectory() {
-   has "${EAPI:-0}" 2 3 4 5 || die "comment_add_subdirectory is banned in 
EAPI 6 and later - use cmake_comment_add_subdirectory instead"
+   [[ ${EAPI} == [2345] ]] || die "comment_add_subdirectory is banned in 
EAPI 6 and later - use cmake_comment_add_subdirectory instead"
 
cmake_comment_add_subdirectory "$@"
 }
@@ -315,7 +315,7 @@ cmake-utils_use_enable() { _cmake_use_me_now ENABLE_ "$@" ; 
}
 # if foo is enabled and -DCMAKE_DISABLE_FIND_PACKAGE_LibFoo=ON if it is 
disabled.
 # This can be used to make find_package optional.
 cmake-utils_use_find_package() {
-   if ! has "${EAPI:-0}" 2 3 4 5 && [[ "$#" != 2 ]] ; then
+   if [[ ${EAPI} != [2345] ]] && [[ "$#" != 2 ]] ; then
die "Usage: cmake-utils_use_find_package  "
fi
 
@@ -456,7 +456,7 @@ enable_cmake-utils_src_prepare() {
 
pushd "${S}" > /dev/null || die
 
-   if ! has "${EAPI:-0}" 2 3 4 5 ; then
+   if [[ ${EAPI} != [2345] ]]; then
default_src_prepare
_cmake_cleanup_cmake
else
@@ -488,7 +488,7 @@ enable_cmake-utils_src_prepare() {
 enable_cmake-utils_src_configure() {
debug-print-function ${FUNCNAME} "$@"
 
-   has "${EAPI:-0}" 2 3 4 5 && _cmake_cleanup_cmake
+   [[ ${EAPI} == [2345] ]] && _cmake_cleanup_cmake
 
_cmake_check_build_dir
 
@@ -564,7 +564,7 @@ enable_cmake-utils_src_configure() {
fi
fi
 
-   has "${EAPI:-0}" 0 1 2 && ! use prefix && local EPREFIX=
+   [[ ${EAPI} == 2 ]] && ! use prefix && local EPREFIX=
 
if [[ ${EPREFIX} ]]; then
cat >> "${build_rules}" <<- _EOF_ || die
@@ -604,7 +604,7 @@ enable_cmake-utils_src_configure() {
local mycmakeargstype=$(declare -p mycmakeargs 2>&-)
if [[ "${mycmakeargstype}" != "declare -a mycmakeargs="* ]]; then
if [[ -n "${mycmakeargstype}" ]] ; then
-   if has "${EAPI:-0}" 2 3 4 5 ; then
+   if [[ ${EAPI} != [2345] ]]; then
eqawarn "Declaring mycmakeargs as a variable is 
deprecated. Please use an array instead."
else
die "Declaring mycmakeargs as a variable is 
banned in EAPI=${EAPI}. Please use an array instead."
-- 
2.7.0

[gentoo-dev] [PATCH 0/3] RFC: cmake-utils.eclass minor updates

[Justin Lecher]

Hi,

Some minor updates on the EAPI testing in the eclass.

Justin

Justin Lecher (3):
  cmake-utils.eclass: Use bash internal testing instead of has()
  cmake-utils.eclass: Drop empty line
  cmake-utils.eclass: Define default EAPI to 0

 eclass/cmake-utils.eclass | 21 ++---
 1 file changed, 10 insertions(+), 11 deletions(-)

-- 
2.7.0

Re: [gentoo-dev] Re: GLEP 67 is in, please update your metadata.dtd!

[Mike Gilbert]

On Mon, Jan 25, 2016 at 1:45 PM, Martin Vaeth  wrote:
> Mike Gilbert  wrote:
>> On Mon, Jan 25, 2016 at 11:31 AM, Luis Ressel  wrote:
>>>
>>> I might be asking this for a second time, but why does repoman download
>>> the metadata.dtd at all? If one fetches from
>>> git://../gentoo-mirror/gentoo (or via rsync, afaik) it is included
>>> in /usr/portage/metadata/dtd/.
>>
>> repoman is a developer tool. The git repo used by developers does not
>> include metadata.dtd.
>
> repoman is useful for everybody who manages a local
> or public repository. I guess only a small number
> of these people use the developers' git repo.
> (For instance, I am one of these...)
>
> It would be nice if repoman would first check whether
> the file is in some ${repo}/metadata/dtd/
> and download to DISTDIR only as a fallback.
> Or if it can be at least configured (e.g. with an option)
> to check for this file (maybe the path can be configured, too)
> before downloading metadata.dtd.

I agree that this would be a nice enhancement.

[gentoo-dev] Update skel.ebuild for EAPI 6

[Ulrich Mueller]

See patch included below. I have kept the changes at the bare minimum
necessary to update this for EAPI 6. A major rewrite of the file may
be considered later.

Ulrich


From 599ad94e1a2f2961e5ef0175bea01cd1b2eb96f7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ulrich=20M=C3=BCller?= 
Date: Mon, 25 Jan 2016 20:01:26 +0100
Subject: [PATCH] skel.ebuild: Update for EAPI 6.

Put less emphasis on eutils and epatch; they will be used less often
with eapply being available in EAPI 6.

Don't mention ancient EAPIs that are banned.

Don't mention einstall since it is banned.
---
 skel.ebuild | 27 +--
 1 file changed, 5 insertions(+), 22 deletions(-)

diff --git a/skel.ebuild b/skel.ebuild
index d907f9b..0483b53 100644
--- a/skel.ebuild
+++ b/skel.ebuild
@@ -12,22 +12,15 @@
 # generated to contain the correct data.
 
 # The EAPI variable tells the ebuild format in use.
-# Defaults to 0 if not specified.
 # It is suggested that you use the latest EAPI approved by the Council.
 # The PMS contains specifications for all EAPIs. Eclasses will test for this
-# variable if they need to use EAPI > 0 features.
-EAPI=5
+# variable if they need to use features that are not universal in all EAPIs.
+EAPI=6
 
-# inherit lists eclasses to inherit functions from. Almost all ebuilds should
-# inherit eutils, as a large amount of important functionality has been
-# moved there. For example, the epatch call mentioned below wont work
-# without the following line:
+# inherit lists eclasses to inherit functions from. For example, an ebuild
+# that needs the epatch function from eutils.eclass won't work without the
+# following line:
 inherit eutils
-# A well-used example of an eclass function that needs eutils is epatch. If
-# your source needs patches applied, it's suggested to put your patch in the
-# 'files' directory and use:
-#
-#   epatch "${FILESDIR}"/patch-name-here
 #
 # eclasses tend to list descriptions of how to use their functions properly.
 # take a look at /usr/portage/eclass/ for more examples.
@@ -111,7 +104,6 @@ RDEPEND="${DEPEND}"
 
 # The following src_configure function is implemented as default by portage, so
 # you only need to call it if you need a different behaviour.
-# This function is available only in EAPI 2 and later.
 #src_configure() {
# Most open-source packages use GNU autoconf for configuration.
# The default, quickest (and preferred) way of running configure is:
@@ -135,9 +127,6 @@ RDEPEND="${DEPEND}"
 
 # The following src_compile function is implemented as default by portage, so
 # you only need to call it, if you need different behaviour.
-# For EAPI < 2 src_compile runs also commands currently present in
-# src_configure. Thus, if you're using an older EAPI, you need to copy them
-# to your src_compile and drop the src_configure function.
 #src_compile() {
# emake (previously known as pmake) is a script that calls the
# standard GNU make with parallel building options for speedier
@@ -152,8 +141,6 @@ RDEPEND="${DEPEND}"
 
 # The following src_install function is implemented as default by portage, so
 # you only need to call it, if you need different behaviour.
-# For EAPI < 4 src_install is just returing true, so you need to always specify
-# this function in older EAPIs.
 #src_install() {
# You must *personally verify* that this trick doesn't install
# anything outside of DESTDIR; do this by reading and
@@ -178,8 +165,4 @@ RDEPEND="${DEPEND}"
#   install
# Again, verify the Makefiles!  We don't want anything falling
# outside of ${D}.
-
-   # The portage shortcut to the above command is simply:
-   #
-   #einstall
 #}
-- 
2.7.0


pgpOBnF0MWtXY.pgp
Description: PGP signature

Re: [gentoo-dev] Re: GLEP 67 is in, please update your metadata.dtd!

[Alec Warner]

On Mon, Jan 25, 2016 at 10:45 AM, Martin Vaeth  wrote:

> Mike Gilbert  wrote:
> > On Mon, Jan 25, 2016 at 11:31 AM, Luis Ressel  wrote:
> >>
> >> I might be asking this for a second time, but why does repoman download
> >> the metadata.dtd at all? If one fetches from
> >> git://../gentoo-mirror/gentoo (or via rsync, afaik) it is included
> >> in /usr/portage/metadata/dtd/.
> >
> > repoman is a developer tool. The git repo used by developers does not
> > include metadata.dtd.
>
> repoman is useful for everybody who manages a local
> or public repository. I guess only a small number
> of these people use the developers' git repo.
> (For instance, I am one of these...)
>
> It would be nice if repoman would first check whether
> the file is in some ${repo}/metadata/dtd/
> and download to DISTDIR only as a fallback.
> Or if it can be at least configured (e.g. with an option)
> to check for this file (maybe the path can be configured, too)
> before downloading metadata.dtd.
>
> In fact, I was so annoyed by the forced downloading
> (which as mentioned is a permission/security issue)
> that I regularly apply a patch to portage which sets
> the download interval to (almost) infinity.
> Perhaps I am not the only one who did such a hack.
>
>
>

So submit a patch to portage?

-A

[gentoo-dev] Re: GLEP 67 is in, please update your metadata.dtd!

[Martin Vaeth]

Mike Gilbert  wrote:
> On Mon, Jan 25, 2016 at 11:31 AM, Luis Ressel  wrote:
>>
>> I might be asking this for a second time, but why does repoman download
>> the metadata.dtd at all? If one fetches from
>> git://../gentoo-mirror/gentoo (or via rsync, afaik) it is included
>> in /usr/portage/metadata/dtd/.
>
> repoman is a developer tool. The git repo used by developers does not
> include metadata.dtd.

repoman is useful for everybody who manages a local
or public repository. I guess only a small number
of these people use the developers' git repo.
(For instance, I am one of these...)

It would be nice if repoman would first check whether
the file is in some ${repo}/metadata/dtd/
and download to DISTDIR only as a fallback.
Or if it can be at least configured (e.g. with an option)
to check for this file (maybe the path can be configured, too)
before downloading metadata.dtd.

In fact, I was so annoyed by the forced downloading
(which as mentioned is a permission/security issue)
that I regularly apply a patch to portage which sets
the download interval to (almost) infinity.
Perhaps I am not the only one who did such a hack.

Re: [gentoo-dev] GLEP 67 is in, please update your metadata.dtd!

[Mike Gilbert]

On Mon, Jan 25, 2016 at 11:31 AM, Luis Ressel  wrote:
> On Mon, 25 Jan 2016 10:37:15 +0100
> Michał Górny  wrote:
>
>> Hello, everyone.
>>
>> I've finished the GLEP 67 transition last night, and it officially
>> applies to all metadata.xml files now.
>>
>
> Great!
>
>> In order to have repoman apply it correct (and not throw errors on new
>> metadata.xml files), it needs to refetch metadata.dtd. Sadly, this
>> currently happens once a week, so it's better to remove the file
>> manually to force refetch:
>>
>>   rm "$(portageq envvar DISTDIR)"/metadata.dtd
>>
>
> I might be asking this for a second time, but why does repoman download
> the metadata.dtd at all? If one fetches from
> git://../gentoo-mirror/gentoo (or via rsync, afaik) it is included
> in /usr/portage/metadata/dtd/.

repoman is a developer tool. The git repo used by developers does not
include metadata.dtd.

Re: [gentoo-dev] GLEP 67 is in, please update your metadata.dtd!

[Luis Ressel]

On Mon, 25 Jan 2016 10:37:15 +0100
Michał Górny  wrote:

> Hello, everyone.
> 
> I've finished the GLEP 67 transition last night, and it officially
> applies to all metadata.xml files now.
> 

Great!

> In order to have repoman apply it correct (and not throw errors on new
> metadata.xml files), it needs to refetch metadata.dtd. Sadly, this
> currently happens once a week, so it's better to remove the file
> manually to force refetch:
> 
>   rm "$(portageq envvar DISTDIR)"/metadata.dtd
> 

I might be asking this for a second time, but why does repoman download
the metadata.dtd at all? If one fetches from
git://../gentoo-mirror/gentoo (or via rsync, afaik) it is included
in /usr/portage/metadata/dtd/.

For me, it's in fact very annoying when repoman wants to download
metatdata.dtd, as my "normal" unix user isn't a member of the portage
group.

By the way, the herds.xml file is still available at
https://api.gentoo.org/packages/herds.xml and can probably be removed
from there as well.


-- 
Regards,
Luis Ressel

Re: [gentoo-dev] New Eclasses: postgres and postgres-multi

[Ian Stakenvicius]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 23/01/16 10:51 AM, Ian Stakenvicius wrote:
> 
> 
>> On Jan 22, 2016, at 3:11 PM, Aaron W. Swenson
>>  wrote:
>> 
>> 
>> I would like some feedback on the documentation/comments in
>> the eclass. I'm certain it could be improved. Though, if you
>> were able to follow them (not a slight, just you were the first
>> to follow them), I might have done good enough.
>> 
> 
> I'll have another look; i don't think I read any of the docs,
> just looked to see that PG_CONFIG was set for me and confirmed
> things looked to work the same as multilib-minimal.

OK here's my full review (with docs and all):

postgres.eclass:

postgres_check_slot() <-- #1, not seeing a need for this as
dependencies should be forced now due to USE flag provisions.  #2,
though, the documentation says it should be used in pkg_pretend but
then in the code there's an exclusion to make it a no-op when it's
run in pkg_pretend.  Perhaps it's supposed to be run in pkg_setup??

postgres_new_user() <-- the documentation seems a little bit unclear
on this one..  It looks like it creates the 'postgres' user/group
and optionally it also creates an additional specified user/group..
 But i'm not sure how creating new users/groups here instead of with
calling enewuser/enewgroup directly in the ebuild is helpful per
se...?  It also seems a bit redundant if you wanted to create say, 2
or 3 extra users/groups, to repeatedly call enewuser postgres 


postgres-multi.eclass:

#1 - main description could perhaps be changed from:

# build against any and all compatible PostgreSQL slots that are also
# enabled by the user.

to:

# build and install for one or more PostgreSQL slots as specified by
# POSTGRES_TARGETS use flags.

#2 - POSTGRES_COMPAT , needs an example and/or text to describe the
syntax of the slot specification.

#3 - _POSTGRES_UNION_SLOTS -- you actually mean here the
intersection between the two sets, rather than the union, right?
Var can likely stay as-is but the description should probably be
updated.

#4 - postgres-multi_foreach() -- this actually runs in the builddir,
not the source dir as mentioned in the text.

#5 - postgres-multi_forbest() -- maybe expand on what the "best"
slot is here, ie that it's the lexicographically biggest slot rather
than something else (like, say, the slot that's currently eselected)

#6 - need docs for postgres-multi_src_prepare() and so forth -- just
simple stuff will suffice I think:  postgres-multi_src_prepare()
copies ${S} into a build directory for each target PG_SLOT and
should be specified; the others are default functions that are
provided for convenience, but postgres-multi_foreach should be used
instead of these when customization is necessary.

...and I think that's it..

-BEGIN PGP SIGNATURE-
Version: GnuPG v2

iF4EAREIAAYFAlamP+kACgkQAJxUfCtlWe2wAAD/QlCKmkKl/9gr42ggY9RUpvUL
HLT1trvmzvto8QLXLeoBAOWRobPqIU4fcoI0on6CJdeVS+ZEK5MFcdf9qDn3yECA
=VjiJ
-END PGP SIGNATURE-

Re: [gentoo-dev] [PATCH] skel.metadata.xml: update for GLEP 67

[Göktürk Yüksek]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

Michael Palimaka:
> I tried to tidy it up a bit too. Any ideas on how to improve
> further are appreciated.
> 
I think we use  very frequently these days. Maybe have
something about that too?

> Michael Palimaka (1): skel.metadata.xml: update for GLEP 67
> 
> skel.metadata.xml | 35 +-- 1 file
> changed, 17 insertions(+), 18 deletions(-)
> 

- --
gokturk

-BEGIN PGP SIGNATURE-

iQEcBAEBCgAGBQJWpjslAAoJEIT4AuXAiM4zeTkH/2AHbL8MgznqRktZAYWQDlry
U8cYVR1rAhMr0urPIrSEFsO8+n4VfK/+GgKRH084fq39AAnVUXZQK9E/t+Njjb39
J2e8kDtrfbF5KYAjuMBuHngvi1/RVHHcepa4qP3bIFeh/Hsdw5nXVClLLs3Wuqln
d0KgW+6OQBFlhV30eVPY2pTiQ8/mw+8bMpIvyXlF+Z/jpXsxoSA229eNImsV/mvW
/b4dF0DZYQuJkQBuqpAP50N0Z/JWKbsk3C0ymuqygbwo71u7m3bkgK849Vh9Xya6
KoPLOG04yZ0fOr727Vwhrq7YHIYJtR+zGrGUgyNcemQ19VM08ZlzN5PVr+r5irA=
=6W7T
-END PGP SIGNATURE-

Re: [gentoo-dev] [PATCH] skel.metadata.xml: update for GLEP 67

[Ulrich Mueller]

> On Tue, 26 Jan 2016, Michael Palimaka wrote:

> -
> - Description of how USE='flag' affects this 
> package
> - Description of how USERLAND='GNU' affects this
> - package
> - Uses app-text/aspell for spell checking.
> - Requires an installed dictionary from 
> app-dicts
> -

> + 
> + Uses app-text/aspell for spell 
> checking.
> + Requires an installed dictionary from 
> app-dicts
> + Description of how USE='flag' affects this 
> package
> + Description of how USERLAND='GNU' 
> affects this
> + package
> + 

Better omit these unrelated indentation changes. Also the length of
lines should be kept below 80 positions.

Ulrich


pgpBjOCFvKWqX.pgp
Description: PGP signature

[gentoo-dev] [PATCH] skel.metadata.xml: update for GLEP 67

[Michael Palimaka]

---
 skel.metadata.xml | 35 +--
 1 file changed, 17 insertions(+), 18 deletions(-)

diff --git a/skel.metadata.xml b/skel.metadata.xml
index 7a496fb..1c8bc32 100644
--- a/skel.metadata.xml
+++ b/skel.metadata.xml
@@ -5,30 +5,29 @@
 
 This is the example metadata file.
 The root element of this file is . Within this element a
-number of subelements are allowed: herd, maintainer, and
-longdescription. herd is a required subelement.
+number of subelements are allowed, the most common being maintainer.
 
 For a full description look at:
 https://devmanual.gentoo.org/ebuild-writing/misc-files/metadata/
 
-
 Before committing, please remove the comments from this file. They are
 not relevant for general metadata.xml files.
 -->
 
-
-
-   @gentoo.org
-
-
-
-
+   
+   example...@gentoo.org
+   Primary maintainer
+   
+   
+   exampleproj...@gentoo.org
+   Gentoo Example Project
+   
+   Long description of the package
+   
+   Uses app-text/aspell for spell 
checking.
+   Requires an installed dictionary from 
app-dicts
+   Description of how USE='flag' affects this 
package
+   Description of how USERLAND='GNU' 
affects this
+   package
+   
 
-- 
2.4.10

[gentoo-dev] [PATCH] skel.metadata.xml: update for GLEP 67

[Michael Palimaka]

I tried to tidy it up a bit too. Any ideas on how to improve further are
appreciated.

Michael Palimaka (1):
  skel.metadata.xml: update for GLEP 67

 skel.metadata.xml | 35 +--
 1 file changed, 17 insertions(+), 18 deletions(-)

-- 
2.4.10

[gentoo-dev] [PATCH] skel.ChangeLog: remove file

[Michael Palimaka]

ChangeLog files are no longer used since the git migration.
---
 skel.ChangeLog | 67 --
 1 file changed, 67 deletions(-)
 delete mode 100644 skel.ChangeLog

diff --git a/skel.ChangeLog b/skel.ChangeLog
deleted file mode 100644
index 10ffc31..000
--- a/skel.ChangeLog
+++ /dev/null
@@ -1,67 +0,0 @@
-# ChangeLog for /
-# Copyright 1999-2016 Gentoo Foundation; Distributed under the GPL v2
-# $Id$
-
-*-- (DD MMM )
-
-  DD MMM ; YOUR_NAME  changed_file1, changed_file2 :
-  Initial import.  Ebuild submitted by submitter_name .
-  Note that the "changed_file" listing is optional if you are simply bumping
-  the rev of the ebuild and are only making changes to the .ebuild file
-  itself.  Also note that we now have a single unified paragraph rather than
-  having the first line separated from the rest by a newline.  Everything
-  should be in one block like this. (note by drobbins, 16 Jul 2002)
-
-  DD MMM ; YOUR_NAME  changed_file1, changed_file2: this is
-  an earlier ChangeLog entry.
-
--- Explanation of ChangeLog format:
-
-  ***
-  THIS IS IMPORTANT: The ChangeLog format is a *chronological* account of all
-  changes made to a set of ebuilds. That means that the most recent ChangeLog
-  entry *always* goes at the top of the file. More explanation below.
-  ***
-
-  ***
-  ANOTHER IMPORTANT NOTE: There are some ChangeLogs that don't follow this
-  format and organize all changes under the "correct" "*" entry. This is not
-  correct. However, rather than making a concerted effort to fix these
-  ChangeLogs, we should spend our energy defining a comprehensive and strict
-  XML-based ChangeLog format which we then migrate to. But for any entries to
-  any ChangeLog that *you* make, please make sure to always add entries to the
-  top of the file like a good boy/girl. Even do this if it's clear that you're
-  adding an entry to a b0rked ChangeLog.
-  ***
-
-  This changelog is targeted to users. This means that the comments should be
-  well explained and written in clean English.
-
-  Every new version or revision of the package should be marked by a '*'
-  separator line as above to indicate where in the chronology it was first
-  added to our Git tree. Any changes since the last revision, really _any
-  changes at all_ have to be added to the top of the file, underneath the
-  initial copyright and file header comments, in exactly the same format as 
this
-  comment. If you are modifying older ebuilds, simply note them as changed
-  files and add your entry to the top of the ChangeLog. Resist the temptation
-  to "organize" your ChangeLog entries by placing them under the "correct" "*"
-  entries -- this isn't the purpose of the "*" entries.
-
-  This means that you start with header line that has the following format,
-  indented two spaces:
-
-  DD MMM ; your_name  changed_file1, changed_file2: Your
-  explanation should follow. It should be indented and wrapped at a line width
-  of 80 characters.  The changed_files can be omitted if they are obvious; for
-  example, if you are only modifying the .ebuild file and committing a new rev
-  of a package.  Any details about what exactly changed in the code should be
-  added as a message when the changes are committed to Git, not in this file.
-
--- A word regarding credit:
-
-  Please add credit information ("ebuild submitted by ...", "patch submitted
-  by ...") to the ChangeLog. Do not add this information to the ebuilds
-  themselves.
-
-  And remember: Give credit where credit is due. We're all doing this for
-  free, so the best we can hope (and expect!) to receive is credit.
-- 
2.4.10

Re: [gentoo-dev] New USE_EXPAND: POSTGRES_TARGETS

[Aaron W. Swenson]

On 2016-01-24 18:33, Michael Orlitzky wrote:
> On 01/24/2016 06:21 PM, Aaron W. Swenson wrote:
> > Attached are the changes I'm looking to make. I've never play with
> > global use flags, so I'd like for somebody to make sure I've done them
> > right.
> > 
> 
> Tiny typo "postges.eclass".

Thank you. Untypoed.


signature.asc
Description: Digital signature

Re: [gentoo-dev] New Eclasses: postgres and postgres-multi

[Aaron W. Swenson]

On 2016-01-24 18:44, Michael Orlitzky wrote:
> On 01/24/2016 06:29 PM, Aaron W. Swenson wrote:
> > Okay, provided that the new USE_EXPAND is okay for POSTGRES_TARGETS,
> > attached are the eclasses that I'll commit to the tree.
> > 
> 
> > case ${EAPI:-0} in
> >   0|1|2|3|4) die "postgres-multi.eclass requires EAPI 5 or higher" ;;
> >   *) ;;
> > esac
> 
> Does this really work with EAPI=6? I didn't try, but it looks like it
> would need an eapply_user somewhere in src_prepare. And, pedantry
> warning, there's no such thing as "EAPI 5 or higher." The lawyers will
> tell you to do something like this instead (stolen from git-r3):
> 
>   case "${EAPI:-0}" in
> 5|6)
> ;;
> *)
> die "Unsupported EAPI=${EAPI} (unknown) for ${ECLASS}"
> ;;
>   esac
> 
> That will require an edit for every new EAPI, but prevents weird crashes
> from things like a missing eapply_user.
> 
> 

Thank you.

I've added the eapply_user to postgres-multi and modified the case
condition to match the hot goods you're selling on the sly.
# Copyright 1999-2016 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
# $Id$

inherit multibuild postgres
EXPORT_FUNCTIONS pkg_setup src_prepare src_compile src_install src_test


# @ECLASS: postgres-multi
# @MAINTAINER:
# PostgreSQL 
# @AUTHOR: Aaron W. Swenson 
# @BLURB: An eclass to build PostgreSQL-related packages against multiple slots
# @DESCRIPTION:
# postgres-multi enables ebuilds, particularly PostgreSQL extensions, to
# build against any and all compatible PostgreSQL slots that are also
# enabled by the user. Additionally makes a developer's life easier with
# exported default functions to do the right thing.


case ${EAPI:-0} in
  0|1|2|3|4) die "postgres-multi.eclass requires EAPI 5 or higher" ;;
  *) ;;
esac


# @ECLASS-VARIABLE: POSTGRES_COMPAT
# @REQUIRED
# @DESCRIPTION:
# A Bash array containing a list of compatible PostgreSQL slots as
# defined by the developer. Must be declared before inheriting this eclass.
if ! declare -p POSTGRES_COMPAT &>/dev/null; then
die 'Required variable POSTGRES_COMPAT not declared.'
fi

# @ECLASS-VARIABLE: _POSTGRES_UNION_SLOTS
# @INTERNAL
# @DESCRIPTION:
# A Bash array containing the union set of user-enabled slots that are
# also in POSTGRES_COMPAT.
export _POSTGRES_UNION_SLOTS=( )

# @FUNCTION _postgres-multi_multibuild_wrapper
# @INTERNAL
# @USAGE: _postgres-multi_multibuild_wrapper  [ ...]
# @DESCRIPTION:
# For the given variant, set the values of the PG_SLOT and PG_CONFIG
# environment variables accordingly and replace any appearance of
# @PG_SLOT@ in the command and arguments with value of ${PG_SLOT}.
_postgres-multi_multibuild_wrapper() {
debug-print-function ${FUNCNAME} "${@}"
export PG_SLOT=${MULTIBUILD_VARIANT}
export PG_CONFIG=$(which pg_config${MULTIBUILD_VARIANT//./})
$(echo "${@}" | sed "s/@PG_SLOT@/${PG_SLOT}/g")
}

# @FUNCTION: postgres-multi_foreach
# @USAGE: postgres-multi_foreach   [ ...]
# @DESCRIPTION:
# Run the given command in the package's source directory for each
# PostgreSQL slot in the union set of the developer defined
# POSTGRES_COMPAT and user-enabled slots. The PG_CONFIG environment
# variable is updated on each iteration to point to the matching
# pg_config command for the current slot. Any appearance of @PG_SLOT@ in
# the command or arguments will be substituted with the slot (e.g., 9.5)
# of the current iteration.
postgres-multi_foreach() {
local MULTIBUILD_VARIANTS=("${_POSTGRES_UNION_SLOTS[@]}")

multibuild_foreach_variant \
_postgres-multi_multibuild_wrapper run_in_build_dir ${@}
}

# @FUNCTION: postgres-multi_forbest
# @USAGE: postgres-multi_forbest   [ ...]
# @DESCRIPTION:
# Run the given command in the package's source directory for the best,
# compatible PostgreSQL slot. The PG_CONFIG environment variable is set
# to the matching pg_config command. Any appearance of @PG_SLOT@ in the
# command or arguments will be substituted with the matching slot (e.g., 9.5).
postgres-multi_forbest() {
# POSTGRES_COMPAT is reverse sorted once in postgres.eclass so
# element 0 has the highest slot version.
local MULTIBUILD_VARIANTS=("${_POSTGRES_UNION_SLOTS[0]}")

multibuild_foreach_variant \
_postgres-multi_multibuild_wrapper run_in_build_dir ${@}
}

# @FUNCTION: postgres-multi_pkg_setup
# @USAGE: postgres-multi_pkg_setup
# @DESCRIPTION:
# Initialize internal environment variable(s). This is required if
# pkg_setup() is declared in the ebuild.
postgres-multi_pkg_setup() {
local user_slot

for user_slot in "${POSTGRES_COMPAT[@]}"; do
use "postgres_targets_postgres${user_slot/\./_}" && \
_POSTGRES_UNION_SLOTS+=( "${user_slot}" )
done

if [[ "${#_POSTGRES_UNION_SLOTS[@]}" -eq "0" ]]; then
die "One of the postgres_targets_postgresSL_OT

Re: [gentoo-dev] GLEP 67 is in, please update your metadata.dtd!

[Andrew Savchenko]

On Mon, 25 Jan 2016 10:37:15 +0100 Michał Górny wrote:
> Hello, everyone.
> 
> I've finished the GLEP 67 transition last night, and it officially
> applies to all metadata.xml files now.
> 
> In order to have repoman apply it correct (and not throw errors on new
> metadata.xml files), it needs to refetch metadata.dtd. Sadly, this
> currently happens once a week, so it's better to remove the file
> manually to force refetch:

skel.metadata.xml should be updated as well, otherwise developers
will have broken example.

That said, skel.ChangeLog should be removed :)

Best regards,
Andrew Savchenko


pgpyf_pR5isia.pgp
Description: PGP signature

Re: [gentoo-dev] New packages up for grabs

[Andrew Savchenko]

On Sun, 24 Jan 2016 19:01:10 -0500 Göktürk Yüksek wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA512
> 
> Michał Górny:
> > Hello, everyone.
> > 
> > As a result of disbanding a few herds, we some new 
> > maintainer-needed packages.
> > 
> > Here's the complete list:
> > 
> > app-benchmarks/bonnie++ app-benchmarks/filebench
> If these haven't been taken already, I can proxy them.

I'll proxy them for you, I have some interest in these packages too.

Best regards,
Andrew Savchenko


pgpFmVTL4nLPJ.pgp
Description: PGP signature

[gentoo-dev] GLEP 67 is in, please update your metadata.dtd!

[Michał Górny]

Hello, everyone.

I've finished the GLEP 67 transition last night, and it officially
applies to all metadata.xml files now.

In order to have repoman apply it correct (and not throw errors on new
metadata.xml files), it needs to refetch metadata.dtd. Sadly, this
currently happens once a week, so it's better to remove the file
manually to force refetch:

  rm "$(portageq envvar DISTDIR)"/metadata.dtd

Please note that the metadata.dtd is unable to correctly enforce
obligatory type="" attribute on maintainers. Please make sure to add
it. I will be adding pkgcheck/repoman checks for that soon.

If you'd like to convert your own repository, you can reuse the herdfix
tool [1]. It's pretty dumb, and can work with any repository:

  git clone https://bitbucket.org/mgorny/herdfix/
  cd herdfix
  # note: this will fetch all data, including ssh-ing to d.g.o
  # to get developer list from /etc/passwd
  make
  ./01-pre-clean.py /repo/path
  ./03-clean-maint-needed.py /repo/path
  ./02-herdfix.py /repo/path herd-mapping.json
  ./04-set-type.py /repo/path projects.xml dev.names

01-pre-clean.py is optional and useful only if you want to separately
commit quoting changes to avoid mixing them in with other changes.

03-clean-maint-needed.py is probably unnecessary since it just updates
maintainer-needed@g.o packages. I doubt you find them often in custom
repositories.

02-herdfix.py is the meat grinder replacing herds with projects. Useful
only if you used  in your repository (which you shouldn't have
been).

04-set-type.py sets type="" on all s. It uses
type="project" for anything found in projects.xml, type="person"
otherwise.

[1]:https://bitbucket.org/mgorny/herdfix/

-- 
Best regards,
Michał Górny



pgpBSa7a2Sbd_.pgp
Description: OpenPGP digital signature

Re: [gentoo-dev] Re: [PATCH v2 17/19] ebuild-writing/misc-files: remove ChangeLog section #485314

[Ulrich Mueller]

> On Sun, 24 Jan 2016, Michael Orlitzky wrote:

> The ChangeLog page is nonsense as-is, and removing it makes the
> devmanual better. Afterwards, if someone wants to take the commit
> message guidelines from the wiki and merge them with the old ChangeLog
> tips, great. There's only two things worth salvaging from the ChangeLog
> page. Here's the combined list:

>   1. Everything from the Git workflow wiki page "Commit message format"
>  section.

I would say not only that section, but most of the page. The devmanual
is the one central place where our development workflow should be
documented, not some random wiki page.

>   2. Mention the "Gentoo-Bug:" identifier.

Right. (But had we settled for "Gentoo-Bug:"? IIRC, last time this was
discussed there was no consensus.)

>  Using "bug #12345" in the commit message itself causes trouble.
>  If you word-wrap on the "#12345", it will silently clobber the
>  message.

That's one of the reasons why I have 'commentchar = ";"' in my
.gitconfig file. (Not sure if that option would be worth mentioning
in our documentation, though.)

> [...]

Ulrich


pgpCIOxORuqZQ.pgp
Description: PGP signature