On Wed, Nov 30, 2016 at 8:35 PM, Mike Gilbert wrote:
> On Wed, Nov 30, 2016 at 7:11 AM, konsolebox wrote:
I also prefer some things this way:
- Indent the contents of the first `if` block for consistency's sake,
and less confusion.
>>>
>>> I disagree; indenting the entire ecla
On Wed, Nov 30, 2016 at 7:11 AM, konsolebox wrote:
>>> I also prefer some things this way:
>>>
>>> - Indent the contents of the first `if` block for consistency's sake,
>>> and less confusion.
>>
>> I disagree; indenting the entire eclass is silly and does not really
>> improve readability. Also,
On 11/30/16, Mike Gilbert wrote:
> On Wed, Nov 30, 2016 at 3:38 AM, konsolebox wrote:
>> - `[[ ${ROOT} == / ]] || return 0` seems to present a harmless false
>> condition, and it doesn't show an error message. I would be helpful
>> to have a comment added above it to give details why.
>
> We onl
On Wed, Nov 30, 2016 at 3:38 AM, konsolebox wrote:
> There are some things I noticed in the tmpfiles_process() function:
>
> - `type` currently also checks for functions, alias, and builtins,
> besides executable files. If that's not intended, the `-P` option
> should be added.
I cannot conceive
There are some things I noticed in the tmpfiles_process() function:
- `type` currently also checks for functions, alias, and builtins,
besides executable files. If that's not intended, the `-P` option
should be added.
- What happens if neither systemd-tmpfiles nor opentmpfiles is found?
- Shouldn
