[gentoo-dev] Re: Re: [gentoo-commits] gentoo-x86 commit in sys-cluster/pvfs2: ChangeLog pvfs2-2.6.3-r1.ebuild
Donnie Berkholz wrote:
On 23:45 Sat 13 Oct , Drake Wyrm wrote:
Donnie Berkholz [EMAIL PROTECTED] wrote:
On 13:36 Sat 13 Oct , Matti Bickel (mabi) wrote:
if kernel_is gt 2 6 20 ; then
epatch ${FILESDIR}/${PV}-register_sysctl_table.patch
fi
if kernel_is ge 2 6 22 ; then
epatch ${FILESDIR}/${PV}-kmem-and-dtor-fix.patch
fi
Mixing 'gt' and 'ge' is a bad idea.
Just outa curiosity, why?
Because it's inconsistent and one generally assumes that people will be
consistent with the way they test numbers. That way you only need to
read the number rather than continually checking every single line to
see how exactly it's tested for.
I don't see how this is inconsistent either: two tests are needed, so that
both patches are only applied for =2.6.22 and first only if 2.6.20.
(If the eclass performs inconsistently, that would need to be fixed.)
--
[EMAIL PROTECTED] mailing list
Re: [gentoo-dev] Re: Re: [gentoo-commits] gentoo-x86 commit in sys-cluster/pvfs2: ChangeLog pvfs2-2.6.3-r1.ebuild
Steve Long [EMAIL PROTECTED] wrote: Mixing 'gt' and 'ge' is a bad idea. Just outa curiosity, why? Because it's inconsistent and one generally assumes that people will be consistent with the way they test numbers. That way you only need to read the number rather than continually checking every single line to see how exactly it's tested for. I don't see how this is inconsistent either: two tests are needed, so that both patches are only applied for =2.6.22 and first only if 2.6.20. The point is that if you stick to ge OR gt, everyone could just skip reading the comparison and focus on the numbers. Will be fixed in the next release, along with kernel-2.4 support... -- Regards, Matti Bickel Signed/Encrypted email preferred (key 4849EC6C) pgpGNkr8MFQEL.pgp Description: PGP signature
