Re: [gentoo-dev] RFC: media-sound/xmms2/xmms2-0.7.ebuild (v2)

2010-06-29 Thread Mike Frysinger
> return 0 nowhere do you check the return value of xmms2_flag, so not much point in returning a value (also, the eerror path no longer returns 1) > ${CHOST:+--with-target-platform=${CHOST}} \ CHOST is guaranteed to always be set, so no need for the ${VAR:+} magic >

Re: [gentoo-dev] RFC: media-sound/xmms2/xmms2-0.7.ebuild (v2)

2010-06-29 Thread Sergei Trofimovich
> > --destdir="${D}" \ > you need to give the DESTDIR to configure ? no wonder xmms2 sucks Completely my fault. Moreover it ignores the option in configure phase (same with '--without-ldconfig') > > ${CTARGET:+--with-target-platform=${CTARGET}} > i highly