Re: [gentoo-dev] cmake-utils.eclass: set default of CMAKE_VERBOSE=1

2012-05-06 Thread Andreas K. Huettel
Am Samstag 05 Mai 2012, 20:54:09 schrieb Andreas K. Huettel:
 Am Freitag, 4. Mai 2012, 18:30:10 schrieb hasufell:
  # @ECLASS-VARIABLE: CMAKE_VERBOSE
  # @DESCRIPTION:
  # Set to enable verbose messages during compilation.
  
  By default this is deactivated which is inconvenient imo and results in
  pastes having minimum information.
  I have to tell users every time to recompile with CMAKE_VERBOSE=1 so
  that I have proper information on what is going on.
  
  Are there any arguments against this being default?
 
 I think the resistance against this more has to do with the output being
 more esthetically pleasing (yes I know this is not really a good point for
 us, but in general the cmake output is quite nice) than with writing to
 stdout is expensive (which was a joke in the previous thread).
 
 That being said, it probably makes sense to change the default to =1, as it
 definitely helps debugging to see the build commands.
 

I've taken the liberty to change the default in the kde overlay. We'll likely 
move this to the main tree with other changes after some testing. Semantics 
needed to change a bit; the description now reads:

# @ECLASS-VARIABLE: CMAKE_VERBOSE
# @DESCRIPTION:
# Set to OFF to disable verbose messages during compilation
: ${CMAKE_VERBOSE:=ON}



-- 

Andreas K. Huettel
Gentoo Linux developer 
dilfri...@gentoo.org
http://www.akhuettel.de/



signature.asc
Description: This is a digitally signed message part.


Re: [gentoo-dev] cmake-utils.eclass: set default of CMAKE_VERBOSE=1

2012-05-05 Thread Kacper Kowalik
On 04.05.2012 18:30, hasufell wrote:
 # @ECLASS-VARIABLE: CMAKE_VERBOSE
 # @DESCRIPTION:
 # Set to enable verbose messages during compilation.
 
 By default this is deactivated which is inconvenient imo and results in
 pastes having minimum information.
 I have to tell users every time to recompile with CMAKE_VERBOSE=1 so
 that I have proper information on what is going on.
 
 Are there any arguments against this being default?
 
Hi,
It's been discussed previously here [1]
with nack from cmake-utils.eclass maintainers and general conclusion
that's too expensive to write to stdout :/
If you're gonna make it happen this time, I'll owe you a beer...
Cheers,
Kacper

[1]
http://archives.gentoo.org/gentoo-dev/msg_1b58b577fde07f7735ae6b9eb34885be.xml



signature.asc
Description: OpenPGP digital signature


Re: [gentoo-dev] cmake-utils.eclass: set default of CMAKE_VERBOSE=1

2012-05-05 Thread Pacho Ramos
El sáb, 05-05-2012 a las 09:49 +0200, Kacper Kowalik escribió:
 On 04.05.2012 18:30, hasufell wrote:
  # @ECLASS-VARIABLE: CMAKE_VERBOSE
  # @DESCRIPTION:
  # Set to enable verbose messages during compilation.
  
  By default this is deactivated which is inconvenient imo and results in
  pastes having minimum information.
  I have to tell users every time to recompile with CMAKE_VERBOSE=1 so
  that I have proper information on what is going on.
  
  Are there any arguments against this being default?
  
 Hi,
 It's been discussed previously here [1]
 with nack from cmake-utils.eclass maintainers and general conclusion
 that's too expensive to write to stdout :/
 If you're gonna make it happen this time, I'll owe you a beer...
 Cheers,
 Kacper
 
 [1]
 http://archives.gentoo.org/gentoo-dev/msg_1b58b577fde07f7735ae6b9eb34885be.xml
 

That would be a good step to get
https://bugs.gentoo.org/show_bug.cgi?id=384193

implemented some day ;)


signature.asc
Description: This is a digitally signed message part


Re: [gentoo-dev] cmake-utils.eclass: set default of CMAKE_VERBOSE=1

2012-05-05 Thread Zac Medico
On 05/05/2012 12:49 AM, Kacper Kowalik wrote:
 On 04.05.2012 18:30, hasufell wrote:
 # @ECLASS-VARIABLE: CMAKE_VERBOSE
 # @DESCRIPTION:
 # Set to enable verbose messages during compilation.

 By default this is deactivated which is inconvenient imo and results in
 pastes having minimum information.
 I have to tell users every time to recompile with CMAKE_VERBOSE=1 so
 that I have proper information on what is going on.

 Are there any arguments against this being default?

 Hi,
 It's been discussed previously here [1]
 with nack from cmake-utils.eclass maintainers and general conclusion
 that's too expensive to write to stdout :/
 If you're gonna make it happen this time, I'll owe you a beer...
 Cheers,
 Kacper
 
 [1]
 http://archives.gentoo.org/gentoo-dev/msg_1b58b577fde07f7735ae6b9eb34885be.xml

They should probably be using the emerge --quiet-build option if they're
concerned about the expense of build output going to the console.

Anyway, it seems like verbose would be a good default, with an option to
override it for people who enjoy watching build output scroll by in
their spare time.
-- 
Thanks,
Zac



Re: [gentoo-dev] cmake-utils.eclass: set default of CMAKE_VERBOSE=1

2012-05-05 Thread Michael Weber
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 05/04/2012 09:37 PM, Mike Gilbert wrote:
 On Fri, May 4, 2012 at 3:25 PM, Johannes Huber j...@gentoo.org
 wrote:
 Am Freitag, 4. Mai 2012, 14:41:42 schrieb Mike Gilbert:
 On Fri, May 4, 2012 at 2:29 PM, hasufell hasuf...@gentoo.org
 wrote:
 
 I think that as an argument pro CMAKE_VERBOSE=1 because that
 would cover 100% instead of 95-99.
++

There was a similar rumor about VERBOSE=1 V=1 and the (`emerge -j 2`
induced emerge `--quiet-build`).

But build.log files will get larger and bugzie has this 1MB upload limit.
File:  Enter the path to the file on your computer (1000 KB limit)
(or paste text as attachment).

We should add an hint to atach compressed build logs (or raise this
limit).

 It would be nice to avoid having to wait for the user to respond
 with the updated build log.

Which may take ages and lead to RESO/NEEDINFO. Not good.

Greetings,

   Michael

- --
Gentoo Dev
http://xmw.de/
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.17 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iF4EAREIAAYFAk+k+g8ACgkQknrdDGLu8JDmMAEAi8vT95lr5K2DkgxZUThy/Yh5
IgfVEVqpm+A3vcBgSZwA/A756k6/WVrJwh2lADr8Sly7hbOpoXYkTkHRO9iu/OVc
=cJST
-END PGP SIGNATURE-



Re: [gentoo-dev] cmake-utils.eclass: set default of CMAKE_VERBOSE=1

2012-05-05 Thread Andreas K. Huettel
Am Freitag, 4. Mai 2012, 18:30:10 schrieb hasufell:
 # @ECLASS-VARIABLE: CMAKE_VERBOSE
 # @DESCRIPTION:
 # Set to enable verbose messages during compilation.
 
 By default this is deactivated which is inconvenient imo and results in
 pastes having minimum information.
 I have to tell users every time to recompile with CMAKE_VERBOSE=1 so
 that I have proper information on what is going on.
 
 Are there any arguments against this being default?

I think the resistance against this more has to do with the output being more 
esthetically pleasing (yes I know this is not really a good point for us, but 
in general the cmake output is quite nice) than with writing to stdout is 
expensive (which was a joke in the previous thread).

That being said, it probably makes sense to change the default to =1, as it 
definitely helps debugging to see the build commands. 

@infra:
However, please raise the file size limit for bugzilla then, and if possible, 
please fix the use of compressed build logs. Right now, I would not recommend 
uploading a compressed log to bugzilla, because:
* I have not found a way to have firefox uncompress and display it correctly 
with one click (always have to download, save, ...)
* and often files end up double-compressed, i.e. save log.gz, gunzip, rename 
log to log.gz, gunzip :(

Cheers, Andreas

-- 
Andreas K. Huettel
Gentoo Linux developer 
kde (team lead), sci, tex, arm, printing
dilfri...@gentoo.org
http://www.akhuettel.de/


signature.asc
Description: This is a digitally signed message part.


Re: [gentoo-dev] cmake-utils.eclass: set default of CMAKE_VERBOSE=1

2012-05-04 Thread Johannes Huber
Am Freitag, 4. Mai 2012, 18:30:10 schrieb hasufell:
 # @ECLASS-VARIABLE: CMAKE_VERBOSE
 # @DESCRIPTION:
 # Set to enable verbose messages during compilation.
 
 By default this is deactivated which is inconvenient imo and results in
 pastes having minimum information.
 I have to tell users every time to recompile with CMAKE_VERBOSE=1 so
 that I have proper information on what is going on.
 
 Are there any arguments against this being default?

In 95-99% of the build failures we get in kde herd the information is 
sufficient. So from my point of view the current behaviour is good.

Greetings

-- 
Johannes Huber (johu)
Gentoo Linux Developer / KDE Team
GPG Key ID F3CFD2BD

signature.asc
Description: This is a digitally signed message part.


Re: [gentoo-dev] cmake-utils.eclass: set default of CMAKE_VERBOSE=1

2012-05-04 Thread hasufell
On 05/04/2012 08:00 PM, Johannes Huber wrote:
 Am Freitag, 4. Mai 2012, 18:30:10 schrieb hasufell:
 # @ECLASS-VARIABLE: CMAKE_VERBOSE # @DESCRIPTION: # Set to enable
 verbose messages during compilation.
 
 By default this is deactivated which is inconvenient imo and
 results in pastes having minimum information. I have to tell
 users every time to recompile with CMAKE_VERBOSE=1 so that I have
 proper information on what is going on.
 
 Are there any arguments against this being default?
 
 In 95-99% of the build failures we get in kde herd the information
 is sufficient. So from my point of view the current behaviour is
 good.
 
 Greetings
 

I think that as an argument pro CMAKE_VERBOSE=1 because that would
cover 100% instead of 95-99.



Re: [gentoo-dev] cmake-utils.eclass: set default of CMAKE_VERBOSE=1

2012-05-04 Thread Mike Gilbert
On Fri, May 4, 2012 at 2:29 PM, hasufell hasuf...@gentoo.org wrote:
 On 05/04/2012 08:00 PM, Johannes Huber wrote:
 Am Freitag, 4. Mai 2012, 18:30:10 schrieb hasufell:
 # @ECLASS-VARIABLE: CMAKE_VERBOSE # @DESCRIPTION: # Set to enable
 verbose messages during compilation.

 By default this is deactivated which is inconvenient imo and
 results in pastes having minimum information. I have to tell
 users every time to recompile with CMAKE_VERBOSE=1 so that I have
 proper information on what is going on.

 Are there any arguments against this being default?

 In 95-99% of the build failures we get in kde herd the information
 is sufficient. So from my point of view the current behaviour is
 good.

 Greetings


 I think that as an argument pro CMAKE_VERBOSE=1 because that would
 cover 100% instead of 95-99.


I only maintain a couple of cmake-based ebuilds, but I find having the
full compiler command line useful. Without it, I have to guess at what
was actually run.



Re: [gentoo-dev] cmake-utils.eclass: set default of CMAKE_VERBOSE=1

2012-05-04 Thread Johannes Huber
Am Freitag, 4. Mai 2012, 14:41:42 schrieb Mike Gilbert:
 On Fri, May 4, 2012 at 2:29 PM, hasufell hasuf...@gentoo.org wrote:
  On 05/04/2012 08:00 PM, Johannes Huber wrote:
  Am Freitag, 4. Mai 2012, 18:30:10 schrieb hasufell:
  # @ECLASS-VARIABLE: CMAKE_VERBOSE # @DESCRIPTION: # Set to enable
  verbose messages during compilation.
  
  By default this is deactivated which is inconvenient imo and
  results in pastes having minimum information. I have to tell
  users every time to recompile with CMAKE_VERBOSE=1 so that I have
  proper information on what is going on.
  
  Are there any arguments against this being default?
  
  In 95-99% of the build failures we get in kde herd the information
  is sufficient. So from my point of view the current behaviour is
  good.
  
  Greetings
  
  I think that as an argument pro CMAKE_VERBOSE=1 because that would
  cover 100% instead of 95-99.
 
 I only maintain a couple of cmake-based ebuilds, but I find having the
 full compiler command line useful. Without it, I have to guess at what
 was actually run.

How about bump docs for that use case? For example 
http://www.gentoo.org/proj/en/qa/backtraces.xml

Cheers
-- 
Johannes Huber (johu)
Gentoo Linux Developer / KDE Team
GPG Key ID F3CFD2BD



Re: [gentoo-dev] cmake-utils.eclass: set default of CMAKE_VERBOSE=1

2012-05-04 Thread Mike Gilbert
On Fri, May 4, 2012 at 3:25 PM, Johannes Huber j...@gentoo.org wrote:
 Am Freitag, 4. Mai 2012, 14:41:42 schrieb Mike Gilbert:
 On Fri, May 4, 2012 at 2:29 PM, hasufell hasuf...@gentoo.org wrote:
  On 05/04/2012 08:00 PM, Johannes Huber wrote:
  Am Freitag, 4. Mai 2012, 18:30:10 schrieb hasufell:
  # @ECLASS-VARIABLE: CMAKE_VERBOSE # @DESCRIPTION: # Set to enable
  verbose messages during compilation.
 
  By default this is deactivated which is inconvenient imo and
  results in pastes having minimum information. I have to tell
  users every time to recompile with CMAKE_VERBOSE=1 so that I have
  proper information on what is going on.
 
  Are there any arguments against this being default?
 
  In 95-99% of the build failures we get in kde herd the information
  is sufficient. So from my point of view the current behaviour is
  good.
 
  Greetings
 
  I think that as an argument pro CMAKE_VERBOSE=1 because that would
  cover 100% instead of 95-99.

 I only maintain a couple of cmake-based ebuilds, but I find having the
 full compiler command line useful. Without it, I have to guess at what
 was actually run.

 How about bump docs for that use case? For example
 http://www.gentoo.org/proj/en/qa/backtraces.xml


As far as I can tell, such documentation is largely ignored unless
users are pointed to it by a comment on a bug. It would be nice to
avoid having to wait for the user to respond with the updated build
log.