On 16:41 Thu 22 Sep , Andreas K. Huettel wrote:
> Am Donnerstag 22 September 2011, 13:27:47 schrieb Michał Górny:
> > > >
> > > > The style change was approved by Donnie already.
> > >
> > > You mean that Donnie agreed with the style change. It's not up to any
> > > individual developer to "a
Am Donnerstag 22 September 2011, 13:27:47 schrieb Michał Górny:
> > >
> > > The style change was approved by Donnie already.
> >
> > You mean that Donnie agreed with the style change. It's not up to any
> > individual developer to "approve" such a change for the entire tree.
>
> What kind of 'en
On Thu, 22 Sep 2011 10:58:28 +
"Jorge Manuel B. S. Vicetto" wrote:
> On 22-09-2011 08:11, Michał Górny wrote:
> > On Thu, 22 Sep 2011 09:01:17 +0200 Ulrich Mueller
> > wrote:
> >
> >>> Attaching fixed version of the last two patches, and a
> >>> complete eclass for convenience.
> >>
> >> J
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 22-09-2011 08:11, Michał Górny wrote:
> On Thu, 22 Sep 2011 09:01:17 +0200 Ulrich Mueller
> wrote:
>
>>> Attaching fixed version of the last two patches, and a
>>> complete eclass for convenience.
>>
>> Just a general comment: Is it really necess
On Thu, 22 Sep 2011 09:01:17 +0200
Ulrich Mueller wrote:
> > Attaching fixed version of the last two patches, and a complete
> > eclass for convenience.
>
> Just a general comment: Is it really necessary to change all
> [[ -n ${foo} ]] and [[ -z ${foo} ]] conditionals to the more obscure
> [[ ${
On 22-09-2011 09:01:17 +0200, Ulrich Mueller wrote:
> > Attaching fixed version of the last two patches, and a complete
> > eclass for convenience.
>
> Just a general comment: Is it really necessary to change all
> [[ -n ${foo} ]] and [[ -z ${foo} ]] conditionals to the more obscure
> [[ ${foo} ]]
> Attaching fixed version of the last two patches, and a complete
> eclass for convenience.
Just a general comment: Is it really necessary to change all
[[ -n ${foo} ]] and [[ -z ${foo} ]] conditionals to the more obscure
[[ ${foo} ]] and [[ ! ${foo} ]]?
The shortest possible form is not always t
Attaching fixed version of the last two patches, and a complete eclass
for convenience.
On Tue, 20 Sep 2011 22:32:52 +0200
Michał Górny wrote:
> 10 -- tries to migrate git.eclass clones to git-2.eclass (#383761).
Fixed invalid output (PVR -> PF).
> 11 -- removes old git.eclass clones to not
On Tue, 20 Sep 2011 22:46:10 +0200
Tomáš Chvátal wrote:
> 0001 - i had reason to put local definitions on the top, it is way
> more readable to see right away what local vars function has, so
> please stick to it.
> 0007 - I placed it into the conditionals to be clear what is
> happening, what if
On Tue, 20 Sep 2011 22:46:10 +0200
Tomáš Chvátal wrote:
> 0007 - I placed it into the conditionals to be clear what is
> happening, what if there will be added another if without the push...
Well, that part is not important, I can rollback it. It was mostly for
the repack/prune part.
> 0010 - 0
On Tue, 20 Sep 2011 23:48:36 +0300
Stratos Psomadakis wrote:
> On 09/20/2011 11:32 PM, Michał Górny wrote:
> > Hello all,
> >
> > I've prepared a bunch of patches to git-2.eclass.
> Just a suggestion (and maybe a bit off-topic), but I think if you sent
> each patch separately, as replies to the o
On 09/20/2011 11:32 PM, Michał Górny wrote:
> Hello all,
>
> I've prepared a bunch of patches to git-2.eclass.
Just a suggestion (and maybe a bit off-topic), but I think if you sent
each patch separately, as replies to the original thread (git send-email
can do that), it would make the review of ea
0001 - i had reason to put local definitions on the top, it is way
more readable to see right away what local vars function has, so
please stick to it.
0004 - Did you ever hear that executing another code in condition is
damn annoying to trace? :)
0007 - I placed it into the conditionals to be clea
Hello all,
I've prepared a bunch of patches to git-2.eclass.
1-2 -- replacing scary unreadable parts of code with nicer ones.
3-4 -- basically just coding style changes.
5-7 -- little logic simplification.
8 -- eclassdoc fixes.
9 -- prevents environment injection of internal var.
10 -- tries
14 matches
Mail list logo
