Re: [gentoo-dev] linux-info.eclass: lacking sources, config checks and module building

2009-09-07 Thread Robin H. Johnson
On Mon, Sep 07, 2009 at 10:28:11AM +0100, Daniel Drake wrote: > Robin H. Johnson wrote: > >It does NOT check /proc/config.gz presently. The original logic against > >not checking /proc was that we were targeting the kernel being built, > >but that's moot given the use of `uname -r` in OUTPUT_DIR. >

Re: [gentoo-dev] linux-info.eclass: lacking sources, config checks and module building

2009-09-07 Thread Daniel Drake
Robin H. Johnson wrote: It does NOT check /proc/config.gz presently. The original logic against not checking /proc was that we were targeting the kernel being built, but that's moot given the use of `uname -r` in OUTPUT_DIR. That seems like a bug. OUTPUT_DIR should default to unset which would

Re: [gentoo-dev] linux-info.eclass: lacking sources, config checks and module building

2009-08-31 Thread Mike Auty
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Ok, Here's the list of ebuilds that feature a CONFIG_CHECK, and which ones I've been through to check for either NONEED (already using ~option), MODULE (builds a module so may really want to bomb out), and FIXED (packages which I've fixed). About hal

Re: [gentoo-dev] linux-info.eclass: lacking sources, config checks and module building

2009-08-30 Thread Mike Auty
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Robin H. Johnson wrote: > If you feel like reviewing ~140 packages and filing bugs for them, I > won't stop you. But I'm just going to go and fix the ones that seem > simple enough to me, and only file bugs for the complex ones. Ok, I'll do what I can

Re: [gentoo-dev] linux-info.eclass: lacking sources, config checks and module building

2009-08-30 Thread Robin H. Johnson
On Mon, Aug 31, 2009 at 01:00:41AM +0100, Mike Auty wrote: > > I missed a bit for the config option. > > If there is NO source of the config data, what do we do? > > Error out or more warnings? > Well, if we can't determine whether a config option's set or not, if > it's not critical (ie, it's ~CHE

Re: [gentoo-dev] linux-info.eclass: lacking sources, config checks and module building

2009-08-30 Thread Mike Auty
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Robin H. Johnson wrote: > Yes, a warning with using /proc/config.gz. > > I missed a bit for the config option. > If there is NO source of the config data, what do we do? > Error out or more warnings? Well, if we can't determine whether a config optio

Re: [gentoo-dev] linux-info.eclass: lacking sources, config checks and module building

2009-08-30 Thread Robin H. Johnson
On Mon, Aug 31, 2009 at 12:30:02AM +0100, Mike Auty wrote: > > Checking a configuration option, for non-module use: > > > > 0. (optional) give an env var to make all checks non-fatal. > > 1. Use existing logic of .config from /usr/src/linux, KERN

Re: [gentoo-dev] linux-info.eclass: lacking sources, config checks and module building

2009-08-30 Thread Mike Auty
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Robin H. Johnson wrote: > The existing state is: > - Force the user to install sources > > Our choices are: > - `uname -r` output. > - Create an override environment variable for all the checks. > > /proc/config.gz comes back here again, in that, we

Re: [gentoo-dev] linux-info.eclass: lacking sources, config checks and module building

2009-08-30 Thread Robin H. Johnson
On Sun, Aug 30, 2009 at 10:58:33PM +0100, Mike Auty wrote: > Robin H. Johnson wrote: > > FYI: > > get_running_version is used in one single ebuild, in the entire tree: > > sys-fs/evms/evms-2.5.5-r10.ebuild > > And there it's only for a warning. > Ok, I was just suggesting that if there was an inten

Re: [gentoo-dev] linux-info.eclass: lacking sources, config checks and module building

2009-08-30 Thread Mike Auty
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Robin H. Johnson wrote: > FYI: > get_running_version is used in one single ebuild, in the entire tree: > sys-fs/evms/evms-2.5.5-r10.ebuild > And there it's only for a warning. Ok, I was just suggesting that if there was an intention to implement confi

Re: [gentoo-dev] linux-info.eclass: lacking sources, config checks and module building

2009-08-30 Thread Robin H. Johnson
On Sun, Aug 30, 2009 at 09:21:24PM +0100, Mike Auty wrote: > [ "${KV_MAJOR}.${KV_MINOR}.${KV_PATCH}${KV_EXTRA}" == "$(uname -r)" ] && \ > OUTPUT_DIR="${OUTPUT_DIR:-/lib/modules/${KV_MAJOR}.${KV_MINOR}.${KV_PATCH}${KV_EXTRA}/build}" This check is inside the get_version call, and is ultimately used t

Re: [gentoo-dev] linux-info.eclass: lacking sources, config checks and module building

2009-08-30 Thread Mike Auty
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Robin H. Johnson wrote: > It does NOT check /proc/config.gz presently. The original logic against > not checking /proc was that we were targeting the kernel being built, > but that's moot given the use of `uname -r` in OUTPUT_DIR. I might be reading t

[gentoo-dev] linux-info.eclass: lacking sources, config checks and module building

2009-08-30 Thread Robin H. Johnson
Seeing the debate raised in the udev thread about checking for the kernel, I'd like to propose that we revise the linux-info.eclass. linux-info already checks a number of locations: - KBUILD_OUTPUT, - KERNEL_DIR, which defaults to /usr/src/linux/ - OUTPUT_DIR, which defaults to /lib/modules/`uname