Re: [gentoo-dev] revdep-rebuild bikeshedding

2013-01-17 Thread Sergey Popov 
17.01.2013 00:43, Paul Varner wrote:
 Here is where the bikeshedding begins:
 1. What variable name do we prefer? REVDEP_DEFAULT_OPTS or
 REVDEP_EMERGE_DEFAULT_OPTS

REVDEP_REBUILD_DEFAULT_OPTS seems fine, IMO.

 2. What behavior do we want? append to EMERGE_DEFAULT_OPTS or replace
 EMERGE_DEFAULT_OPTS

replace is better

-- 
Best regards, Sergey Popov
Gentoo Linux Developer
Desktop-effects project lead



signature.asc
Description: OpenPGP digital signature

[gentoo-dev] revdep-rebuild bikeshedding

2013-01-16 Thread Paul Varner 
All:

Time for some bikeshedding :)

For the gentoolkit-0.3.0 series, I removed any filtering of emerge
options set in EMERGE_DEFAULT_OPS for revdep-rebuild.  This has caused
some people to complain because some of the flags in their
EMERGE_DEFAULT_OPTS are not suitable for a revdep-rebuild run.

I am not going to go back to filtering any of the emerge options,
however, I just added support for a make.conf variable called
REVDEP_DEFAULT_OPTS which currently gets appended to the list of options
after the EMERGE_DEFAULT_OPTS and before the command line options.

Here is where the bikeshedding begins:
1. What variable name do we prefer? REVDEP_DEFAULT_OPTS or
REVDEP_EMERGE_DEFAULT_OPTS
2. What behavior do we want? append to EMERGE_DEFAULT_OPTS or replace
EMERGE_DEFAULT_OPTS

Regards,
Paul

Re: [gentoo-dev] revdep-rebuild bikeshedding

2013-01-16 Thread Rich Freeman 
On Wed, Jan 16, 2013 at 3:43 PM, Paul Varner fuzzy...@gentoo.org wrote:
 2. What behavior do we want? append to EMERGE_DEFAULT_OPTS or replace
 EMERGE_DEFAULT_OPTS

Replace is probably better.  You can always manually append if you
want to, but it is much harder to remove unless portage has logic to
handle a inverse of every option and processing them in order (ie
--with-bdeps=y --with-bdeps=n works out to a no, and vice-versa).  If
you just replace it you'll eliminate a bunch of issues.

Rich

Re: [gentoo-dev] revdep-rebuild bikeshedding

2013-01-16 Thread Ian Stakenvicius 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 16/01/13 03:43 PM, Paul Varner wrote:
 All:
 
 Time for some bikeshedding :)
 
 For the gentoolkit-0.3.0 series, I removed any filtering of emerge 
 options set in EMERGE_DEFAULT_OPS for revdep-rebuild.  This has
 caused some people to complain because some of the flags in their 
 EMERGE_DEFAULT_OPTS are not suitable for a revdep-rebuild run.
 
 I am not going to go back to filtering any of the emerge options, 
 however, I just added support for a make.conf variable called 
 REVDEP_DEFAULT_OPTS which currently gets appended to the list of
 options after the EMERGE_DEFAULT_OPTS and before the command line
 options.
 
 Here is where the bikeshedding begins: 1. What variable name do we
 prefer? REVDEP_DEFAULT_OPTS or REVDEP_EMERGE_DEFAULT_OPTS

+1 on REVDEP_DEFAULT_OPTS , but if things are going to be verbose
might as well make them completely verbose with
REVDEP_REBUILD_DEFAULT_EMERGE_OPTS

 2. What behavior do we want? append to EMERGE_DEFAULT_OPTS or
 replace EMERGE_DEFAULT_OPTS

+1 on the replace.
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.19 (GNU/Linux)

iF4EAREIAAYFAlD3FDIACgkQ2ugaI38ACPC3gQEAvUlApXInabHifnIXlqsUJhJX
syeaaDkOXLzSO1L3vskA/2xX2YxAMnnmtFkv+QLBi+Kx+fLi60ZE/0QD1Zd5LH/3
=h5CO
-END PGP SIGNATURE-

Re: [gentoo-dev] revdep-rebuild bikeshedding

2013-01-16 Thread Albert Hopkins 


On Wed, Jan 16, 2013, at 03:57 PM, Ian Stakenvicius wrote:
[...]
 +1 on the replace.

+1