Re: [gentoo-dev] [PATCH] linux-mod.eclass: support module signing

2022-07-05 Thread Mike Gilbert
On Tue, Jul 5, 2022 at 3:02 PM Georgy Yakovlev wrote: > > ...snip > > > > > In that case, I think the only viable way to make this work is to > > > disable automatic stripping and handle stripping via custom code in > > > the ebuild/eclass. > > > > > might work indeed if we do something like

Re: [gentoo-dev] [PATCH] linux-mod.eclass: support module signing

2022-07-05 Thread Kenton Groombridge
On 22/07/05 12:02PM, Georgy Yakovlev wrote: > started playing with my old code and got blocked right away: > > looks like dostrip just creates a list of files/directories to strip > and processed at the very end of install phase. > > so skipping strip and doing manual one might be problematic. >

Re: [gentoo-dev] [PATCH] linux-mod.eclass: support module signing

2022-07-05 Thread Georgy Yakovlev
...snip > > > In that case, I think the only viable way to make this work is to > > disable automatic stripping and handle stripping via custom code in > > the ebuild/eclass. > > > might work indeed if we do something like (pseudo-bash) > > if [[ module_sign == yes ]]; then >     dostrip -x

Re: [gentoo-dev] [PATCH] linux-mod.eclass: support module signing

2022-06-27 Thread Georgy Yakovlev
On Mon, 2022-06-27 at 17:50 -0400, Mike Gilbert wrote: > On Mon, Jun 27, 2022 at 5:11 PM Georgy Yakovlev > wrote: > > > > On Mon, 2022-06-27 at 15:49 -0400, Mike Gilbert wrote: > > > On Mon, Jun 27, 2022 at 3:42 PM Georgy Yakovlev > > > wrote: > > > > > > > > On Mon, 2022-06-27 at 14:56 -0400,

Re: [gentoo-dev] [PATCH] linux-mod.eclass: support module signing

2022-06-27 Thread Mike Gilbert
On Mon, Jun 27, 2022 at 5:11 PM Georgy Yakovlev wrote: > > On Mon, 2022-06-27 at 15:49 -0400, Mike Gilbert wrote: > > On Mon, Jun 27, 2022 at 3:42 PM Georgy Yakovlev > > wrote: > > > > > > On Mon, 2022-06-27 at 14:56 -0400, Mike Gilbert wrote: > > > > On Mon, Jun 27, 2022 at 2:35 PM Kenton

Re: [gentoo-dev] [PATCH] linux-mod.eclass: support module signing

2022-06-27 Thread Georgy Yakovlev
On Mon, 2022-06-27 at 16:02 -0400, Kenton Groombridge wrote: > > > Why can't we do both in pkg_preinst? I am thinking it would be > > > best > > > if > > > we drop the current compression implementation and rework your > > > old > > > code > > > to handle both compression and signing since the

Re: [gentoo-dev] [PATCH] linux-mod.eclass: support module signing

2022-06-27 Thread Georgy Yakovlev
On Mon, 2022-06-27 at 15:49 -0400, Mike Gilbert wrote: > On Mon, Jun 27, 2022 at 3:42 PM Georgy Yakovlev > wrote: > > > > On Mon, 2022-06-27 at 14:56 -0400, Mike Gilbert wrote: > > > On Mon, Jun 27, 2022 at 2:35 PM Kenton Groombridge > > > wrote: > > > > > so looks like we need to combine both

Re: [gentoo-dev] [PATCH] linux-mod.eclass: support module signing

2022-06-27 Thread Kenton Groombridge
> > Why can't we do both in pkg_preinst? I am thinking it would be best > > if > > we drop the current compression implementation and rework your old > > code > > to handle both compression and signing since the signing code is more > > or > > less already complete. > > i'm not sure if sign-file

Re: [gentoo-dev] [PATCH] linux-mod.eclass: support module signing

2022-06-27 Thread Mike Gilbert
On Mon, Jun 27, 2022 at 3:42 PM Georgy Yakovlev wrote: > > On Mon, 2022-06-27 at 14:56 -0400, Mike Gilbert wrote: > > On Mon, Jun 27, 2022 at 2:35 PM Kenton Groombridge > > wrote: > > > > so looks like we need to combine both methods and do the > > > > following: > > > > - if signing requested

Re: [gentoo-dev] [PATCH] linux-mod.eclass: support module signing

2022-06-27 Thread Georgy Yakovlev
On Mon, 2022-06-27 at 14:35 -0400, Kenton Groombridge wrote: > On 22/06/26 04:15AM, Georgy Yakovlev wrote: > > On Sun, 2022-06-26 at 03:52 -0700, Georgy Yakovlev wrote: > > > On Tue, 2022-06-21 at 14:19 -0400, Kenton Groombridge wrote: > > > > eee74b9fca1 adds support for module compression, but

Re: [gentoo-dev] [PATCH] linux-mod.eclass: support module signing

2022-06-27 Thread Georgy Yakovlev
On Mon, 2022-06-27 at 14:56 -0400, Mike Gilbert wrote: > On Mon, Jun 27, 2022 at 2:35 PM Kenton Groombridge > wrote: > > > so looks like we need to combine both methods and do the > > > following: > > >  - if signing requested without compression - sign in > > > pkg_preinst. > > >  - if signing

Re: [gentoo-dev] [PATCH] linux-mod.eclass: support module signing

2022-06-27 Thread Kenton Groombridge
On 22/06/27 02:56PM, Mike Gilbert wrote: > On Mon, Jun 27, 2022 at 2:35 PM Kenton Groombridge wrote: > > > so looks like we need to combine both methods and do the following: > > > - if signing requested without compression - sign in pkg_preinst. > > > - if signing requested with compression -

Re: [gentoo-dev] [PATCH] linux-mod.eclass: support module signing

2022-06-27 Thread Mike Gilbert
On Mon, Jun 27, 2022 at 2:35 PM Kenton Groombridge wrote: > > so looks like we need to combine both methods and do the following: > > - if signing requested without compression - sign in pkg_preinst. > > - if signing requested with compression - sign in src_install > > > > Why can't we do both

Re: [gentoo-dev] [PATCH] linux-mod.eclass: support module signing

2022-06-27 Thread Kenton Groombridge
On 22/06/26 04:15AM, Georgy Yakovlev wrote: > On Sun, 2022-06-26 at 03:52 -0700, Georgy Yakovlev wrote: > > On Tue, 2022-06-21 at 14:19 -0400, Kenton Groombridge wrote: > > > eee74b9fca1 adds support for module compression, but this breaks > > > loading > > > out of tree modules when module

Re: [gentoo-dev] [PATCH] linux-mod.eclass: support module signing

2022-06-26 Thread Georgy Yakovlev
On Sun, 2022-06-26 at 03:52 -0700, Georgy Yakovlev wrote: > On Tue, 2022-06-21 at 14:19 -0400, Kenton Groombridge wrote: > > eee74b9fca1 adds support for module compression, but this breaks > > loading > > out of tree modules when module signing is enforced because modules > > must > > be signed

Re: [gentoo-dev] [PATCH] linux-mod.eclass: support module signing

2022-06-26 Thread Georgy Yakovlev
On Tue, 2022-06-21 at 14:19 -0400, Kenton Groombridge wrote: > eee74b9fca1 adds support for module compression, but this breaks > loading > out of tree modules when module signing is enforced because modules > must > be signed before they are compressed. Additionally, the recommended > Portage

Re: [gentoo-dev] [PATCH] linux-mod.eclass: support module signing

2022-06-23 Thread Kenton Groombridge
On 22/06/23 08:51AM, Mike Pagano wrote: > On 6/21/22 14:21, Kenton Groombridge wrote: > > On 22/06/21 02:19PM, Kenton Groombridge wrote: > > > eee74b9fca1 adds support for module compression, but this breaks loading > > > out of tree modules when module signing is enforced because modules must > >

Re: [gentoo-dev] [PATCH] linux-mod.eclass: support module signing

2022-06-23 Thread Mike Pagano
On 6/21/22 14:21, Kenton Groombridge wrote: On 22/06/21 02:19PM, Kenton Groombridge wrote: eee74b9fca1 adds support for module compression, but this breaks loading out of tree modules when module signing is enforced because modules must be signed before they are compressed. Additionally, the

[gentoo-dev] [PATCH] linux-mod.eclass: support module signing

2022-06-21 Thread Kenton Groombridge
eee74b9fca1 adds support for module compression, but this breaks loading out of tree modules when module signing is enforced because modules must be signed before they are compressed. Additionally, the recommended Portage hook[1] no longer works with this change. Add module signing support in

Re: [gentoo-dev] [PATCH] linux-mod.eclass: support module signing

2018-04-15 Thread NP-Hardass
On 04/14/2018 05:25 PM, Georgy Yakovlev wrote: > Hi, > > There is an old bug[1] to support > linux kernel module signing at install. > > And here is my first attempt to modify an eclass. > Need proper input on it and a kick in the right direction. > > Add 3 variables, settable by users if they

[gentoo-dev] [PATCH] linux-mod.eclass: support module signing

2018-04-14 Thread Georgy Yakovlev
Hi, There is an old bug[1] to support linux kernel module signing at install. And here is my first attempt to modify an eclass. Need proper input on it and a kick in the right direction. Add 3 variables, settable by users if they keep keys somewhere safe. Otherwise it just works with the