Re: [gentoo-dev] [PATCH v2] python-utils-r1.eclass: avoid nested ebegin calls

2022-07-11 Thread Mike Gilbert
On Mon, Jul 11, 2022 at 2:20 PM Mike Gilbert wrote: > > On Mon, Jul 11, 2022 at 2:01 PM Anna wrote: > > > > On 2022-07-11 19:57, Ulrich Mueller wrote: > > > > On Mon, 11 Jul 2022, Mike Gilbert wrote: > > > > > > >> Maybe leave ebegin/eend in place then, which was invented precisely for > > >

Re: [gentoo-dev] [PATCH v2] python-utils-r1.eclass: avoid nested ebegin calls

2022-07-11 Thread Mike Gilbert
On Mon, Jul 11, 2022 at 2:49 PM Frederik Pfautsch wrote: > > Am 11.07.22 um 20:14 schrieb Mike Gilbert: > > On Mon, Jul 11, 2022 at 1:57 PM Ulrich Mueller wrote: > >> > >>> On Mon, 11 Jul 2022, Mike Gilbert wrote: > >> > Maybe leave ebegin/eend in place then, which was invented

Re: [gentoo-dev] [PATCH v2] python-utils-r1.eclass: avoid nested ebegin calls

2022-07-11 Thread Frederik Pfautsch
Am 11.07.22 um 20:14 schrieb Mike Gilbert: On Mon, Jul 11, 2022 at 1:57 PM Ulrich Mueller wrote: On Mon, 11 Jul 2022, Mike Gilbert wrote: Maybe leave ebegin/eend in place then, which was invented precisely for this use case? What's so bad about nesting it? It leads to odd looking

Re: [gentoo-dev] [PATCH v2] python-utils-r1.eclass: avoid nested ebegin calls

2022-07-11 Thread Mike Gilbert
On Mon, Jul 11, 2022 at 2:01 PM Anna wrote: > > On 2022-07-11 19:57, Ulrich Mueller wrote: > > > On Mon, 11 Jul 2022, Mike Gilbert wrote: > > > > >> Maybe leave ebegin/eend in place then, which was invented precisely for > > >> this use case? What's so bad about nesting it? > > > > > It leads

Re: [gentoo-dev] [PATCH v2] python-utils-r1.eclass: avoid nested ebegin calls

2022-07-11 Thread Mike Gilbert
On Mon, Jul 11, 2022 at 1:57 PM Ulrich Mueller wrote: > > > On Mon, 11 Jul 2022, Mike Gilbert wrote: > > >> Maybe leave ebegin/eend in place then, which was invented precisely for > >> this use case? What's so bad about nesting it? > > > It leads to odd looking output. > > >

Re: [gentoo-dev] [PATCH v2] python-utils-r1.eclass: avoid nested ebegin calls

2022-07-11 Thread Ulrich Mueller
> On Mon, 11 Jul 2022, Mike Gilbert wrote: >> Maybe leave ebegin/eend in place then, which was invented precisely for >> this use case? What's so bad about nesting it? > It leads to odd looking output. >

Re: [gentoo-dev] [PATCH v2] python-utils-r1.eclass: avoid nested ebegin calls

2022-07-11 Thread Mike Gilbert
On Mon, Jul 11, 2022 at 1:17 PM Ionen Wolkens wrote: > > On Mon, Jul 11, 2022 at 01:08:52PM -0400, Mike Gilbert wrote: > > On Mon, Jul 11, 2022 at 12:56 PM Ulrich Mueller wrote: > > > > > > > On Mon, 11 Jul 2022, Ionen Wolkens wrote: > > > >> -ebegin " python_check_deps" > > > >> -

Re: [gentoo-dev] [PATCH v2] python-utils-r1.eclass: avoid nested ebegin calls

2022-07-11 Thread Ionen Wolkens
On Mon, Jul 11, 2022 at 01:08:52PM -0400, Mike Gilbert wrote: > On Mon, Jul 11, 2022 at 12:56 PM Ulrich Mueller wrote: > > > > > On Mon, 11 Jul 2022, Ionen Wolkens wrote: > > >> -ebegin " python_check_deps" > > >> -python_check_deps > > >> -eend ${?} > > >> +einfo "

Re: [gentoo-dev] [PATCH v2] python-utils-r1.eclass: avoid nested ebegin calls

2022-07-11 Thread Mike Gilbert
On Mon, Jul 11, 2022 at 12:11 PM Ionen Wolkens wrote: > > On Mon, Jul 11, 2022 at 09:16:10AM -0400, Mike Gilbert wrote: > > It's common for python_check_deps to call python_has_version, which > > calls ebegin itself. > > > > Signed-off-by: Mike Gilbert > > --- > > eclass/python-utils-r1.eclass

Re: [gentoo-dev] [PATCH v2] python-utils-r1.eclass: avoid nested ebegin calls

2022-07-11 Thread Mike Gilbert
On Mon, Jul 11, 2022 at 12:56 PM Ulrich Mueller wrote: > > > On Mon, 11 Jul 2022, Ionen Wolkens wrote: > >> -ebegin " python_check_deps" > >> -python_check_deps > >> -eend ${?} > >> +einfo " python_check_deps" > >> +if python_check_deps; then > >> +einfo "

Re: [gentoo-dev] [PATCH v2] python-utils-r1.eclass: avoid nested ebegin calls

2022-07-11 Thread Ulrich Mueller
> On Mon, 11 Jul 2022, Ionen Wolkens wrote: >> -ebegin " python_check_deps" >> -python_check_deps >> -eend ${?} >> +einfo " python_check_deps" >> +if python_check_deps; then >> +einfo " python_check_deps succeeded" >> +else >> +einfo "

Re: [gentoo-dev] [PATCH v2] python-utils-r1.eclass: avoid nested ebegin calls

2022-07-11 Thread Ionen Wolkens
On Mon, Jul 11, 2022 at 09:16:10AM -0400, Mike Gilbert wrote: > It's common for python_check_deps to call python_has_version, which > calls ebegin itself. > > Signed-off-by: Mike Gilbert > --- > eclass/python-utils-r1.eclass | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > >

Re: [gentoo-dev] [PATCH v2] python-utils-r1.eclass: avoid nested ebegin calls

2022-07-11 Thread Michał Górny
On Mon, 2022-07-11 at 09:16 -0400, Mike Gilbert wrote: > It's common for python_check_deps to call python_has_version, which > calls ebegin itself. > > Signed-off-by: Mike Gilbert > --- > eclass/python-utils-r1.eclass | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff