Re: [gentoo-dev] [PATCH v2 1/4] eclass/go-module: add support for building based on go.sum

2020-02-22 Thread William Hubbs
I did find a way to apply your patch to the eclass today, so I'm working with it locally now. I would find it much more difficult to add license info to EGO_SUM than to add it to LICENSE= directly. The lines in EGO_SUM are already pretty long and adding info to them manually is more tedious than

Re: [gentoo-dev] [PATCH v2 1/4] eclass/go-module: add support for building based on go.sum

2020-02-19 Thread William Hubbs
On Wed, Feb 19, 2020 at 09:20:13AM -0600, William Hubbs wrote: > On Wed, Feb 19, 2020 at 07:36:27AM +, Robin H. Johnson wrote: > > On Tue, Feb 18, 2020 at 11:46:45PM -0600, William Hubbs wrote: > > > > -# If it does not have a vendor directory, you should use the EGO_VENDOR > > > > +#

Re: [gentoo-dev] [PATCH v2 1/4] eclass/go-module: add support for building based on go.sum

2020-02-19 Thread William Hubbs
On Wed, Feb 19, 2020 at 07:36:27AM +, Robin H. Johnson wrote: > On Tue, Feb 18, 2020 at 11:46:45PM -0600, William Hubbs wrote: > > > -# If it does not have a vendor directory, you should use the EGO_VENDOR > > > +# Alternatively, older versions of this eclass used the EGO_VENDOR > > > #

Re: [gentoo-dev] [PATCH v2 1/4] eclass/go-module: add support for building based on go.sum

2020-02-18 Thread Robin H. Johnson
On Tue, Feb 18, 2020 at 11:46:45PM -0600, William Hubbs wrote: > > -# If it does not have a vendor directory, you should use the EGO_VENDOR > > +# Alternatively, older versions of this eclass used the EGO_VENDOR > > # variable and the go-module_vendor_uris function as shown in the > > # example

Re: [gentoo-dev] [PATCH v2 1/4] eclass/go-module: add support for building based on go.sum

2020-02-18 Thread William Hubbs
On Mon, Feb 17, 2020 at 01:22:29AM -0800, Robin H. Johnson wrote: > EGO_SUM mode now supplements the existing EGO_VENDOR mode. > > EGO_SUM should be populated by the maintainer, directly from the go.sum > file of the root package. See eclass and conversion examples for further > details: