Re: [gentoo-dev] Last rites: app-admin/fluentd
On Wed, 2024-01-10 at 16:20 +0200, Jaco Kroon wrote: > > > > > Tests are busy running now. Seem to be slow. Updated ebuild pushed > to the PR. Will advise test outcome on the PR. I'd be happy to help out with ruby-specific issues and dependencies. > > Someone will probably need/want to look at this circular dependency > at some point. > > * Error: circular dependencies: > > (dev-ruby/rspec-expectations-3.12.3:3/3::gentoo, ebuild scheduled for > merge) depends on > (dev-ruby/rspec-3.12.0:3/3::gentoo, ebuild scheduled for merge) > (buildtime) > (dev-ruby/rspec-expectations-3.12.3:3/3::gentoo, ebuild scheduled > for merge) (buildtime) We won't be able to fix that, unfortunately. This test framework uses itself to test itself, so it needs to be bootstrapped somehow. Kind regards, Hans signature.asc Description: This is a digitally signed message part
Re: [gentoo-dev] Last rites: app-admin/fluentd
Hi Sam, On 2024/01/10 13:02, Sam James wrote: Jaco Kroon writes: How critical is it that they do? Even for the bump PR they do not, they fail with the below, and frankly my knowledge of ruby is outright scary. The below to me indicates that the tests are designed specifically to run from a git checkout, there are two possible "fixes": 1. patch the code to not require this. 2. disable tests. Looking at the code it's simply looking for the .git folder, so mkdir /.git may circumvent this problem if we can solve the below. Test phase: app-admin/fluentd-1.16.3 * Running test phase for ruby31 [...] [...] :85:in `require': cannot load such file -- rr (LoadError) Try adding a test dep on dev-ruby/rr. Tests are busy running now. Seem to be slow. Updated ebuild pushed to the PR. Will advise test outcome on the PR. Someone will probably need/want to look at this circular dependency at some point. * Error: circular dependencies: (dev-ruby/rspec-expectations-3.12.3:3/3::gentoo, ebuild scheduled for merge) depends on (dev-ruby/rspec-3.12.0:3/3::gentoo, ebuild scheduled for merge) (buildtime) (dev-ruby/rspec-expectations-3.12.3:3/3::gentoo, ebuild scheduled for merge) (buildtime) [test] for each depends on the other, so setting a global FEATURES=test breaks things. I don't think this is a critical issue. Anyway, if it works for you in production, and you're willing to (reluctantly) adopt it, then we can work on the tests later. "no choice", so please do proceed to merge the PR. Kind regards, Jaco
Re: [gentoo-dev] Last rites: app-admin/fluentd
Jaco Kroon writes: > Hi, > > On 2024/01/09 13:42, Michał Górny wrote: >> On Tue, 2024-01-09 at 12:54 +0200, Jaco Kroon wrote: >>> https://github.com/gentoo/gentoo/pull/34126 ?? >>> >>> Perhaps I'm missing something if you say it's non-trivial but we're >>> using that on 9 hosts currently. >>> >> Do tests pass for you? https://bugs.gentoo.org/879181#c2 indicated that >> they do not. > > How critical is it that they do? > > Even for the bump PR they do not, they fail with the below, and > frankly my knowledge of ruby is outright scary. The below to me > indicates that the tests are designed specifically to run from a git > checkout, there are two possible "fixes": > > 1. patch the code to not require this. > 2. disable tests. > Test phase: app-admin/fluentd-1.16.3 > * Running test phase for ruby31 > [...] > [...] > :85:in > `require': cannot load such file -- rr (LoadError) Try adding a test dep on dev-ruby/rr. Anyway, if it works for you in production, and you're willing to (reluctantly) adopt it, then we can work on the tests later.
Re: [gentoo-dev] Last rites: app-admin/fluentd
Hi, On 2024/01/09 13:42, Michał Górny wrote: On Tue, 2024-01-09 at 12:54 +0200, Jaco Kroon wrote: https://github.com/gentoo/gentoo/pull/34126 ?? Perhaps I'm missing something if you say it's non-trivial but we're using that on 9 hosts currently. Do tests pass for you? https://bugs.gentoo.org/879181#c2 indicated that they do not. How critical is it that they do? Even for the bump PR they do not, they fail with the below, and frankly my knowledge of ruby is outright scary. The below to me indicates that the tests are designed specifically to run from a git checkout, there are two possible "fixes": 1. patch the code to not require this. 2. disable tests. >>> Test phase: app-admin/fluentd-1.16.3 * Running test phase for ruby31 fatal: not a git repository (or any parent up to mount point /) Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set). /usr/bin/ruby31 -w -I"lib:test" -Eascii-8bit:ascii-8bit /usr/lib64/ruby/gems/3.1.0/gems/rake-13.0.6/lib/rake/rake_test_loader.rb "test/command/test_binlog_reader.rb" "test/command/test_ca_generate.rb" "test/command/test_cap_ctl.rb" "test/command/test_cat.rb" "test/command/test_ctl.rb" "test/command/test_fluentd.rb" "test/command/test_plugin_config_formatter.rb" "test/command/test_plugin_generator.rb" "test/compat/test_calls_super.rb" "test/compat/test_parser.rb" "test/config/test_config_parser.rb" "test/config/test_configurable.rb" "test/config/test_configure_proxy.rb" "test/config/test_dsl.rb" "test/config/test_element.rb" "test/config/test_literal_parser.rb" "test/config/test_plugin_configuration.rb" "test/config/test_section.rb" "test/config/test_system_config.rb" "test/config/test_types.rb" "test/counter/test_client.rb" "test/counter/test_error.rb" "test/counter/test_mutex_hash.rb" "test/counter/test_server.rb" "test/counter/test_store.rb" "test/counter/test_validator.rb" "test/log/test_console_adapter.rb" "test/plugin/in_tail/test_fifo.rb" "test/plugin/in_tail/test_io_handler.rb" "test/plugin/in_tail/test_position_file.rb" "test/plugin/out_forward/test_ack_handler.rb" "test/plugin/out_forward/test_connection_manager.rb" "test/plugin/out_forward/test_handshake_protocol.rb" "test/plugin/out_forward/test_load_balancer.rb" "test/plugin/out_forward/test_socket_cache.rb" "test/plugin/test_bare_output.rb" "test/plugin/test_base.rb" "test/plugin/test_buf_file.rb" "test/plugin/test_buf_file_single.rb" "test/plugin/test_buf_memory.rb" "test/plugin/test_buffer.rb" "test/plugin/test_buffer_chunk.rb" "test/plugin/test_buffer_file_chunk.rb" "test/plugin/test_buffer_file_single_chunk.rb" "test/plugin/test_buffer_memory_chunk.rb" "test/plugin/test_compressable.rb" "test/plugin/test_file_util.rb" "test/plugin/test_filter.rb" "test/plugin/test_filter_grep.rb" "test/plugin/test_filter_parser.rb" "test/plugin/test_filter_record_transformer.rb" "test/plugin/test_filter_stdout.rb" "test/plugin/test_formatter_csv.rb" "test/plugin/test_formatter_hash.rb" "test/plugin/test_formatter_json.rb" "test/plugin/test_formatter_ltsv.rb" "test/plugin/test_formatter_msgpack.rb" "test/plugin/test_formatter_out_file.rb" "test/plugin/test_formatter_single_value.rb" "test/plugin/test_formatter_tsv.rb" "test/plugin/test_in_debug_agent.rb" "test/plugin/test_in_exec.rb" "test/plugin/test_in_forward.rb" "test/plugin/test_in_gc_stat.rb" "test/plugin/test_in_http.rb" "test/plugin/test_in_monitor_agent.rb" "test/plugin/test_in_object_space.rb" "test/plugin/test_in_sample.rb" "test/plugin/test_in_syslog.rb" "test/plugin/test_in_tail.rb" "test/plugin/test_in_tcp.rb" "test/plugin/test_in_udp.rb" "test/plugin/test_in_unix.rb" "test/plugin/test_input.rb" "test/plugin/test_metadata.rb" "test/plugin/test_metrics.rb" "test/plugin/test_metrics_local.rb" "test/plugin/test_multi_output.rb" "test/plugin/test_out_copy.rb" "test/plugin/test_out_exec.rb" "test/plugin/test_out_exec_filter.rb" "test/plugin/test_out_file.rb" "test/plugin/test_out_forward.rb" "test/plugin/test_out_http.rb" "test/plugin/test_out_null.rb" "test/plugin/test_out_relabel.rb" "test/plugin/test_out_roundrobin.rb" "test/plugin/test_out_secondary_file.rb" "test/plugin/test_out_stdout.rb" "test/plugin/test_out_stream.rb" "test/plugin/test_output.rb" "test/plugin/test_output_as_buffered.rb" "test/plugin/test_output_as_buffered_backup.rb" "test/plugin/test_output_as_buffered_compress.rb" "test/plugin/test_output_as_buffered_overflow.rb" "test/plugin/test_output_as_buffered_retries.rb" "test/plugin/test_output_as_buffered_secondary.rb" "test/plugin/test_output_as_standard.rb" "test/plugin/test_owned_by.rb" "test/plugin/test_parser.rb" "test/plugin/test_parser_apache.rb" "test/plugin/test_parser_apache2.rb" "test/plugin/test_parser_apache_error.rb" "test/plugin/test_parser_csv.rb" "test/plugin/test_parser_json.rb" "test/plugin/test_parser_labeled_tsv.rb" "test/plugin/test_parser_multiline.rb" "test/plugin/test_parser_nginx.rb"
Re: [gentoo-dev] Last rites: app-admin/fluentd
On Tue, 2024-01-09 at 12:54 +0200, Jaco Kroon wrote: > https://github.com/gentoo/gentoo/pull/34126 ?? > > Perhaps I'm missing something if you say it's non-trivial but we're > using that on 9 hosts currently. > Do tests pass for you? https://bugs.gentoo.org/879181#c2 indicated that they do not. -- Best regards, Michał Górny signature.asc Description: This is a digitally signed message part
Re: [gentoo-dev] Last rites: app-admin/fluentd
https://github.com/gentoo/gentoo/pull/34126 ?? Perhaps I'm missing something if you say it's non-trivial but we're using that on 9 hosts currently. On 2023/12/31 12:34, Michał Górny wrote: # Michał Górny (2023-12-31) # Unresolved vulnerability. The current version is from 2022-03, # and the bump is non-trivial. # Removal on 2024-01-30. Bug #879181. app-admin/fluentd
