-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Dne 12.3.2011 11:37, Paweł Hajdan, Jr. napsal(a):
One of my ebuilds is using virtualx eclass, and I noticed the following
code inside the eclass:
retval=$?
# Now kill Xvfb
kill $(cat /tmp/.X${XDISPLAY}-lock)
else
On Sat, 12 Mar 2011 11:37:28 +0100
Paweł Hajdan, Jr. phajdan...@gentoo.org wrote:
Shouldn't that last line look more like this (notice $retval instead
of $?):
[[ $retval -ne 0 ]] die ${FUNCNAME}: the ${VIRTALX_COMMAND}
failed.
What do you think?
I'd say even '${VIRTUALX_COMMAND}'.
Doug Goldstein wrote:
Doug Goldstein wrote:
Doug Goldstein wrote:
While the rule of thumb has been if an eclass needs something it should
provide it's own depends. However the virtualx eclass needs to be
different simply because in some cases it's only uses for tests (this is
it's most
Doug Goldstein wrote:
Doug Goldstein wrote:
While the rule of thumb has been if an eclass needs something it should
provide it's own depends. However the virtualx eclass needs to be
different simply because in some cases it's only uses for tests (this is
it's most common usage in the
Doug Goldstein wrote:
While the rule of thumb has been if an eclass needs something it should
provide it's own depends. However the virtualx eclass needs to be
different simply because in some cases it's only uses for tests (this is
it's most common usage in the whole) tree. When it's used for
Doug Goldstein wrote:
While the rule of thumb has been if an eclass needs something it should
provide it's own depends. However the virtualx eclass needs to be
different simply because in some cases it's only uses for tests (this is
it's most common usage in the whole) tree. When it's used for
On 11:35 Thu 16 Oct , Doug Goldstein wrote:
Doug Goldstein wrote:
While the rule of thumb has been if an eclass needs something it should
provide it's own depends. However the virtualx eclass needs to be
different simply because in some cases it's only uses for tests (this is
it's
On Thursday 16 October 2008 23:54:32 Donnie Berkholz wrote:
I'm not sure whether this would work, but one idea would be to handle
dependencies depending on what's in IUSE of the ebuild inheriting.
That would require ebuilds to set IUSE before inheriting the eclass.
--
Bo Andresen
