[gentoo-portage-dev] Fix Misc. Bash Errors in phase-helpers.sh.

2018-02-03 Thread R0b0t1
On line 699, I suspect the test may erroneously expand into: if [ -f ./Makefile ./makefile -o -f ./GNUmakefile ] ; then If both files are present. The test was changed to include both names explicitly. It could also be rewritten with [[, but it seems like it would still either need a loop or

Re: [gentoo-portage-dev] [PATCH] emerge: enable --dynamic-deps=y by default once again (bug 646458)

2018-02-03 Thread Michał Górny
W dniu sob, 03.02.2018 o godzinie 03∶20 -0800, użytkownik Zac Medico napisał: > On 02/03/2018 02:54 AM, Michał Górny wrote: > > W dniu sob, 03.02.2018 o godzinie 00∶57 -0800, użytkownik Zac Medico > > napisał: > > > On 02/03/2018 12:26 AM, Michał Górny wrote: > > > > W dniu pią, 02.02.2018 o

Re: [gentoo-portage-dev] [PATCH] emerge: enable --dynamic-deps=y by default once again (bug 646458)

2018-02-03 Thread Zac Medico
On 02/03/2018 02:54 AM, Michał Górny wrote: > W dniu sob, 03.02.2018 o godzinie 00∶57 -0800, użytkownik Zac Medico > napisał: >> On 02/03/2018 12:26 AM, Michał Górny wrote: >>> W dniu pią, 02.02.2018 o godzinie 18∶23 -0800, użytkownik Zac Medico >>> napisał: There's been a lot of pushback

Re: [gentoo-portage-dev] [PATCH] repoman: Add commit message verification

2018-02-03 Thread Michał Górny
W dniu sob, 03.02.2018 o godzinie 09∶58 +0100, użytkownik Ulrich Mueller napisał: > > > > > > On Fri, 2 Feb 2018, Michał Górny wrote: > > Add a check for common mistakes in commit messages. For now, it is > > pretty rough and exits immediately but it should be integrated with > > the editor in the

Re: [gentoo-portage-dev] [PATCH] emerge: enable --dynamic-deps=y by default once again (bug 646458)

2018-02-03 Thread Michał Górny
W dniu sob, 03.02.2018 o godzinie 00∶57 -0800, użytkownik Zac Medico napisał: > On 02/03/2018 12:26 AM, Michał Górny wrote: > > W dniu pią, 02.02.2018 o godzinie 18∶23 -0800, użytkownik Zac Medico > > napisał: > > > There's been a lot of pushback involving the --dynamic-deps=n default. > > > >

Re: [gentoo-portage-dev] [PATCH] repoman: Add commit message verification

2018-02-03 Thread Ulrich Mueller
> On Fri, 2 Feb 2018, Michał Górny wrote: > Add a check for common mistakes in commit messages. For now, it is > pretty rough and exits immediately but it should be integrated with > the editor in the future. Have you tested this against existing commits in the gentoo repo? Ulrich

Re: [gentoo-portage-dev] [PATCH] emerge: enable --dynamic-deps=y by default once again (bug 646458)

2018-02-03 Thread Zac Medico
On 02/03/2018 12:26 AM, Michał Górny wrote: > W dniu pią, 02.02.2018 o godzinie 18∶23 -0800, użytkownik Zac Medico > napisał: >> There's been a lot of pushback involving the --dynamic-deps=n default. > > Most of it pushed by a single rogue developer. > >> What we really need is a tool to apply

Re: [gentoo-portage-dev] [PATCH] emerge: enable --dynamic-deps=y by default once again (bug 646458)

2018-02-03 Thread Michał Górny
W dniu pią, 02.02.2018 o godzinie 18∶23 -0800, użytkownik Zac Medico napisał: > There's been a lot of pushback involving the --dynamic-deps=n default. Most of it pushed by a single rogue developer. > What we really need is a tool to apply dependency changes in-place, > without the need for a