Re: [gentoo-portage-dev] [PATCH v2] eapply: Output verbosely only if patch fails to apply with -F0

2019-12-13 Thread Ulrich Mueller
> On Fri, 13 Dec 2019, Mike Gilbert wrote: >> > It also triggers pointless bug reports. Please remove this. >> >> I don't like that eqawarn either (see above). >> >> OTOH, users shouldn't normally have "qa" in PORTAGE_ELOG_CLASSES, >> so they won't see the warning? > Here's a bug report

Re: [gentoo-portage-dev] [PATCH] eapply: Drop -s option for patch.

2019-12-13 Thread Mike Gilbert
On Fri, Dec 13, 2019 at 4:42 PM Michał Górny wrote: > > On Fri, 2019-12-13 at 16:37 -0500, Mike Gilbert wrote: > > On Fri, Dec 13, 2019 at 3:36 PM Michał Górny wrote: > > > Just like 'many of the proposals lately', developers are going to be > > > the ones disabling it (because they don't care),

[gentoo-portage-dev] RFC: [QA] notice with 'failed' seds [was PATCH: eapply drop -s option]

2019-12-13 Thread Michael 'veremitz' Everitt
On 13/12/19 20:36, Michał Górny wrote [excerpted]: > > Is this really an argument for or *against* it? Developers are entirely > capable of keeping seds that do nothing for years, as well as patches > that -- while apparently applying correctly -- are entirely meaningless. I think there is some

Re: [gentoo-portage-dev] [PATCH] eapply: Drop -s option for patch.

2019-12-13 Thread Michael 'veremitz' Everitt
On 13/12/19 21:59, Michał Górny wrote: > On Fri, 2019-12-13 at 21:56 +, Michael 'veremitz' Everitt wrote: >> On 13/12/19 21:42, Michał Górny wrote: >>> On Fri, 2019-12-13 at 16:37 -0500, Mike Gilbert wrote: On Fri, Dec 13, 2019 at 3:36 PM Michał Górny wrote: > Just like 'many of the

Re: [gentoo-portage-dev] [PATCH] eapply: Drop -s option for patch.

2019-12-13 Thread Michał Górny
On Fri, 2019-12-13 at 21:56 +, Michael 'veremitz' Everitt wrote: > On 13/12/19 21:42, Michał Górny wrote: > > On Fri, 2019-12-13 at 16:37 -0500, Mike Gilbert wrote: > > > On Fri, Dec 13, 2019 at 3:36 PM Michał Górny wrote: > > > > Just like 'many of the proposals lately', developers are going

Re: [gentoo-portage-dev] [PATCH] eapply: Drop -s option for patch.

2019-12-13 Thread Michael 'veremitz' Everitt
On 13/12/19 21:42, Michał Górny wrote: > On Fri, 2019-12-13 at 16:37 -0500, Mike Gilbert wrote: >> On Fri, Dec 13, 2019 at 3:36 PM Michał Górny wrote: >>> Just like 'many of the proposals lately', developers are going to be >>> the ones disabling it (because they don't care), and users will be

Re: [gentoo-portage-dev] [PATCH] eapply: Drop -s option for patch.

2019-12-13 Thread Michał Górny
On Fri, 2019-12-13 at 16:37 -0500, Mike Gilbert wrote: > On Fri, Dec 13, 2019 at 3:36 PM Michał Górny wrote: > > Just like 'many of the proposals lately', developers are going to be > > the ones disabling it (because they don't care), and users will be the > > ones enabling it (because they do

Re: [gentoo-portage-dev] [PATCH] eapply: Drop -s option for patch.

2019-12-13 Thread Mike Gilbert
On Fri, Dec 13, 2019 at 3:36 PM Michał Górny wrote: > Just like 'many of the proposals lately', developers are going to be > the ones disabling it (because they don't care), and users will be the > ones enabling it (because they do care), just to learn that developers > don't care and go

Re: [gentoo-portage-dev] [PATCH] eapply: Drop -s option for patch.

2019-12-13 Thread Michał Górny
On Fri, 2019-12-13 at 21:31 +0100, Fabian Groffen wrote: > On 13-12-2019 14:24:33 -0500, Michael Orlitzky wrote: > > On 12/13/19 9:28 AM, Fabian Groffen wrote: > > > We are providing those patches, maybe. In reality very often the > > > patches originate from somewhere else though. And you don't

Re: [gentoo-portage-dev] [PATCH] eapply: Drop -s option for patch.

2019-12-13 Thread Fabian Groffen
On 13-12-2019 14:24:33 -0500, Michael Orlitzky wrote: > On 12/13/19 9:28 AM, Fabian Groffen wrote: > > > > We are providing those patches, maybe. In reality very often the > > patches originate from somewhere else though. And you don't want to > > have to respin all of those just because. At

Re: [gentoo-portage-dev] [PATCH] eapply: Drop -s option for patch.

2019-12-13 Thread Zac Medico
On 12/13/19 6:28 AM, Fabian Groffen wrote: > On 13-12-2019 15:24:40 +0100, Michał Górny wrote: ...and why do we consider it correct to apply patches when the context doesn't match? If our only goal is to make things 'easier' for 'everyone', then we could just pass -F and ignore

Re: [gentoo-portage-dev] [PATCH] eapply: Drop -s option for patch.

2019-12-13 Thread Michael Orlitzky
On 12/13/19 9:28 AM, Fabian Groffen wrote: > > We are providing those patches, maybe. In reality very often the > patches originate from somewhere else though. And you don't want to > have to respin all of those just because. At least that's what I feel. > Just because... the context

Re: [gentoo-portage-dev] [PATCH] eapply: Drop -s option for patch.

2019-12-13 Thread Fabian Groffen
On 13-12-2019 15:24:40 +0100, Michał Górny wrote: > > > ...and why do we consider it correct to apply patches when the context > > > doesn't match? If our only goal is to make things 'easier' for > > > 'everyone', then we could just pass -F and ignore all the context. > > > > > > Though I

Re: [gentoo-portage-dev] [PATCH] eapply: Drop -s option for patch.

2019-12-13 Thread Michał Górny
On Fri, 2019-12-13 at 09:06 -0500, Mike Gilbert wrote: > On Fri, Dec 13, 2019 at 8:52 AM Michał Górny wrote: > > On Fri, 2019-12-13 at 08:47 -0500, Mike Gilbert wrote: > > > On Thu, Dec 12, 2019 at 3:15 PM Ulrich Mueller wrote: > > > > > > > > > On Thu, 12 Dec 2019, Mike Gilbert wrote: > > > > >

Re: [gentoo-portage-dev] [PATCH] eapply: Drop -s option for patch.

2019-12-13 Thread Mike Gilbert
On Fri, Dec 13, 2019 at 8:52 AM Michał Górny wrote: > > On Fri, 2019-12-13 at 08:47 -0500, Mike Gilbert wrote: > > On Thu, Dec 12, 2019 at 3:15 PM Ulrich Mueller wrote: > > > > > > > > On Thu, 12 Dec 2019, Mike Gilbert wrote: > > > > I think this should be reverted. It causes too much noise, and

Re: [gentoo-portage-dev] [PATCH v2] eapply: Output verbosely only if patch fails to apply with -F0

2019-12-13 Thread Mike Gilbert
On Thu, Dec 12, 2019 at 4:15 PM Ulrich Mueller wrote: > > > On Thu, 12 Dec 2019, Mike Gilbert wrote: > > > On Wed, Nov 27, 2019 at 11:14 PM Michał Górny wrote: > >> On Wed, 2019-11-27 at 23:49 +0100, Ulrich Mueller wrote: > > >> > The difference is that there is now a QA warning for

Re: [gentoo-portage-dev] [PATCH] eapply: Drop -s option for patch.

2019-12-13 Thread Michał Górny
On Fri, 2019-12-13 at 08:47 -0500, Mike Gilbert wrote: > On Thu, Dec 12, 2019 at 3:15 PM Ulrich Mueller wrote: > > > > > > > On Thu, 12 Dec 2019, Mike Gilbert wrote: > > > I think this should be reverted. It causes too much noise, and > > > "solves" a problem only very rarely. > > > > Now, how

Re: [gentoo-portage-dev] [PATCH] eapply: Drop -s option for patch.

2019-12-13 Thread Mike Gilbert
On Thu, Dec 12, 2019 at 3:15 PM Ulrich Mueller wrote: > > > On Thu, 12 Dec 2019, Mike Gilbert wrote: > > > I think this should be reverted. It causes too much noise, and > > "solves" a problem only very rarely. > > Now, how many lines of output does this typically produce, compared > to the