fix + flag[1:]
> + else:
> + nv =
> use_expand_prefix + flag
> + l.append(nv)
> + ret.setdefault(k.cp, {})[k] =
> tuple(l)
> return ret
>
It looks harmless enough, but I'd like to wait a bit before merge I
think. This also needs a man page description update somewhere.
We need to have another meeting, decide where to cut off for the next
release.
--
Brian Dolbec
pym/portage/package/ebuild/fetch.py| 7 +-
> pym/portage/sync/controller.py | 18 ++- 3 files
> changed, 46 insertions(+), 19 deletions(-)
>
Looks good
--
Brian Dolbec
.
>
> Fixes: d217db2bc76e ("Make use of optparse to fix argument parsing
> for Python 2.6 in bin/chpathtool.py.") ---
> bin/chpathtool.py | 22 --
> 1 file changed, 8 insertions(+), 14 deletions(-)
>
>
Looks good. :)
--
Brian Dolbec
//bugs.gentoo.org/show_bug.cgi?id=536926
> ---
> man/emerge.1| 2 +-
> pym/_emerge/depgraph.py | 2 +-
> pym/portage/tests/resolver/test_backtracking.py | 7 ++-
> 3 files changed, 8 insertions(+), 3 deletions(-)
>
Looks good, merge please.
--
Brian Dolbec
rified that all the the new entries in _decompressors
> support -c and -q, as required by BinpkgExtractorAsync.
yes, looks good, merge please
--
Brian Dolbec
ertions(+), 2 deletions(-)
>
looks good, merge please
--
Brian Dolbec
nce
> it doesn't serve any purpose.
> ---
> pym/portage/sync/modules/cvs/cvs.py | 36
> ++-- 1 file changed, 14
> insertions(+), 22 deletions(-)
>
Looks good, merge please
--
Brian Dolbec
rtage/util/cpuinfo.py| 18 ++
> 2 files changed, 25 insertions(+), 1 deletion(-)
> create mode 100644 pym/portage/util/cpuinfo.py
>
looks good, merge please
--
Brian Dolbec
27;s simple and it works. Maybe we'll come up
> with something fancier later on.
I didn't think it was "ugly", 2 lines of code and some comments...
yes, merge please
--
Brian Dolbec
pym/portage/sync/modules/git/git.py | 14 +-
> 1 file changed, 1 insertion(+), 13 deletions(-)
>
>
Looks good. Thanks.
--
Brian Dolbec
| 31
> +++--
> pym/portage/sync/modules/rsync/rsync.py | 2 +-
> pym/portage/sync/modules/svn/svn.py | 6 --
> pym/portage/sync/modules/websync/websync.py | 6 -- 6 files
> changed, 18 insertions(+), 41 deletions(-)
>
This one is good to merge
--
Brian Dolbec
or not. In fact, remove the whole check since
> it doesn't serve any purpose.
> ---
> pym/portage/sync/modules/svn/svn.py | 42
> +++-- 1 file changed, 17
> insertions(+), 25 deletions(-)
>
>
Looks good, thank you for this update.
--
Brian Dolbec
s/git/git.py index 35943dd..d4f2cc1 100644
> --- a/pym/portage/sync/modules/git/git.py
> +++ b/pym/portage/sync/modules/git/git.py
> @@ -63,9 +63,13 @@ class GitSync(SyncBase):
> sync_uri = self.repo.sync_uri
> if sync_uri.startswith("file://"):
> sync_uri = sync_uri[6:]
> - exitcode = portage.process.spawn_bash("cd %s ; %s
> clone %s ." % \
> + depth_arg = ''
> + if self.repo.sync_depth is not None:
> + depth_arg = '--depth %d ' %
> self.repo.sync_depth
> + exitcode = portage.process.spawn_bash("cd %s ; %s
> clone %s%s ." % \ (portage._shell_quote(self.repo.location),
> self.bin_command,
> + depth_arg,
> portage._shell_quote(sync_uri)),
> **portage._native_kwargs(self.spawn_kwargs))
> if exitcode != os.EX_OK:
--
Brian Dolbec
patch. It was something I missed removing when
I first ported the controller module from the emaint one which
pre-pends an 'all' to the list.
--
Brian Dolbec
= self.repo.sync_uri
> if sync_uri.startswith("file://"):
> sync_uri = sync_uri[6:]
> - exitcode = portage.process.spawn_bash("cd %s ; %s
> clone %s ." % \
> + depth_arg = ''
> + if self.repo.sync_clone_depth is not None:
> + depth_arg = '--depth %d ' %
> self.repo.sync_clone_depth
> + exitcode = portage.process.spawn_bash("cd %s ; %s
> clone %s%s ." % \ (portage._shell_quote(self.repo.location),
> self.bin_command,
> + depth_arg,
> portage._shell_quote(sync_uri)),
> **portage._native_kwargs(self.spawn_kwargs))
> if exitcode != os.EX_OK:
--
Brian Dolbec
rrors='strict'), mode='rb')
> + except IOError as e:
> + if e.errno == PermissionDenied.errno:
> + raise PermissionDenied(f)
> + elif e.errno in (errno.ENOENT, errno.ESTALE):
> + raise FileNotFound(f)
> + else:
> + raise
> +
> + try:
> + return _compression_probe_file(f)
> + finally:
> + if open_file:
> + f.close()
> +
> +def _compression_probe_file(f):
> +
> + m = _compression_re.match(f.read(6))
> + if m is not None:
> + for k, v in m.groupdict().items():
> + if v is not None:
> + return k
> +
> + return None
--
Brian Dolbec
On Thu, 15 Jan 2015 20:53:02 -0800
Zac Medico wrote:
> On 01/15/2015 07:00 PM, Brian Dolbec wrote:
> > On Thu, 15 Jan 2015 17:27:23 -0800
> > Zac Medico wrote:
> >># Add -q to bzip2 opts, in order to avoid
> >> "trailing garbage after # EOF igno
'strict'), mode='rb')
> + except IOError as e:
> + if e.errno == PermissionDenied.errno:
> + raise PermissionDenied(f)
> + elif e.errno in (errno.ENOENT, errno.ESTALE):
> +
| 26 +
> > pym/portage/dep/_slot_operator.py | 13 +++
> > pym/portage/tests/resolver/test_changed_deps.py | 120
> > + 6 files changed, 323 insertions(+), 12
> > deletions(-) create mode 100644
> > pym/portage/tests/resolver/test_changed_deps.py
>
> Any feedback on this? I think it's good to merge.
yeah, looks good, merge approved :)
--
Brian Dolbec
On Sun, 11 Jan 2015 21:16:55 -0800
Zac Medico wrote:
> This eliminates 4 instances of duplicate code from the rcs_archive and
> file_archive functions.
>
> Suggested-by: Brian Dolbec
> ---
Looks much better,
Thank you, merge both patches please
--
Brian Dolbec
On Sun, 11 Jan 2015 17:39:23 -0800
Zac Medico wrote:
> On 01/11/2015 05:21 PM, Brian Dolbec wrote:
> > On Sun, 11 Jan 2015 00:49:50 -0800
> > Zac Medico wrote:
> >> archive) @@ -285,6 +303,12 @@ def file_archive(archive, curconf,
> >> newconf, mrgc
f stat.S_ISLNK(mystat.st_mode):
> os.symlink(os.readlink(newconf),
> newconf_archive)
That makes duplicated code in 4 places :/ I know it's only 4 lines of
actual code plus 2 more for the same repeated comments.
BUT...
This diff doens't show if it's all in the same class.
If possible I'd prefer a small breakout function to do the unlink.
Decorate it with @staticmethod even. If it's named right, you won't
even need the comments repeated throughout the code. Just the
docstring with that comment info.
--
Brian Dolbec
On Wed, 7 Jan 2015 02:08:16 -0800
Zac Medico wrote:
> Fix commit c8a850685232b938cf0896fc2d80e72d57edad17 to re-use the keys
> from _SUBMODULE_PATH_MAP for option choices.
>
> Fixes: c8a850685232 ("Add --sync-submodule
> (534070)") Suggested-by: Brian Dolbec
>
portant.
>
Please file a feature request bug for gentoolkit/eclean.
If I can ever get caught up with other things or we get a gsoc student
that needs some extra work...
Also with eclean and emaint rewritten (by me) so that eclean could use
emaint modules directly. I have thought a few times we might migrate
eclean from gentoolkit to emaint module(s) They can even be installed
separately from portage via ebuild. The emaint system is fully modular
with a plug-in system.
--
Brian Dolbec
Then the:
"choices": ("glsa", "news", "profiles"),
could become:
"choices": list(_SUBMODULE_PATH_MAP)
Then there is only one place to edit as options or code change.
--
Brian Dolbec
On Wed, 17 Dec 2014 17:49:56 -0500
Michael Orlitzky wrote:
> On 12/17/2014 05:32 PM, Brian Dolbec wrote:
> >
> > Only code changes I see to portage, pkgcore (I know nothing about
> > paludis) are to look for the glsa's in the 2 possible locations.
> > The st
e to portage, pkgcore (I know nothing about
paludis) are to look for the glsa's in the 2 possible locations. The
standalone glsa repo, failing that, backup to the gentoo tree.
--
Brian Dolbec
of python version.
>
> X-Gentoo-Bug: 532784
> X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=532784
> ---
> PATCH v2 replaces the _unicode_decode call with
> _unicode(errors="replace"), which is required in order to force the
> EnvironmentError object to be converted to a unicode string.
>
Yup, LGTM
--
Brian Dolbec
RepoConfigLoader.mainRepoLocation()
> > function has been deleted. ]]]
> >
> > --
> > Arfrever Frehtes Taifersar Arahesis
> >
>
> LGTM.
+1
--
Brian Dolbec
RepoConfigLoader.mainRepoLocation()
> > function have been deleted. ]]]
> >
> > --
> > Arfrever Frehtes Taifersar Arahesis
> >
>
> LGTM.
yup, merge
--
Brian Dolbec
d.
> > 1 call to deprecated
> > portage.repository.config.RepoConfigLoader.mainRepo() function has
> > been deleted. ]]]
> >
> > --
> > Arfrever Frehtes Taifersar Arahesis
> >
>
> LGTM.
+1
--
Brian Dolbec
t; --
> Arfrever Frehtes Taifersar Arahesis
lg, merge
--
Brian Dolbec
signature.asc
Description: PGP signature
ver Frehtes Taifersar Arahesis
yeah, lg, merge
--
Brian Dolbec
signature.asc
Description: PGP signature
think about when we can stabilize layman with the repos.conf
support. If this hits the tree in a regular release before a layman
release is stable. We'll be hearing a lot of flak over it.
I think we should be able to start a layman stabilization soon... need
to check on bugs, etc..
- --
Brian Dolb
s to deprecated
> portage.repository.config.RepoConfigLoader.mainRepo() function have
> been deleted. ]]]
>
> --
> Arfrever Frehtes Taifersar Arahesis
yeah, go ahead, merge. Thanks
--
Brian Dolbec
signature.asc
Description: PGP signature
t; ppc64 amd64-linux x86-freebsd m68k s390 ppc-openbsd x64-freebsd
> ppc-macos sparc64-freebsd arm ppc-aix x86-netbsd x86-solaris
> x64-openbsd x86-winnt sparc x86-linux m68k-mint x64-solaris sh x86
> ppc arm64
>
> I suggest to make it predictable.
>
> [[[
> Sor
deprecated PORTDIR, PORTDIR_OVERLAY and SYNC variables.
> ]]]
>
> --
> Arfrever Frehtes Taifersar Arahesis
@team, I want everyone to weigh in on this one before it is merged.
--
Brian Dolbec
signature.asc
Description: PGP signature
d compatibility.
> "--verbose-main-repo-display",
> ]
+++ pym/_emerge/main.py
@@ -50,6 +50,7 @@
"--tree",
"--unordered-display",
"--update",
+# Option does nowt, but temporarily kept for backward compatibility.
^^^ what the hell
On Sun, 7 Dec 2014 19:47:21 +0100
Ulrich Mueller wrote:
>
> > In a separate patch we can also include Brian's deb2targz xz
> > handling for AIX, I guess.
>
> +1
>
> Ulrich
OK, pushed :)
--
Brian Dolbec
signature.asc
Description: PGP signature
.color == 'y' and \
> portage.output.nocolor()
> portage.settings.unlock()
> portage.settings['NOCOLOR'] = 'true'
> + portage.settings.backup_changes('NOCOLOR')
> portage.settings.lock()
>
> ebuild = pargs.pop(0)
that looks like a "DOH!" fix patch ;)
merge please
--
Brian Dolbec
.py
> @@ -629,6 +629,7 @@ setup(
> ['$portage_setsdir', ['cnf/sets/portage.conf']],
> ['$docdir', ['NEWS', 'RELEASE-NOTES']],
> ['$portage_base/bin', ['bin/deprecated-path']],
> + ['$sysconfdir/portage/postsync.d',
> ['cnf/postsync.d/example']], ],
>
> cmdclass = {
I committed a trimmed down slightly re-worded version which installs to
repo.postsync.d/example.
This new repo.postsync.d directory and system is strictly for per-repo
hooks. In this way, the original postsync.d directory hooks are only
run once after all repos are run. It also does not break compatibility
with existing hooks.
--
Brian Dolbec
On Sat, 6 Dec 2014 20:51:38 -0800
Brian Dolbec wrote:
> On Sat, 06 Dec 2014 18:04:28 -0800
> Zac Medico wrote:
>
> > On 12/06/2014 05:54 PM, Brian Dolbec wrote:
> > > From b02b4dff30a7930d5308e400a46c3e59bbee0350 Mon Sep 17 00:00:00
> > > 2001 From: Brian Dolbe
On Sat, 06 Dec 2014 18:04:28 -0800
Zac Medico wrote:
> On 12/06/2014 05:54 PM, Brian Dolbec wrote:
> > From b02b4dff30a7930d5308e400a46c3e59bbee0350 Mon Sep 17 00:00:00
> > 2001 From: Brian Dolbec
> > Date: Sat, 6 Dec 2014 14:54:36 -0800
> > Subject: [PATCH] portage
On Sat, 06 Dec 2014 17:39:45 -0800
Zac Medico wrote:
> On 12/06/2014 04:53 PM, Brian Dolbec wrote:
> >
> > From cd6ef521f930578763ae043a4bc43281bba3bf0e Mon Sep 17 00:00:00
> > 2001 From: Brian Dolbec
> > Date: Sat, 6 Dec 2014 14:54:36 -0800
> > Subject: [PATC
+ protected = False
> +
> + elif src_md5 == cfgfiledict.get(dest_real,
> [None])[0]: # An identical update has previously been
> # merged. Skip it unless the user
> has chosen # --noconfmem.
LGTM
--
Brian Dolbec
From cd6ef521f930578763ae043a4bc43281bba3bf0e Mon Sep 17 00:00:00 2001
From: Brian Dolbec
Date: Sat, 6 Dec 2014 14:54:36 -0800
Subject: [PATCH 2/2] portage/sync/controller.py: Make a per-repo postsync.d
subdir
This then runs per-repo postsync hooks only on scripts in the per-repo subdir.
This
From 4cb661d994cf8503c4459b8f7da7ee0f739a9826 Mon Sep 17 00:00:00 2001
From: Brian Dolbec
Date: Sat, 6 Dec 2014 14:51:13 -0800
Subject: [PATCH 1/2] bin/phase-helpers.shL Fix unpack() for deb2targz .xz types
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
ertions(+), 3 deletions(-)
>
> This file also contains an invalid IFS=OLDIFS setting (which should
> really be IFS=$OLDIFS).
Done, merged, thanks.
--
Brian Dolbec
s.") % \
> - time.strftime('%c',
> time.localtime(lastsync)))
> + _unicode_decode(time.strftime(
> + '%c', time.localtime(lastsync
> return True
> return False
yes, LGTM, merge it
--
Brian Dolbec
> here, since
> + # negative flags may later interact with
> other flags pulled
> + # in via USE_ORDER.
> + configdict_defaults['USE'] = '
> '.join(defaults_use) # Set to None so this code only runs once.
> self._make_defaults = None
>
This code looks fine. As for the test, I know you know what you are
doing :)
LGTM
--
Brian Dolbec
ile_contexts_path}" -r "${D}" "${D}"
> + /usr/sbin/setfiles -F
> "${file_contexts_path}" -r "${D}" "${D}" ) || die "Failed to set
> SELinux security labels." else
> # nonfatal, since merging can happen outside
> a SE kernel
It's fine with me if you fine with it. I just thought you would have
acked it in the bug.
--
Brian Dolbec
; and world writable)"
> - for x in $unsafe_files ; do
> - __eqawarnlog world-writable-setid "$x"
> - done
> + eqatag -v world-writable-setid $unsafe_files
> +
> die "Unsafe files found in \${D}. Portage will not
> install them." fi
>
--
Brian Dolbec
; X-Gentoo-Bug: 490732
> X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=490732
> ---
> PATCH v3 fixes emerge --unmerge --pretend to succeed when /var/db/pkg
> is not writable (--pretend actions may still be useful when operating
> with a readonly filesystem).
>
LGTM
--
Brian Dolbec
13.5% fewer use_reduce calls.
>
> X-Gentoo-Bug: 529660
> X-Gentoo-Url: https://bugs.gentoo.org/show_bug.cgi?id=529660
> ---
patch looks good, just did you mean "Memorize" & "memorization" instead
of "Memoize" & "memoization"
--
Brian Dolbec
able(self):
> + """
> + @rtype: bool
> + @return: True if var/db/pkg is writable, False
> otherwise
> + """
> + return os.access(first_existing(self._dbroot),
> os.W_OK) +
> + @property
> def root(self):
> warnings.warn("The root attribute of "
> "portage.dbapi.vartree.vardbapi"
--
Brian Dolbec
On Mon, 17 Nov 2014 22:06:41 -0800
Brian Dolbec wrote:
> On Mon, 17 Nov 2014 21:09:42 -0800
> Zac Medico wrote:
>
> > On 11/11/2014 05:55 PM, Zac Medico wrote:
> > > This patch causes dep_zapdeps to check which USE flags cause a
> > > match to fail, and us
use.mask or use.force.
> >
> > X-Gentoo-Bug: 515584
> > X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=515584
>
> Any issues with this? I think this one is good to merge.
I thought this was merged already... I'll recheck in the morning
--
Brian Dolbec
ander (bernalex) will reset the meeting scheduler with some days to
fill in with your availability.
Some patches/branches up for review/inclusion, plugin-sync, new
indexed search for emerge, qa checks patches, EAPI 6, ...
--
Brian Dolbec
X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=490732
> ---
> This updated patch fixes the typo spotted by Brian Dolbec.
>
LGTM, go for it.
but for future reference...
use brackets to group multiline imports instead of line continuations.
- from portage.
tyManager import
> ContentsCaseSensitivityManager
> import errno
> import fnmatch
> @@ -1525,6 +1526,7 @@ class dblink(object):
> # When necessary, this attribute is modified for
> # compliance with RESTRICT=preserve-libs.
> self._preserve_libs = "preserve-libs" in
> mysettings.features
> + self._contents = ContentsCaseSensitivityManager(self)
>
> def __hash__(self):
> return hash(self._hash_key)
> @@ -1612,6 +1614,7 @@ class dblink(object):
> self.contentscache = None
> self._contents_inodes = None
> self._contents_basenames = None
> + self._contents.clear_cache()
>
> def getcontents(self):
> """
--
Brian Dolbec
bug #433453.")
> ---
Just a wrong word in the commit message, otherwise looks good
--
Brian Dolbec
nctions
or the sensitivity set exported versions of them.
> def __hash__(self):
> return hash(self._hash_key)
>
> @@ -1612,6 +1619,7 @@ class dblink(object):
> self.contentscache = None
> self._contents_inodes = None
> self._contents_basenames = None
> + self._contents_case_sensitivity_manager.clear_cache()
again...
+ self._contents.clear_cache()
>
> def getcontents(self):
> """
--
Brian Dolbec
challenge? ;)
I think it would certainly make the code more maintainable, less
daunting and more clearly defined. We could even split vartree.py into
some smaller files or sub-pkg. I dislike multi-thousand lines of code
files and classes. It makes it much more difficult to move around and
keep track of interactions between the code (complexity) and to learn
everything it does.
--
Brian Dolbec
nappropriate replacement
> parent of
> + # a lower version than desired.
> + ResolverPlaygroundTestCase(
> + ["@world"],
> + success = True,
> + options = { "--update": True,
> "--deep": True },
> + mergelist = []),
> + )
> +
> + playground = ResolverPlayground(ebuilds=ebuilds,
> + installed=installed, world=world,
> debug=False)
> + try:
> + for test_case in test_cases:
> + playground.run_TestCase(test_case)
> +
> self.assertEqual(test_case.test_success,
> + True, test_case.fail_msg)
> + finally:
> + playground.cleanup()
--
Brian Dolbec
13 insertions(+), 1 deletion(-)
>
LGTM, merge your fixed patch.
Thank you Swen and Zac
--
Brian Dolbec
typo...^
:)
> + ReadOnlyFileSystem):
> pass
> try:
> try:
--
Brian Dolbec
> atomic_ofstream(self._cache_delta_filename, 'w',
> + encoding=_encodings['repo.content'],
> errors='strict')
> + json.dump({
> + "version":
> self._aux_cache_delta_version,
> + "timestamp": timestamp
> + }, f, ensure_ascii=False)
> + f.close()
> + apply_secpass_permissions(
> + self._cache_delta_filename,
> mode=0o644) +
> self._aux_cache["modified"] = set()
>
> @property
> @@ -1590,6 +1723,12 @@ class dblink(object):
> self.dbdir, noiselevel=-1)
> return
>
> + if self.dbdir is self.dbpkgdir:
> + counter, = self.vartree.dbapi.aux_get(
> + self.mycpv, ["COUNTER"])
> + self.vartree.dbapi._cache_delta("remove",
> self.mycpv,
> + self.settings["SLOT"].split("/")[0],
> counter) +
> shutil.rmtree(self.dbdir)
> # If empty, remove parent category directory.
> try:
> @@ -4196,6 +4335,8 @@ class dblink(object):
> self.delete()
> _movefile(self.dbtmpdir, self.dbpkgdir,
> mysettings=self.settings) self._merged_path(self.dbpkgdir,
> os.lstat(self.dbpkgdir))
> + self.vartree.dbapi._cache_delta("add",
> + self.mycpv, slot, counter)
> finally:
> self.unlockdb()
>
--
Brian Dolbec
to maintain them.
>
> Fixes: 2fcdb5f36fac ("Add btrfs.* to default PORTAGE_XATTR_EXCLUDE
> (527636)") X-Gentoo-Bug: 527636
> X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=527636
> Acked-by: Brian Dolbec
> Acked-by: Anthony G. Basile
> ---
> bin/
2.515s
user0m11.795s
sys 0m0.660s
big_daddy portage #
I know the above times are probably slowed by not having overlays indexed, but
it is still a significant speedup.
esearch is only marginally slower doing a -S search than a regular pkg-name
search, typically just over 0.2 seconds
The above was done with only the gentoo repo indexed, plus I need to clean out
some old ebuilds in overlays.
But I was shocked to see the normal -s searches going from 3.4s to 5.5s with
your new index.
Also I did not see a way to specify all repos to be index updated. It is I
believe a requirement of this new system. Re-running is for each repo
installed individually is something to be reserved for the new postsync() to do
when it lands in master.
--
Brian Dolbec
+
> pym/portage/util/__init__.py| 35 ++- 3 files
> changed, 463 insertions(+), 119 deletions(-) create mode 100644
> pym/portage/tests/emerge/test_config_protect.py
>
See my github inline comments re: use of my* variables
--
Brian Dolbec
On Sun, 02 Nov 2014 09:27:07 -0800
Zac Medico wrote:
> On 11/02/2014 09:19 AM, Brian Dolbec wrote:
> >
> > I'm a little confused. Is this a fix for Bertrands bashrc patches
> > already applied? Or is it unrelated?
>
> It's a feature enhancement to add
PGP SIGNATURE-
>
Yes, it is fine. In fact we are almost ready for an alpha release of
gentoo-keys.
Doing this will give us some to test ggp signed commits for a git
commit hook :)
- --
Brian Dolbec
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0
iQJ8BA
om_prof,
> True, True,
> + ('profile-bashrcs',)))
> del custom_prof
>
> self.profiles = tuple(self.profiles)
I'm a little confused. Is this a fix for Bertrands bashrc patches
already applied? Or is it unrelated?
--
Brian Dolbec
40f5f05bc31eb571702f
> Reviewed-on: https://chromium-review.googlesource.com/225423
> Tested-by: David James
> Reviewed-by: Mike Frysinger
> ---
> pym/portage/dbapi/bintree.py | 8 ----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Squash the 2 commits together and commit please
--
Brian Dolbec
age/tests/resolver/test_virtual_slot.py | 66
> + 2 files changed, 87 insertions(+)
>
Looks good, merge away
--
Brian Dolbec
pym/portage/tests/resolver/test_virtual_slot.py | 11 ++- 3 files
> changed, 106 insertions(+), 31 deletions(-)
>
not that I'll pretend to understand all the code changes, but looks good
merge away
--
Brian Dolbec
E_XATTR_EXCLUDE="security.*
> system.nfs4_acl" +PORTAGE_XATTR_EXCLUDE="btrfs.* security.*
> system.nfs4_acl"
> #*
> #** DO NOT EDIT THIS FILE **
--
Brian Dolbec
return list(self._cp_map)
> + cp_map = self._cp_map
> + for cpv in self._vardb.cpv_all():
> + cp = portage.cpv_getkey(cpv)
> + if cp is not None:
> + cp_list = cp_map.get(cp)
> + if cp_list is None:
> + cp_list = []
> + cp_map[cp] = cp_list
> + cp_list.append(_pkg_str(cpv))
> + return list(cp_map)
> +
> + def match(self, atom):
> + if not isinstance(atom, Atom):
> + atom = Atom(atom)
> + cp_list = self._cp_map.get(atom.cp)
> + if cp_list is None:
> + return []
> + self._vardb._cpv_sort_ascending(cp_list)
> + return portage.match_from_list(atom, cp_list)
> +
> + def aux_get(self, cpv, attrs, myrepo = None):
> + pkg_data =
> self._vardb._aux_cache["packages"].get(cpv)
> + if not isinstance(pkg_data, tuple) or \
> + len(pkg_data) != 2 or \
> + not isinstance(pkg_data[1], dict):
> + pkg_data = None
> + if pkg_data is None:
> + # It may be missing from _aux_cache due to
> + # _aux_cache_threshold.
> + return self._vardb.aux_get(cpv, attrs)
> + metadata = pkg_data[1]
> + return [metadata.get(k, "") for k in attrs]
Otherwise it looks good.
--
Brian Dolbec
ss to the EROOT directory (not due to the 0002 bit). For
> > use in conditional logic (for example, see doebuild.py diff),
> > "unprivileged" is automatically added to the FEATURES variable.
> >
> > X-Gentoo-Bug: 433453
> > X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=433453
>
> Now that 2.2.14 in released, can we merge this?
yes
--
Brian Dolbec
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
On Thu, 9 Oct 2014 12:18:34 -0700
Brian Dolbec wrote:
> >
> On Thu, 09 Oct 2014 11:17:17 +0200
> Alexander Berntsen wrote:
>
>> >
> > On 08/10/14 22:10, Brian Dolbec wrote:
> > > Can you edit whenisgood f
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
On Thu, 09 Oct 2014 11:17:17 +0200
Alexander Berntsen wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
> On 08/10/14 22:10, Brian Dolbec wrote:
> > Can you edit whenisgood for a meeting this weekend/next week. If
&
merge.
We will be having a team meeting soon to decide recent patches, etc..
Although I think for the 2.2.14 final release we will not include this,
just a few bug fixes. After 2.2.14 final is released we will likely
merge it so it will be in for awhile and then the 2.2.15 release.
--
Brian Dolbec
On Wed, 3 Sep 2014 17:35:40 -0700
Version 2 with all noted things fixed, also the tests pass, and rebased
onto the current master as of the travis-ci tests fix commit.
Brian Dolbec wrote:
>
> Most of you know about the plugin-sync branch of our portage.git repo.
> I believe it is
einstall packages when slot/sub-slot := " "operator dependencies can
> be satisfied by a newer slot, so that " @@ -803,6 +810,12 @@ def
> parse_opts(tmpcmdline, silent=False): if myoptions.quiet_fail in
> true_y: myoptions.quiet_fail = 'y'
>
> + if myoptions.read_news in true_y:
> + myoptions.read_news = True
> + else:
> + myoptions.read_news = None
> +
> +
> if myoptions.rebuild_if_new_slot in true_y:
> myoptions.rebuild_if_new_slot = 'y'
>
LGTM, merge please :)
--
Brian Dolbec
, 19 insertions(+), 3 deletions(-)
>
>
committed and released in 2.2.14_rc1
--
Brian Dolbec
bin/install-qa-check.d/90gcc-warnings | 62
> +++ 1 file changed, 33 insertions(+),
>
Merged Both patches, 1 & 2 of 2, released in 2.2.14_rc1
--
Brian Dolbec
unmask_unrestricted_atoms = \
>
> self._frozen_config.myopts.get("--autounmask-unrestricted-atoms",
> "n") == True quiet = "--quiet" in self._frozen_config.myopts
> pretend = "--pretend" in self._frozen_config.myopts
> - ask = "--ask" in self._frozen_config.myopts
> enter_invalid = '--ask-enter-invalid' in
> self._frozen_config.myopts
> def check_if_latest(pkg):
committed, released in 2.2.14_rc1
--
Brian Dolbec
On Thu, 25 Sep 2014 11:30:53 -0700
Brian Dolbec wrote:
> On Thu, 25 Sep 2014 11:12:51 -0700
> Zac Medico wrote:
>
> > On 09/24/2014 10:48 PM, Michał Górny wrote:
> > > Spotted-by: Zac Medico
> > > ---
> > > bin/phase-functions.sh
On Thu, 25 Sep 2014 22:29:32 -0700
Zac Medico wrote:
> On 09/25/2014 09:22 PM, Brian Dolbec wrote:
> > OK, I've commented out the pkg_preinst sanity check for now.
> >
> > I've also updated the ebuild to create the deprecation
> > symlinks. setup.py
here as well. Although it is the same code installed as
currently.
If our testing doesn't come up with any more regressions, I'll release
the rc1 for some additional testing.
--
Brian Dolbec
portage-2.2.14_rc1.ebuild
Description: Binary data
src_unpack() { default; }
> > declare -F src_prepare >/dev/null || \
> >
>
> LGTM. I'm pretty sure there are no other issues with
> 772ed29fd9e7cf722aed943adbe33a27f250e1ff, so I'd say we should go
> ahead and merge it with these 2 fixes.
yeah, my thought too.
It's also why I was bugging him to get this fixed, so we could re-apply
it all.
--
Brian Dolbec
urposes). If not running from a source tree,
> then the PATH variable is used to locate the quickpkg binary.
>
> X-Gentoo-Bug: 523152
> X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=523152
LGTM, merge it please.
--
Brian Dolbec
solver/ResolverPlayground.py | 16
> ++-- 2 files changed, 21 insertions(+), 6 deletions(-)
>
LGTM
--
Brian Dolbec
, generate pseudo-deps for such installed packages, and use
> those to generate the rebuild info.
>
> X-Gentoo-Bug: 521990
> X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=521990
> ---
>
LGTM, merge away
--
Brian Dolbec
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
On Mon, 08 Sep 2014 09:56:59 +0200
Alexander Berntsen wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
> LGTM.
> - --
> Alexander
> berna...@gentoo.org
>
+1, commit
- --
Brian Dolbec
-BEGIN PG
any questions about any of the
current/recent patches submitted. Also please reply to the list mails
for any of those patches with your concerns or error detections.
--
Brian Dolbec
On Mon, 08 Sep 2014 18:32:56 -0700
Zac Medico wrote:
> The attached patch fixes bug #522362 and includes a test case. Any
> future updates to this patch can be found in this branch:
>
> https://github.com/zmedico/portage/tree/bug_522362
>
LGTM
--
Brian Dolbec
e.
> >
>
> It would be nice. As currently, when people commit to overlays using
> repoman, logs look quite unclear. Adding such an option to overlay
> configuration files is a good idea.
>
> --
> Jauhien
>
>
Tom, can you have a look at this for the repoman rewrite.
On Thu, 4 Sep 2014 08:54:48 +0200
Michał Górny wrote:
> Dnia 2014-09-03, o godz. 23:48:50
> Brian Dolbec napisał(a):
>
> > if it still isn't correct, please reply with it corrected...
> > much appreciated :)
>
> [[ -n ${repo_sync_type} && ( ${repo_s
On Thu, 4 Sep 2014 08:38:29 +0200
Michał Górny wrote:
> Dnia 2014-09-03, o godz. 18:22:15
> Brian Dolbec napisał(a):
>
> > fixed: bracket spacing (spotted by mrueg)
> >
> > diff --git a/bin/emerge-webrsync b/bin/emerge-webrsync
> > index 2f0689c..43
401 - 500 of 634 matches
Mail list logo
