Re: [gentoo-portage-dev] [PATCH 1/3] emerge: Deprecate --autounmask

2014-01-27 Thread Tom Wijsman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Mon, 27 Jan 2014 23:13:20 +0100 Alexander Berntsen alexan...@plaimi.net wrote: On 27/01/14 23:00, Tom Wijsman wrote: A first idea from looking at search engine results is through the menu View and then click Message Source; maybe there's

Re: [gentoo-portage-dev] [PATCH 1/3 v2] Have repoman check if the packages to unpack rare archive formats from SRC_URI are present in DEPEND (bug #205909).

2014-01-21 Thread Tom Wijsman
that are in @system are not complained about by this code: if format not in system_set_atoms: -- With kind regards, Tom Wijsman (TomWij) Gentoo Developer E-mail address : tom...@gentoo.org GPG Public Key : 6D34E57D GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D

Re: [gentoo-portage-dev] Signing off patches

2014-01-21 Thread Tom Wijsman
, Tom Wijsman (TomWij) Gentoo Developer E-mail address : tom...@gentoo.org GPG Public Key : 6D34E57D GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D signature.asc Description: PGP signature

Re: [gentoo-portage-dev] [PATCH 1/3] pym/portage/package/ebuild/fetch.py: Factor out _get_checksum_failure_max_tries

2014-01-19 Thread Tom Wijsman
(settings.get(key), default) !!! Variable %s contains non-integer value: '%s % (key, ...) If needed, add a word to key to make the variable name slightly more meaningful; but avoid the full length if possible. eg. try_mirrors_key -- With kind regards, Tom Wijsman (TomWij) Gentoo Developer E-mail

Re: [gentoo-portage-dev] [PATCH 2/3] pym/portage/package/ebuild/fetch.py: Factor out _get_fetch_resume_size

2014-01-19 Thread Tom Wijsman
empty, silently use the default. v = default Afterwards, you have 'match = _fetch_resume_size_re.match(v)' in both places, you can again just have this once. Can the two remaining code blocks just be placed after that? -- With kind regards, Tom Wijsman (TomWij) Gentoo Developer E-mail

Re: [gentoo-portage-dev] Signing off patches

2014-01-19 Thread Tom Wijsman
On Sat, 18 Jan 2014 20:15:57 -0800 W. Trevor King wk...@tremily.us wrote: On Sun, Jan 19, 2014 at 02:33:06AM +0100, Tom Wijsman wrote: On Sat, 18 Jan 2014 15:24:59 -0800 W. Trevor King wk...@tremily.us wrote: If it doesn't need to get updated, then it probably already started out

Re: [gentoo-portage-dev] [PATCH 2/3] pym/portage/package/ebuild/fetch.py: Factor out _get_fetch_resume_size

2014-01-19 Thread Tom Wijsman
On Sun, 19 Jan 2014 18:01:23 -0800 W. Trevor King wk...@tremily.us wrote: On Mon, Jan 20, 2014 at 02:41:41AM +0100, Tom Wijsman wrote: There is some duplicate code here, I think the conditions can be rewritten in such way that the duplicate code doesn't take place. Do you want a rewrite

Re: [gentoo-portage-dev] Signing off patches

2014-01-18 Thread Tom Wijsman
On Sat, 18 Jan 2014 08:43:12 -0800 W. Trevor King wk...@tremily.us wrote: On Sat, Jan 18, 2014 at 04:02:02PM +0100, Tom Wijsman wrote: I think the idea is that you shouldn't need to refer to an external resource like the mailing list to understand the idea behind the patch, Either someone

Re: [gentoo-portage-dev] Signing off patches

2014-01-18 Thread Tom Wijsman
;). However, if a consistent syntax already exists, I see no reason not to use it when it suits your purpose. We discuss here whether to make it policy to use the same syntax. -- With kind regards, Tom Wijsman (TomWij) Gentoo Developer E-mail address : tom...@gentoo.org GPG Public Key : 6D34E57D

[gentoo-portage-dev] [PATCH 2/3 v2] Have repoman check that a package directory contains at least one ebuild (bug #245305).

2014-01-17 Thread Tom Wijsman
--- bin/repoman | 8 man/repoman.1 | 3 +++ 2 files changed, 11 insertions(+) diff --git a/bin/repoman b/bin/repoman index d1542e9..44f3d3d 100755 --- a/bin/repoman +++ b/bin/repoman @@ -326,6 +326,7 @@ qahelp = { SRC_URI.mirror: A uri listed in profiles/thirdpartymirrors is

Re: [gentoo-portage-dev] [PATCH 1/3] Have repoman check if the packages to unpack rare archive formats from SRC_URI are present in DEPEND (bug #205909).

2014-01-17 Thread Tom Wijsman
. -- With kind regards, Tom Wijsman (TomWij) Gentoo Developer E-mail address : tom...@gentoo.org GPG Public Key : 6D34E57D GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D signature.asc Description: PGP signature

[gentoo-portage-dev] When must we write tests, when is it optional?

2014-01-17 Thread Tom Wijsman
Hello Looking back on the repoman patches from both me and creffett, we haven't written tests; it's on my plan to still do that, if possible. This makes me wonder: Should writing tests be a requirement? When? -- With kind regards, Tom Wijsman (TomWij) Gentoo Developer E-mail address : tom

Re: [gentoo-portage-dev] [PATCH 1/3] Have repoman check if the packages to unpack rare archive formats from SRC_URI are present in DEPEND (bug #205909).

2014-01-16 Thread Tom Wijsman
On Wed, 15 Jan 2014 17:44:15 -0800 Alec Warner anta...@gentoo.org wrote: On Wed, Jan 15, 2014 at 4:07 PM, Tom Wijsman tom...@gentoo.org wrote: --- bin/repoman | 53 + man/repoman.1 | 4 2 files changed, 57 insertions(+) I

Re: [gentoo-portage-dev] [PATCH 1/3] Have repoman check if the packages to unpack rare archive formats from SRC_URI are present in DEPEND (bug #205909).

2014-01-16 Thread Tom Wijsman
On Thu, 16 Jan 2014 08:03:03 +0100 Sebastian Luther sebastianlut...@gmx.de wrote: Am 16.01.2014 01:07, schrieb Tom Wijsman: --- bin/repoman | 53 + man/repoman.1 | 4 2 files changed, 57 insertions(+) diff --git a/bin

Re: [gentoo-portage-dev] [PATCH 1/3] Have repoman check if the packages to unpack rare archive formats from SRC_URI are present in DEPEND (bug #205909).

2014-01-16 Thread Tom Wijsman
. And now we have a bunch of great new volunteers. Yes, we do. Sebastian even *told* you specifically how to do this properly. Where did he? So please do. Why? - -- With kind regards, Tom Wijsman (TomWij) Gentoo Developer E-mail address : tom...@gentoo.org GPG Public Key : 6D34E57D GPG

Re: [gentoo-portage-dev] [PATCH 1/3] Have repoman check if the packages to unpack rare archive formats from SRC_URI are present in DEPEND (bug #205909).

2014-01-16 Thread Tom Wijsman
/syntax/, checks/metadata/ and so on. I really would love to see repoman refactored, redesigned and/or rewritten; but it is to soon for me to do this the most wise way, as I need to understand the code. I plan to do this 2 - 4 weeks from now. -- With kind regards, Tom Wijsman (TomWij) Gentoo

[gentoo-portage-dev] [PATCH 2/3] Have repoman check that a package directory contains at least one ebuild (bug #245305).

2014-01-15 Thread Tom Wijsman
--- bin/repoman | 8 man/repoman.1 | 3 +++ 2 files changed, 11 insertions(+) diff --git a/bin/repoman b/bin/repoman index 9b703dc..3263ceb 100755 --- a/bin/repoman +++ b/bin/repoman @@ -330,6 +330,7 @@ qahelp = { SRC_URI.mirror: A uri listed in profiles/thirdpartymirrors is

[gentoo-portage-dev] Repoman patches for bugs #205909, #245305 and #482084.

2014-01-15 Thread Tom Wijsman
). [PATCH 2/3] Have repoman check that a package directory contains at least one ebuild (bug #245305). [PATCH 3/3] Have repoman deprecate G2CONF for the GNOME team. (bug #482084). -- With kind regards, Tom Wijsman (TomWij) Gentoo Developer E-mail address : tom...@gentoo.org GPG Public

Re: [gentoo-portage-dev] Bugzilla workflow

2014-01-14 Thread Tom Wijsman
the bug RESOLVED, FIXED. Sounds good. -- With kind regards, Tom Wijsman (TomWij) Gentoo Developer E-mail address : tom...@gentoo.org GPG Public Key : 6D34E57D GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D signature.asc Description: PGP signature

Re: [gentoo-portage-dev] [PATCH] Document bugzilla workflow

2014-01-14 Thread Tom Wijsman
. +It is encouraged to set the alias field for frequently used bugs. Yes, but please set it to something specific enough; I'm tired of searching for a random word and get into one or another old bug. -- With kind regards, Tom Wijsman (TomWij) Gentoo Developer E-mail address : tom...@gentoo.org GPG Public

Re: [gentoo-portage-dev] [PATCH] Add repoman check to warn if src_prepare/src_configure are used in EAPI 0/1

2014-01-13 Thread Tom Wijsman
. -- With kind regards, Tom Wijsman (TomWij) Gentoo Developer E-mail address : tom...@gentoo.org GPG Public Key : 6D34E57D GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D signature.asc Description: PGP signature

Re: [gentoo-portage-dev] [PATCH 1/2] Add list of live eclasses to portage.const

2013-11-29 Thread Tom Wijsman
subversion tla + git-r3, Thank you very much, that warning gets me every time. -- With kind regards, Tom Wijsman (TomWij) Gentoo Developer E-mail address : tom...@gentoo.org GPG Public Key : 6D34E57D GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D signature.asc

[gentoo-portage-dev] [IDEA] Enumerate solutions for blockers, to avoid tedious manual work. (was: Re: [gentoo-dev] Releng breakage with respect to move from dev-python/python-exec to dev-lang/python-e

2013-11-03 Thread Tom Wijsman
respond there and drop gentoo-dev from CC, thank you very much in advance. -- With kind regards, Tom Wijsman (TomWij) Gentoo Developer E-mail address : tom...@gentoo.org GPG Public Key : 6D34E57D GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D signature.asc Description