Re: [gentoo-portage-dev] [PATCH] depgraph: make _minimize_children deterministic (bug 631894)

2017-09-25 Thread Zac Medico
On 09/24/2017 11:11 PM, Brian Dolbec wrote: > On Sun, 24 Sep 2017 11:57:19 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > >> In order for the eliminate_pkg loop to produce deterministic results, >> the order of the pkgs list must not be random. Prefer to eliminate

[gentoo-portage-dev] [PATCH] depgraph: make _minimize_children deterministic (bug 631894)

2017-09-24 Thread Zac Medico
In order for the eliminate_pkg loop to produce deterministic results, the order of the pkgs list must not be random. Prefer to eliminate installed packages first, in case rebuilds are needed, and also sort in ascending order so that older versions are eliminated first. X-Gentoo-bug: 631894

Re: [gentoo-portage-dev] [PATCH] repoman: Update --bug/--closes description for bugs.g.o hooks

2017-09-02 Thread Zac Medico
On 09/02/2017 12:10 PM, Michał Górny wrote: > Update the description for --bug and --closes to account for the fact > that the tags are now handled by git hooks on Gentoo Infra, and cause > actions on Gentoo Bugzilla. > > // NB: It would probably make sense for --closes to default to Gentoo > bug

Re: [gentoo-portage-dev] [PATCH] Do not enable optimizations by default to work-around pycparser issue

2017-09-02 Thread Zac Medico
On 09/02/2017 02:05 PM, Michał Górny wrote: > W dniu sob, 02.09.2017 o godzinie 12∶19 -0700, użytkownik Zac Medico > napisał: >> On 09/02/2017 10:46 AM, Michał Górny wrote: >>> dev-python/pycparser-2.18+ exposes a design flaw in dev-python/ply that >>> makes it unable

Re: [gentoo-portage-dev] [PATCH] Do not enable optimizations by default to work-around pycparser issue

2017-09-02 Thread Zac Medico
On 09/02/2017 12:19 PM, Zac Medico wrote: > On 09/02/2017 10:46 AM, Michał Górny wrote: >> dev-python/pycparser-2.18+ exposes a design flaw in dev-python/ply that >> makes it unable to work with -OO code. Remove the optimizations from >> Portage shebangs to prevent triggeri

Re: [gentoo-portage-dev] [PATCH] Do not enable optimizations by default to work-around pycparser issue

2017-09-02 Thread Zac Medico
On 09/02/2017 10:46 AM, Michał Górny wrote: > dev-python/pycparser-2.18+ exposes a design flaw in dev-python/ply that > makes it unable to work with -OO code. Remove the optimizations from > Portage shebangs to prevent triggering the issue until we find a proper > solution for it. > > Bug:

Re: [gentoo-portage-dev] [PATCH] ebuild.sh: Fail on command-not-found in global scope

2017-08-31 Thread Zac Medico
On 08/31/2017 07:56 AM, Michał Górny wrote: > The PMS specifies that ebuilds must not call external commands in global > scope. We can not prevent that from happening at the moment since a few > ebuilds in Gentoo are still doing that. > > Instead, start increasing strictness by explicitly failing

Re: [gentoo-portage-dev] [PATCH] ebuild.sh: Explicitly ban get_libdir in global scope

2017-08-31 Thread Zac Medico
On 08/30/2017 01:45 PM, Michał Górny wrote: > W dniu śro, 30.08.2017 o godzinie 13∶35 -0700, użytkownik Zac Medico > napisał: >> On 08/30/2017 01:31 PM, Michał Górny wrote: >>> W dniu śro, 30.08.2017 o godzinie 10∶48 -0700, użytkownik Zac Medico >>> napisał: >&

Re: [gentoo-portage-dev] [PATCH] ebuild.sh: Explicitly ban get_libdir in global scope

2017-08-30 Thread Zac Medico
On 08/30/2017 01:31 PM, Michał Górny wrote: > W dniu śro, 30.08.2017 o godzinie 10∶48 -0700, użytkownik Zac Medico > napisał: >> On 08/30/2017 02:06 AM, Michał Górny wrote: >>> The value of get_libdir depends on the profile, and so it is not useful >>> for depend

Re: [gentoo-portage-dev] [PATCH] ebuild.sh: Explicitly ban get_libdir in global scope

2017-08-30 Thread Zac Medico
On 08/30/2017 10:52 AM, Ulrich Mueller wrote: >>>>>> On Wed, 30 Aug 2017, Zac Medico wrote: > >> It's possible that there are working ebuilds that call get_libdir in >> global scope. > > How could that be possible when get_libdir() is defined in > ph

Re: [gentoo-portage-dev] [PATCH] ebuild.sh: Explicitly ban get_libdir in global scope

2017-08-30 Thread Zac Medico
On 08/30/2017 02:06 AM, Michał Górny wrote: > The value of get_libdir depends on the profile, and so it is not useful > for dependency calculations. Furthermore, it seems that Portage does > not handle defining it in global scope well due to EAPI checking magic. > Ban it completely where it is

Re: [gentoo-portage-dev] [PATCH v2] __dyn_install: improve reporting of build and image sizes

2017-08-27 Thread Zac Medico
On 08/27/2017 08:06 AM, Fabian Groffen wrote: > Prior to this commit, the reported sizes would look like: > > * Final size of build directory: 34942 KiB > * Final size of installed tree: 5627 KiB > > Because the sizes aren't aligned, it is hard to (visually) compare them. > On top of this,

Re: [gentoo-portage-dev] [PATCH] __dyn_install: improve reporting of build and image sizes

2017-08-26 Thread Zac Medico
On 08/24/2017 06:02 AM, Fabian Groffen wrote: > Prior to this commit, the reported sizes would look like: > > * Final size of build directory: 34942 KiB > * Final size of installed tree: 5627 KiB > > Because the sizes aren't aligned, it is hard to (visually) compare them. > On top of this,

Re: [gentoo-portage-dev] [PATCH] _collision_protect: report progress in work todo

2017-08-26 Thread Zac Medico
On 08/24/2017 06:28 AM, Fabian Groffen wrote: > Currently Portage reports its progress in checking collisions forward > every 1000th file like so: > > * checking 4149 files for package collisions > 1000 files checked ... > 2000 files checked ... > 3000 files checked ... > 4000 files checked ...

[gentoo-portage-dev] [PATCH] digraph.add: sort priorities with bisect.insort

2017-08-20 Thread Zac Medico
Reported-by: Sergei Trofimovich --- pym/portage/util/digraph.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pym/portage/util/digraph.py b/pym/portage/util/digraph.py index ba0e81c07..bf20d5d4e 100644 --- a/pym/portage/util/digraph.py +++

[gentoo-portage-dev] [PATCH 2/2] quickpkg: revert premature return from quickpkg_atom (bug 628060)

2017-08-16 Thread Zac Medico
Revert premature return from the quickpkg_atom function for atoms that match multiple slots. This fixes it to create packages for all matched slots, rather than just the lowest version. Fixes: cff2c0149142 ("Support different compressors for binary packages") X-Gentoo-bug: 628060

[gentoo-portage-dev] [PATCH 1/2] quickpkg: revert accidental changes to "protect" function (bug 628010)

2017-08-16 Thread Zac Medico
Revert accidental changes to the "protect" function's return value that were mixed in with changes to the "quickpkg_atom" function's return value. Fixes: cff2c0149142 ("Support different compressors for binary packages") X-Gentoo-bug: 628010 X-Gentoo-bug-url: https://bugs.gentoo.org/628010 ---

Re: [gentoo-portage-dev] [PATCH] Rewrite doins in python (bug 624526)

2017-08-14 Thread Zac Medico
On 08/14/2017 12:49 PM, M. J. Everitt wrote: > On 14/08/17 08:39, Zac Medico wrote: >> From: Hidehiko Abe <hideh...@chromium.org> >> >> doins is written in bash. However, specifically in case that >> too many files are installed, it is very slow. >>

[gentoo-portage-dev] [PATCH] Rewrite doins in python (bug 624526)

2017-08-14 Thread Zac Medico
From: Hidehiko Abe doins is written in bash. However, specifically in case that too many files are installed, it is very slow. This CL rewrites the script in python for performance. BUG=chromium:712659 TEST=time (./setup_board --forace && \ ./build_package --withdev

Re: [gentoo-portage-dev] Re: [PATCH] emerge: add --autounmask-keep-keywords option (bug 622480)

2017-08-13 Thread Zac Medico
On 08/13/2017 07:00 PM, M. J. Everitt wrote: > Interesting .. I'm sure I shied away from that option for some reason > ... wonder if zmedico can shed some light on the difference between the > new options and the old, apart from some added flexibility ... The --autounmask-keep-keywords option

Re: [gentoo-portage-dev] [PATCH] emerge: add --autounmask-keep-keywords option (bug 622480)

2017-08-13 Thread Zac Medico
On 08/13/2017 05:23 PM, M. J. Everitt wrote: > On 14/08/17 01:19, Zac Medico wrote [excerpted]: >> You'll get the same result as --autounmask-use-only if you use >> --autounmask-keep-keywords together with --autounmask-keep-masks. >> >> This way, we can also ad

Re: [gentoo-portage-dev] [PATCH] emerge: add --autounmask-keep-keywords option (bug 622480)

2017-08-13 Thread Zac Medico
On 08/13/2017 04:37 PM, M. J. Everitt wrote: > On 12/08/17 19:08, Zac Medico wrote: >> The option prevents --autounmask from making changes to >> package.accept_keywords. This option does not imply >> --autounmask-keep-masks, so --autounmask is still allowed >> to cr

Re: [gentoo-portage-dev] [PROPOSAL] Don't split user visible messages across multiple lines

2017-08-13 Thread Zac Medico
On 03/15/2017 03:32 PM, Brian Dolbec wrote: > On Mon, 27 Feb 2017 20:33:28 +0200 > Alexandru Elisei wrote: > >> I was working on emerge --sync and my test repo configuration >> generated several warning messages. Finding the exact location where >> the warnings was

[gentoo-portage-dev] [PATCH] emerge: add --autounmask-keep-keywords option (bug 622480)

2017-08-12 Thread Zac Medico
The option prevents --autounmask from making changes to package.accept_keywords. This option does not imply --autounmask-keep-masks, so --autounmask is still allowed to create package.unmask changes unless the --autounmask-keep-masks is also specified. X-Gentoo-bug: 622480 X-Gentoo-bug-url:

Re: [gentoo-portage-dev] Fine-grained --autounmask-* options to disable keyword, license, or USE changes?

2017-08-12 Thread Zac Medico
On 08/12/2017 12:57 AM, Zac Medico wrote: > Like --autounmask-keep-masks, it can be useful to prevent --autounmask > from creating other kinds of changes: > > * keywords > * license > * use > > In order to prevent changes to keywords, should we be consistent with &

[gentoo-portage-dev] Fine-grained --autounmask-* options to disable keyword, license, or USE changes?

2017-08-12 Thread Zac Medico
Like --autounmask-keep-masks, it can be useful to prevent --autounmask from creating other kinds of changes: * keywords * license * use In order to prevent changes to keywords, should we be consistent with --autounmask-keep-masks, and call the option --autounmask-keep-keywords? Other ideas?

[gentoo-portage-dev] portage-2.3.7 release soon

2017-08-10 Thread Zac Medico
Is there anything that we want to merge before the portage-2.3.7 release? I'd like to merge the eapply_user patch: https://bugs.gentoo.org/show_bug.cgi?id=608880 Anything else? -- Thanks, Zac signature.asc Description: OpenPGP digital signature

[gentoo-portage-dev] [PATCH] eapply_user: combine sort for all dirs (bug 608880)

2017-08-06 Thread Zac Medico
Combine the patch basenames from all matched directories into a list, and apply them in POSIX sorted order. This allows patches in more-specific directories to override patches of the same basename found in less-specific directories. An empty patch (or /dev/null symlink) negates a patch with the

Re: [gentoo-portage-dev] [PATCH v4] repoman commit: Support --bug (-b) and --closes (-c) for git footer

2017-08-06 Thread Zac Medico
On Sat, Aug 5, 2017 at 11:53 PM, Michał Górny wrote: > Support two new options: --bug (-b) and --closes (-c) to add a plain > 'Bug' reference and a 'Closes' footer for a GitHub pull request. Both > options can be specified multiple times, resulting in multiple footer > tags

Re: [gentoo-portage-dev] [PATCH v3] repoman commit: Support --bug (-b) and --closes (-c) for git footer

2017-08-05 Thread Zac Medico
On Sat, Aug 5, 2017 at 2:26 PM, Michał Górny wrote: > + parser.add_argument( > + '-b', '--bug', dest='bug', action='append', > metavar='', > + default=[], > + help=( > + 'Mention a Gentoo or

Re: [gentoo-portage-dev] [PATCH] make.globals: Enable FEATURES=multilib-strict by default

2017-08-02 Thread Zac Medico
On Wed, Jul 26, 2017 at 12:20 AM, Michał Górny wrote: > Enable the multilib-strict feature necessary for Portage to detect > ebuilds not respecting libdir for libraries. Since those issues were > reliably fixed over the years and we're nearing the removal of 'lib' > symlink, I

[gentoo-portage-dev] [PATCH] multilib-strict: disable recursion into subdirectories (bug 424423)

2017-07-31 Thread Zac Medico
Disable recursion into subdirectories, in order to avoid false-positives. The MULTILIB_STRICT_EXEMPT variable only served to filter false-positives that were triggered by recursion, so it will no longer be needed. X-Gentoo-bug: 424423 X-Gentoo-bug-url:

Re: [gentoo-portage-dev] [PATCH] emerge --getbinpkg: https support for If-Modified-Since

2017-07-31 Thread Zac Medico
On Mon, Jul 31, 2017 at 8:10 AM, Brian Dolbec <dol...@gentoo.org> wrote: > On Mon, 31 Jul 2017 00:11:09 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > >> When https certificate and hostname verification is enabled for >> stdlib http clients (PEP 476), use pytho

Re: [gentoo-portage-dev] [PATCH] make.globals: Enable FEATURES=multilib-strict by default

2017-07-31 Thread Zac Medico
On Wed, Jul 26, 2017 at 1:44 PM, Michał Górny <mgo...@gentoo.org> wrote: > On śro, 2017-07-26 at 11:29 -0700, Zac Medico wrote: >> You might think that, but I just checked our profiles and the only one >> that currently has it enabled is profiles/arch/sparc/make.defaults. I

[gentoo-portage-dev] [PATCH] emerge --getbinpkg: https support for If-Modified-Since

2017-07-31 Thread Zac Medico
When https certificate and hostname verification is enabled for stdlib http clients (PEP 476), use python for If-Modified-Since header support. When python lacks PEP 476 support, continue to use FETCHCOMMAND for https certificate and hostname verification (see security bug 469888). X-Gentoo-bug:

Re: [gentoo-portage-dev] [PATCH v2] Support different compressors for binary packages

2017-07-30 Thread Zac Medico
On Sun, Jul 30, 2017 at 1:27 PM, Zac Medico <zmed...@gentoo.org> wrote: > On Sat, Jul 29, 2017 at 10:50 PM, Michał Górny <mgo...@gentoo.org> wrote: >> On nie, 2017-07-30 at 00:56 +0200, Manuel Rüger wrote: >>> Pushed as: >>> https://gitweb

Re: [gentoo-portage-dev] [PATCH v2] Support different compressors for binary packages

2017-07-30 Thread Zac Medico
On Sat, Jul 29, 2017 at 10:50 PM, Michał Górny wrote: > On nie, 2017-07-30 at 00:56 +0200, Manuel Rüger wrote: >> Pushed as: >> https://gitweb.gentoo.org/proj/portage.git/commit/?id=cff2c0149142843316e1851c2e73bcec30f08471 >> >> Thanks for the patient reviews, Zac! >> > > I'm

Re: [gentoo-portage-dev] [PATCH v2] Support different compressors for binary packages

2017-07-29 Thread Zac Medico
On Sat, Jul 29, 2017 at 3:56 PM, Manuel Rüger wrote: > Pushed as: > https://gitweb.gentoo.org/proj/portage.git/commit/?id=cff2c0149142843316e1851c2e73bcec30f08471 > > Thanks for the patient reviews, Zac! > > Cheers, > Manuel I've added an early warning for invalid

Re: [gentoo-portage-dev] [PATCH v2] Support different compressors for binary packages

2017-07-28 Thread Zac Medico
The patch is looking really good now. Thanks for working on this! On Fri, Jul 28, 2017 at 2:59 AM, Manuel Rüger wrote: > @@ -518,6 +526,26 @@ def doebuild_environment(myebuild, mydo, myroot=None, > settings=None, > mysettings["KV"] = "" >

Re: [gentoo-portage-dev] [PATCH] make.globals: Enable FEATURES=multilib-strict by default

2017-07-26 Thread Zac Medico
On Wed, Jul 26, 2017 at 10:11 AM, Michał Górny <mgo...@gentoo.org> wrote: > On śro, 2017-07-26 at 09:58 -0700, Zac Medico wrote: >> On Wed, Jul 26, 2017 at 12:20 AM, Michał Górny <mgo...@gentoo.org> wrote: >> > Enable the multilib-strict feature necessary for

Re: [gentoo-portage-dev] [PATCH] make.globals: Enable FEATURES=multilib-strict by default

2017-07-26 Thread Zac Medico
On Wed, Jul 26, 2017 at 12:20 AM, Michał Górny wrote: > Enable the multilib-strict feature necessary for Portage to detect > ebuilds not respecting libdir for libraries. Since those issues were > reliably fixed over the years and we're nearing the removal of 'lib' > symlink, I

Re: [gentoo-portage-dev] Leader election

2017-07-11 Thread Zac Medico
On 07/11/2017 09:22 AM, Brian Dolbec wrote: > On Sun, 2 Jul 2017 11:28:09 -0700 > Brian Dolbec wrote: > >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA512 > >> On Sat, 24 Jun 2017 20:20:16 -0700 >> Brian Dolbec wrote: > >>> On Sun, 18 Jun 2017 15:48:44

Re: [gentoo-portage-dev] [PATCH] fuzzy search: weigh category similarity independently (bug 623648)

2017-07-09 Thread Zac Medico
On Sun, Jul 9, 2017 at 7:16 AM, Brian Dolbec <dol...@gentoo.org> wrote: > On Sat, 8 Jul 2017 13:03:58 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > >> Weigh the similarity of category and package names independently, >> in order to avoid matching lots o

[gentoo-portage-dev] [PATCH] fuzzy search: weigh category similarity independently (bug 623648)

2017-07-08 Thread Zac Medico
Weigh the similarity of category and package names independently, in order to avoid matching lots of irrelevant packages in the same category when the package name is much shorter than the category name. X-Gentoo-bug: 623648 X-Gentoo-bug-url: https://bugs.gentoo.org/show_bug.cgi?id=623648 ---

Re: [gentoo-portage-dev] [PATCH] Support different (de)compressors for binary packages

2017-07-05 Thread Zac Medico
On Wed, Jul 5, 2017 at 1:03 AM, Michał Górny <mgo...@gentoo.org> wrote: > On wto, 2017-07-04 at 23:33 +0200, Manuel Rüger wrote: >> On 04.07.2017 21:29, Zac Medico wrote: >> > On Fri, Jun 30, 2017 at 2:49 AM, Manuel Rüger <mr...@gentoo.org> wrote: >> > >

Re: [gentoo-portage-dev] [PATCH] Support different (de)compressors for binary packages

2017-07-04 Thread Zac Medico
On Tue, Jul 4, 2017 at 2:33 PM, Manuel Rüger <mr...@gentoo.org> wrote: > On 04.07.2017 21:29, Zac Medico wrote: >> On Fri, Jun 30, 2017 at 2:49 AM, Manuel Rüger <mr...@gentoo.org> wrote: >>> + >>> COMPRESSION_COMMAND=$(PYTHONPATH=$

Re: [gentoo-portage-dev] Leader election

2017-07-04 Thread Zac Medico
On 07/02/2017 12:02 PM, Brian Dolbec wrote: > On Sun, 2 Jul 2017 11:28:09 -0700 > Brian Dolbec wrote: > >> On Sat, 24 Jun 2017 20:20:16 -0700 >> Brian Dolbec wrote: > >>> On Sun, 18 Jun 2017 15:48:44 +0200 >>> Alexander Berntsen

Re: [gentoo-portage-dev] [PATCH] Support different (de)compressors for binary packages

2017-07-04 Thread Zac Medico
On Fri, Jun 30, 2017 at 2:49 AM, Manuel Rüger wrote: > + > COMPRESSION_COMMAND=$(PYTHONPATH=${PORTAGE_PYTHONPATH:-${PORTAGE_PYM_PATH}} > \ > + "${PORTAGE_PYTHON:-/usr/bin/python}" > "$PORTAGE_BIN_PATH"/binpkg-helper.py \ > + compressioncmd

Re: [gentoo-portage-dev] [PATCH] emerge: Add head commit per repo to --info

2017-07-04 Thread Zac Medico
On Fri, Jun 30, 2017 at 2:46 AM, Manuel Rüger wrote: > This adds the following to emerge --info output for git and rsync based > repositories: > > Head commit of repository gentoo: 0518b330edac963f54f98df33391b8e7b9eaee4c > --- > pym/_emerge/actions.py | 10

[gentoo-portage-dev] Re: [PATCH v2] portage/dep/depcheck.py: Whitespace, add indentation level after newline

2017-07-02 Thread Zac Medico
On Sat, Jun 18, 2016 at 12:26 PM, Sergei Trofimovich wrote: > From: Sergei Trofimovich > > CC: dol...@gentoo.org > Signed-off-by: Sergei Trofimovich > --- > V2: updated subject > pym/portage/dep/dep_check.py | 4 ++-- > 1 file

Re: [gentoo-portage-dev] [PATCH] const: Change the MANIFEST2_REQUIRED_HASH to SHA512

2017-06-15 Thread Zac Medico
On Thu, Jun 15, 2017 at 12:42 AM, Michał Górny wrote: > > Following the plan established in GLEP 59, we're long overdue > deprecating SHA256. Since we have finally got rid of the last packages > lacking SHA512 checksums, we can proceed with that. In order to prepare > for it,

Re: [gentoo-portage-dev] [PATCH] const: Remove unused MANIFEST1_REQUIRED_HASH

2017-06-15 Thread Zac Medico
On Thu, Jun 15, 2017 at 12:27 AM, Michał Górny wrote: > The MANIFEST1_REQUIRED_HASH constant is not used anywhere, so it should > be possible to remove it safely. > --- > pym/portage/const.py | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/pym/portage/const.py

Re: [gentoo-portage-dev] [PATCH] GitSync: Support setting environment variables for git

2017-06-05 Thread Zac Medico
On Mon, Jun 5, 2017 at 6:39 AM, Brian Dolbec <dol...@gentoo.org> wrote: > On Mon, 5 Jun 2017 01:40:08 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > > > From: Manuel Rüger <mr...@gentoo.org> > > > > This can be used to provide private SSH keys to po

[gentoo-portage-dev] [PATCH] GitSync: Support setting environment variables for git

2017-06-05 Thread Zac Medico
From: Manuel Rüger This can be used to provide private SSH keys to portage in order to clone repositories from a non-public repository. An exemplary usage would be setting this in the repositories' repos.conf: sync-git-env = "GIT_SSH_COMMAND=ssh -i /etc/portage/.ssh/id_rsa -o

Re: [gentoo-portage-dev] Re: [PATCH v2] depgraph: prune unnecessary rebuilds for --autounmask-continue (bug 619626)

2017-06-01 Thread Zac Medico
On Thu, Jun 1, 2017 at 5:48 PM, Brian Dolbec <dol...@gentoo.org> wrote: > On Thu, 1 Jun 2017 09:11:55 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > > > On Thu, Jun 1, 2017 at 8:50 AM, Zac Medico <zmed...@gentoo.org> wrote: > > > > >

[gentoo-portage-dev] [PATCH v2] depgraph: prune unnecessary rebuilds for --autounmask-continue (bug 619626)

2017-06-01 Thread Zac Medico
When there are autounmask USE changes, avoid unnecessary rebuilds by accepting binary packages that were rejected due to the preexisting USE configuration. This reuses the prune_rebuilds backtracker support which was added for bug 439688. X-Gentoo-bug: 619626 X-Gentoo-bug-url:

[gentoo-portage-dev] Re: [PATCH] depgraph: prune unnecessary rebuilds for --autounmask-continue (bug 619626)

2017-06-01 Thread Zac Medico
On Thu, Jun 1, 2017 at 1:31 AM, Zac Medico <zmed...@gentoo.org> wrote: > > @@ -4245,6 +4300,12 @@ class depgraph(object): > self._dynamic_config._skip_restart = True > return False, myfavorites > >

[gentoo-portage-dev] [PATCH] depgraph: prune unnecessary rebuilds for --autounmask-continue (bug 619626)

2017-06-01 Thread Zac Medico
When there are autounmask USE changes, avoid unnecessary rebuilds by accepting binary packages that were rejected due to the preexisting USE configuration. This reuses the prune_rebuilds backtracker support which was added for bug 439688. X-Gentoo-bug: 619626 X-Gentoo-bug-url:

Re: [gentoo-portage-dev] [PATCH v2] man/portage.5: document -* in profile "packages" files (bug 610670)

2017-05-30 Thread Zac Medico
On Mon, May 29, 2017 at 3:03 PM, Brian Dolbec <dol...@gentoo.org> wrote: > On Sun, 28 May 2017 13:15:12 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > > > The -* wildcard has been supported since portage-2.3.4, but it was > > not explicitly documented. > >

Re: [gentoo-portage-dev] [PATCH] depgraph: account for binpkg-multi-instance in unused warning (bug 619620)

2017-05-30 Thread Zac Medico
On Mon, May 29, 2017 at 10:15 PM, Brian Dolbec <dol...@gentoo.org> wrote: > On Mon, 29 May 2017 15:11:41 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > > > On Mon, May 29, 2017 at 3:03 PM, Brian Dolbec <dol...@gentoo.org> > > wrote: > > > > &g

Re: [gentoo-portage-dev] [PATCH v2] emerge: warn for --autounmask-continue with --autounmask=n (bug 619612)

2017-05-29 Thread Zac Medico
On Mon, May 29, 2017 at 3:10 PM, Brian Dolbec <dol...@gentoo.org> wrote: > On Mon, 29 May 2017 14:10:23 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > > > In order to avoid possible confusion when the user has specified > > --autounmask-continue and EMERGE_DEFAU

[gentoo-portage-dev] [PATCH v2] emerge: warn for --autounmask-continue with --autounmask=n (bug 619612)

2017-05-29 Thread Zac Medico
In order to avoid possible confusion when the user has specified --autounmask-continue and EMERGE_DEFAULT_OPTS contains --autounmask=n, display a warning message as follows: * --autounmask-continue has been disabled by --autounmask=n X-Gentoo-bug: 619612 X-Gentoo-bug-url:

Re: [gentoo-portage-dev] [PATCH] depgraph: make --autounmask-continue imply --autounmask

2017-05-29 Thread Zac Medico
On Mon, May 29, 2017 at 4:03 AM, Alexander Berntsen wrote: > Looks OK. Although I'm not a fan of the proposed change. Changes like > these make scripts a tiny bit more tedious. If you have a bunch of > --autounmask stuff in your script, you can now just do --autounmask=n >

Re: [gentoo-portage-dev] Re: [PATCH] man/portage.5: document -* in profile "packages" files (bug 610670)

2017-05-28 Thread Zac Medico
On Sun, May 28, 2017 at 6:02 AM, Martin Vaeth <mar...@mvath.de> wrote: > Zac Medico <zmed...@gentoo.org> wrote: > > > > The -* affects both > > Thanks. Maybe this could be pointed out more explicit in the > documentation patch you suggested: I have asked, b

[gentoo-portage-dev] [PATCH v2] man/portage.5: document -* in profile "packages" files (bug 610670)

2017-05-28 Thread Zac Medico
The -* wildcard has been supported since portage-2.3.4, but it was not explicitly documented. X-Gentoo-Bug: 610670 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=610670 --- [PATCH v2] clarifies that -* discards @system and @profile packages as suggested by Martin Vaeth. man/portage.5

[gentoo-portage-dev] [PATCH] depgraph: account for binpkg-multi-instance in unused warning (bug 619620)

2017-05-28 Thread Zac Medico
With FEATURES=binpkg-multi-instance, it is normal to have some unused binary packages, so don't warn if the selected package is the latest version and the most recent build. X-Gentoo-bug: 619620 X-Gentoo-bug-url: https://bugs.gentoo.org/show_bug.cgi?id=619620 --- pym/_emerge/depgraph.py | 9

[gentoo-portage-dev] [PATCH] depgraph: make --autounmask-continue imply --autounmask

2017-05-28 Thread Zac Medico
This fixes conflicting behavior when EMERGE_DEFAULT_OPTS contains --autounmask=n. X-Gentoo-bug: 619612 X-Gentoo-bug-url: https://bugs.gentoo.org/show_bug.cgi?id=619612 --- pym/_emerge/depgraph.py | 3 +++ pym/portage/tests/emerge/test_simple.py | 3 ++- 2 files changed, 5

Re: [gentoo-portage-dev] Re: [PATCH] man/portage.5: document -* in profile "packages" files (bug 610670)

2017-05-27 Thread Zac Medico
On Sat, May 27, 2017 at 10:20 PM, Martin Vaeth <mar...@mvath.de> wrote: > Zac Medico <zmed...@gentoo.org> wrote: > > The -* wildcard has been supported since portage-2.3.4, but it was > > not explicitly documented. > > Shouldn't this be -** to remove all _syst

[gentoo-portage-dev] [PATCH] man/portage.5: document -* in profile "packages" files (bug 610670)

2017-05-27 Thread Zac Medico
The -* wildcard has been supported since portage-2.3.4, but it was not explicitly documented. X-Gentoo-Bug: 610670 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=610670 --- man/portage.5 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/man/portage.5

Re: [gentoo-portage-dev] [PATCH] emerge: add --onlydeps-with-rdeps=<y|n> option (bug 294719)

2017-05-14 Thread Zac Medico
On Sun, May 14, 2017 at 6:30 AM, Brian Dolbec <dol...@gentoo.org> wrote: > On Thu, 11 May 2017 12:01:18 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > > > From: William Throwe <w...@cornell.edu> > > > > Add --onlydeps-with-rdeps=n option in

Re: [gentoo-portage-dev] [PATCH 2/2] emerge: default --backtrack=10 (bug 540562)

2017-05-14 Thread Zac Medico
On Sun, May 14, 2017 at 6:37 AM, Brian Dolbec <dol...@gentoo.org> wrote: > On Tue, 9 May 2017 20:52:35 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > > > Since the default behavior is now for emerge to terminate early for > > autounmask changes (unles

Re: [gentoo-portage-dev] [PATCH 1/2] emerge: terminate backtracking early for autounmask changes (bug 615680)

2017-05-14 Thread Zac Medico
On Sun, May 14, 2017 at 6:38 AM, Brian Dolbec <dol...@gentoo.org> wrote: > On Tue, 9 May 2017 20:52:34 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > > > Since autounmask changes are a strong indicator that backtracking > > will ultimately fail to pr

Re: [gentoo-portage-dev] [PATCH] file_copy: fix lseek offset after EINTR (bug 618086)

2017-05-14 Thread Zac Medico
On Sun, May 14, 2017 at 6:31 AM, Brian Dolbec <dol...@gentoo.org> wrote: > On Tue, 9 May 2017 23:59:34 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > > > Fix the lseek offset for the plain read/write loop to account > > for buffered data that has not been writ

[gentoo-portage-dev] [PATCH] emerge: add --onlydeps-with-rdeps=<y|n> option (bug 294719)

2017-05-11 Thread Zac Medico
From: William Throwe Add --onlydeps-with-rdeps=n option in order to omit pure run-time dependencies with --onlydeps. The dependencies that get pulled in are those that are necessary for the equivalent --buildpkgonly command to succeed. The default --onlydeps behavior remains

[gentoo-portage-dev] [PATCH] file_copy: fix lseek offset after EINTR (bug 618086)

2017-05-10 Thread Zac Medico
Fix the lseek offset for the plain read/write loop to account for buffered data that has not been written to to the output file yet (due to previous interruption by EINTR). This code only affects Linux 2.6.32 and earlier (newer kernels use copy_file_range or sendfile). X-Gentoo-bug: 618086

[gentoo-portage-dev] [PATCH 1/2] emerge: terminate backtracking early for autounmask changes (bug 615680)

2017-05-09 Thread Zac Medico
Since autounmask changes are a strong indicator that backtracking will ultimately fail to produce a solution, terminate early for autounmask changes, and add a --autounmask-backtrack= option to modify this behavior. The --autounmask-continue option implies --autounmask-backtrack=y behavior,

[gentoo-portage-dev] [PATCH 2/2] emerge: default --backtrack=10 (bug 540562)

2017-05-09 Thread Zac Medico
Since the default behavior is now for emerge to terminate early for autounmask changes (unless either --autounmask-backtrack=y or --autounmask-continue is enabled), it is much less likely that time will be wasted by fruitless backtracking. Therefore, raise the default backtrack value from 3 to 10,

Re: [gentoo-portage-dev] [PATCH] file_copy: replace loff_t with off_t for portability (bug 617778)

2017-05-09 Thread Zac Medico
On Tue, May 9, 2017 at 9:18 AM, Brian Dolbec <dol...@gentoo.org> wrote: > On Sun, 7 May 2017 16:50:40 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > > > The loff_t type is a GNU extension, so use the portable off_t > > type instead. Also, enable Larg

[gentoo-portage-dev] [PATCH] file_copy: replace loff_t with off_t for portability (bug 617778)

2017-05-07 Thread Zac Medico
The loff_t type is a GNU extension, so use the portable off_t type instead. Also, enable Large File Support macros in setup.py, for 64-bit offsets. Reported-by: Patrick Steinhardt X-Gentoo-bug: 617778 X-Gentoo-bug-url: https://bugs.gentoo.org/show_bug.cgi?id=617778 --- setup.py

Re: [gentoo-portage-dev] [PATCH] Eventloop: fix deadlock involving idle_add/call_soon (bug 617550)

2017-05-05 Thread Zac Medico
On Fri, May 5, 2017 at 10:51 AM, Brian Dolbec <dol...@gentoo.org> wrote: > On Fri, 5 May 2017 02:12:53 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > > > Guarantee that newly added idle_add/call_soon callbacks have an > > opportunity to execute before the event

[gentoo-portage-dev] [PATCH] Eventloop: fix deadlock involving idle_add/call_soon (bug 617550)

2017-05-05 Thread Zac Medico
Guarantee that newly added idle_add/call_soon callbacks have an opportunity to execute before the event loop decides to wait on self._thread_condition without a timeout. This fixes a case where the event loop would wait on self._thread_condition indefinitely, even though a callback scheduled by

[gentoo-portage-dev] Re: [PATCH 3/3] depgraph._in_blocker_conflict: call _validate_blockers if needed (bug 615982)

2017-04-20 Thread Zac Medico
On Tue, Apr 18, 2017 at 10:00 PM, Zac Medico <zmed...@gentoo.org> wrote: > Sometimes _complete_graph calls _slot_operator_update_probe, which > sometimes calls _in_blocker_conflict. This case occurs infrequently, > so call _validate_blockers only if needed. > > Fixes: a8

[gentoo-portage-dev] [PATCH 2/3] depgraph: fix _validate_blockers to revert state from previous calls

2017-04-18 Thread Zac Medico
Since the _solve_non_slot_operator_slot_conflicts method can remove packages from the graph, it's possible that some of the state changes made by previous _validate_blockers calls are no longer valid. Therefore, revert state when appropriate. --- pym/_emerge/depgraph.py | 6 ++ 1 file

[gentoo-portage-dev] [PATCH 3/3] depgraph._in_blocker_conflict: call _validate_blockers if needed (bug 615982)

2017-04-18 Thread Zac Medico
Sometimes _complete_graph calls _slot_operator_update_probe, which sometimes calls _in_blocker_conflict. This case occurs infrequently, so call _validate_blockers only if needed. Fixes: a83bb83909c5 ("depgraph: trigger slot operator rebuilds via _complete_graph (bug 614390)") X-Gentoo-bug:

[gentoo-portage-dev] [PATCH 1/3] digraph: add update and clear methods

2017-04-18 Thread Zac Medico
Also, optimize the add method to avoid creating a lot of duplicate priorities when called by the update method. --- pym/portage/tests/util/test_digraph.py | 4 +++- pym/portage/util/digraph.py| 26 -- 2 files changed, 27 insertions(+), 3 deletions(-) diff

Re: [gentoo-portage-dev] [PATCH 2/2] EbuildBuild: async spawn_nofetch in _fetchonly_exit (bug 614116)

2017-04-03 Thread Zac Medico
On Mon, Apr 3, 2017 at 1:21 PM, Brian Dolbec <dol...@gentoo.org> wrote: > On Sun, 2 Apr 2017 19:36:54 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > >> Replace a synchronous spawn_nofetch call with an asynchronous one, >> in order to avoid event loop

Re: [gentoo-portage-dev] [PATCH 1/2] EbuildBuild: eliminate call to digestgen (bug 614116)

2017-04-03 Thread Zac Medico
On Mon, Apr 3, 2017 at 1:21 PM, Brian Dolbec <dol...@gentoo.org> wrote: > On Sun, 2 Apr 2017 19:36:53 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > >> Eliminate the call to digestgen in EbuildBuild._fetchonly_exit, >> and make Scheduler._generate_digests ca

Re: [gentoo-portage-dev] [PATCH] AsynchronousLock: add async_unlock method (bug 614108)

2017-04-03 Thread Zac Medico
On Mon, Apr 3, 2017 at 1:03 PM, Brian Dolbec <dol...@gentoo.org> wrote: > On Sun, 2 Apr 2017 15:51:40 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > >> Add an async_unlock method, in order to avoid event loop >> recursion which is incompatible with asyncio

Re: [gentoo-portage-dev] [PATCH] emerge: fix --autounmask-continue to work with --getbinpkg (bug 614474)

2017-04-03 Thread Zac Medico
On Mon, Apr 3, 2017 at 12:57 PM, Brian Dolbec <dol...@gentoo.org> wrote: > On Sat, 1 Apr 2017 18:02:03 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > >> Fix action_build to populate binarytree instances with remote package >> metadata following config reload, us

[gentoo-portage-dev] [PATCH 1/2] EbuildBuild: eliminate call to digestgen (bug 614116)

2017-04-02 Thread Zac Medico
Eliminate the call to digestgen in EbuildBuild._fetchonly_exit, and make Scheduler._generate_digests call it earlier when --fetchonly is enabled. This avoids event loop recursion which is not compatible with asyncio (digestgen makes many calls that can trigger event loop recursion). X-Gentoo-bug:

[gentoo-portage-dev] [PATCH 2/2] EbuildBuild: async spawn_nofetch in _fetchonly_exit (bug 614116)

2017-04-02 Thread Zac Medico
Replace a synchronous spawn_nofetch call with an asynchronous one, in order to avoid event loop recursion which is not compatible with asyncio. This involves refactoring of spawn_nofetch to provide an asynchronous interface. X-Gentoo-bug: 614116 X-Gentoo-bug-url:

[gentoo-portage-dev] [PATCH] AsynchronousLock: add async_unlock method (bug 614108)

2017-04-02 Thread Zac Medico
Add an async_unlock method, in order to avoid event loop recursion which is incompatible with asyncio. X-Gentoo-bug: 614108 X-Gentoo-bug-url: https://bugs.gentoo.org/show_bug.cgi?id=614108 --- pym/_emerge/AsynchronousLock.py | 89 +--

[gentoo-portage-dev] [PATCH] emerge: fix --autounmask-continue to work with --getbinpkg (bug 614474)

2017-04-01 Thread Zac Medico
Fix action_build to populate binarytree instances with remote package metadata following config reload, using a new getbinpkg_refresh=False parameter to prevent redundant fetching of remote package metadata. X-Gentoo-bug: 614474 X-Gentoo-bug-url: https://bugs.gentoo.org/show_bug.cgi?id=614474

Re: [gentoo-portage-dev] [PATCH] depgraph: trigger slot operator rebuilds via _complete_graph (bug 614390)

2017-03-31 Thread Zac Medico
On Fri, Mar 31, 2017 at 10:06 PM, Brian Dolbec <dol...@gentoo.org> wrote: > On Fri, 31 Mar 2017 21:11:41 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > >> Fix _complete_graph to trigger rebuilds of parent packages when they >> pull in installed package

[gentoo-portage-dev] [PATCH] depgraph: trigger slot operator rebuilds via _complete_graph (bug 614390)

2017-03-31 Thread Zac Medico
Fix _complete_graph to trigger rebuilds of parent packages when they pull in installed packages that had already been scheduled for rebuild by the previous calculation. X-Gentoo-bug: 614390 X-Gentoo-bug-url: https://bugs.gentoo.org/show_bug.cgi?id=614390 --- pym/_emerge/depgraph.py

Re: [gentoo-portage-dev] [PATCH] pkg_use_display: show masked/forced state of USE_EXPAND flags (bug 490562)

2017-03-31 Thread Zac Medico
On Fri, Mar 31, 2017 at 1:05 PM, Brian Dolbec <dol...@gentoo.org> wrote: > On Wed, 22 Mar 2017 09:32:36 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > >> Fix pkg_use_display to test if the prefixed flag is in use.force or >> use.mask, rather than the unprefixed

[gentoo-portage-dev] Re: [PATCH] pkg_use_display: show masked/forced state of USE_EXPAND flags (bug 490562)

2017-03-31 Thread Zac Medico
On Wed, Mar 22, 2017 at 9:32 AM, Zac Medico <zmed...@gentoo.org> wrote: > Fix pkg_use_display to test if the prefixed flag is in use.force or > use.mask, rather than the unprefixed flag. > > X-Gentoo-bug: 490562 > X-Gentoo-bug-url: https://bugs.gentoo.org/show_bug.cgi?i

[gentoo-portage-dev] [PATCH] SpawnProcess: fix event loop recursion in _pipe_logger_exit (bug 613990)

2017-03-27 Thread Zac Medico
Fix SpawnProcess._pipe_logger_exit to wait for process exit status asynchronously, in order to avoid event loop recursion. This is required for asyncio compatibility, and also protects emerge from exceeding the maximum recursion depth limit like in bug 402335. X-Gentoo-bug: 613990

Re: [gentoo-portage-dev] [PATCH] emerge: use asyncio interfaces for spinner during owner lookup (bug 591760)

2017-03-26 Thread Zac Medico
On Sun, Mar 26, 2017 at 7:25 PM, Zac Medico <zmed...@gentoo.org> wrote: > On Sun, Mar 26, 2017 at 6:58 PM, Brian Dolbec <dol...@gentoo.org> wrote: >> On Sun, 26 Mar 2017 18:01:01 -0700 >> Zac Medico <zmed...@gentoo.org> wrote: >> >>>

Re: [gentoo-portage-dev] [PATCH] emerge: use asyncio interfaces for spinner during owner lookup (bug 591760)

2017-03-26 Thread Zac Medico
On Sun, Mar 26, 2017 at 6:58 PM, Brian Dolbec <dol...@gentoo.org> wrote: > On Sun, 26 Mar 2017 18:01:01 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > >> X-Gentoo-bug: 591760 >> X-Gentoo-bug-url: https://bugs.gentoo.org/show_bug.cgi?id=591760 >> --

<    4   5   6   7   8   9   10   11   12   13   >