Re: [gentoo-portage-dev] Re: equery refactorization

2008-12-06 Thread Michael A. Smith
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Douglas Anderson wrote: | On Thu, Dec 4, 2008 at 2:43 PM, Alec Warner [EMAIL PROTECTED] wrote: | nitpick feel free to ignore me | Don't put stuff in __init__.py. | | Make a file called equery (no .py) and do all the work in the modules | you import;

[gentoo-portage-dev] Re: equery refactorization

2008-12-06 Thread Michael A. Smith
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Regarding gentoolkit/trunk/src/equery/tests I discovered all the test kit that's in equery, and have been refactoring 'em. They're written in bash, not python, so they're a candidate for some kind of python unit testing. Right now, however, that's

Re: [gentoo-portage-dev] Re: equery refactorization

2008-12-06 Thread Douglas Anderson
On Sun, Dec 7, 2008 at 12:02 PM, Michael A. Smith [EMAIL PROTECTED] wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Regarding gentoolkit/trunk/src/equery/tests I discovered all the test kit that's in equery, and have been refactoring 'em. They're written in bash, not python, so

Re: [gentoo-portage-dev] Re: equery refactorization

2008-12-06 Thread Michael A. Smith
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Let me rephrase: The tests as they are written are not all that helpful or functional. Therefore I'm refactoring them so that they are. If I don't, they won't be any good at all. These are not sophisticated tests that comprehensively review your

Re: [gentoo-portage-dev] Re: equery refactorization

2008-12-06 Thread Douglas Anderson
On Sun, Dec 7, 2008 at 12:34 PM, Michael A. Smith [EMAIL PROTECTED] wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Let me rephrase: The tests as they are written are not all that helpful or functional. Therefore I'm refactoring them so that they are. If I don't, they won't be any

Re: [gentoo-portage-dev] Re: equery refactorization

2008-12-06 Thread Marius Mauch
On Sun, 7 Dec 2008 12:44:25 +0900 Douglas Anderson [EMAIL PROTECTED] wrote: I also thought about renaming the list(l) option as search, because if you look at the help output, almost every module lists something. equery's list is actually a search, I don't see why we shouldn't name it that. I

Re: [gentoo-portage-dev] Re: equery refactorization

2008-12-05 Thread Douglas Anderson
On Thu, Dec 4, 2008 at 2:43 PM, Alec Warner [EMAIL PROTECTED] wrote: nitpick feel free to ignore me Don't put stuff in __init__.py. Make a file called equery (no .py) and do all the work in the modules you import; eg. from equery import driver if __name__ == __main__: driver.Run()

Re: [gentoo-portage-dev] Re: equery refactorization

2008-12-03 Thread Alec Warner
On Wed, Dec 3, 2008 at 1:03 AM, Douglas Anderson [EMAIL PROTECTED] wrote: On Wed, Dec 3, 2008 at 7:21 AM, Michael Smith [EMAIL PROTECTED] wrote: I had the same idea and even began working on a roadmap for it. Step 1: move gentoolkit to site-packages Step 2: move individual command classes to