[gentoo-portage-dev] [PATCH] emerge --search: use slash to auto-detect category (bug 647940)

2018-02-18 Thread Zac Medico
Since search strings containing a slash do no work unless category match mode is enabled, use slash to auto-detect category match mode, so that users do not have to prefix the search string with the special @ symbol. Bug: https://bugs.gentoo.org/647940 --- pym/_emerge/search.py | 4 1 file

Re: [gentoo-portage-dev] [PATCH v2 1/3] repoman: Add commit message verification

2018-02-18 Thread Michał Górny
W dniu nie, 18.02.2018 o godzinie 09∶11 -0800, użytkownik Brian Dolbec napisał: > On Sat, 17 Feb 2018 13:56:46 +0100 > Michał Górny wrote: > > > + > > + footer_re = re.compile(r'^[\w-]+:') > > + > > + @classmethod > > + def verify_commit_message(cls, msg): > > ... > > +

Re: [gentoo-portage-dev] [PATCH] emerge --search: use slash to auto-detect category (bug 647940)

2018-02-18 Thread Brian Dolbec
On Sun, 18 Feb 2018 13:27:31 -0800 Zac Medico wrote: > Since search strings containing a slash do no work unless category > match mode is enabled, use slash to auto-detect category match mode, > so that users do not have to prefix the search string with the special > @

Re: [gentoo-portage-dev] [PATCH v2 1/3] repoman: Add commit message verification

2018-02-18 Thread Brian Dolbec
On Sat, 17 Feb 2018 13:56:46 +0100 Michał Górny wrote: > + > + footer_re = re.compile(r'^[\w-]+:') > + > + @classmethod > + def verify_commit_message(cls, msg): ... > + if all(cls.footer_re.match(l) for l in lines if l.strip()): Why declare the footer_re

Re: [gentoo-portage-dev] [PATCH v2 1/3] repoman: Add commit message verification

2018-02-18 Thread Brian Dolbec
On Sat, 17 Feb 2018 13:18:03 + "M. J. Everitt" wrote: > On 17/02/18 12:56, Michał Górny wrote: > > Add a check for common mistakes in commit messages. For now, it is > > pretty rough and works only for -m/-F. It will be extended to work > > in the interactive mode in the

Re: [gentoo-portage-dev] [PATCH v2 1/3] repoman: Add commit message verification

2018-02-18 Thread M. J. Everitt
On 18/02/18 16:28, Brian Dolbec wrote: > On Sat, 17 Feb 2018 13:18:03 + > "M. J. Everitt" wrote: > >> Might I suggest breaking out checks into a separate module? I think >> that hard-coding it all is likely to become a pain as time goes on, >> more checks get added, etc