Am 16.01.2014 01:07, schrieb Tom Wijsman:
> ---
> bin/repoman | 53 +
> man/repoman.1 | 4
> 2 files changed, 57 insertions(+)
>
> diff --git a/bin/repoman b/bin/repoman
> index d1542e9..9b703dc 100755
> --- a/bin/repoman
> +++ b/bin/rep
On Wed, Jan 15, 2014 at 5:07 PM, Jesus Rivero (Neurogeek) <
neurog...@gentoo.org> wrote:
>
> On Jan 15, 2014 7:09 PM, "Tom Wijsman" wrote:
> >
> > ---
> > bin/repoman | 8
> > man/repoman.1 | 3 +++
> > 2 files changed, 11 insertions(+)
> >
> > diff --git a/bin/repoman b/bin/repoman
>
On Wed, Jan 15, 2014 at 4:07 PM, Tom Wijsman wrote:
> ---
> bin/repoman | 53 +
> man/repoman.1 | 4
> 2 files changed, 57 insertions(+)
>
>
I urge you to not author new checks like this. /usr/bin/repoman is already
a mess.
Write these
On Jan 15, 2014 7:08 PM, "Tom Wijsman" wrote:
>
> ---
> bin/repoman | 2 ++
> man/repoman.1 | 3 +++
> pym/repoman/checks.py | 10 ++
> 3 files changed, 15 insertions(+)
>
> diff --git a/bin/repoman b/bin/repoman
> index 3263ceb..6754edd 100755
> --- a/bin/repoman
> ++
On Jan 15, 2014 7:09 PM, "Tom Wijsman" wrote:
>
> ---
> bin/repoman | 8
> man/repoman.1 | 3 +++
> 2 files changed, 11 insertions(+)
>
> diff --git a/bin/repoman b/bin/repoman
> index 9b703dc..3263ceb 100755
> --- a/bin/repoman
> +++ b/bin/repoman
> @@ -330,6 +330,7 @@ qahelp = {
>
---
bin/repoman | 53 +
man/repoman.1 | 4
2 files changed, 57 insertions(+)
diff --git a/bin/repoman b/bin/repoman
index d1542e9..9b703dc 100755
--- a/bin/repoman
+++ b/bin/repoman
@@ -36,6 +36,9 @@ pym_path =
osp.join(osp.dirname(osp.
---
bin/repoman | 2 ++
man/repoman.1 | 3 +++
pym/repoman/checks.py | 10 ++
3 files changed, 15 insertions(+)
diff --git a/bin/repoman b/bin/repoman
index 3263ceb..6754edd 100755
--- a/bin/repoman
+++ b/bin/repoman
@@ -318,6 +318,7 @@ qahelp = {
"EAPI.incompa
---
bin/repoman | 8
man/repoman.1 | 3 +++
2 files changed, 11 insertions(+)
diff --git a/bin/repoman b/bin/repoman
index 9b703dc..3263ceb 100755
--- a/bin/repoman
+++ b/bin/repoman
@@ -330,6 +330,7 @@ qahelp = {
"SRC_URI.mirror": "A uri listed in profiles/thirdpartymirrors is
In reply, you will find three repoman patches; PATCH 1 is a bit more complex
which I will detail here, the other two patches should be fairly trivial.
In the first patch I need to use the @system set, as I only want to check
DEPEND for packages not in the @system set; thus here is kept in mind tha
On Wed, 15 Jan 2014 16:35:48 -0500
Chris Reffett wrote:
> ---
> pym/repoman/checks.py | 31 ++-
> 1 file changed, 30 insertions(+), 1 deletion(-)
Can you please use In-Reply-To to avoid threads from breaking?
Due to the patches being in four threads, collapsing the
On Wed, 15 Jan 2014 21:43:58 +0100
Sebastian Luther wrote:
> 1) If you fix something that has a bug, you should refer to that in
> the git commit message.
Yes, this might need to go into the commit policy.
> What I meant was to allow people to test different styles and hope
> that the one that
Chris Reffett posted on Wed, 15 Jan 2014 16:35:48 -0500 as excerpted:
[snip the actual patch... and that's all the content there was]
TL;DR summary: please include commit descriptions and append one-line vN
changelogs as the vN increases.
I'm not sure whether there's an accepted practice for po
---
pym/repoman/checks.py | 31 ++-
1 file changed, 30 insertions(+), 1 deletion(-)
diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py
index 85aa065..c814fa7 100644
--- a/pym/repoman/checks.py
+++ b/pym/repoman/checks.py
@@ -15,7 +15,7 @@ import repoman.errors
Am 15.01.2014 22:03, schrieb Chris Reffett:
> + def check_eapi(self, eapi):
> + return eapi in ('0', '1')
> +
Instead of hard coding EAPIs here, you should use the functions in
portage.eapi like eapi_has_src_prepare_and_src_configure().
Same applies for the later part of the patch
---
pym/repoman/checks.py | 29 +
1 file changed, 29 insertions(+)
Ignore v2, I apparently didn't commit all of my changes and so that patch
won't work. Undid the compression of the src_prepare/src_configure regex,
because the way that the regex is set up means that it
Am 15.01.2014 19:41, schrieb Tom Wijsman:
>>> Yes, I see some commit messages not refer to bugs which is
>>> something we will want to avoid; think this might need to go
>>> into the commit policy.
>>>
>> There's nothing wrong with fixing/implementing something that
>> nobody filed a bug about.
>
On Wed, 15 Jan 2014 18:29:20 +0100
Sebastian Luther wrote:
> Am 15.01.2014 17:20, schrieb Tom Wijsman:
> > On Wed, 15 Jan 2014 07:29:19 +0100
> > Sebastian Luther wrote:
> >
> >> Am 15.01.2014 04:11, schrieb Tom Wijsman:
> >>
> >>
> >> I send the first mail with this wording 8 days ago. Enough
Am 15.01.2014 17:20, schrieb Tom Wijsman:
> On Wed, 15 Jan 2014 07:29:19 +0100
> Sebastian Luther wrote:
>
>> Am 15.01.2014 04:11, schrieb Tom Wijsman:
>>
>>
>> I send the first mail with this wording 8 days ago. Enough time to
>> comment on it. I'd prefer to discuss it on the list.
>
> Yes, but
On Wed, 15 Jan 2014 07:29:19 +0100
Sebastian Luther wrote:
> Am 15.01.2014 04:11, schrieb Tom Wijsman:
>
> > More discussion is needed before we should add this; at least I
> > think it should be brought up during the meeting this Sunday,
> > because we've barely had feedback and at least one sug
---
pym/repoman/checks.py | 29 +
1 file changed, 29 insertions(+)
diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py
index 85aa065..5c55b0d 100644
--- a/pym/repoman/checks.py
+++ b/pym/repoman/checks.py
@@ -731,6 +731,21 @@ class DeprecatedHasq(LineCheck):
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 15/01/14 04:22, Tom Wijsman wrote:
> Instead of this, we can add vapier's suggestion to set a proper
> name and e-mail; we can add other minor issues like these to the
> policy in the future as they become more visible (or Git
> functionality chan
21 matches
Mail list logo
