[gentoo-portage-dev] [PATCH] GenChangeLogs: parallelize remaining git calls, scale linearly (bug 565540)

2015-11-12 Thread Zac Medico
Move all git calls to the subprocesses, so performance scales linearly with --jobs. X-Gentoo-Bug: 565540 X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=565540 --- bin/egencache | 33 ++--- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/bin/e

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-12 Thread Mike Frysinger
On 12 Nov 2015 21:07, Tim Harder wrote: > On 2015-11-11 14:42, Zac Medico wrote: > > Please unset all new internal function inside bin/save-ebuild-env.sh. > > Note that it already uses this line to unset functions beginning with > > ___eapi: > > > >unset -f $(compgen -A function ___eapi_) > > >

Re: [gentoo-portage-dev] [PATCH] ebuild: unset all funcs/vars that start with ___

2015-11-12 Thread Zac Medico
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/12/2015 05:55 PM, Mike Frysinger wrote: > Since the __* (two) namespace is reserved, and ___* (three) has > rarely (if ever) been used in ebuilds, we can nuke all funcs/vars > that start with that. It makes clean up easier for us. --- > bin/sav

Re: [gentoo-portage-dev] [PATCH] ebuild: clear __bashpid & __start_distcc from env

2015-11-12 Thread Zac Medico
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/12/2015 05:50 PM, Mike Frysinger wrote: > These are internal funcs that should not be exported into the env. > --- bin/save-ebuild-env.sh | 1 + 1 file changed, 1 insertion(+) > > diff --git a/bin/save-ebuild-env.sh b/bin/save-ebuild-env.sh inde

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-12 Thread Zac Medico
On 11/12/2015 06:33 PM, Tim Harder wrote: > On 2015-11-12 21:25, Zac Medico wrote: >>> Just to note another approach, pkgcore generates global and per-eapi >>> function lists at install time (or uses the generation scripts when >>> running from a checkout) so manually tracking lists of functions is

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-12 Thread Tim Harder
On 2015-11-12 21:25, Zac Medico wrote: > > Just to note another approach, pkgcore generates global and per-eapi > > function lists at install time (or uses the generation scripts when > > running from a checkout) so manually tracking lists of functions isn't > > required. > That seems like a prett

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-12 Thread Zac Medico
On 11/12/2015 06:07 PM, Tim Harder wrote: > On 2015-11-11 14:42, Zac Medico wrote: >> Please unset all new internal function inside bin/save-ebuild-env.sh. >> Note that it already uses this line to unset functions beginning with >> ___eapi: > >>unset -f $(compgen -A function ___eapi_) > >> Ho

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-12 Thread Tim Harder
On 2015-11-11 14:42, Zac Medico wrote: > Please unset all new internal function inside bin/save-ebuild-env.sh. > Note that it already uses this line to unset functions beginning with > ___eapi: >unset -f $(compgen -A function ___eapi_) > However, your __eapi functions will not be matched beca

[gentoo-portage-dev] [PATCH] ebuild: unset all funcs/vars that start with ___

2015-11-12 Thread Mike Frysinger
Since the __* (two) namespace is reserved, and ___* (three) has rarely (if ever) been used in ebuilds, we can nuke all funcs/vars that start with that. It makes clean up easier for us. --- bin/save-ebuild-env.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bin/save-ebuil

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-12 Thread Mike Frysinger
On 12 Nov 2015 16:58, Zac Medico wrote: > On 11/12/2015 04:06 PM, Mike Frysinger wrote: > > from ebuilds/eclasses that have already stopped using __: > > __do_sed_fix () > > ___ECLASS_RECUR_MULTILIB=yes > > ___ECLASS_RECUR_TOOLCHAIN_FUNCS=yes > > __versionator_shopt_toggle () > > __versionator__tes

[gentoo-portage-dev] [PATCH] ebuild: clear __bashpid & __start_distcc from env

2015-11-12 Thread Mike Frysinger
These are internal funcs that should not be exported into the env. --- bin/save-ebuild-env.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/bin/save-ebuild-env.sh b/bin/save-ebuild-env.sh index 8036342..31c2d60 100644 --- a/bin/save-ebuild-env.sh +++ b/bin/save-ebuild-env.sh @@ -76,6 +76,7 @

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-12 Thread Zac Medico
On 11/12/2015 04:06 PM, Mike Frysinger wrote: > On 11 Nov 2015 22:40, Zac Medico wrote: >> On 11/11/2015 10:33 PM, Zac Medico wrote: >>> On 11/11/2015 01:11 PM, Mike Frysinger wrote: On 11 Nov 2015 13:04, Zac Medico wrote: > On 11/11/2015 12:55 PM, Mike Frysinger wrote: >> On 11 Nov 20

Re: [gentoo-portage-dev] [PATCH] ebuild: set up bash compat levels

2015-11-12 Thread Mike Frysinger
On 11 Nov 2015 22:40, Zac Medico wrote: > On 11/11/2015 10:33 PM, Zac Medico wrote: > > On 11/11/2015 01:11 PM, Mike Frysinger wrote: > >> On 11 Nov 2015 13:04, Zac Medico wrote: > >>> On 11/11/2015 12:55 PM, Mike Frysinger wrote: > On 11 Nov 2015 11:42, Zac Medico wrote: > > On 11/10/2015

Re: [gentoo-portage-dev] [PATCH] egencache: fix results when GIT_DIR is used in the environment.

2015-11-12 Thread Robin H. Johnson
On Wed, Nov 11, 2015 at 10:09:42PM -0800, Zac Medico wrote: > On 11/11/2015 02:30 PM, robb...@gentoo.org wrote: > > From: "Robin H. Johnson" > > > > If GIT_DIR is used, and .git is outside the root of the checkout, then > > --work-tree=... needs to be specified, otherwise any Git command that > >

Re: [gentoo-portage-dev] [PATCH] egencache --update-changelogs: Respect GIT_DIR

2015-11-12 Thread Zac Medico
On 11/08/2015 11:24 PM, Michał Górny wrote: > Allow generating ChangeLogs from external git checkout via using > GIT_DIR, rather than requiring the repository to be git. > --- > bin/egencache | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/bin/egencache b/bin/egencache

[gentoo-portage-dev] [PATCH] FindVCS: support optional cwd argument

2015-11-12 Thread Zac Medico
Since os.chdir calls may not be safe to use in threads, iterators, or event-driven code, make FindVCS support a cwd argument which defaults to the current working directory. --- pym/repoman/vcs/vcs.py | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/pym/rep

Re: [gentoo-portage-dev] [PATCH] egencache: Delay updating Manifests until all other tasks complete

2015-11-12 Thread Brian Dolbec
On Thu, 12 Nov 2015 08:56:34 -0800 Zac Medico wrote: > On 11/12/2015 08:35 AM, Zac Medico wrote: > > On 11/12/2015 07:00 AM, Michał Górny wrote: > >> Since thick Manifests can reference other files (ChangeLogs > >> especially), their generation should be run as the lask task done > >> by egenca

Re: [gentoo-portage-dev] [PATCH] egencache: Delay updating Manifests until all other tasks complete

2015-11-12 Thread Zac Medico
On 11/12/2015 08:35 AM, Zac Medico wrote: > On 11/12/2015 07:00 AM, Michał Górny wrote: >> Since thick Manifests can reference other files (ChangeLogs especially), >> their generation should be run as the lask task done by egencache, >> followed only by timestamp update. > > GenPkgDescIndex needs

Re: [gentoo-portage-dev] [PATCH] egencache: Delay updating Manifests until all other tasks complete

2015-11-12 Thread Zac Medico
On 11/12/2015 07:00 AM, Michał Górny wrote: > Since thick Manifests can reference other files (ChangeLogs especially), > their generation should be run as the lask task done by egencache, > followed only by timestamp update. GenPkgDescIndex needs to execute last, since it accesses the metadata. --

[gentoo-portage-dev] [PATCH] egencache: Delay updating Manifests until all other tasks complete

2015-11-12 Thread Michał Górny
Since thick Manifests can reference other files (ChangeLogs especially), their generation should be run as the lask task done by egencache, followed only by timestamp update. --- bin/egencache | 46 +++--- 1 file changed, 23 insertions(+), 23 deletions(-) d