Re: [gentoo-portage-dev] [PATCH v2] depgraph: fix missed atom_not_selected initialization (bug 612846)

2017-03-16 Thread Zac Medico
On Thu, Mar 16, 2017 at 3:33 PM, Brian Dolbec wrote: > On Thu, 16 Mar 2017 14:19:07 -0700 > Zac Medico wrote: > >> Fix the _slot_operator_update_probe method to ensure that the >> atom_not_selected variable is always properly initialized. This >> problem

[gentoo-portage-dev] [PATCH] depgraph: fix missed atom_not_selected initialization (bug 612846)

2017-03-16 Thread Zac Medico
Fix the _slot_operator_update_probe method to ensure that the atom_not_selected variable is always properly initialized. This problem prevented the method from identifying slot operator rebuild candidates, leading to dependency conflicts and/or missed updates. For example, this may have triggered

Re: [gentoo-portage-dev] [PATCH] portage.package.ebuild: Use a fake FILESDIR to catch invalid accesses

2017-03-16 Thread Michał Górny
On czw, 2017-03-16 at 21:29 +0100, Ulrich Mueller wrote: > > > > > > On Thu, 16 Mar 2017, Michał Górny wrote: > > + mysettings["FILESDIR"] = os.path.join(settings["PORTAGE_BUILDDIR"], > > "files") > > I believe that this contradicts current PMS 11.1, which defines > FILESDIR as follows: "The

Re: [gentoo-portage-dev] [PATCH] portage.package.ebuild: Use a fake FILESDIR to catch invalid accesses

2017-03-16 Thread Ulrich Mueller
> On Thu, 16 Mar 2017, Michał Górny wrote: > + mysettings["FILESDIR"] = os.path.join(settings["PORTAGE_BUILDDIR"], > "files") I believe that this contradicts current PMS 11.1, which defines FILESDIR as follows: "The full path to the package's files directory, used for small support

[gentoo-portage-dev] [PATCH] portage.package.ebuild: Use a fake FILESDIR to catch invalid accesses

2017-03-16 Thread Michał Górny
Use a model of fake FILESDIR path to ensure that invalid accesses to FILESDIR will result in failures rather than being silently allowed by Portage. This mostly involves accesses in the global scope and pkg_* phases, although the current model does not cover the latter completely (i.e. does not

Re: [gentoo-portage-dev] [PROPOSAL] Don't split user visible messages across multiple lines

2017-03-16 Thread Brian Dolbec
On Thu, 16 Mar 2017 09:43:08 +0200 Alexandru Elisei wrote: > On Thu, Mar 16, 2017 at 12:32 AM, Brian Dolbec > wrote: > > That could be pretty hard to do for all messages. > > Especially messages with embedded data > > > > eg: "%s is missing %s

Re: [gentoo-portage-dev] [PROPOSAL] Don't split user visible messages across multiple lines

2017-03-16 Thread Alexandru Elisei
On Thu, Mar 16, 2017 at 12:32 AM, Brian Dolbec wrote: > That could be pretty hard to do for all messages. > Especially messages with embedded data > > eg: "%s is missing %s required use flag..." % ('sys-apps/foo', 'bar') For that case we could use: "%s is missing %s