ions(+), 1
> deletion(-) create mode 100644
I'd say go for it, merge. There's been no additional feedback or review
--
Brian Dolbec
6MAs
> 9nw1c9xqoGLhCiWvAK5PZOz4/cfEUtEawUrQg4wtoPap05qzMx8fsk3rX9J7ifrq
> rQlBVxwGQqjN9ykzDl2IkY8/W9sx8Nhe5/M5rmUCsk0KUzhcrkQNCOHdzSSU2jSM
> Yimj4y+gBnizHIVn2+sAZ4vosTXic/zVKi5meYgSM4pBRAwD4GJgQ5vV//cWTTZl
> 6QTa+hD/NQZAQd14COhc
> =9N4L
> -END PGP SIGNATURE-
>
ne ==
> eapi_attrs.iuse_effective):
> + if not has_changed:
> return
>
> # Filter out USE flags that aren't part of IUSE.
> This has to
looks good :)
--
Brian Dolbec
s changed, 152 insertions(+), 12
yeah, looks fine
--
Brian Dolbec
success = True,
> mergelist = expected_mergelist),
> )
> @@ -229,6 +229,12 @@ class SlotConflictRebuildTestCase(TestCase):
> ResolverPlaygroundTestCase(
> ["app-misc/A"],
> success = True,
> + mergelist = ['app-misc/A-2']),
> +
> + ResolverPlaygroundTestCase(
> + ["app-misc/A"],
> + options={"--update": True, "--deep":
> True},
> + success = True,
> mergelist = ['app-misc/B-2',
> 'app-misc/C-1', 'app-misc/A-2']), )
>
looks good :)
--
Brian Dolbec
except Exception as e:
> +
> missing_white_space_check(token, pos) raise InvalidDependString(
> _("Invalid
> token '%s', token %s") % (token, pos+1))
looks good :)
--
Brian Dolbec
| 5 +
> pym/portage/tests/resolver/ResolverPlayground.py | 5 +
> pym/portage/tests/resolver/test_bdeps.py | 215
> +++ 6 files changed, 266 insertions(+), 5
> deletions(-) create mode 100644
Looks fine, merge please :)
--
Brian Dolbec
ppend((pkg,
> > source_file))
> > + else:
> > + atoms.append(pkg)
> > + continue
> > pkg = pkg[1:]
> > - if pkg[:1] == '*' and mybasename == 'packages':
> > + if pkg[:1] == '*' and is_packages_file:
> > pkg = pkg[1:]
> > try:
> > pkg = Atom(pkg,
> > allow_wildcard=allow_wildcard,
>
--
Brian Dolbec
modules/git/git.py
> +++ b/pym/portage/sync/modules/git/git.py
> @@ -52,7 +52,9 @@ class GitSync(NewBase):
> git_cmd_opts = ""
> if self.settings.get("PORTAGE_QUIET") == "1":
> git_cmd_opts += " --quiet"
> - if self.repo.sync_depth is not None:
> + if self.repo.clone_depth is not None:
> + git_cmd_opts += " --depth %d" %
> self.repo.clone_depth
> + elif self.repo.sync_depth is not None:
> git_cmd_opts += " --depth %d" %
> self.repo.sync_depth if
> self.repo.module_specific_options.get('sync-git-clone-extra-opts'):
> git_cmd_opts += " %s" %
> self.repo.module_specific_options['sync-git-clone-extra-opts']
hmm, I might be out of sync, but if this isn't merged already, looks
fine.
--
Brian Dolbec
t line_escaped.endswith('\0'):
> + if not line_escaped:
> line = multiline
> num = multinum
> multiline = None
> else:
> continue
> else:
> - if line_escaped.endswith('\0'):
> + if line_escaped:
> multinum = num
> multiline = line
> continue
Code seems fine to me, I trust you ;)
--
Brian Dolbec
> __pycache__/
> *.class
> +*.so
> /build
> /tags
> +setup.cfg
>
> repoman/build
looks good, push please :)
--
Brian Dolbec
k, so that the result is cached in the main process.
> > + bool(groups)
> > +
> > parent_pid = os.getpid()
> > pid = None
> > try:
> >
>
> Pushed:
>
> https://gitweb.gentoo.org/proj/portage.git/commit/?id=ccf975296daec92d376c4989e5ffb2a6cdbe8a2d
Sorry, it's been hard to keep up with email last few days, but yeah,
this is a trivial patch. I know it's been a bastard to track down the
source of the problem. Thanks
--
Brian Dolbec
ailed repo? Probably not.
Thanks Alexandru, Zac.
--
Brian Dolbec
t;See the make.conf(5) man
> page for " "PORT_LOGDIR_CLEAN usage instructions.")
> return msg
Thanks, applied by hand. Seems it was not rebased onto your previous
patches. My editor also did a bit on whitespace cleanup. So you will
likely have to force your branch to the new master since your commit
will likely not like mine.
--
Brian Dolbec
; could not
> be opened for reading")
> - return errors
> + if errors:
> + return (False, errors)
> + return (True, None)
>
> def fix(self, **kwargs):
> onProgress = kwargs.get('onProgress', None)
> @@ -83,7 +85,9 @@ class WorldHandler(object):
> except
> portage.exception.PortageException: errors.append("%s could not be
> opened for writing" % \ self.world_file)
> - return errors
> + if errors:
> + return (False, errors)
> + return (True, None)
> finally:
> world_set.unlock()
>
> diff --git a/pym/portage/tests/emerge/test_simple.py
> b/pym/portage/tests/emerge/test_simple.py
> index b1a2af5..5930f6c 100644
> --- a/pym/portage/tests/emerge/test_simple.py
> +++ b/pym/portage/tests/emerge/test_simple.py
> @@ -382,6 +382,7 @@ pkg_preinst() {
> "PORTAGE_PYTHON" : portage_python,
> "PORTAGE_REPOSITORIES" :
> settings.repositories.config_string(), "PORTAGE_TMPDIR" :
> portage_tmpdir,
> + "PORT_LOGDIR" : portage_tmpdir,
> "PYTHONDONTWRITEBYTECODE" :
> os.environ.get("PYTHONDONTWRITEBYTECODE", ""), "PYTHONPATH" :
> pythonpath, "__PORTAGE_TEST_PATH_OVERRIDE" : fake_bin,
merged :) thank you
--
Brian Dolbec
AGES[rval])
> + else:
> + msg.append("PORT_LOGDIR_CLEAN
> command returned %s"
> + % ("%d" % rval if rval else
> "None")) msg.append("See the make.conf(5) man page for "
> "PORT_LOGDIR_CLEAN usage
> instructions.") return msg
Thank you, looks good
--
Brian Dolbec
eep these modules pythonic in the sense that
they return standard True/False for API use. In this case returning
True/False would also make it easy to process the list of rcodes
returned to main()
sys.exit(False in rcodes)
which will reverse the True/False to 0/1 automatically for us and make
it super simple to process a variable length list success/fail results.
--
Brian Dolbec
commit_footer = "\n"
> if dco_sob:
> commit_footer += "Signed-off-by:
> %s\n" % (dco_sob, ) commit_footer += "(Portage version: %s/%s/%s" % \
looks good, you can push it once your enable to the repo...
--
Brian Dolbec
04: # IPv6
> data = yield from
> reader.readexactly(16) addr = socket.inet_ntop(socket.AF_INET6, data)
looks good
--
Brian Dolbec
off the trailing period.
Merged finally.
--
Brian Dolbec
pgphgbv3LXihw.pgp
Description: OpenPGP digital signature
On Wed, 4 Jan 2017 14:29:01 -0800
Brian Dolbec <dol...@gentoo.org> wrote:
> On Wed, 4 Jan 2017 13:14:38 -0500
> Mike Gilbert <flop...@gentoo.org> wrote:
>
> > X-Gentoo-Bug: 602002
> > X-Gentoo-Bug-URL: https://bugs.gentoo.org/602002
> > ---
> &g
",
> + "metadata.bad",
> "%s/metadata.xml: unused
> local USE-description: '%s'" % (xpkg, myflag))
> return False
Thanks, looks good.
--
Brian Dolbec
| 8 +-
> .../resolver/test_imagemagick_graphicsmagick.py| 104
> + 2 files changed, 110 insertions(+), 2
> deletions(-) create mode 100644
> pym/portage/tests/resolver/test_imagemagick_graphicsmagick.py
>
LGTM
--
Brian Dolbec
writemsg(" selected: %s\n" %
> (selected_pkg,), noiselevel=-1)
> + writemsg(" skipped: %s (see unsatisfied
> dependency below)\n"
> + % (pkg,), noiselevel=-1)
>
> for parent, root, atom in parent_atoms:
> self._show_unsatisfied_dep(root,
> atom, myparent=parent)
looks good :)
--
Brian Dolbec
t. +
> + Instances of this class will have missing attributes for
> metadata that
> + has not been passed into the constructor. The missing
> attributes are
> + used to distinguish missing metadata values from undefined
> metadata values.
> + For example, the repo attribute will be missing if the
> 'repository' key
> + is missing from the metadata dictionary.
> """
>
> def __new__(cls, cpv, metadata=None, settings=None,
> eapi=None,
LGTM
--
Brian Dolbec
> compute_multilib_category(elf_header)
> + entry.filename =
> entry.filename[root_len:]
> + owner =
> plibs.pop(entry.filename, None)
> + lines.append((owner,
> "scanelf", _unicode(entry))) proc.wait()
> proc.stdout.close()
>
looks fine
--
Brian Dolbec
On Mon, 5 Dec 2016 13:00:36 -0800
Zac Medico <zmed...@gentoo.org> wrote:
> On 12/05/2016 12:41 PM, Brian Dolbec wrote:
> > From 5074b2bfb36b6b9117f188588da55de3b5c01435 Mon Sep 17 00:00:00
> > 2001 From: Brian Dolbec <dol...@gentoo.org>
> > Date: Mon, 5 Dec 2016 1
On Mon, 5 Dec 2016 13:10:38 -0800
Zac Medico <zmed...@gentoo.org> wrote:
> On 12/05/2016 12:32 PM, Brian Dolbec wrote:
> > On Mon, 5 Dec 2016 11:42:10 -0800
> > Brian Dolbec <dol...@gentoo.org> wrote:
> >
> >> From 1586f1a25c41fb6036a24b47cfa58e3e8
From 5074b2bfb36b6b9117f188588da55de3b5c01435 Mon Sep 17 00:00:00 2001
From: Brian Dolbec <dol...@gentoo.org>
Date: Mon, 5 Dec 2016 11:56:02 -0800
Subject: [PATCH] portage/__init__.py: Fix live versioning to look for portage
tags only
---
pym/portage/__init__.py | 2 +-
1 file chan
On Mon, 5 Dec 2016 11:42:10 -0800
Brian Dolbec <dol...@gentoo.org> wrote:
> From 1586f1a25c41fb6036a24b47cfa58e3e818b8a58 Mon Sep 17 00:00:00 2001
> From: Brian Dolbec <dol...@gentoo.org>
> Date: Mon, 5 Dec 2016 11:27:15 -0800
> Subject: [PATCH] repoman: Fix versioning
On Sat, 3 Dec 2016 14:10:33 -0800
Zac Medico <zmed...@gentoo.org> wrote:
> On 12/03/2016 01:49 PM, Brian Dolbec wrote:
> > + if self.file_type_lt(self, other):
> > + return True
> > + elif self.file_type_lt(other, self):
> >
On Sat, 3 Dec 2016 14:20:05 -0800
Zac Medico <zmed...@gentoo.org> wrote:
> On 12/03/2016 01:48 PM, Brian Dolbec wrote:
> >
> > From c4a61bebca1cfeb0833cefb2c64be6156bdb8e8d Mon Sep 17 00:00:00
> > 2001 From: "hackers.terabit" <terabit.fun...@yandex.com>
dynamic_config._package_tracker.match(
> + root,
> pkg.slot_atom, installed=False))), None)
> if not e_pkg:
> break
LGTM
--
Brian Dolbec
default.write("# " + file_name)
return last_file_path
--
2.9.3
--
Brian Dolbec
'.ebuild_changed'),
> 'w').close()
> -if 'digest' in tmpsettings.features:
> - if pargs and pargs[0] not in ("digest", "manifest"):
> - pargs = ['digest'] + pargs
> - # We only need to build digests on the first pass.
> - tmpsettings.features.discard('digest')
> -
> checked_for_stale_env = False
>
> for arg in pargs:
looks fine to me
--
Brian Dolbec
return 1
> + fi
> else
> __vecho "unpack ${x}: file
> format not recognized. Ignoring." fi
looks good, thanks
--
Brian Dolbec
| 6 --
> pym/portage/package/ebuild/digestcheck.py | 2 +-
> pym/portage/repository/config.py | 18 ++
> 4 files changed, 27 insertions(+), 8 deletions(-)
>
LGTM
--
Brian Dolbec
current_higher = (highest_cpv is None or
> + vercmp(avail_pkg.version,
> highest_cpv.version) > 0) +
> + if current_higher or (all_match_current and
> not all_match_previous): cp_map[avail_pkg.cp] = avail_pkg
>
> this_choice = _dep_choice(atoms=atoms,
> slot_map=slot_map,
looks good
--
Brian Dolbec
except KeyError:
> + pass
> + else:
> + continue
> +
> # emulate the Element.itertext()
> method from python-2.7 inner_text = []
> stack = []
third time's the charm ;) LGTM
--
Brian Dolbec
eb0bb334d44c9
>
Yeah, this will be best, go for it.
--
Brian Dolbec
On Sat, 5 Nov 2016 13:56:44 +0100
Manuel Rüger <mr...@gentoo.org> wrote:
> On 05.11.2016 00:15, Zac Medico wrote:
> > On 11/04/2016 03:55 PM, Zac Medico wrote:
> >> On 11/04/2016 03:47 PM, Brian Dolbec wrote:
> >>> On Fri, 4 Nov 2016 13:53:02 -0700
> &g
On Fri, 4 Nov 2016 13:53:02 -0700
Zac Medico <zmed...@gentoo.org> wrote:
> On 11/04/2016 01:43 PM, Michał Górny wrote:
> > On Fri, 4 Nov 2016 13:19:39 -0700
> > Zac Medico <zmed...@gentoo.org> wrote:
> >
> >> On 11/04/2016 01:14 PM, Brian Dolbec wrote:
a stable request portage-2.3.2 when the time
> comes?
I'm not sure. Do we -r1 it adding a patch or two and ask it be stabled?
--
Brian Dolbec
> X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=597752
>
> Any feedback?
Sorry, I was behind on emails from the weekend.
This stuff is dabbling into the dep calc voodo ;) But I ddin't see any
typo's :) I trust you got it right.
--
Brian Dolbec
update_index_cmd = [self.bin_command,
> > 'update-index', '-q', '--unmerged', '--refresh']
> > exitcode =
> > subprocess.call(update_index_cmd,
> > cwd=portage._unicode_encode(self.repo.location))
>
> LGTM.
+1 LGTM too
--
Brian Dolbec
On Thu, 3 Nov 2016 09:10:14 -0700
Zac Medico <zmed...@gentoo.org> wrote:
> On 11/02/2016 11:17 PM, Brian Dolbec wrote:
> > On Wed, 2 Nov 2016 21:57:09 -0700
> > Zac Medico <zmed...@gentoo.org> wrote:
> >
> >> On 11/02/2016 05:17 PM, Zac Medico w
artin Väth.
I suspect we won't hear the end of our breakage of a perfectly working
git module until maybe we add enough git-sync-options configurable in
repos.conf to account for every possible file system and every possible
repo useage/abuse-age...
Maybe we should just ship several versions of a git module... one for
every use case ;) (kidding)
--
Brian Dolbec
gs.gentoo.org/show_bug.cgi?id=597918
> ---
> bin/emerge-webrsync | 51
> +++
> man/make.conf.5 | 6 -- 2 files changed, 51 insertions(+), 6
> deletions(-)
>
LGTM
--
Brian Dolbec
h. Brian!
> > >
> >
> > I vote for Brian too. Brian! :)
>
> ++Brian.
>
hmm, seems I've been drafted :)
--
Brian Dolbec
pgpSl0knogBs1.pgp
Description: OpenPGP digital signature
day, unless anyone
> objects to this.
> - --
> Alexander
> alexan...@plaimi.net
> https://secure.plaimi.net/~alexander
>
>
Of course I nominate Alexander again :)
Sure, voting next week works for me...
- --
Brian Dolbec
-BEGIN PGP SIGNATURE--
or inclusion in
> portage-2.3.2.
Sorry, been out all day, and again tomorrow...
Yeah, looks fine
--
Brian Dolbec
self.settings.pop('PORTAGE_EBUILD_EXIT_FILE', None)
if self.phase not in self._phases_without_builddir:
if 'PORTAGE_BUILDDIR_LOCKED' not in
self.settings:
--
Brian Dolbec
On Thu, 15 Sep 2016 14:47:31 -0700
Zac Medico <zmed...@gentoo.org> wrote:
> On 09/15/2016 12:50 PM, Brian Dolbec wrote:
> >
> > From 08f6d22b366c8dc2968573ebc4fd4f0401ea67b7 Mon Sep 17 00:00:00
> > 2001 From: Brian Dolbec <dol...@gentoo.org>
> > Date: Thu,
On Thu, 15 Sep 2016 12:50:13 -0700
Brian Dolbec <dol...@gentoo.org> wrote:
> From 08f6d22b366c8dc2968573ebc4fd4f0401ea67b7 Mon Sep 17 00:00:00 2001
> From: Brian Dolbec <dol...@gentoo.org>
> Date: Thu, 15 Sep 2016 12:45:10 -0700
> Subject: [PATCH] repoman: Update man page
From 08f6d22b366c8dc2968573ebc4fd4f0401ea67b7 Mon Sep 17 00:00:00 2001
From: Brian Dolbec <dol...@gentoo.org>
Date: Thu, 15 Sep 2016 12:45:10 -0700
Subject: [PATCH] repoman: Update man page and commitmsgfile option
Use .lower() on the leading message 9 charachters of hte messag
On Wed, 14 Sep 2016 17:01:27 -0400
"Anthony G. Basile" <bas...@opensource.dyc.edu> wrote:
> As per Brian's request on IRC, here's the patchset for adding a C
> module to help check locales.
>
Merged
--
Brian Dolbec
== "LICENSE"])
> - badprovsyntax = len([z for z in type_list if z == "PROVIDE"])
> - baddepsyntax = len(type_list) != badlicsyntax + badprovsyntax
> + badlicsyntax = len([z for z in badsyntax if z[0] ==
> "LICENSE"])
> + badprovsyntax = len([z for z in badsyntax if z[0] ==
> "PROVIDE"])
> + baddepsyntax = len(badsyntax) != badlicsyntax + badprovsyntax
> badlicsyntax = badlicsyntax > 0
> #badprovsyntax = badprovsyntax > 0
>
looks good, thanks for the fast fix Zac.
--
Brian Dolbec
e digraph (%s nodes):\n\n" %
> +
> (len(selected_nodes),), noiselevel=-1)
> +
> cycle_digraph.debug_print()
> +
> writemsg("\n", noiselevel=-1) +
> + if leaves:
> +
> writemsg("runtime cycle leaf: %s\n\n" %
> +
> (selected_nodes[0],), noiselevel=-1)
> if prefer_asap and
> asap_nodes and not selected_nodes: # We failed to find any asap nodes
> to merge, so ignore diff --git
As usual, we are not resolver guru's, but the code changes look decent
enough :)
LGTM
--
Brian Dolbec
if exitcode == os.EX_OK and self.repo.sync_depth is
> not None:
> + reset_cmd = [self.bin_command, 'reset',
> '--hard', remote_branch]
> + if quiet:
> + reset_cmd.append('--quiet')
> + exitcode = subprocess.call(reset_cmd,
> +
> cwd=portage._unicode_encode(self.repo.location)) +
> if exitcode != os.EX_OK:
> msg = "!!! git pull error in %s" %
> self.repo.location self.logger(self.xterm_titles, msg)
looks fine
--
Brian Dolbec
gt; solve that somehow.
>
> Fixed in v2 by making load_emerge_config update existing RootConfig
> instances in-place.
looks fine to me
--
Brian Dolbec
can't be exposed to
> options like this should not have root access.
yeah, the development work I've been doing for work has me making a
bunch of new ebuilds for pkgs not yet in the tree.
This feature would make it easier for sure.
I also like the idea of this feature.
I don't think there will be many users killing their system by
overusing it or adding it to EMERGE_DEFAULT_OPTS.
--
Brian Dolbec
lp = {
> "Ebuild has a dependency that refers to an unknown
> package" " (which may be valid if it is a blocker for a
> renamed/removed package," " or is an alternative choice provided by
> an overlay)"),
> + "dependency.badslotop": (
> + "RDEPEND contains ':=' slot operator under '||'
> dependency."), "file.executable": (
> "Ebuilds, digests, metadata.xml, Manifest, and
> ChangeLog do not need" " the executable bit"),
I've merged V4 and it is in the 2.3.0 release.
Thank you
--
Brian Dolbec
ions.mode != "manifest" and
> self.options.digest != "y":
> + if not self.generate_manifest:
> # Don't do this when generating manifests,
> since that uses # additional keys if spawn_nofetch is called
> (RESTRICT and # DEFINED_PHASES).
> @@ -286,8 +292,8 @@ class Scanner(object):
> if self.kwargs['checks']['ebuild_notadded']:
> self.vcs_settings.status.check(checkdir,
> checkdir_relative, xpkg)
> - manifester = manifest.Manifest(**self.kwargs)
> - manifester.update_manifest(checkdir)
> + if self.generate_manifest:
> +
> manifest.Manifest(**self.kwargs).update_manifest(checkdir)
> checkdirlist = os.listdir(checkdir)
> dynamic_data = {
Works for me :)
--
Brian Dolbec
> +
> bintree.dbapi.match('={}'.format(backup_dblink.mycpv))):
> + if binpkg.build_time == build_time:
> + return os.EX_OK
>
> self.lockdb()
> try:
looks fine to me, I trust it'll do the job :)
--
Brian Dolbec
On Sat, 18 Jun 2016 20:37:06 +0100
Sergei Trofimovich <sly...@gmail.com> wrote:
> On Sat, 18 Jun 2016 11:02:53 -0700
> Brian Dolbec <dol...@gentoo.org> wrote:
>
> > > + if runtime:
> > > + try:
> > > +
rn [0, "%s" % (e,)]
>
Looks good other than the "repoman:" in the summary. You may have
found this via your repoman changes, but this is a portage namespace
file. Plus only one file.
so...
portage/dep/depcheck.py: Whitespace, add indentation level after newline
--
Brian Dolbec
gt; b/repoman/pym/repoman/qa_data.py index b9475e8..48ab389 100644
> --- a/repoman/pym/repoman/qa_data.py
> +++ b/repoman/pym/repoman/qa_data.py
> @@ -58,6 +58,8 @@ qahelp = {
> "Ebuild has a dependency that refers to an unknown
> package" " (which may be valid if it is a blocker for a
> renamed/removed package," " or is an alternative choice provided by
> an overlay)"),
> + "dependency.badslotop": (
> + "RDEPEND contains ':=' slot operator under '||'
> dependency."), "file.executable": (
> "Ebuilds, digests, metadata.xml, Manifest, and
> ChangeLog do not need" " the executable bit"),
--
Brian Dolbec
o
have the same rules for committing as the tree does.
signed commits, signed pushes
- --
Brian Dolbec
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.1
iQJ8BAEBCgBmBQJXYWniXxSAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNUQ3Qzc0RTA4MUNDNzBEQjRBN
h.
>
>
> [0] <https://wiki.gentoo.org/wiki/Project:Portage/Meetings>
> - --
> Alexander
> berna...@gentoo.org
> https://secure.plaimi.net/~alexander
>
Yeah, will do...
Sorry, I slept in... something that doesn't happen oft
ortage/Meetings#Agenda>
> - --
> Alexander
> berna...@gentoo.org
Here it the full list of times:
WhenIsGood Results
Event: Portage meeting
Date: June 7, 2016
Time: 2:00:00 PM
Can make it:Brian Dolbec , bernalex, mgorny
Add to calendar:iCal export
(Outlook, Mac i
nows more about this so I'll let him be the judge.
> - --
> Alexander
> berna...@gentoo.org
I agree that all 3 look good, But I would say that the other changes
Michal proposed should be their own commit(s). This being the first,
the others each adding to it.
- --
Brian
gt; __init__.py. Shouldn't that stuff be pulled into a separate file and
> imported cleanly?
>
Yes, there is generally far too much code in many of the __init__.py's.
There are many with over 1K LOC
--
Brian Dolbec
> >> portage, as a side effect, we introduce the machinary for future
> >> modules in setup.py.
> > Split it into two commits.
> >
> Read the code, you really can't.
>
I think he means the setup.py change that adds the extension
capability, then add the locale cha
On Mon, 16 May 2016 12:20:00 -0700
Zac Medico <zmed...@gentoo.org> wrote:
> On 03/14/2016 11:36 AM, Brian Dolbec wrote:
> > On Mon, 14 Mar 2016 11:26:23 +0100
> > Alexander Berntsen <berna...@gentoo.org> wrote:
> >
> >> -BEGIN PGP SIGNED MESSAGE---
d code/pkgcore testing.
Overall I like it, but I'll let others review the actual code
implementation since I'm not an experienced "C" coder. In 30
years, I never did more than hello world a few times in C. And the
pascal coding I did in College is more like python than c.
--
Brian Dolbec
epoman after I finish getting some
in progress changes done so the new repoman code can be released.
--
Brian Dolbec
rious mandatory elements in the metadata"
> +HOMEPAGE="https://wiki.gentoo.org/wiki/GLEP:68;
> +LICENSE="HPND"
> +SLOT="0"
> +KEYWORDS="~amd64"
merged thank you
--
Brian Dolbec
ious mandatory elements in the metadata"
> +HOMEPAGE="https://wiki.gentoo.org/wiki/GLEP:68;
> +LICENSE="HPND"
> +SLOT="0"
> +KEYWORDS="~amd64"
merged, thank you
--
Brian Dolbec
Begin forwarded message:
Date: Wed, 4 May 2016 00:14:55 -0700
From: Brian Dolbec <dol...@gentoo.org>
To: Göktürk Yüksek <gokt...@binghamton.edu>
Subject: Re: [PATCH] xml-text/missing-doctype: test for missing DOCTYPE
in metadata.xml
On Wed, 4 May 2016 01:57:19 -0400
Göktürk
, individual
commits can be looked at via your favourite means.
[1] https://github.com/djc/portage/commits/repoman-metadata
[2] https://gitweb.gentoo.org/proj/portage.git/
--
Brian Dolbec
diff --git a/pym/repoman/_xml.py b/pym/repoman/_xml.py
deleted file mode 100644
index 33a536a..000
--- a/pym
On Sun, 1 May 2016 18:38:50 -0700
Brian Dolbec <dol...@gentoo.org> wrote:
> On Sun, 1 May 2016 21:08:47 -0400
> Göktürk Yüksek <gokt...@binghamton.edu> wrote:
>
> > Check for:
> > - type attribute in
> > - name attribute in
> > - name attribute
Gentoo Foundation
> +# Distributed under the terms of the GNU General Public License v2
> +# $Id$
> +
> +EAPI=6
> +
> +DESCRIPTION="Missing metadata.xml file"
> +HOMEPAGE="https://gitweb.gentoo.org/repo/proj/gen-b0rk.git/;
> +SRC_URI=""
> +
> +LICENSE="HPND"
> +SLOT="0"
> +KEYWORDS="~amd64"
Thank you, Please push them
--
Brian Dolbec
On Sun, 24 Apr 2016 15:04:57 -0700
Zac Medico <zmed...@gentoo.org> wrote:
> On 04/24/2016 02:45 PM, Zac Medico wrote:
> > On 04/24/2016 01:00 AM, Brian Dolbec wrote:
> >> On Sun, 24 Apr 2016 08:15:56 +0200
> >> Michał Górny <mgo...@gentoo.org> wrote:
&g
But this step did prove the basic tightened up modules data interface.
And debugged the initial conversion, so I'll be coding the rest of the
conversion in the morning. Then I'll apply your xml patches.
--
Brian Dolbec
pgpXCUQyyOHUM.pgp
Description: OpenPGP digital signature
riptions
> in metadata.xml # (unless there are any invalids, to avoid noise)
> - if kwargs.get('validity_fuse'):
> + if valid_state:
> for myflag in
> muselist.difference(used_useflags): self.qatracker.add_error(
> "metadata.warning",
> diff --git a/pym/repoman/scanner.py b/pym/repoman/scanner.py
> index a9f56e9..e9a8e20 100644
> --- a/pym/repoman/scanner.py
> +++ b/pym/repoman/scanner.py
> @@ -9,7 +9,7 @@ import portage
> from portage import normalize_path
> from portage import os
> from portage.output import green
> -from repoman.fuse import Fuse
> +from portage.util.futures import Future
> from repoman.modules.commit import repochecks
> from repoman.profile import check_profiles, dev_profile_keywords,
> setup_profile from repoman.repos import repo_metadata
> @@ -232,7 +232,7 @@ class Scanner(object):
> 'repolevel': self.repolevel,
> 'catdir': catdir,
> 'pkgdir': pkgdir,
> - 'validity_fuse': Fuse()
> + 'validity_future': Future()
> }
> # need to set it up for ==> self.modules or
> some other ordered list for mod in ['Manifests', 'IsEbuild',
> 'KeywordChecks', 'FileChecks',
Yeah, it's sat long enough with me to be fine with it this way, it is
more flexible to handle both default states but only in the code it is
used in. It also can work for strings and any other data that isn't
normally an instance pointer.
Push it and I'll use Future() for those where it is needed in the
module_spec func_kwargs.
--
Brian Dolbec
[19:06] <dwfreed|phone> git log -m --first-parent --format=%ct -1 .
[19:06] so just add the --first-parent option?
[19:07] <dwfreed|phone> you want -m toolmod = self.grab(['git',
self._work_tree, 'log', '--format=%ct', '-1', '.'])
[19:06] <dwfreed|phone> git log -m --first-parent --format=%ct -1 .
[19:06] so just add the --first-parent option?
[19:07] <dwfreed|phone> you want -m too
Don't we need to add the -m --first-parent ???
--
Brian Dolbec
KiB')
looks good. Also if you haven't looked at the forum thread again.
Portage did not fail when he set python 2.7 as the active one. So it
is 3.4 only that is failing for him (just those 2 installed).
--
Brian Dolbec
ch. It looks like it is
not valid for the cvs and svn modules now that they are separate
modules.
--
Brian Dolbec
On Mon, 14 Mar 2016 17:18:27 -0700
Zac Medico <zmed...@gentoo.org> wrote:
> On 03/14/2016 10:52 AM, Brian Dolbec wrote:
> > On Mon, 14 Mar 2016 10:22:11 -0700
> > Zac Medico <zmed...@gentoo.org> wrote:
> >
> >> On 03/14/2016 10:14 AM, Zac Medico wr
makes it easier to know that any bugs
submitted for .29 that re not repoman specific, apply to .28 as well.
But more that if no non-repoman bugs were filed, then that clears .28
for stabilization.
- --
Brian Dolbec
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.1
On Mon, 14 Mar 2016 10:22:11 -0700
Zac Medico <zmed...@gentoo.org> wrote:
> On 03/14/2016 10:14 AM, Zac Medico wrote:
> > On 03/05/2016 01:37 PM, Brian Dolbec wrote:
> >
> >> Zac, I'm done with code changes in the rewrite. Ready for a last
> >> look bef
time.strftime('%s\n' %
> TIMESTAMP_FORMAT, time.gmtime()))
> + except (EnvironmentError,
> portage.exception.PortageException): ret.append(os.EX_IOERR)
> else:
> ret.append(os.EX_OK)
looks fine to me.
--
Brian Dolbec
t is desirable to add these things.
>
> - --
> Alexander
> berna...@gentoo.org
commit message fixed and merged...
- --
Brian Dolbec
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.1
iQJ8BAEBCgBmBQJW4fxxXxSAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXR
On Wed, 9 Mar 2016 12:07:13 -0800
Brian Dolbec <dol...@gentoo.org> wrote:
> I've scheduled a meeting for tomorrow, March 10, 2016 at 20:30 UTC
> (8:30PM UTC)
>
> topics:
>
> 1) next release
> 2) repoman stage2 rewrite merge status
> 3) repoman stage3 rewr
From e13e87a38f404a95ec7705f9fd8920201b632f42 Mon Sep 17 00:00:00 2001
From: Brian Dolbec <dol...@gentoo.org>
Date: Thu, 10 Mar 2016 08:11:51 -0800
Subject: [PATCH] repoman: Make the output qiuet when options.quiet=True (bug
576958)
In some cases do not output anything.
In some cases,
I've scheduled a meeting for tomorrow, March 10, 2016 at 20:30 UTC
(8:30PM UTC)
topics:
1) next release
2) repoman stage2 rewrite merge status
3) repoman stage3 rewrite discussion for moving data
to the tree/api.gentoo.org
4) open discussion
--
Brian Dolbec
atted with him in our IRC channel...
And I had him change this first patch for the patch v2 which is the one
I merged.
- --
Brian Dolbec
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.1
iQJ8BAEBCgBmBQJW3uXKXxSAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXR
ux_cache_keys:
> aux_cache[x] = mydata.get(x, "")
> @@ -817,6 +817,7 @@ class portdbapi(dbapi):
>
> def melt(self):
> self.xcache = {}
> + self._aux_cache = {}
> self.frozen = 0
>
>
fetchonly=fetchonly,
> allow_missing_digests=False, digests=dist_digests):
> spawn_nofetch(mydbapi, myebuild,
> settings=mysettings, fd_pipes=fd_pipes)
Makes sense to be consistent to me :)
--
Brian Dolbec
,
> "distutils": "distutils-r1",
> + "games": False,
> "gems": "ruby-fakegem",
> "mono": "mono-env",
> "python": "python-r1 / python-single-r1 /
> python-any-r1",
Yeah, merge it, it won't be a rebase issue.
--
Brian Dolbec
101 - 200 of 520 matches
Mail list logo
