Re: [gentoo-portage-dev] PATCH: gentoolkit: Make portage.config object a global object

2005-09-21 Thread Alec Warner
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Brian Harring wrote: > On Tue, Sep 20, 2005 at 06:55:44PM -0500, Paul Varner wrote: > >>On Tue, 2005-09-20 at 18:34 -0500, Brian Harring wrote: >> Updated patch to add a semaphore to control access to the global portage.config object. Unless a

Re: [gentoo-portage-dev] PATCH: gentoolkit: Make portage.config object a global object

2005-09-20 Thread Paul Varner
On Tue, 2005-09-20 at 19:00 -0500, Brian Harring wrote: > On Tue, Sep 20, 2005 at 06:55:44PM -0500, Paul Varner wrote: > > On Tue, 2005-09-20 at 18:34 -0500, Brian Harring wrote: > > > > Updated patch to add a semaphore to control access to the global > > > > portage.config object. Unless anyone se

Re: [gentoo-portage-dev] PATCH: gentoolkit: Make portage.config object a global object

2005-09-20 Thread Brian Harring
On Tue, Sep 20, 2005 at 06:55:44PM -0500, Paul Varner wrote: > On Tue, 2005-09-20 at 18:34 -0500, Brian Harring wrote: > > > Updated patch to add a semaphore to control access to the global > > > portage.config object. Unless anyone sees any other issues with this > > > patch, I will be placing it

Re: [gentoo-portage-dev] PATCH: gentoolkit: Make portage.config object a global object

2005-09-20 Thread Paul Varner
On Wed, 2005-09-21 at 08:46 +0900, Jason Stubbs wrote: > > Updated patch to add a semaphore to control access to the global > > portage.config object. Unless anyone sees any other issues with this > > patch, I will be placing it into gentoolkit. > > Is the settingslock created in __init__.py acces

Re: [gentoo-portage-dev] PATCH: gentoolkit: Make portage.config object a global object

2005-09-20 Thread Paul Varner
On Tue, 2005-09-20 at 18:34 -0500, Brian Harring wrote: > > Updated patch to add a semaphore to control access to the global > > portage.config object. Unless anyone sees any other issues with this > > patch, I will be placing it into gentoolkit. > Reason for a semaphore over threading.Lock ? No r

Re: [gentoo-portage-dev] PATCH: gentoolkit: Make portage.config object a global object

2005-09-20 Thread Jason Stubbs
On Wednesday 21 September 2005 02:37, Paul Varner wrote: > On Fri, 2005-09-16 at 11:59 -0500, Paul Varner wrote: > > http://bugs.gentoo.org/show_bug.cgi?id=90680 > > > > Author: Paul Varner > > > > The current implementation of gentoolkit creates a portage.config > > object for every package object

Re: [gentoo-portage-dev] PATCH: gentoolkit: Make portage.config object a global object

2005-09-20 Thread Brian Harring
On Tue, Sep 20, 2005 at 12:37:27PM -0500, Paul Varner wrote: > On Fri, 2005-09-16 at 11:59 -0500, Paul Varner wrote: > > http://bugs.gentoo.org/show_bug.cgi?id=90680 > > > > Author: Paul Varner > > > > The current implementation of gentoolkit creates a portage.config object > > for every package

Re: [gentoo-portage-dev] PATCH: gentoolkit: Make portage.config object a global object

2005-09-20 Thread Paul Varner
On Fri, 2005-09-16 at 11:59 -0500, Paul Varner wrote: > http://bugs.gentoo.org/show_bug.cgi?id=90680 > > Author: Paul Varner > > The current implementation of gentoolkit creates a portage.config object > for every package object that it creates. While this is the correct > thing to do from an obj

Re: [gentoo-portage-dev] PATCH: gentoolkit: Make portage.config object a global object

2005-09-19 Thread Paul de Vrieze
On Monday 19 September 2005 10:26, Jason Stubbs wrote: > On Monday 19 September 2005 17:18, Paul de Vrieze wrote: > > I doubt though that the config object should be modified. > > The Package object needs to call setcpv() on the config object to get > at the per-package USE flags after they have be

Re: [gentoo-portage-dev] PATCH: gentoolkit: Make portage.config object a global object

2005-09-19 Thread Jason Stubbs
On Monday 19 September 2005 17:18, Paul de Vrieze wrote: > I doubt though that the config object should be modified. The Package object needs to call setcpv() on the config object to get at the per-package USE flags after they have been stacked. > But if it must in some cases a lazy copy scheme

Re: [gentoo-portage-dev] PATCH: gentoolkit: Make portage.config object a global object

2005-09-19 Thread Paul de Vrieze
On Saturday 17 September 2005 02:32, Alec Warner wrote: > Jason Stubbs wrote: > > On Saturday 17 September 2005 01:59, Paul Varner wrote: > >>http://bugs.gentoo.org/show_bug.cgi?id=90680 > >> > >>Author: Paul Varner > >> > >>The current implementation of gentoolkit creates a portage.config > >> obj

Re: [gentoo-portage-dev] PATCH: gentoolkit: Make portage.config object a global object

2005-09-16 Thread Paul Varner
On Sat, 2005-09-17 at 08:09 +0900, Jason Stubbs wrote: > I tried doing this once before locally, but found some issue with it. > Unfortunately, I can't remember what that issue was. If you are calling > setcpv() for every call to the package object that utilizes the config > object and no utiliz

Re: [gentoo-portage-dev] PATCH: gentoolkit: Make portage.config object a global object

2005-09-16 Thread Alec Warner
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jason Stubbs wrote: > On Saturday 17 September 2005 01:59, Paul Varner wrote: > >>http://bugs.gentoo.org/show_bug.cgi?id=90680 >> >>Author: Paul Varner >> >>The current implementation of gentoolkit creates a portage.config object >>for every package o

Re: [gentoo-portage-dev] PATCH: gentoolkit: Make portage.config object a global object

2005-09-16 Thread Jason Stubbs
On Saturday 17 September 2005 01:59, Paul Varner wrote: > http://bugs.gentoo.org/show_bug.cgi?id=90680 > > Author: Paul Varner > > The current implementation of gentoolkit creates a portage.config object > for every package object that it creates. While this is the correct > thing to do from an obj

[gentoo-portage-dev] PATCH: gentoolkit: Make portage.config object a global object

2005-09-16 Thread Paul Varner
http://bugs.gentoo.org/show_bug.cgi?id=90680 Author: Paul Varner The current implementation of gentoolkit creates a portage.config object for every package object that it creates. While this is the correct thing to do from an object-oriented programming point of view, this implementation consumes