Re: [Geoserver-devel] Build failure on master in Maven but not Eclipse?

2017-05-24 Thread Ben Caradoc-Davies
Ian, good catch. That might have easily have affected a user. Just when we thought we had sanitised all our inputs ... Kind regards, Ben. On 24/05/17 23:00, Ian Turton wrote: > OK I've managed to dig to the bottom of this one - > https://github.com/geoserver/geoserver/pull/2357 > > Longer

Re: [Geoserver-devel] Build failure on master in Maven but not Eclipse?

2017-05-24 Thread Ian Turton
OK I've managed to dig to the bottom of this one - https://github.com/geoserver/geoserver/pull/2357 Longer answer - for some reason I have some environment variables like BACKGROUND_CYAN= [46m (with an Escape char at the start) in my user env. If you pass these unescaped to the Dom parser it

Re: [Geoserver-devel] Build failure on master in Maven but not Eclipse?

2017-05-24 Thread Andrea Aime
Hi Ian, does it make sense to change the test so that it dumps the raw xml (as a string) to the output before trying to parse it? Would likely help to see what might be wrong with it. Cheers Andrea On Wed, May 24, 2017 at 9:42 AM, Ian Turton wrote: > mvn -version: > >

Re: [Geoserver-devel] Build failure on master in Maven but not Eclipse?

2017-05-24 Thread Ian Turton
mvn -version: Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T16:41:47+00:00) Maven home: /usr/share/maven-3.3.9 Java version: 1.8.0_66, vendor: Oracle Corporation Java home: /usr/lib/jvm/jdk1.8.0_66/jre Default locale: en_GB, platform encoding: UTF-8 OS name: "linux",

Re: [Geoserver-devel] Build failure on master in Maven but not Eclipse?

2017-05-23 Thread Ben Caradoc-Davies
Ian, a full build is passing for master on Boundless Jenkins, Travis CI, and for me locally on debian unstable amd64 with OpenJDK 8. As Andrea wrote, most likely a platform encoding issue. What is your platform and encoding? What is the output of "mvn -version"? You could also try a full "mvn

Re: [Geoserver-devel] Build failure on master in Maven but not Eclipse?

2017-05-23 Thread Andrea Aime
Ciao Ian, never seen it, but stackoverflow offers the following: https://stackoverflow.com/questions/13877013/org-xml-sax-saxparseexception-an-invalid-xml-character-unicode-0x1b-was-foun Hmm.. encoding issue somewhere? Cheers Andrea On Tue, May 23, 2017 at 5:02 PM, Ian Turton

[Geoserver-devel] Build failure on master in Maven but not Eclipse?

2017-05-23 Thread Ian Turton
I'm currently getting a build failure with mvn but not eclipse on a fresh checkout of master in RestConfig: Tests in error: testGetStatusAsHTML(org.geoserver.rest.catalog.AboutControllerTest): An invalid XML character (Unicode: 0x1b) was found in the element content of the document. Obviously