Re: [Geoserver-devel] Call for vote GSIP-91

2013-01-23 Thread Alessio Fabiani
+1 here. Having al SSL filter on the chain seems to be a very good improvement, especially on REST responses which send clear text and is possible in some cases to have back the store passwords in clear. Had a quick look at the code, the headers look fine, javadoc on methods fine and there are

Re: [Geoserver-devel] Call for vote GSIP-91

2013-01-23 Thread Christian Mueller
The whole security doc needs some love, this is on my TODO list Christian 2013/1/23 Alessio Fabiani alessio.fabi...@geo-solutions.it +1 here. Having al SSL filter on the chain seems to be a very good improvement, especially on REST responses which send clear text and is possible in some

Re: [Geoserver-devel] Call for vote GSIP-91

2013-01-22 Thread Phil Scadden
+0 On the face of it, I am all for improvements and better control on security but I dont think I have engaged enough with the recent enhancements to judge this one. Notice: This email and any attachments are confidential. If received in error please destroy and immediately notify us. Do not

Re: [Geoserver-devel] Call for vote GSIP-91

2013-01-17 Thread Christian Mueller
Hi Justin, the core code is available for review. https://github.com/mcrmcr/geoserver-1/commit/3a648f8465f33a8c924d2c9ec00f0e3bec5c938a Tests are passing. The important classes are GeoServerSSLFilter GeoServerRequestMatcher I will start working on the admin GUI now. 2013/1/16 Justin

Re: [Geoserver-devel] Call for vote GSIP-91

2013-01-17 Thread Simone Giannecchini
0 Regards, Simone Giannecchini == Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information. == Ing. Simone Giannecchini @simogeo Founder/Director GeoSolutions S.A.S. Via Poggio alle Viti 1187 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584

Re: [Geoserver-devel] Call for vote GSIP-91

2013-01-17 Thread Justin Deoliveira
Hey Christian, Looked over this commit and it looks good. No issues here. -Justin On Thu, Jan 17, 2013 at 5:43 AM, Christian Mueller mcrmc...@gmail.comwrote: Hi Justin, the core code is available for review.

Re: [Geoserver-devel] Call for vote GSIP-91

2013-01-16 Thread Christian Mueller
Thanks for the hint, in this situation I will try to finish the core code until Friday and hope for a review from Justin. Fortunately, Justin is 8 hours behind me :-) I think the admin GUI is not so critical and I try to finish until Sunday. Cheers Christian 2013/1/16 Andrea Aime

Re: [Geoserver-devel] Call for vote GSIP-91

2013-01-16 Thread Jody Garnett
+0 on the proposal from me :-) I have my monday slightly earlier than you, and need to complete the release promptly (or try again the next weekend). -- Jody Garnett On Wednesday, 16 January 2013 at 11:02 PM, Christian Mueller wrote: Thanks for the hint, in this situation I will try to

Re: [Geoserver-devel] Call for vote GSIP-91

2013-01-16 Thread Justin Deoliveira
Sounds good Christian. I will try to review as soon as the patch is available. On Tue, Jan 15, 2013 at 10:51 PM, Christian Mueller mcrmc...@gmail.comwrote: @Andrea: No, there is no new pattern language, this is only an example. The admin has to deal with simple ANT patterns. @Justin GSIP

Re: [Geoserver-devel] Call for vote GSIP-91

2013-01-15 Thread Andrea Aime
On Mon, Jan 14, 2013 at 10:30 AM, Christian Mueller mcrmc...@gmail.comwrote: The GSIP is here http://geoserver.org/display/GEOS/GSIP+91+-+Enhance+authentication+filter+chain+configuration This is the last round concerning authentication filter chains and I want to bring it in during the

Re: [Geoserver-devel] Call for vote GSIP-91

2013-01-15 Thread Christian Mueller
Exactly this is the problem. On the top of the page you can manage individual authentication filters. (add,remove,edit). I want to have the same logic/look and feel for authentication chains. Until now, we have a fixed set of chains and I want to add flexibility. This is the hard part. The

Re: [Geoserver-devel] Call for vote GSIP-91

2013-01-15 Thread Andrea Aime
On Tue, Jan 15, 2013 at 5:03 PM, Christian Mueller mcrmc...@gmail.comwrote: Exactly this is the problem. On the top of the page you can manage individual authentication filters. (add,remove,edit). I want to have the same logic/look and feel for authentication chains. Until now, we have a

Re: [Geoserver-devel] Call for vote GSIP-91

2013-01-15 Thread Justin Deoliveira
Hey Christian, How does this relate to GSIP-82? Also, is there a patch i can check out? -Justin On Tue, Jan 15, 2013 at 11:16 AM, Andrea Aime andrea.a...@geo-solutions.itwrote: On Tue, Jan 15, 2013 at 5:03 PM, Christian Mueller mcrmc...@gmail.comwrote: Exactly this is the problem. On the

Re: [Geoserver-devel] Call for vote GSIP-91

2013-01-15 Thread Christian Mueller
@Andrea: No, there is no new pattern language, this is only an example. The admin has to deal with simple ANT patterns. @Justin GSIP 91 could be named GSIP 82, part II. It is the successor for completing chain configuration logic. This will be the last major rework in the security core code. I

Re: [Geoserver-devel] Call for vote GSIP-91

2013-01-15 Thread Rahkonen Jukka
+0 GSIP sounds good but I do not really know much about this area. -Jukka Rahkonen- Lähettäjä: Christian Mueller [mailto:mcrmc...@gmail.com] Lähetetty: 16. tammikuuta 2013 7:51 Vastaanottaja: Justin Deoliveira Kopio: geoserver-devel; Andrea Aime Aihe: Re: [Geoserver-devel] Call for vote GSIP-91