Re: [Geoserver-devel] Vector tiles pipeline: why simplifying before clipping?

2018-11-18 Thread Andrea Aime
On Tue, Nov 13, 2018 at 3:31 PM Andrea Aime wrote: > I'll prepare a pull request to switch the two ops in the meantime. > Pull request available here: https://github.com/geoserver/geoserver/pull/3246 Cheers Andrea == GeoServer Professional Services from the experts! Visit

Re: [Geoserver-devel] Vector tiles pipeline: why simplifying before clipping?

2018-11-13 Thread Jim Hughes
As of JTS 1.16, there isn't a single makeValid call.:( When I've heard it discussed, it sounds like makeValid functions are usually a bunch of tricks applied one after another to try and fix up a topology. *shrugs* Jim On 11/13/18 9:31 AM, Andrea Aime wrote: On Tue, Nov 13, 2018 at 3:08

Re: [Geoserver-devel] Vector tiles pipeline: why simplifying before clipping?

2018-11-13 Thread Andrea Aime
On Tue, Nov 13, 2018 at 3:08 PM Gabriel Roldan wrote: > Hello, > > I don't think there's any good reason for simplifying before clipping. > Maybe just not having tested or thought too much about it. I do remember > though that without topology preserving simplification we ran into a number > of

Re: [Geoserver-devel] Vector tiles pipeline: why simplifying before clipping?

2018-11-13 Thread Gabriel Roldan
Hello, I don't think there's any good reason for simplifying before clipping. Maybe just not having tested or thought too much about it. I do remember though that without topology preserving simplification we ran into a number of issues with the resulting tiles, to my deception, knowing it's so

Re: [Geoserver-devel] Vector tiles pipeline: why simplifying before clipping?

2018-11-12 Thread Jim Hughes
Hi Andrea, Generally, this seems like the much safer approach.  I could imagine lines moving a little bit if you do things in the other order. That said, is there any room to leverage the pre-generalized DataStore tricks along the way here?  It seems like that's a nice technique to dealing

Re: [Geoserver-devel] Vector tiles pipeline: why simplifying before clipping?

2018-11-11 Thread Ian Turton
I can't think of any reason to simplify and then clip as opposed to the reverse, in fact I would expect cases where you'd get a slightly "better" answer by clipping and simplifying. Ian On Sun, 11 Nov 2018 at 10:07, Andrea Aime wrote: > Hi, > following a report of slow vector tiles generation