Re: [Geotools-devel] PMC: Map Context Refractor Proposal

2010-06-12 Thread Jody Garnett
Micheal please check the issue for an updated patch I have separated out a MapViewport holding the bounds+crs for the map. The map does retain an internal MapViewport for use in an interactive session. But I can understand your need to keep one on the side for background rendering; or to have m

Re: [Geotools-devel] FeatureSource dispose and setTransaction

2010-06-12 Thread Andrea Aime
Jody Garnett ha scritto: > This came up a while ago; and I am hitting it again as I go through > the steps of cleaning up a map layer. > > I would like to add the following methods: - > FeatureSource.dispose(); > clean up after a feature source - mostly cleans up any outstanding > listeners I gu

Re: [Geotools-devel] GeoTools OSGi compatibility

2010-06-12 Thread Jody Garnett
Hi Mathieu: Wanted to introduce you to Crag from the uDig project - who cheerfully asked me how geotools / osgi relationship was going. When he last checked in Harald was working on it (but as you saw on that page Harald left instructions and thus nothing has happened). I had kind of a basic /

[Geotools-devel] FeatureSource dispose and setTransaction

2010-06-12 Thread Jody Garnett
This came up a while ago; and I am hitting it again as I go through the steps of cleaning up a map layer. I would like to add the following methods: - FeatureSource.dispose(); clean up after a feature source - mostly cleans up any outstanding listeners I guess - FeatureSource.setTransaction( Tra

Re: [Geotools-devel] PMC: Map Context Refractor Proposal

2010-06-12 Thread Jody Garnett
On 12/06/2010, at 6:53 PM, Michael Bedward wrote: > Hi Jody, > > A few comments / queries to get started (sorry for the bitty nature of > what follows but I'm multi-mutli-tasking this weekend :) No worries thanks for the review; I am slated to commit this weekend. I am unsure if I should commit

Re: [Geotools-devel] PMC: Map Context Refractor Proposal

2010-06-12 Thread Michael Bedward
Hi Jody, A few comments / queries to get started (sorry for the bitty nature of what follows but I'm multi-mutli-tasking this weekend :) First up - it's so good to see this becoming reality. It's going to make many things much easier and cleaner. In the Layer class, are the the methods for firi