Re: [Geotools-devel] ContentFeatureStore transaction and event improvements

2011-11-27 Thread Jody Garnett
Okay everything is merged; reviewed and committed. This has the property-ng transaction independence tests working. There is one last fix required for that module - https://jira.codehaus.org/browse/GEOT-2026 The fix is small; amounting to cutting and pasting the the code to update the FeatureT

Re: [Geotools-devel] ContentFeatureStore transaction and event improvements

2011-11-27 Thread Jody Garnett
Darn Andrea I was working on that today as well. I am going to see how much we overlapped. I moved Diff into ContentFeatureState; and was passing the ContentFeatureStore into the readers in order to handle event notification. I will try and review / merge your patch. -- Jody Garnett On Sun

Re: [Geotools-devel] ContentFeatureStore transaction and event improvements

2011-11-26 Thread Andrea Aime
On Thu, Nov 24, 2011 at 2:49 PM, Andrea Aime wrote: > > On Wed, Nov 23, 2011 at 11:37 PM, Jody Garnett wrote: >> >> I thought about that; and we have two ways to consider simple. I don't >> really want to stuff a Diff into ContentState that many implementations will >> ignore. Extra stuff you a

Re: [Geotools-devel] ContentFeatureStore transaction and event improvements

2011-11-24 Thread Andrea Aime
On Wed, Nov 23, 2011 at 11:37 PM, Jody Garnett wrote: > I thought about that; and we have two ways to consider simple. I don't > really want to stuff a Diff into ContentState that many implementations > will ignore. Extra stuff you are not using does end up being complex as > well. > Most implem

Re: [Geotools-devel] ContentFeatureStore transaction and event improvements

2011-11-23 Thread Jody Garnett
I thought about that; and we have two ways to consider simple. I don't really want to stuff a Diff into ContentState that many implementations will ignore. Extra stuff you are not using does end up being complex as well. In anycase I will hook this up to PropertyDataStore and try out both appro

Re: [Geotools-devel] ContentFeatureStore transaction and event improvements

2011-11-23 Thread Andrea Aime
On Wed, Nov 23, 2011 at 4:20 PM, Justin Deoliveira wrote: > > > On Tue, Nov 22, 2011 at 4:37 PM, Jody Garnett >> I put up classes for an initial patch. >> As I copied the code across and ported I found nice clear spots for >> everything. One change here is that we need a specific subclass of >> C

Re: [Geotools-devel] ContentFeatureStore transaction and event improvements

2011-11-23 Thread Justin Deoliveira
On Tue, Nov 22, 2011 at 4:37 PM, Jody Garnett wrote: > I put up classes for an initial patch. > > As I copied the code across and ported I found nice clear spots for > everything. One change here is that we need a specific subclass of > ContentState in order to hold the Diff. It will be up to cla

Re: [Geotools-devel] ContentFeatureStore transaction and event improvements

2011-11-22 Thread Jody Garnett
I put up classes for an initial patch. As I copied the code across and ported I found nice clear spots for everything. One change here is that we need a specific subclass of ContentState in order to hold the Diff. It will be up to classes using the Diff support to make use of this implementati

Re: [Geotools-devel] ContentFeatureStore transaction and event improvements

2011-11-21 Thread Justin Deoliveira
Sounds like a good idea. Can't provide much feedback now... but will happily help review a patch once it's up. On Mon, Nov 21, 2011 at 2:52 AM, Andrea Aime wrote: > (previously sent to geotools-users by mistake) > > Hi, > while I was working on shapefile-ng I noticed that ContentFeatureStore > do

[Geotools-devel] ContentFeatureStore transaction and event improvements

2011-11-21 Thread Andrea Aime
(previously sent to geotools-users by mistake) Hi, while I was working on shapefile-ng I noticed that ContentFeatureStore does not provide any help in supporting transactions and feature modification events, so I've opened the following two jiras: http://jira.codehaus.org/browse/GEOT-3956 http://j