Re: [Geotools-devel] Inconsistency in ResourceId

2011-11-07 Thread Mark Leslie
On 8 November 2011 00:53, Gabriel Roldan wrote: >> Gabriel, >> As an aside, I've been looking at the wfs-2 datastore work you pointed >> me at and trying to find a graceful way of adding the query version >> filtering that won't be limited to ResourceId filters.  I was hoping >> to have something

Re: [Geotools-devel] Inconsistency in ResourceId

2011-11-07 Thread Gabriel Roldan
> Gabriel, > As an aside, I've been looking at the wfs-2 datastore work you pointed > me at and trying to find a graceful way of adding the query version > filtering that won't be limited to ResourceId filters.  I was hoping > to have something sensible to discuss with you about that, but haven't >

Re: [Geotools-devel] Inconsistency in ResourceId

2011-11-07 Thread Gabriel Roldan
On Mon, Nov 7, 2011 at 7:52 AM, Jody Garnett wrote: > I have updated ResourceIdImpl to allow version to use 0l to represent null. >  I assume the use for this is when you have a feature id (but not the rid) > and wish to request all features. cool. You're right in that if you're asking for a speci

Re: [Geotools-devel] Inconsistency in ResourceId

2011-11-07 Thread Jody Garnett
I have updated ResourceIdImpl to allow version to use 0l to represent null. I assume the use for this is when you have a feature id (but not the rid) and wish to request all features. -- Jody Garnett On Monday, 7 November 2011 at 5:35 PM, Jody Garnett wrote: > On Monday, 7 November 2011 at

Re: [Geotools-devel] Inconsistency in ResourceId

2011-11-06 Thread Jody Garnett
On Monday, 7 November 2011 at 2:57 PM, Mark Leslie wrote: > So at a minimum, ResourceIdImpl needs to accept null Version / date > range gracefully. This was where I was getting failures last week, > hence the application of the default value, so I'll need to look back > and find out what that was b

Re: [Geotools-devel] Inconsistency in ResourceId

2011-11-06 Thread Mark Leslie
So at a minimum, ResourceIdImpl needs to accept null Version / date range gracefully. This was where I was getting failures last week, hence the application of the default value, so I'll need to look back and find out what that was breaking. I'm also hitting some interesting concerns when both th

Re: [Geotools-devel] Inconsistency in ResourceId

2011-11-06 Thread Jody Garnett
> In your example, though, the versioning info is handled by Rid, which > is as specific as a Version object. > > Rid should be its own thing (and not a Version object.. Version can be one of the following: - relative to the current RID - (ALL, PREVIOUS, etc...) - index (this is a count startin

Re: [Geotools-devel] Inconsistency in ResourceId

2011-11-06 Thread Mark Leslie
Hmm. You make good sense. I actually brought that default in when testing against the wfs2 code, but it looks like I didn't look hard enough. As things are implemented, the ResourceIdImpl requires either a Version or a date range. This makes sense to me, as that's mostly what ResourceId adds to

Re: [Geotools-devel] Inconsistency in ResourceId

2011-11-04 Thread Jody Garnett
I thought hard on this one as well; let me read the spec again. Right I remember: This case is represent that as a specific FeatureId ( fid + rid ) to identify a specific record. Please not if you are updating geogit mark has been making good progress so you may want verify you are not duplica

[Geotools-devel] Inconsistency in ResourceId

2011-11-03 Thread Gabriel Roldan
Hello Jody, in updating my geoserver wfs2 versioning branch to use ResourceId from GeoTools trunk I found what looks like an inconsistency in ResourceIdImpl: The following constructor should left the version be null: public ResourceIdImpl(String fid, String featureVersion) { this(fid,