Re: [Geotools-devel] JDBC DatastoreTest testFeatureReader question

2011-03-29 Thread Jesse Eichar
I have posted a patch if you feel like reviewing it. http://jira.codehaus.org/browse/GEOT-3485 Jesse On Tue, Mar 29, 2011 at 4:38 PM, Justin Deoliveira wrote: > Yeah, it is a dialect for teradata's spatial database. > > http://www.teradata.com/t/ > > Jesse should be proposing a new unsupported

Re: [Geotools-devel] JDBC DatastoreTest testFeatureReader question

2011-03-29 Thread Justin Deoliveira
Yeah, it is a dialect for teradata's spatial database. http://www.teradata.com/t/ Jesse should be proposing a new unsupported module this week which will be accompanied shortly after by a geoserver community module. -Justin On Tue, Mar 29, 2011 at 8:32 AM, Andrea Aime wrote: > On Tue, Mar 29,

Re: [Geotools-devel] JDBC DatastoreTest testFeatureReader question

2011-03-29 Thread Andrea Aime
On Tue, Mar 29, 2011 at 3:07 PM, Justin Deoliveira wrote: > +1 on removing any bad assumptions from the base tests. I just ask that you > run the tests on at least h2 to ensure that there are no breakages. Any > other databases like postgis that you can run on even better. Fully agree. Out of cur

Re: [Geotools-devel] JDBC DatastoreTest testFeatureReader question

2011-03-29 Thread Justin Deoliveira
+1 on removing any bad assumptions from the base tests. I just ask that you run the tests on at least h2 to ensure that there are no breakages. Any other databases like postgis that you can run on even better. On Tue, Mar 29, 2011 at 6:13 AM, Jesse Eichar wrote: > I have created a ticket for this

Re: [Geotools-devel] JDBC DatastoreTest testFeatureReader question

2011-03-29 Thread Jesse Eichar
I have created a ticket for this and will attache a patch for review in a few minutes. I have since found other instances of this assumption. I will add all the findings to that ticket: http://jira.codehaus.org/browse/GEOT-3485 I would like a review from Justin or Andrea before I commit to ensu

Re: [Geotools-devel] JDBC DatastoreTest testFeatureReader question

2011-03-29 Thread christian . mueller
Many db systems retrieve the records in the inserting order if no order by is given. But this is not part of any sql standard, the order of the records is not guaranteed unless an order by clause is present. The test relies on a false assumption and should be rewritten. This can be done by c

[Geotools-devel] JDBC DatastoreTest testFeatureReader question

2011-03-29 Thread Jesse Eichar
Hi, currently the testGetFeatureReader in JDBCDatastoreTest assumes that the features are retrieved from the database in a certain order and if the database does not return the features in the same order as they are inserted the test fails. My question: Is there a rule that states that features m