Re: [Geotools-devel] Layer vs StyleLayer

2011-07-18 Thread Michael Bedward
Hi Jody, Regarding Andrea's comment below, can we have a chat about this on IRC please ? Alternatively, if there is already a TODO list for it please point me to it. cheers Michael On 11 July 2011 22:46, Andrea Aime wrote: > Btw, don't forget to modify the streaming renderer to do anything wi

Re: [Geotools-devel] Layer vs StyleLayer

2011-07-11 Thread Andrea Aime
On Mon, Jul 11, 2011 at 2:19 PM, Jody Garnett wrote: > Even for direct layer it would be fine; they will usually return an empty > feature collection. > My plans are to back port from uDig: > - some kind of ScalebarLayer > - some kind of NorthArrowLayer > For GeoTools I was hoping we could make a

Re: [Geotools-devel] Layer vs StyleLayer

2011-07-11 Thread Jody Garnett
Even for direct layer it would be fine; they will usually return an empty feature collection. My plans are to back port from uDig: - some kind of ScalebarLayer - some kind of NorthArrowLayer For GeoTools I was hoping we could make a GridLayer, IconLayer. And I was hoping we could make an exampl

Re: [Geotools-devel] Layer vs StyleLayer

2011-07-11 Thread Michael Bedward
Hi Jody, Sorry for the late reply to this one... > Now here is a more interesting question ...  should we move setStyle up to > the Layer class and remove StyleLayer as not interesting? Even if a layer > does not use SLD; the fact that it makes "something" available as features > main mean that a

Re: [Geotools-devel] Layer vs StyleLayer

2011-07-06 Thread Jody Garnett
Ah; no good reason - There was however an "ok" reason; by providing an implementation and code that extended StyleLayer was not forced to provide the same boiler plate methods. Cutting and pasting the same setStyle / getStyle code into FeatureLayer, GridCoverageLayer and GridReaderLayer seemed

Re: [Geotools-devel] Layer vs StyleLayer

2011-07-06 Thread Michael Bedward
Um... sorry Jody but I still don't understand. Why have an implementation at the Layer level rather than an abstract method ? Michael On 6 July 2011 19:29, Jody Garnett wrote: > Andrea asked the same question ... > Layer.getStyle() is something that each layer implementation needs to > provide

Re: [Geotools-devel] Layer vs StyleLayer

2011-07-06 Thread Jody Garnett
Andrea asked the same question ... Layer.getStyle() is something that each layer implementation needs to provide to spoon feed feature based renderers a style they can chew on. In the same manner they get to spoon feed a FeatureSource (even if their content is not features). Good times this

[Geotools-devel] Layer vs StyleLayer

2011-07-06 Thread Michael Bedward
Hi Jody, Can you enlighten me on the relationship between the Layer.getStyle method, which puts a Style into the user data map, and the StyleLayer.getStyle method which returns a sub-class field ? Michael -- All of the d