Re: [Geotools-devel] Pull Request Policy

2013-06-26 Thread Christian Mueller
Hi Chris I am completely with you, but I think we should discuss this in a new thread. Cheers Christian 2013/6/26 Chris Holmes > Ah right, apologies Christian, I'd completely forgotten, I guess because > you've actually been doing great work with it for so long, and you've > expanded your con

Re: [Geotools-devel] Pull Request Policy

2013-06-26 Thread Chris Holmes
Ah right, apologies Christian, I'd completely forgotten, I guess because you've actually been doing great work with it for so long, and you've expanded your contributions in to many other areas. Oh yeah, and merging the file and database image modules would be really great. One preliminary step mi

Re: [Geotools-devel] Pull Request Policy

2013-06-26 Thread Christian Mueller
Hi @Chris. I am the long term maintainer of the DB2 module. See the latestet release notes http://geotoolsnews.blogspot.co.at/2013/06/geotools-93-released.html There is almost no feed back from the community, enhancements are done based on my experience or from requirements sent to me by David Adl

Re: [Geotools-devel] Pull Request Policy

2013-06-25 Thread Andrea Aime
On Wed, Jun 26, 2013 at 8:15 AM, Brett Walker wrote: > Andrea, > > ** ** > > It was my misunderstanding on my part. It was trying to have a discussion > which would educate subsequent commits. This being the first of several. I > should have had the discussion on this mailing list rather on t

Re: [Geotools-devel] Pull Request Policy

2013-06-25 Thread Brett Walker
feedback or commit it please. Brett From: [email protected] [mailto:[email protected]] On Behalf Of Andrea Aime Sent: Wednesday, 26 June 2013 4:10 PM To: Brett Walker Cc: Geotools-Devel list Subject: Re: [Geotools-devel] Pull Request Policy On Tue, Jun 25, 2013 at 11:39 PM, Brett

Re: [Geotools-devel] Pull Request Policy

2013-06-25 Thread Andrea Aime
On Tue, Jun 25, 2013 at 11:39 PM, Brett Walker wrote: > Ignoring worthwhile patches could appear to give the cold shoulder to the > wider community. > Ah, if you were referring to this pull request: https://github.com/geotools/geotools/pull/208 the reason why it's not applied yet is that the pul

Re: [Geotools-devel] Pull Request Policy

2013-06-25 Thread Andrea Aime
On Tue, Jun 25, 2013 at 11:39 PM, Brett Walker wrote: > Hi, > > What is the policy/procedure/expectation for pull requests that have been > submitted for more than a couple of weeks? > > There are a number of pull requests that have been sitting 'dormant' for a > while. Do they sit forever open wi

Re: [Geotools-devel] Pull Request Policy

2013-06-25 Thread Chris Holmes
** > Cool, I'll let the real devs comment on those :) Chris > ** > > Brett > > ** ** > > *From:* [email protected] [mailto:[email protected]] *On Behalf > Of *Chris Holmes > *Sent:* Wednesday, 26 June 2013 1:17 PM > *To:* Brett Walker > *C

Re: [Geotools-devel] Pull Request Policy

2013-06-25 Thread Brett Walker
Brett From: [email protected] [mailto:[email protected]] On Behalf Of Chris Holmes Sent: Wednesday, 26 June 2013 1:17 PM To: Brett Walker Cc: [email protected] Subject: Re: [Geotools-devel] Pull Request Policy Welcome Brett! As you can tell we get too many requests from p

Re: [Geotools-devel] Pull Request Policy

2013-06-25 Thread Chris Holmes
r. > > GeoTools is a large body of work. I have lots to learn but am very willing. > > While this is brief, I am open to further queries. > > Please consider my request for commit access, > Brett > > -----Original Message- > From: Jody Garnett [mailto:jody.garn...@gma

Re: [Geotools-devel] Pull Request Policy

2013-06-25 Thread Brett Walker
.com] Sent: Wednesday, 26 June 2013 8:09 AM To: Brett Walker Cc: Geotools-Devel list Subject: Re: [Geotools-devel] Pull Request Policy Same as a patch in Jira - should have a test case, subject to volunteer time, etc... Pull request coming in via our change control procedure are planned during

Re: [Geotools-devel] Pull Request Policy

2013-06-25 Thread Ben Caradoc-Davies
And in particular, pull requests need the agreement of the maintainers of all affected modules. Unattended pull requests may require lobbying. Maintainers can be nagged on the mailing lists or by assigning issues to them in Jira. Pull requests from committers get faster attention because of re

Re: [Geotools-devel] Pull Request Policy

2013-06-25 Thread Jody Garnett
Same as a patch in Jira - should have a test case, subject to volunteer time, etc... Pull request coming in via our change control procedure are planned during our bi-weekly meeting, and in the case of GeoSolutions API change the subject of scheduling. In this case geotools is entering lockdown

[Geotools-devel] Pull Request Policy

2013-06-25 Thread Brett Walker
Hi, What is the policy/procedure/expectation for pull requests that have been submitted for more than a couple of weeks? There are a number of pull requests that have been sitting 'dormant' for a while. Do they sit forever open with no feedback, or should they be closed, with comment, if not f