Re: [Geotools-devel] wfs 2.0 in wfs-ng module

2015-01-19 Thread Niels Charlier
Hello Jody, Thanks for working on my pull requests. I will look at all your remarks and answer/resolve shortly. Sorry for the issue with the kml patch I approved. I read and checked all the code but in the future I will always make a local build as well before merging. Regards Niels On 18

Re: [Geotools-devel] wfs 2.0 in wfs-ng module

2015-01-17 Thread Jody Garnett
Thanks Sampo, it really helps having someone familiar with the codebase to provide a review. I will check it over for the usual glitches (headers, formatting) and look at including it today. And thanks to Niels for the hustle getting these pull requests in time. -- Jody Garnett On 17 January 201

Re: [Geotools-devel] wfs 2.0 in wfs-ng module

2015-01-17 Thread Sampo Savolainen
Hi, I rebuilt the war and the wfs-ng store registers just fine. I must've botched the earlier geoserver build I tried with. I'm giving this pull request my full hearted support for inclusion into GeoTools 13. Sampo Sampo On Fri, Jan 16, 2015 at 6:36 PM, Sampo Savolainen < sampo.savolai...@

Re: [Geotools-devel] wfs 2.0 in wfs-ng module

2015-01-16 Thread Sampo Savolainen
Thats great news. So what about including this is 2.7? Btw. Niels, what maven commands do you use to produce the build? It sounds like I'm missing some options or something. Sampo On Jan 16, 2015 6:10 PM, "Niels Charlier" wrote: > Sampo, it works for me in a tomcat. I think the issue must be

Re: [Geotools-devel] wfs 2.0 in wfs-ng module

2015-01-16 Thread Niels Charlier
Sampo, it works for me in a tomcat. I think the issue must be with your setup. Regards Niels On 16-01-15 16:29, Niels Charlier wrote: > I'll give it a try > > On 16-01-15 07:38, Sampo Savolainen wrote: >> >Hi, >> > >> >This is weird: If I run GeoServer in eclipse using the Start class in >> >gs-

Re: [Geotools-devel] wfs 2.0 in wfs-ng module

2015-01-16 Thread Niels Charlier
I'll give it a try On 16-01-15 07:38, Sampo Savolainen wrote: > Hi, > > This is weird: If I run GeoServer in eclipse using the Start class in > gs-web-app, the Capabilities is registered fine. However, if I build the > war and deploy it in tomcat, GeoServer cannot register the schema. Is there > a

Re: [Geotools-devel] wfs 2.0 in wfs-ng module

2015-01-15 Thread Niels Charlier
I have done so. Regards Niels On 15-01-15 18:21, Sampo Savolainen wrote: > Hi, > > Can you push the rebased branch so I can test the exact same version? > > Sampo > On Jan 15, 2015 5:37 PM, "Niels Charlier" wrote: > >> Hello Sampo, >> >> I cannot reproduce this error. I have rebased everything.

Re: [Geotools-devel] wfs 2.0 in wfs-ng module

2015-01-15 Thread Sampo Savolainen
Hi, Can you push the rebased branch so I can test the exact same version? Sampo On Jan 15, 2015 5:37 PM, "Niels Charlier" wrote: > Hello Sampo, > > I cannot reproduce this error. I have rebased everything. I can use the > mentioned file to create a datastore in geoserver. > > Regards, > Niels >

Re: [Geotools-devel] wfs 2.0 in wfs-ng module

2015-01-15 Thread Niels Charlier
Hello Sampo, I cannot reproduce this error. I have rebased everything. I can use the mentioned file to create a datastore in geoserver. Regards, Niels On 15-01-15 12:02, Sampo Savolainen wrote: > Hi, > > This should happen when adding a wfs-ng store using the mentioned test > GetCapabilities fi

Re: [Geotools-devel] wfs 2.0 in wfs-ng module

2015-01-15 Thread Sampo Savolainen
Hi, This should happen when adding a wfs-ng store using the mentioned test GetCapabilities file. If it works for you, then I guess something goes wrong when rebasing the branch. Sampo On Thu, Jan 15, 2015 at 12:42 PM, Niels Charlier wrote: > Hello Sampo, > > Can you clarify how I can rep

Re: [Geotools-devel] wfs 2.0 in wfs-ng module

2015-01-15 Thread Sampo Savolainen
Hi, Yeah, rebasing Niels's branch works. Unfortunately something is broken with the schema bindings in this branch. I'm unable to register the FMI Capabilities document with GeoServer (see exception below). The funny thing is, that the gt-xsd-wfs unit test that parses this document works fine. I

Re: [Geotools-devel] wfs 2.0 in wfs-ng module

2015-01-14 Thread Andrea Aime
On Wed, Jan 14, 2015 at 3:47 PM, Sampo Savolainen < sampo.savolai...@spatineo.com> wrote: > Hi, > > As this does not (should not) touch on anything else, I think it's a > candidate for including in the release. Of course there's not much time > left for the freeze window. I'll test this as soon as

Re: [Geotools-devel] wfs 2.0 in wfs-ng module

2015-01-14 Thread Andrea Aime
On Wed, Jan 14, 2015 at 3:25 PM, Niels Charlier wrote: > Hi Sampo, > > Your testing is important actually, so that we can be absolutely 100% sure > there is no regression with regards to your work. > > For WFS2.0/GML3.2 I use the geotools PullParser rather than the > gt-wfs-ng's own internal par

Re: [Geotools-devel] wfs 2.0 in wfs-ng module

2015-01-14 Thread Sampo Savolainen
Hi, As this does not (should not) touch on anything else, I think it's a candidate for including in the release. Of course there's not much time left for the freeze window. I'll test this as soon as I can. In fact, I tried to build this but I couldn't build GeoServer against your branch: [ERROR]

Re: [Geotools-devel] wfs 2.0 in wfs-ng module

2015-01-14 Thread Niels Charlier
Hi Sampo, Your testing is important actually, so that we can be absolutely 100% sure there is no regression with regards to your work. For WFS2.0/GML3.2 I use the geotools PullParser rather than the gt-wfs-ng's own internal parser. I think ideally we should get rid of the internal parser all

Re: [Geotools-devel] wfs 2.0 in wfs-ng module

2015-01-14 Thread Sampo Savolainen
Hi, This is really good timing. We just noticed some issues regarding GML feature parsing when using my cascaded stored query support. I'll try your branch tomorrow and report back. In the meanwhile I'd like to know if you are proposing this feature for the next stable release? Sampo On Tue, J