Re: [Geotools-devel] JDBCDataStore blocks search hints on virtual tables

2022-12-28 Thread Uhrig, Stefan via GeoTools-Devel
Hi Andrea, Thanks for your reply. Your proposal sounds good to me. I'll open a Jira item and prepare a pull request. Cheers, Stefan From: Andrea Aime Sent: Tuesday, December 27, 2022 11:52 AM To: Uhrig, Stefan Cc: Jody Garnett ; GeoTools Subject: Re: [Geotools-devel] JDBCDataStore blocks

Re: [Geotools-devel] JDBCDataStore blocks search hints on virtual tables

2022-12-27 Thread Andrea Aime
On Wed, Dec 14, 2022 at 2:45 PM Uhrig, Stefan wrote: > > If you don’t have objections, I’d like to add a way to let the SQLDialect > decide. However, I’m not sure what the best way would be. I considered the > following options: > > > >1. Ask the SQLDialect via a method whether hints should

Re: [Geotools-devel] JDBCDataStore blocks search hints on virtual tables

2022-12-14 Thread Uhrig, Stefan via GeoTools-Devel
u think? Thanks and best regards, Stefan From: Andrea Aime Sent: Wednesday, December 14, 2022 10:20 AM To: Uhrig, Stefan Cc: GeoTools Subject: Re: [Geotools-devel] JDBCDataStore blocks search hints on virtual tables HI Stefan, a virtual table can be built around any resultset returning statem

Re: [Geotools-devel] JDBCDataStore blocks search hints on virtual tables

2022-12-14 Thread Andrea Aime
HI Stefan, a virtual table can be built around any resultset returning statement (e.g., a stored procedure), and the JDBCDataStore machinery makes no attempt to understand the SQL being provided, it just uses it as a subquery in the from clause. Query hints, at least in the databases that I'm

Re: [Geotools-devel] JDBCDataStore blocks search hints on virtual tables

2022-12-13 Thread Jody Garnett
I am sure it was just lack of scope; since the virtual tables can be any SQL query - it was probably not obvious how to integrate a select hint? If you have a join for example which select would you like to add the hint to? Or would you like to create a subquery and do the select on the result?

[Geotools-devel] JDBCDataStore blocks search hints on virtual tables

2022-12-13 Thread Uhrig, Stefan via GeoTools-Devel
Hi all, Recently, a group of GeoServer users on HANA requested the possibility to append hints to SQL queries. Luckily, there was already SQLDialect#handleSelectHints(). So, I could just override the method in HanaDialect and append the hints to the query, which I did in [GEOT-7230]