Re: [Geotools-devel] proposal: Restructure GeoTools into Jigsaw modules

> By the way, how does Jigsaw work with optional dependencies? Can we > still leave out unused dependencies like with the current classpath? Or > will Java 11 spit the dummy? > Good question, here is my speculation: If the dependency is something like log4j and we have adapting code that we can

Re: [Geotools-devel] proposal: Restructure GeoTools into Jigsaw modules

On 27/09/2018 10:01, Jody Garnett wrote: Hey Ben - are you available for the code sprint? Completely understand if you are not being a small business, but we would really love your help. Sorry, I am not likely to be available. Additional comments/confusion inline: On Wed, 26 Sep 2018 at

Re: [Geotools-devel] proposal: Restructure GeoTools into Jigsaw modules

Hey Ben - are you available for the code sprint? Completely understand if you are not being a small business, but we would really love your help. Additional comments/confusion inline: On Wed, 26 Sep 2018 at 14:50, Ben Caradoc-Davies wrote: > Does Jigsaw prevent classpath trickery like

Re: [Geotools-devel] proposal: Restructure GeoTools into Jigsaw modules

Does Jigsaw prevent classpath trickery like gt-xsd-gml3 org.geotools.referencing.crs.EPSGCRSAuthorityFactory? This is required to make tests pass in Eclipse. Are modules like gt-app-schema that define classes in several packages also defined in other modules affected by this change? I guess

Re: [Geotools-devel] proposal: Restructure GeoTools into Jigsaw modules

On Wed, Sep 26, 2018 at 8:12 PM Jody Garnett wrote: > > "I think it is a requirement for the work". The work is "Restructure >> GeoTools into Jigsaw modules" and covers two items: >> * Providing an automatic module name for each jar >> * Refactoring the codebase to avoid package conflicts >> >>

Re: [Geotools-devel] proposal: Restructure GeoTools into Jigsaw modules

> "I think it is a requirement for the work". The work is "Restructure > GeoTools into Jigsaw modules" and covers two items: > * Providing an automatic module name for each jar > * Refactoring the codebase to avoid package conflicts > > Can you explain how this package renaming is required for the

Re: [Geotools-devel] proposal: Restructure GeoTools into Jigsaw modules

On Tue, Sep 25, 2018 at 9:13 PM Jody Garnett wrote: > I like the direction, but does not seem a requirement, more of a nice to >> have. Can we do it towards the end, when everything >> is building and ready to merge in mainline? >> > > We may be able to move it near the end - but I think it is a

Re: [Geotools-devel] proposal: Restructure GeoTools into Jigsaw modules

Okay Java 11 is here: - http://jdk.java.net/11 - https://www.oracle.com/technetwork/java/javase/downloads/jdk11-downloads-5066655.html I would like to start on branch for this restricting on Friday, or experiment to resolving any feedback/questions from this discussion thread. Candidates for

Re: [Geotools-devel] proposal: Restructure GeoTools into Jigsaw modules

1. remove org.opengis packages > >> It seems like good timing, and with the module system any conflict over >> org.opengis packages will be more keenly felt. >> >> Here is the proposal renaming org.opengis to org.geotools.api: >> - org.geotools.api.filter.Filter >> -

Re: [Geotools-devel] proposal: Restructure GeoTools into Jigsaw modules

Thanks for the discussion - you have given me some items to think about. For the plugins I only found a few conflicts, gt-epsg-hsql for example, where an implementation uses the same package name on purpose (I think to access some package visible API). Technically there is one other approach to

Re: [Geotools-devel] proposal: Restructure GeoTools into Jigsaw modules

On Fri, Sep 21, 2018 at 8:10 PM Jody Garnett wrote: > That is great - which book? > This one, in its current "early access" version: https://www.manning.com/books/the-java-module-system So far good book, the prose flows and has good information. > 1. remove org.opengis packages > > It seems

Re: [Geotools-devel] proposal: Restructure GeoTools into Jigsaw modules

That is great - which book? I trust your intelligence on a wide range of matters, while you research the technical side - there are a couple strategic decisions in the middle of this proposal that I would appreciate your guidance / input on. 1. remove org.opengis packages It seems like good

Re: [Geotools-devel] proposal: Restructure GeoTools into Jigsaw modules

Hi Jody, I got myself a book on java modularity and reading through it in my spare time. Will take a couple of weeks I believe before I can add any intelligent comment on the proposal, sorry :-) Cheers Andrea On Tue, Sep 18, 2018 at 1:18 AM Jody Garnett wrote: > Proposal is here: Restructure

Re: [Geotools-devel] proposal: Restructure GeoTools into Jigsaw modules

I've looked over the proposal, and we reviewed it during yesterday's PMC meeting. First off, thanks for putting this together. During discussion, you mentioned we could have Eclipse generate a refactoring script to use when refactoring other projects to conform to the GeoTools API changes -

[Geotools-devel] proposal: Restructure GeoTools into Jigsaw modules

Proposal is here: Restructure GeoTools into Jigsaw modules Feedback welcome, I expect we will have some discussion before voting. -- Jody Garnett ___ GeoTools-Devel