[ABANDON] libosmocore[master]: change version of used python interpreter to generic one

2017-05-08 Thread Harald Welte
Harald Welte has abandoned this change. Change subject: change version of used python interpreter to generic one .. Abandoned no follow-up for 7 weeks. Please resurrect when needed. -- To view, visit https://gerrit.osmocom.or

osmo-pcu[master]: remove pcu own bitvector implementation

2017-05-08 Thread Harald Welte
Patch Set 2: ping? -- To view, visit https://gerrit.osmocom.org/1753 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8f797631d89aa12b6e48efb2dc153a3e2f059f7 Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner:

libosmocore[master]: vty: cleanup logging functions

2017-05-08 Thread Harald Welte
Patch Set 2: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/2084/2/include/osmocom/core/logging.h File include/osmocom/core/logging.h: Line 335: const char *log_vty_command_string() OSMO_DEPRECATED("For internal use inside libosmocore only."); you could introduce a libosmovty.map fil

osmo-bts[master]: measurement: fix clearing of L1 info valid flag

2017-05-08 Thread Harald Welte
Patch Set 1: can this be part of the patch the clears it in the new location? I think it would be more logical. -- To view, visit https://gerrit.osmocom.org/2413 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie511cba7927b4ab80a5b7551c3

[MERGED] osmo-bts[master]: bts: revert trx shutdown order

2017-05-08 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bts: revert trx shutdown order .. bts: revert trx shutdown order When a new TRX is allocated using gsm_bts_trx_alloc() (see gsm_data_shared.c in openbsc.

libosmocore[master]: Simplify ctrl cmd lookup

2017-05-08 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2462 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida1b389b571c60c26813cd29e61b3e4423c5df0f Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master Ger

osmo-trx[master]: debian: remove obsolete dependency

2017-05-08 Thread Harald Welte
Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/2400 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ea72b4123a280a846086d083c4f3189d611f8cf Gerrit-PatchSet: 3 Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit

osmo-bts[master]: sysmobts: Store a simple network config in the EEPROM as well

2017-05-08 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/450 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8a37fe952ef2a8ef36778729f506f900accf8d1 Gerrit-PatchSet: 3 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-

[MERGED] osmo-bts[master]: sysmobts: Store a simple network config in the EEPROM as well

2017-05-08 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: sysmobts: Store a simple network config in the EEPROM as well .. sysmobts: Store a simple network config in the EEPROM as well Make it possible to store:

osmo-sip-connector[master]: evpoll: Implement poll with ppoll and map select to poll..

2017-05-08 Thread Harald Welte
Patch Set 2: Hi Holger, I think nobody really understands the issue sufficiently to comment on it. Otherwise we would have seen feedback here. So make the call and proceed, please :) -- To view, visit https://gerrit.osmocom.org/1987 To unsubscribe, visit https://gerrit.osmocom.org/settings

[MERGED] openbsc[master]: Gb: use textual representation for parse log

2017-05-08 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Gb: use textual representation for parse log .. Gb: use textual representation for parse log Use textual representation for message type and protocol des

openbsc[master]: Gb: use textual representation for parse log

2017-05-08 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2482 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida925258be119619d8705361730c554a130b75bc Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-

libosmocore[master]: gprs: add value strings for NS PDU type

2017-05-08 Thread Harald Welte
Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/2473/1/src/gb/gprs_ns.c File src/gb/gprs_ns.c: Line 300: OSMO_VALUE_STRING(NS_PDUT_UNITDATA), I really don;'t like the aut-generated value strings in a lot of cases. The user expects to se a "NS-UNITDATA", as this is

osmo-gsm-manuals[master]: OsmoBTS/chapters/configuration.adoc: Add bts index in example

2017-05-08 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2460 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If13643cdfa59c50b6af8ab0657635fed2ca219f0 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: maste

[MERGED] libosmocore[master]: gsm0808: fix control flow issue

2017-05-08 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: gsm0808: fix control flow issue .. gsm0808: fix control flow issue Coverity Scan reported a control flow issue in line 206: CID 166898: Control flow iss

libosmocore[master]: gsm0808: fixup length check of the element decoder functions

2017-05-08 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2446 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78bc887f68d1963d28c6fcd631ac20ccd893d6d6 Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master Ger

openbsc[master]: Use ipa.py for ctrl tests

2017-05-08 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2466 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I676390abe2f179df6004cdd33d0eaaf60e18df03 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-

[MERGED] osmo-gsm-manuals[master]: OsmoBTS/chapters/configuration.adoc: Add bts index in example

2017-05-08 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: OsmoBTS/chapters/configuration.adoc: Add bts index in example .. OsmoBTS/chapters/configuration.adoc: Add bts index in example Change-Id: If13643cdfa59c5

openbsc[master]: Make BTS type and variant converters shareable

2017-05-08 Thread Harald Welte
Patch Set 9: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/2286/9/openbsc/src/libcommon/gsm_data_shared.c File openbsc/src/libcommon/gsm_data_shared.c: Line 72:{ BTS_OSMO_LITECELL15, "Litecell15" }, if we ever want to use any of those in the VTY (which we probably will soone

openbsc[master]: Make BTS type and variant converters shareable

2017-05-08 Thread Harald Welte
Patch Set 9: definitely we want to report individual features to the BSC, that's what I jokingly described as "abis oml bts classmark". But I guess that's going to be a follow-up patch and is unrelated to the bSC being able to show the properties such as the BTS variant and software version o

osmo-bts[master]: Signal to BSC when PCU disconnects

2017-05-08 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2288 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41a731bd719aee0bbb98d3236405fb3a7f3ddec0 Gerrit-PatchSet: 3 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit

openbsc[master]: Use libosmocore for SW Description parsing

2017-05-08 Thread Harald Welte
Patch Set 9: has ipa firmware update tested with this patch? if yes, we can +2 it -- To view, visit https://gerrit.osmocom.org/2166 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib94db414e94a2a1f234ac6f1cb346dca1c7a8be3 Gerrit-PatchSet:

libosmocore[master]: core/conv: strip unused memalign() call

2017-05-08 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2455 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide764d1c643527323334ef14335be7f8915f7622 Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master Ger

[MERGED] libosmocore[master]: configure.ac: add SIMD detection capabilities

2017-05-08 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: configure.ac: add SIMD detection capabilities .. configure.ac: add SIMD detection capabilities This change adds a check whether compiler supports some SI

libosmocore[master]: configure.ac: check for __builtin_cpu_supports call support

2017-05-08 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2519 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d52cfb3e8fab3eedc0293a2842708cbee0f476a Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Ger

[MERGED] libosmocore[master]: core/conv: strip unused memalign() call

2017-05-08 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: core/conv: strip unused memalign() call .. core/conv: strip unused memalign() call The alligned memory allocation is only required for SSE, which is curr

[MERGED] libosmocore[master]: configure.ac: check for __builtin_cpu_supports call support

2017-05-08 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: configure.ac: check for __builtin_cpu_supports call support .. configure.ac: check for __builtin_cpu_supports call support The '__builtin_cpu_supports' i

openbsc[master]: libmsc: send RP-ACK to MS after ESME sends SMPP DELIVER-SM-RESP

2017-05-08 Thread Harald Welte
Patch Set 2: Code-Review-1 (5 comments) https://gerrit.osmocom.org/#/c/2488/2/openbsc/src/libmsc/smpp_openbsc.c File openbsc/src/libmsc/smpp_openbsc.c: Line 464: static void *smpp_cmd_ctx; if the smpp_cmd are allocated with the esme as context, this one can go. Line 524: smpp_cmd_err(da

<    1   2