Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4973
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c3ca0c660388b1e2c82df17ec540c846201b0c7
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4974
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If0659a878deb383ed0300217e2c41c8c79b2b6a5
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4963
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id10311332aeabd8fd3ba1922198e34708e04cef9
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4970
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie647d93a54aefad5bde8a9411d983cd60714b83d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4968
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I477984d5e3bee8aea32419482d6bc48b1e74e6c2
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4965
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If08ba48ab9c28bf3c2db4014837c1304cec04aaf
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4967
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f8b45d6580d42b00de847c8100023b414771939
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4966
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I11c5213b90de27dc2606f73c686f263008b6522f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Patch Set 1: Code-Review+2
I think this behavior is still a bit odd and can be misleading to the user. We
should at least clearly log such situations in the HLR, irrespective of what
cause value we return on GSUP
--
To view, visit https://gerrit.osmocom.org/4976
To unsubscribe, visit https:/
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4975
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f628aa9d62b778951726bebec8cf338444fc897
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: test_common: fix compiler warning: include ranap_common.h
..
test_common: fix compiler warning: include ranap_common.h
test_common.c:85:2: warning: imp
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4978
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6395dcde35359617cae52ff59d4eb53930097c7d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/4977/1/src/hnbgw_cn.c
File src/hnbgw_cn.c:
PS1, Line 474: 24
Does this follow
http://osmocom.org/projects/cellular-infrastructure/wiki/Point_Codes ?
--
To view, visit https://gerrit.osmocom.org/4977
To unsubscribe, visit https://gerrit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4962
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice192e1f7f1bdafe0941160f43e573349aaceb75
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit
Review at https://gerrit.osmocom.org/4978
cosmetic: osmo-hnbgw: log remote SCCP addresses on startup
Change-Id: I6395dcde35359617cae52ff59d4eb53930097c7d
---
M src/hnbgw_cn.c
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/78/497
Review at https://gerrit.osmocom.org/4977
osmo-hnbgw: auto-config remote PCs if omitted
The current default point-code for OsmoMSC is 0.23.1 and for OsmoSGSN 0.0.2.
Not sure how we ended up with those, but that is secondary and can be changed.
Before this patch, osmo-hnbgw requires a cs7 confi
Review at https://gerrit.osmocom.org/4975
cosmetic: rx_send_auth_info(): decide error cause with switch()
Prepare for tweaking error handling in a subsequent patch: use switch() instead
of if().
Prepares-for: I90df7b255317df1e5d968e7ce3b9d2c404b98db8
Change-Id: I1f628aa9d62b778951726bebec8cf33
Review at https://gerrit.osmocom.org/4976
return GMM_CAUSE_IMSI_UNKNOWN if there is no auth data
If we have a subscriber entry that lacks auth data, we currently return
GMM_CAUSE_NET_FAIL, which in the MSC log looks like the HLR is not connected or
something grave. Instead, return GMM_CAUSE_IMS
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4974
to look at the new patch set (#2).
fix use after free: missing conn_get on CC paging response
Adjust test expectations accordingly.
The error was:
==16084==ERROR: AddressSanitizer:
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4973
to look at the new patch set (#2).
add msc_vlr_test_call to reproduce a sanitizer error
On MT call, there is a bug in CC conn use which leads to an early free and
use-after-free.
Add m
Neels Hofmeyr has submitted this change and it was merged.
Change subject: mgcp_test: test_no_cycle: sanitize: free endp
..
mgcp_test: test_no_cycle: sanitize: free endp
Release endpoint to avoid sanitizer errors.
Change-Id: I
Neels Hofmeyr has submitted this change and it was merged.
Change subject: tests: sanitize: fix mem leaks, clean after tests
..
tests: sanitize: fix mem leaks, clean after tests
Fix various mem leaks in the testing code.
Add t
Neels Hofmeyr has submitted this change and it was merged.
Change subject: mgcp_test: sanitize: free msgb_ctx
..
mgcp_test: sanitize: free msgb_ctx
Ensure that all msgb were cleaned up, then free the overall msgb_ctx, in order
Neels Hofmeyr has submitted this change and it was merged.
Change subject: ranap_msg_factory: sanitize: memcpy instead of unaligned int
copy
..
ranap_msg_factory: sanitize: memcpy instead of unaligned int copy
The sanitize bui
Patch Set 3:
> Yes the otherway around. But what was the conclusion on the ntohl
> here?
my conclusion is that I prefer ntohl to clarify network byte order instead of
just big endian "for no specific reason"
--
To view, visit https://gerrit.osmocom.org/4928
To unsubscribe, visit https://gerr
Review at https://gerrit.osmocom.org/4970
msc_vlr_tests: set a valid lac for fake conns
Change-Id: Ie647d93a54aefad5bde8a9411d983cd60714b83d
---
M tests/msc_vlr/msc_vlr_test_authen_reuse.err
M tests/msc_vlr/msc_vlr_test_gsm_authen.err
M tests/msc_vlr/msc_vlr_test_gsm_ciph.err
M tests/msc_vlr/ms
Review at https://gerrit.osmocom.org/4969
msc_vlr_tests: fix test nr arg: clear errno before strtol()
Change-Id: I8e9376f20a44f6348bcb85f0ff27a429dc90e1b8
---
M tests/msc_vlr/msc_vlr_tests.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs
Review at https://gerrit.osmocom.org/4967
cosmetic: log: CC trans_alloc: log trans_id and subscr, not memory addrs
Change-Id: I5f8b45d6580d42b00de847c8100023b414771939
---
M src/libmsc/transaction.c
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo
Review at https://gerrit.osmocom.org/4968
cosmetic: debug log: mncc: detached subscr: show subscriber
Change-Id: I477984d5e3bee8aea32419482d6bc48b1e74e6c2
---
M src/libmsc/gsm_04_08.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes
Review at https://gerrit.osmocom.org/4974
fix use after free: missing conn_get on CC paging response
Adjust test expectations accordingly.
The error was:
==16084==ERROR: AddressSanitizer: heap-use-after-free on address
0x6150f5f4 at pc 0x561be639ac2b bp 0x7ffc0aabbe40 sp 0x7ffc0aabbe38
Review at https://gerrit.osmocom.org/4971
cosmetic: log error when using a conn that's in release
If a conn is attempted to be used when in release, log an error, but don't skip
tracking.
No current code path apparently hits this, according to msc_vlr_tests. Just
making sure that we will promi
Review at https://gerrit.osmocom.org/4973
add msc_vlr_test_call to reproduce a sanitizer error
On MT call, there is a bug in CC conn use which leads to an early free and
use-after-free.
Add msc_vlr_test_call to show both MO and MT call legs separately and reproduce
the failure. It is visible i
Review at https://gerrit.osmocom.org/4972
subscr_conn: introduce usage tokens for ref error tracking
When hunting a conn use count bug, it was very hard to figure out who's (not)
using the conn. To ease tracking down this bug and future bugs, explicitly name
what a conn is being reserved for, a
Review at https://gerrit.osmocom.org/4966
cosmetic: log: CC state transition: log trans id and subscr
Change-Id: I11c5213b90de27dc2606f73c686f263008b6522f
---
M src/libmsc/gsm_04_08.c
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/chang
Review at https://gerrit.osmocom.org/4965
sms_queue_test: sanitize: clean up talloc contexts when done
To avoid sanitizer build failures, ensure that the talloc contexts are empty
when done and free them.
Separate the msgb context from the overall talloc context for clarity: if
nested, the out
Review at https://gerrit.osmocom.org/4963
bssap: remove libosmo-legacy-mgcp dependancy
the functions mgcp_timeslot_to_endpoint() and rtp_calculate_port()
which are used to calculate the port in the sccp-lite / non AoIP
case are part of libosmo-legacy-mgcp. Unfortunately libosmo-mgcp
and libosmo
Review at https://gerrit.osmocom.org/4964
mgcp: use mgw assigned connection identifiers
osmo-mgw assigns connection identifiers which are returned with
the response to the CRCX.
store the assigned connection identifiers and use them to identify
the connections.
Depends osmo-mgw: Iab6a6038e761
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4905
to look at the new patch set (#2).
libosmo-mgcp: Connection Identifiers are allocated by MGW, not CA
The MGCP connection identifier is allocated by the MGW while processing
the CRCX, se
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4906
to look at the new patch set (#2).
MGCP: Connection Identifiers are hex strings
The MGCP spec in RFC3435 is quite clear: Connection Identifiers are
hexadecimal strings of up to 32 chara
Patch Set 2:
I created this task a follow-up to improve related stuff:
https://osmocom.org/issues/2673
--
To view, visit https://gerrit.osmocom.org/4213
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e3ec741247d728232f8c07c94eb63f0685
Patch Set 1:
To elaborate further. Before this change I had to know what
test_successive_allocation is doing. If I understand it correctly you are
confused that for min_class and max_class sometimes the same class and
sometimes different classes are passed.
You try to solve this by introducin
Patch Set 1: Code-Review-1
(4 comments)
I don't get this churn.. It is different to what Jacob wrote but in which way
is it better or needed?
You remove one test (function) and inline it. Change some parameters. Say you
remove one wrapper, add another? Why?
https://gerrit.osmocom.org/#/c/495
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/4957/1/tests/alloc/AllocTest.cpp
File tests/alloc/AllocTest.cpp:
Line 482: case TEST_MODE_DL_ONLY: return (char*)"DL only";
no need to introduce this first and then change from ONLY to only
--
To view, visit https://
Patch Set 1: Code-Review+2
hmm okay
--
To view, visit https://gerrit.osmocom.org/4957
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30a4b8f561a9677f4e9ded33a051a249bd15a6a2
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: mas
44 matches
Mail list logo
