Review at https://gerrit.osmocom.org/5522
hnbgw: use proper talloc ctx for vty telnet init
Change-Id: I355c6e5489f24566612528cd679c5cab21eed008
---
M src/hnbgw.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/22/5522/1
diff --git
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5521
to look at the new patch set (#2).
hnbgw: use proper VTY port number defined in libosmocore (4261)
We used to have hardcoded 2323 from early development, use the proper
libosmocore defi
Review at https://gerrit.osmocom.org/5518
common: ports: tweak OpenGGSN to osmo-ggsn as on port-numbers wiki page
Related: https://osmocom.org/projects/cellular-infrastructure/wiki/Port_Numbers
Change-Id: Ieaac06c9d914fc7481107ca8ebe6192b36b91bcd
---
M common/chapters/port_numbers.adoc
1 file c
Review at https://gerrit.osmocom.org/5519
ports: add osmo-hnbgw as on port-numbers wiki page
Related: https://osmocom.org/projects/cellular-infrastructure/wiki/Port_Numbers
Related: Ife52a968a41cb286f640006587877971ff66c1a4 (libosmocore)
Change-Id: I28bd7a97d24455f88fadc6724d45c3264ba2fce4
---
Review at https://gerrit.osmocom.org/5521
hnbgw: use proper VTY port number defined in libosmocore (4261)
We used to have hardcoded 2323 from early development, use the proper
libosmocore definition instead.
Depends: Ife52a968a41cb286f640006587877971ff66c1a4 (libosmocore)
Change-Id: Id67d89695
Review at https://gerrit.osmocom.org/5520
ports: define proper VTY and CTRL ports for OsmoHNBGW
So far it uses 2323, a development default. Instead, assign new ports,
appending to the common range of VTY and CTRL ports: 4261 and 4262.
Related: https://osmocom.org/projects/cellular-infrastructu
This is most probably related to / fixed by https://gerrit.osmocom.org/5516 :
[ 142s] [0;m<001e> rate_ctr.c:195 counter group 'msc' already exists for
index 0
[ 142s]
[0;m/usr/src/packages/BUILD/openbsc/tests/testsuite.dir/at-groups/1/test-source:
line 25: 20213 Segmentation fault
$ab
Patch Set 4: -Code-Review Verified+1
verified to work in manual test with two nano3G
--
To view, visit https://gerrit.osmocom.org/5381
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I189f8e2663353276b1c615d2f78455dafe568045
Gerrit-PatchS
Review at https://gerrit.osmocom.org/5516
rate_ctr: fix osmo-sgsn DoS: don't return NULL on already used index
Recent patch I563764af1d28043e909234ebb048239125ce6ecd introduced returning
NULL from rate_ctr_group_alloc() when the index passed already exists.
Instead of returning NULL, find an u
Review at https://gerrit.osmocom.org/5517
gprs_gmm: segfault: gracefully handle failure to alloc context
This counter allocation error I hit uncovers a segfault when allocating an MM
context fails in the GSM_MI_TYPE_TMSI case:
DRANAP <001a> ../../../src/osmo-iuh/src/iu_client.c:509
handle_c
Patch Set 4:
(1 comment)
https://gerrit.osmocom.org/#/c/4893/4/src/osmo_ss7.c
File src/osmo_ss7.c:
Line 1792: osmo_ss7_xua_server_create(struct osmo_ss7_instance *inst, enum
osmo_ss7_asp_protocol proto,
> to keep the public API backwards compatible, you should rather introduce os
We don't need
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/armv7l
Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/armv7l
Check out the package for editing:
osc checkout network:osmocom:nightly openbsc
Last lines of build log:
[ 41
Patch Set 1: Verified-1
This should actually be merged against branch laforge/nightly instead of
201705, since 201705 still doesn't use an osmo-sgsn new enough.
--
To view, visit https://gerrit.osmocom.org/5485
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: com
Review at https://gerrit.osmocom.org/5515
fix debug log: put 'deriving 2G from 3G' in proper place
Don't log "deriving 2G from 3G" when we're actually calculating separately; log
it when we're actually deriving from 3G.
Add log "calculating 2G separately" in the right place.
The test output c
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/5514
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a122cee4fa98115140e4a34f623958697affed2
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: mas
Neels Hofmeyr has submitted this change and it was merged.
Change subject: jobs: master: fix: libosmoabis should trigger osmo-hlr
..
jobs: master: fix: libosmoabis should trigger osmo-hlr
Change-Id: I9a122cee4fa98115140e4a34f62
Review at https://gerrit.osmocom.org/5514
jobs: master: fix: libosmoabis should trigger osmo-hlr
Change-Id: I9a122cee4fa98115140e4a34f623958697affed2
---
M jobs/master-builds.yml
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/14/55
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/aarch64
Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/aarch64
Check out the package for editing:
osc checkout network:osmocom:nightly openbsc
Last lines of build log:
[ 1
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/x86_64
Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly openbsc
Last lines of build log:
[ 14
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.04/x86_64
Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.04/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly openbsc
Last lines of build log:
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_16.04/x86_64
Package network:osmocom:nightly/openbsc failed to build in xUbuntu_16.04/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly openbsc
Last lines of build log:
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.10/x86_64
Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.10/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly openbsc
Last lines of build log:
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_16.10/x86_64
Package network:osmocom:nightly/openbsc failed to build in xUbuntu_16.10/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly openbsc
Last lines of build log:
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_8.0/x86_64
Package network:osmocom:nightly/openbsc failed to build in Debian_8.0/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly openbsc
Last lines of build log:
[ 13
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/i586
Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/i586
Check out the package for editing:
osc checkout network:osmocom:nightly openbsc
Last lines of build log:
[ 150s]
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_16.10/i586
Package network:osmocom:nightly/openbsc failed to build in xUbuntu_16.10/i586
Check out the package for editing:
osc checkout network:osmocom:nightly openbsc
Last lines of build log:
[
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.04/i586
Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.04/i586
Check out the package for editing:
osc checkout network:osmocom:nightly openbsc
Last lines of build log:
[
Harald Welte has submitted this change and it was merged.
Change subject: remove unused 'lac' member of 'struct gsm_subscriber_connection'
..
remove unused 'lac' member of 'struct gsm_subscriber_connection'
This field was used
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5504
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc4b8f3776c35df7e81252efb78ec740a371de7f
Gerrit-PatchSet: 4
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: gsm_data.h: Document all fields of gsm_subscriber_connection
..
gsm_data.h: Document all fields of gsm_subscriber_connection
Change-Id: I429fe7817f075d07
Harald Welte has submitted this change and it was merged.
Change subject: osmo_bsc.h: document every field in 'struct osmo_bsc_sccp_con'
..
osmo_bsc.h: document every field in 'struct osmo_bsc_sccp_con'
Change-Id: I674ed61a22fa
Harald Welte has submitted this change and it was merged.
Change subject: Remove unused struct osmo_bsc_sccp_con member sccp_queue_size
..
Remove unused struct osmo_bsc_sccp_con member sccp_queue_size
Change-Id: Ibc4b8f3776c35d
Harald Welte has submitted this change and it was merged.
Change subject: osmo-bsc: Move user plane/voice related bits into sub-structure
..
osmo-bsc: Move user plane/voice related bits into sub-structure
This clarifies which m
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5504
to look at the new patch set (#4).
Remove unused struct osmo_bsc_sccp_con member sccp_queue_size
Change-Id: Ibc4b8f3776c35df7e81252efb78ec740a371de7f
---
M include/osmocom/bsc/osmo_bsc.
Harald Welte has submitted this change and it was merged.
Change subject: osmo-bsc.cfg.tmpl: Remove bogus VTY commands
..
osmo-bsc.cfg.tmpl: Remove bogus VTY commands
There are plenty of VTY commands that were inherited from Os
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/5513
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I79ff48983d9cb7b875c1859870d5e3bce2c0ef22
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Bra
Review at https://gerrit.osmocom.org/5513
osmo-bsc.cfg.tmpl: Remove bogus VTY commands
There are plenty of VTY commands that were inherited from OsmoNITB,
but which make no sense in a BSC. Upstream OsmoBSC has removed them in
change-ids Ib626f43a3a3ca69dfc127afe5832eb58f7fb6a38,
c499e5c62e9bef
Harald Welte has submitted this change and it was merged.
Change subject: Remove unused RRLP options/codec
..
Remove unused RRLP options/codec
RRLP is handled in OsmoMSC after the split from NITB, so let's remove
any bogus VTY
Harald Welte has submitted this change and it was merged.
Change subject: remove libosmo-sccp dependency for osmo-bsc
..
remove libosmo-sccp dependency for osmo-bsc
libosmo-sccp is the old sccp-lite-focused SCCP implementation
Harald Welte has submitted this change and it was merged.
Change subject: Remove bogus vty config for LU reject cause
..
Remove bogus vty config for LU reject cause
The LU reject cause (like anything MM related) is under contro
Harald Welte has submitted this change and it was merged.
Change subject: osmo_bsc_bssap.c: Spelling fixes in comment
..
osmo_bsc_bssap.c: Spelling fixes in comment
Change-Id: I32b2d08bf25cd2d343755ac8491e4f5f758ccee6
---
M src
Harald Welte has submitted this change and it was merged.
Change subject: Remove bogus MM INFO configuration
..
Remove bogus MM INFO configuration
The network name and other MM INFO is controlled by the MSC, not the BSC.
Chang
Harald Welte has submitted this change and it was merged.
Change subject: Remove dead code left over from NITB split
..
Remove dead code left over from NITB split
There still is a lot of dead code that we inherited from the NIT
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5479
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I919bffe88babd90227c89abd4434322965c32ebb
Gerrit-PatchSet: 4
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: Remove some more dead code
..
Remove some more dead code
Change-Id: I919bffe88babd90227c89abd4434322965c32ebb
---
M include/osmocom/bsc/gsm_data.h
M incl
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5476
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib626f43a3a3ca69dfc127afe5832eb58f7fb6a38
Gerrit-PatchSet: 4
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5478
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cbf72fc50cff29e7c1633ba752cbf15b4b84c58
Gerrit-PatchSet: 4
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5477
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I559ae31d67726845c9699c8b6127e21c6f63ace6
Gerrit-PatchSet: 4
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5507
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I429fe7817f075d0794645d37f5ea11b104102ba0
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5508
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I319945538fd3e3bc5cf3b9d82533641cb8ba5256
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5505
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I674ed61a22fad5cc09c45128dbc73474893aefb6
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5503
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I32b2d08bf25cd2d343755ac8491e4f5f758ccee6
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5506
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I618822e6f2d48adce25f9df5c25acbce7c858412
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5509
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bdf009d3c7e2473dd42da02762039a19430d6ce
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5475
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e0af56a158f25a4f1384d667c03eb20e72df5b8
Gerrit-PatchSet: 4
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5501
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4285b18b152b070c148228604d1e61a8adedba1
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5502
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f274be7d196cd7a5b1ec9ada949130fb06e984d
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: Remove unneeded .py scripts
..
Remove unneeded .py scripts
The ipa.py has been moved to osmo-python-tests as osmo_ipa - use it for
vty and ctrl tests ins
Harald Welte has submitted this change and it was merged.
Change subject: Remove unneeded .py scripts
..
Remove unneeded .py scripts
The ipa.py has been moved to osmo-python-tests as osmo_ipa - use it for
vty and ctrl tests ins
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5512
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ef4ca790878921a5846f64942a8de8a6ff9c11c
Gerrit-PatchSet: 2
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerri
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5478
to look at the new patch set (#4).
Remove bogus MM INFO configuration
The network name and other MM INFO is controlled by the MSC, not the BSC.
Change-Id: I1cbf72fc50cff29e7c1633ba752c
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5476
to look at the new patch set (#4).
Remove unused RRLP options/codec
RRLP is handled in OsmoMSC after the split from NITB, so let's remove
any bogus VTY commands left over in the BSC.
C
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5477
to look at the new patch set (#4).
Remove bogus vty config for LU reject cause
The LU reject cause (like anything MM related) is under control of
OsmoMSC, not BSC.
Change-Id: I559ae31d
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5475
to look at the new patch set (#4).
Remove dead code left over from NITB split
There still is a lot of dead code that we inherited from the NITB
days, let's remove more of it.
libtrau w
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5512
to look at the new patch set (#2).
Remove unneeded .py scripts
The ipa.py has been moved to osmo-python-tests as osmo_ipa - use it for
vty and ctrl tests instead of local copy. The soap
Patch Set 2:
How to reproduce the issues you mention in commit log?
--
To view, visit https://gerrit.osmocom.org/5492
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I40a37b212274cb70ebb1e1d9d1b3743eb2d64d05
Gerrit-PatchSet: 2
Gerrit-Proj
remove libosmo-sccp dependency for osmo-bsc
libosmo-sccp is the old sccp-lite-focused SCCP implementation that we
used before libosmo-sigtran was created. The new osmo-bsc in this
repository is using libosmo-sigtran and shouldn't be using parts of
libosmo-sccp anymore.
We only keep it around in
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5479
to look at the new patch set (#3).
Remove some more dead code
Change-Id: I919bffe88babd90227c89abd4434322965c32ebb
---
M include/osmocom/bsc/gsm_data.h
M include/osmocom/bsc/gsm_data_sh
cosmetic: Hide all accesses to conn->bts behind conn_get_bts()
This is a new inline function that hides all accesses to conn->bts.
A follow-up patch will then point this to conn->lchan->ts->trx->bts
to get rid of the bts field.
Change-Id: Ib6cf7097ced34eebe80441c29ab1534f21956a33
---
M include/
remove obsolete gsm_subscriber_connection.bts member
This member was merely a cache for conn->lchan->ts->trx->bts,
so let's avoid having to keep copies of the same data (which needs
to be kept up to date).
Change-Id: Id3bff8b18425ef5d45eb460ac9eb620023013ba0
---
M include/osmocom/bsc/gsm_data.h
osmo_bsc_bssap.c: Spelling fixes in comment
Change-Id: I32b2d08bf25cd2d343755ac8491e4f5f758ccee6
---
M src/osmo-bsc/osmo_bsc_bssap.c
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/03/5503/2
diff --git a/src/osmo-bsc/osmo_bsc_bssa
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5477
to look at the new patch set (#3).
Remove bogus vty config for LU reject cause
The LU reject cause (like anything MM related) is under control of
OsmoMSC, not BSC.
Change-Id: I559ae31d
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5478
to look at the new patch set (#3).
Remove bogus MM INFO configuration
The network name and other MM INFO is controlled by the MSC, not the BSC.
Change-Id: I1cbf72fc50cff29e7c1633ba752c
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5476
to look at the new patch set (#3).
Remove unused RRLP options/codec
RRLP is handled in OsmoMSC after the split from NITB, so let's remove
any bogus VTY commands left over in the BSC.
C
remove unused 'lac' member of 'struct gsm_subscriber_connection'
This field was used in write-pnly mode, i.e. set but never read.
Change-Id: I319945538fd3e3bc5cf3b9d82533641cb8ba5256
---
M include/osmocom/bsc/gsm_data.h
M src/libbsc/bsc_api.c
2 files changed, 0 insertions(+), 3 deletions(-)
bsc_test.c: Use proper network/bts/lchan structures
don't mock them, simply call the respective functions to get
a gsm_network and a gsm_bts with all its subordinate members.
Change-Id: I8bdf009d3c7e2473dd42da02762039a19430d6ce
---
M tests/bsc/bsc_test.c
1 file changed, 4 insertions(+), 5 deleti
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5507
to look at the new patch set (#2).
gsm_data.h: Document all fields of gsm_subscriber_connection
Change-Id: I429fe7817f075d0794645d37f5ea11b104102ba0
---
M include/osmocom/bsc/gsm_data.h
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5475
to look at the new patch set (#3).
Remove dead code left over from NITB split
There still is a lot of dead code that we inherited from the NITB
days, let's remove more of it.
libtrau w
more remove
Change-Id: Ibc4b8f3776c35df7e81252efb78ec740a371de7f
---
M include/osmocom/bsc/osmo_bsc.h
1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/04/5504/2
diff --git a/include/osmocom/bsc/osmo_bsc.h b/include/osmocom/bsc/osmo
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5505
to look at the new patch set (#2).
osmo_bsc.h: document every field in 'struct osmo_bsc_sccp_con'
Change-Id: I674ed61a22fad5cc09c45128dbc73474893aefb6
---
M include/osmocom/bsc/osmo_bsc
osmo-bsc: Move user plane/voice related bits into sub-structure
This clarifies which members of the struct are for what.
Change-Id: I618822e6f2d48adce25f9df5c25acbce7c858412
---
M include/osmocom/bsc/osmo_bsc.h
M src/osmo-bsc/osmo_bsc_api.c
M src/osmo-bsc/osmo_bsc_audio.c
M src/osmo-bsc/osmo_bsc
Review at https://gerrit.osmocom.org/5512
Remove unneeded .py scripts
The ipa.py has been moved to osmo-python-tests as osmo_ipa - use it for
vty and ctrl tests instead of local copy. The soap.py and twisted_ipa.py
are not SGSN-specific: leftovers from repository split which are now
available i
Review at https://gerrit.osmocom.org/5511
remove obsolete gsm_subscriber_connection.bts member
This member was merely a cache for conn->lchan->ts->trx->bts,
so let's avoid having to keep copies of the same data (which needs
to be kept up to date).
Change-Id: Id3bff8b18425ef5d45eb460ac9eb620023
Review at https://gerrit.osmocom.org/5504
more remove
Change-Id: Ibc4b8f3776c35df7e81252efb78ec740a371de7f
---
M include/osmocom/bsc/osmo_bsc.h
1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/04/5504/1
diff --git a/include/osmoc
Review at https://gerrit.osmocom.org/5505
osmo_bsc.h: document every field in 'struct osmo_bsc_sccp_con'
Change-Id: I674ed61a22fad5cc09c45128dbc73474893aefb6
---
M include/osmocom/bsc/osmo_bsc.h
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc
Review at https://gerrit.osmocom.org/5506
osmo-bsc: Move user plane/voice related bits into sub-structure
This clarifies which members of the struct are for what.
Change-Id: I618822e6f2d48adce25f9df5c25acbce7c858412
---
M include/osmocom/bsc/osmo_bsc.h
M src/osmo-bsc/osmo_bsc_api.c
M src/osmo-
Review at https://gerrit.osmocom.org/5508
remove unused 'lac' member of 'struct gsm_subscriber_connection'
This field was used in write-pnly mode, i.e. set but never read.
Change-Id: I319945538fd3e3bc5cf3b9d82533641cb8ba5256
---
M include/osmocom/bsc/gsm_data.h
M src/libbsc/bsc_api.c
2 files c
Review at https://gerrit.osmocom.org/5510
cosmetic: Hide all accesses to conn->bts behind conn_get_bts()
This is a new inline function that hides all accesses to conn->bts.
A follow-up patch will then point this to conn->lchan->ts->trx->bts
to get rid of the bts field.
Change-Id: Ib6cf7097ced
Review at https://gerrit.osmocom.org/5507
gsm_data.h: Document all fields of gsm_subscriber_connection
Change-Id: I429fe7817f075d0794645d37f5ea11b104102ba0
---
M include/osmocom/bsc/gsm_data.h
1 file changed, 14 insertions(+), 8 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc
Review at https://gerrit.osmocom.org/5509
bsc_test.c: Use proper network/bts/lchan structures
don't mock them, simply call the respective functions to get
a gsm_network and a gsm_bts with all its subordinate members.
Change-Id: I8bdf009d3c7e2473dd42da02762039a19430d6ce
---
M tests/bsc/bsc_test
Review at https://gerrit.osmocom.org/5502
remove libosmo-sccp dependency for osmo-bsc
libosmo-sccp is the old sccp-lite-focused SCCP implementation that we
used before libosmo-sigtran was created. The new osmo-bsc in this
repository is using libosmo-sigtran and shouldn't be using parts of
libo
Review at https://gerrit.osmocom.org/5503
osmo_bsc_bssap.c: Spelling fixes in comment
Change-Id: I32b2d08bf25cd2d343755ac8491e4f5f758ccee6
---
M src/osmo-bsc/osmo_bsc_bssap.c
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/03/550
Review at https://gerrit.osmocom.org/5501
Remove unneeded .py scripts
The ipa.py has been moved to osmo-python-tests as osmo_ipa - use it for
vty and ctrl tests instead of local copy. The soap.py and twisted_ipa.py
are not BSC-specific: leftovers from repository split which are now
available in
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4980
to look at the new patch set (#14).
mgcp: use osmo-mgw to switch rtp streams
in the current implementation we still use osmo-bsc_mgcp, which
has many problems and is also
Review at https://gerrit.osmocom.org/5498
iu: iu_helpers: add functions to decode ip/port from rab-ass
add ranap_transp_assoc_decode() to decode the port information from
an RANAP_IuTransportAssociation_t field.
add ranap_transp_layer_addr_decode() to decode the ip-address from
an RANAP_Trans
Review at https://gerrit.osmocom.org/5499
ranap_msg_factory: check IE encoder return codes
in many functions, the returncode (rc) from the IE encoder functions
is not checked.
Add a return code check and log error message (like it is already
done in the functions which already check the return
Review at https://gerrit.osmocom.org/5500
ranap_msg_factory: remove unusued variable
remove variable i in ranap_new_msg_sec_mod_compl() as it is not
used (compiler warning)
Change-Id: I93d9e95109fb78bc6cc161745b9e14de8b623d4f
---
M src/ranap_msg_factory.c
1 file changed, 1 insertion(+), 1 dele
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5496
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie536d61c5af89a530533b22d8ecab1c804a38289
Gerrit-PatchSet: 1
Gerrit-Project: python/osmo-python-tests
Gerrit-Branc
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5493
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I880c8afa8d02ef112a80cb54f649ec71902bbd4c
Gerrit-PatchSet: 1
Gerrit-Project: python/osmo-python-tests
Gerrit-Branc
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5483
to look at the new patch set (#3).
Ignore compilation byproducts
Change-Id: Ic04a1b9411b851547ef7ce7a9b562cb290081ca9
---
M .gitignore
1 file changed, 3 insertions(+), 0 deletions(-)
1 - 100 of 125 matches
Mail list logo