Patch Set 4: (1 comment)
https://gerrit.osmocom.org/#/c/4893/4/src/osmo_ss7.c File src/osmo_ss7.c: Line 1792: osmo_ss7_xua_server_create(struct osmo_ss7_instance *inst, enum osmo_ss7_asp_protocol proto, > to keep the public API backwards compatible, you should rather introduce os We don't need changes anywhere else because the only direct user of this API is osmo-stp which resides in this same repository and its implementation is fixed in the same code. Other users like osmo-msc or osmo-bsc, afaik, use the "simple_server" API, whose implementation is also fixed internally in this commit to bind the IPs after creating the server, which means no code or VTY change is needed for projects using the "simple_server" API. -- To view, visit https://gerrit.osmocom.org/4893 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79738963d633bec70705ff159c5b2127cd498aa2 Gerrit-PatchSet: 4 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-HasComments: Yes
