Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5651
to look at the new patch set (#3).
Fix RAI construction
The gsm48_construct_ra() expect 6-byte buffer while ra_id.digits is
3-byte buffer. The function fills in LAC and RAC as well so
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5651
to look at the new patch set (#2).
Fix RAI construction
The gsm48_construct_ra() expect 6-byte buffer while ra_id.digits is
3-byte buffer. The function fills in LAC and RAC as well so
Review at https://gerrit.osmocom.org/5651
Fix RAI construction
The gsm48_construct_ra() expect 6-byte buffer while ra_id.digits is
3-byte buffer. The function fills in LAC and RAC as well so we should
pass entire struct, not just 'digits' part which only store MCC/MNC.
Change-Id:
Review at https://gerrit.osmocom.org/5649
Use existing function to obtain TSC
Change-Id: I209f26b527a41b3b6f8e405f2a21b3d4bc4746fb
---
M src/common/pcu_sock.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/49/5649/1
diff --git
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5645
to look at the new patch set (#2).
Update license notes
* replace references to OpenBTS with OsmoTRX
* drop trademark notice
* drop outdated example
Change-Id:
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4980
to look at the new patch set (#17).
mgcp: use osmo-mgw to switch rtp streams
in the current implementation we still use osmo-bsc_mgcp, which
has many problems and is
Review at https://gerrit.osmocom.org/5648
cosmetic: mgcp: remove duplicate logging
do not print an additional log lines when the mgcp FSM gets
halted. This is already done by osmo-fsm
Change-Id: I5aebbcacb68eab3c6afb19991dbf63a02524e4d7
---
M src/osmo-bsc/osmo_bsc_mgcp.c
1 file changed, 0
Max has submitted this change and it was merged.
Change subject: Update legal disclaimer
..
Update legal disclaimer
* drop trademark passage
* add link to OpenBTS website and corresponding attribution
* replace OpenBTS
Max has submitted this change and it was merged.
Change subject: Remove unused headers
..
Remove unused headers
Change-Id: Idadb17aeb85b011d114ffc1d81c920544bac1989
---
M CommonLibs/VectorTest.cpp
M
Max has submitted this change and it was merged.
Change subject: Remove outdated references to OpenBTS
..
Remove outdated references to OpenBTS
Change-Id: I2df613bf59af28e2f44a520d0ee953932bcf4d7e
---
M AUTHORS
1 file changed,
Max has submitted this change and it was merged.
Change subject: Update installation instructions
..
Update installation instructions
* remove references to OpenBTS
* update URLs
* remove unnecessary requirements
Change-Id:
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5340
to look at the new patch set (#4).
TBF: move window parameters to UL/DL level
The UL and DL TBF use different classes implementing window
management. Hence it's better to
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5337
to look at the new patch set (#4).
TBF-UL: add simpler test helper
Add function to set both V_R and V_Q values to 0 which is useful for TBF
test.
Change-Id:
Patch Set 1:
> I have not dropped it, I've moved it to readme - if I understood it
> correctly, it's not part of the actual license, just clarification
> comment. If so, than readme seemsl ike a better place to avoid
> confusion between actual license terms and related explanations.
A GPLv3
Max has submitted this change and it was merged.
Change subject: Mark release target as virtual
..
Mark release target as virtual
Change-Id: Iee747faa3171663f1874a5eacddd56607de55297
---
M Makefile.am
1 file changed, 2
Review at https://gerrit.osmocom.org/5647
Update path to ctrl scripts
Change-Id: Ib95e1ad33bbf115c8190f97210925549e6dc081a
Related: OS#2550
---
M common/chapters/control_if.adoc
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals
Patch Set 1:
I have not dropped it, I've moved it to readme - if I understood it correctly,
it's not part of the actual license, just clarification comment. If so, than
readme seemsl ike a better place to avoid confusion between actual license
terms and related explanations.
--
To view,
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5625
to look at the new patch set (#2).
MNCC: Add MNCC to string dumper
As MNCC is rather hard to debug (wireshark cannot trace UNIX domain
sockets), let's add our own decoder that we can
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5646
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia40df831649cdb68898db9ca77868c422a8d631d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/5645/1/COPYING
File COPYING:
PS1, Line 676:
:
:
:
:
:
:
:
:
:
:
:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5644
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ec26beaaa74dd3d98f27d110055a8f0cdd3c991
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5643
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idadb17aeb85b011d114ffc1d81c920544bac1989
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5641
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee747faa3171663f1874a5eacddd56607de55297
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5642
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2df613bf59af28e2f44a520d0ee953932bcf4d7e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/5645
Update license notes
* move clarification passages to README
* replace references to OpenBTS with OsmoTRX
* rearrange paragraphs for easier reading
* drop trademark notice
Change-Id: I144f96c507bfe48df350fb0350edbeba87126462
Related: OS#2600
---
M
Review at https://gerrit.osmocom.org/5644
Update installation instructions
* remove references to OpenBTS
* update URLs
* remove unnecessary requirements
Change-Id: I6ec26beaaa74dd3d98f27d110055a8f0cdd3c991
Related: OS#2600
---
M INSTALLATION
1 file changed, 5 insertions(+), 13 deletions(-)
Review at https://gerrit.osmocom.org/5646
Update legal disclaimer
* drop trademark passage
* add link to OpenBTS website and corresponding attribution
* replace OpenBTS references with OsmoTRX
Change-Id: Ia40df831649cdb68898db9ca77868c422a8d631d
Related: OS#2600
---
M LEGAL
1 file changed, 7
Review at https://gerrit.osmocom.org/5643
Remove unused headers
Change-Id: Idadb17aeb85b011d114ffc1d81c920544bac1989
---
M CommonLibs/VectorTest.cpp
M Transceiver52M/Channelizer.cpp
M Transceiver52M/Synthesis.cpp
M Transceiver52M/USRPDevice.cpp
4 files changed, 1 insertion(+), 8 deletions(-)
Review at https://gerrit.osmocom.org/5641
Mark release target as virtual
Change-Id: Iee747faa3171663f1874a5eacddd56607de55297
---
M Makefile.am
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/41/5641/1
diff --git a/Makefile.am
Review at https://gerrit.osmocom.org/5642
Remove outdated references to OpenBTS
Change-Id: I2df613bf59af28e2f44a520d0ee953932bcf4d7e
---
M AUTHORS
1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/42/5642/1
diff --git a/AUTHORS
Review at https://gerrit.osmocom.org/5640
Use 127.0.0.1 for GSMTAP logging by default
Previously the were no default value provided in case of unspecified
hostname in "log gsmtap" vty config. This leads to confusing log
messages because NULL was used as a hostname:
Inconsistent indentation --
Review at https://gerrit.osmocom.org/5639
Describe gsmtap log destination
Change-Id: If34e1640d1033daacc955f4285013b8c1be644d2
Fixes: OS#2608
---
M common/chapters/logging.adoc
1 file changed, 21 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals
daniel has submitted this change and it was merged.
Change subject: libdbi: Add version 0.9.0 to fix osmo-msc build failure
..
libdbi: Add version 0.9.0 to fix osmo-msc build failure
A patch is needed to fix compilation:
*
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5283
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7416b4118e5b73c6ffb98e3546bc62a36c7a967a
Gerrit-PatchSet: 6
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
dexter has submitted this change and it was merged.
Change subject: client: mgcp_response_parse_params: check rtp port
..
client: mgcp_response_parse_params: check rtp port
Also check the port number for plausibility like we
Max has submitted this change and it was merged.
Change subject: window: move encoding into functions
..
window: move encoding into functions
* move window size encoding and writing into separate functions
* introduce
Max has submitted this change and it was merged.
Change subject: TBF-DL: mark rcvd_dl_ack() parameters as boolean
..
TBF-DL: mark rcvd_dl_ack() parameters as boolean
The final(_ack) parameter of rcvd_dl_ack() only used as
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5340
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b55aa8947db65f7206adcf53ea32b74a831d9e6
Gerrit-PatchSet: 3
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5338
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If7aa72f5aa66c5e9c255542c066b5494c098aab2
Gerrit-PatchSet: 3
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/5337/3/src/rlc.h
File src/rlc.h:
Line 346: void reset_v_x();
if it resets V and Q, why is the function called reset_v_x ?
--
To view, visit https://gerrit.osmocom.org/5337
To unsubscribe, visit https://gerrit.osmocom.org/settings
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5339
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc4d68f049a45d4b42c5594f50594ff0d44c1bac
Gerrit-PatchSet: 3
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 2: Code-Review+1
re-instating Vadim's +1 after fixing typo
--
To view, visit https://gerrit.osmocom.org/5634
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7b474138444f0ceea160f74df4b693030ea07a8
Gerrit-PatchSet: 2
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5618
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4319c595a1ccb20c87d86c1ab1e58e95da34d7b
Gerrit-PatchSet: 3
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Harald Welte has submitted this change and it was merged.
Change subject: Remove obsolete ./configure option
..
Remove obsolete ./configure option
The '--enable-vty-tests' is just alias to '--enable-external-tests'
anyway.
Harald Welte has submitted this change and it was merged.
Change subject: Fix llc_queue_size() type
..
Fix llc_queue_size() type
It either returns 0 or LLC queue size() which has size_t return
type. This means it can never be
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5626
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a6e849d349ab12854976bd0d68537a370a9c83d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5605
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9492d8e988b464aa41f572611cbf2461bb8be3eb
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/5638
Remove BSC-specific parts
The dead code is from before repo-split time.
Change-Id: I9d4ee8d55a4096bf47407c7d2bdbf3063bf1666e
---
M include/osmo-bts/gsm_data_shared.h
M src/common/gsm_data_shared.c
2 files changed, 1 insertion(+), 108 deletions(-)
Patch Set 3: Verified+1
--
To view, visit https://gerrit.osmocom.org/5618
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4319c595a1ccb20c87d86c1ab1e58e95da34d7b
Gerrit-PatchSet: 3
Gerrit-Project: meta-telephony
Gerrit-Branch: 201705
Patch Set 2:
(4 comments)
https://gerrit.osmocom.org/#/c/5618/1/recipes-misc/libdbi/files/fix-0.9.0-compile.patch
File recipes-misc/libdbi/files/fix-0.9.0-compile.patch:
Line 8: + SQLITE3_LIBS=-lsqlite3
> Please provide somewhere a reference explaining that this is a backport com
50 matches
Mail list logo
