Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6231
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d5b63909eef3d592aec6d51452f3b1811d8cc07
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6230
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e3064f4c3c4c7af5d3491f850090516e541f4d3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6222
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5099abe68b580c75b47bc797bf93f01084f0c4db
Gerrit-PatchSet: 1
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6006
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I921d9bbe58be1c3298e164a37f3c974880b3759f
Gerrit-PatchSet: 2
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: protocol: check the packetization in local cx options
..
protocol: check the packetization in local cx options
When the local connection options in an
Harald Welte has submitted this change and it was merged.
Change subject: bsc: reduce code duplication; add new test case on too short
messages
..
bsc: reduce code duplication; add new test case on too short messages
Harald Welte has submitted this change and it was merged.
Change subject: client: fix sdp parameter ordering
..
client: fix sdp parameter ordering
The parameter ordering of the client responses does not match the
ordering as
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6228
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8232ee58c14a4358a01b5428ff2b4e559491b185
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6217
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63cac2ebc982ffead92703c22bf68c7aafa7936c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: client: prohibit endpoint ids without @ character
..
client: prohibit endpoint ids without @ character
The function mgcp_msg_gen() does only check if
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6007
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id778181a40638bce15c6f085841c35c1895d2602
Gerrit-PatchSet: 2
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: remove spaces from pointer symbol
..
cosmetic: remove spaces from pointer symbol
Change-Id: Id778181a40638bce15c6f085841c35c1895d2602
---
M
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6220
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6073419a4b6cdcd31880672564f0861cb4bd02f5
Gerrit-PatchSet: 1
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: client: Do not accept endpoint ids with wildcards in responses
..
client: Do not accept endpoint ids with wildcards in responses
When the client gets a
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6219
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic94bd8c025b7b3eb006b639fecfd7282194e504a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6218
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02aaa3042f2a0e32eb4ec6b8753deab7082947a0
Gerrit-PatchSet: 1
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6229
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f81b955567d2a33ead350ed312c4c4f6dd7ed8a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6221
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I92dd1556e4a26b4bef8e1c8c57141552abf988ca
Gerrit-PatchSet: 1
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/6234
WIP.. figure out asyncio..
Change-Id: If00263c251d7f5ff3b33bf4fadbfcc4bf53bb0f2
---
A TODO
M src/osmo_ms_driver/__main__.py
M src/osmo_ms_driver/event_server.py
M src/osmo_ms_driver/starter.py
M src/osmo_ms_driver/ul_test.py
5 files changed, 29
Review at https://gerrit.osmocom.org/6230
Create a cumulative distribution function class
We are using the CDF to decide which percentage of the jobs should
be running at a given point. The x-axis is time and the y-axis the
percentage of how many jobs should be running.
There are three
Review at https://gerrit.osmocom.org/6231
cdf: Add API to scale percent to target value
We want to start 10k of instances and it is easier to
have the necessary conversion from percent to number
in the CDF function.
Change-Id: I9d5b63909eef3d592aec6d51452f3b1811d8cc07
---
M
Review at https://gerrit.osmocom.org/6232
WIP.. add example test script and support library
Change-Id: Ica5aa0c2f86d0e5d8a2bc4dc0652de18762dd156
---
A src/osmo_ms_driver/lua/json.lua
A src/osmo_ms_driver/lua/ms_support.lua
A src/osmo_ms_driver/templates/ms_lu_test.lua.tmpl
3 files changed, 426
Review at https://gerrit.osmocom.org/6228
bsc: reduce code duplication; add new test case on too short messages
Change-Id: I8232ee58c14a4358a01b5428ff2b4e559491b185
---
M bsc/BSC_Tests.ttcn
M library/L3_Templates.ttcn
2 files changed, 78 insertions(+), 45 deletions(-)
git pull
Review at https://gerrit.osmocom.org/6229
bsc: Add TC_err_84_unknown_msg to check if unknown RR message triggers RR STATUS
... as declared in TS 24.008 Section 8.4
Change-Id: I4f81b955567d2a33ead350ed312c4c4f6dd7ed8a
---
M bsc/BSC_Tests.ttcn
1 file changed, 22 insertions(+), 0 deletions(-)
Harald Welte has submitted this change and it was merged.
Change subject: Make sending an SMS to an unknown subscriber B work over SMPP.
..
Make sending an SMS to an unknown subscriber B work over SMPP.
Make the
Harald Welte has submitted this change and it was merged.
Change subject: aoip_smpp: Since recent osmo-msc, we accept all sms in
store mode
..
aoip_smpp: Since recent osmo-msc, we accept all sms in store mode
Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6194
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb5656f3ca93f4343441d90e30fbe904382c44e3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6192
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3d78919568ad9252b4d19c3ddab5068d1c52db2
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: BSC_Tests: fix f_pageing_helper() in case no paging was expected
..
BSC_Tests: fix f_pageing_helper() in case no paging was expected
We have to wait for
Harald Welte has submitted this change and it was merged.
Change subject: bsc: Change expectation in paging tests
..
bsc: Change expectation in paging tests
When we page an unknown/unsupported CellIdentifier format, OsmoBSC
Harald Welte has submitted this change and it was merged.
Change subject: bsc: Add TC_classmark to test RR CLASSMARK -> BSSMAP CLASSMARK
conversion
..
bsc: Add TC_classmark to test RR CLASSMARK -> BSSMAP CLASSMARK conversion
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6215
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I261f948d6054d0c90078c1dd0b2785a967b0a49b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: bsc: Add TC_unsol_ass_compl / unsolicited assignment complete
..
bsc: Add TC_unsol_ass_compl / unsolicited assignment complete
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: BSC_Tests: Implement remaining missing paging tests
..
BSC_Tests: Implement remaining missing paging tests
We now test all of the cell identification
Harald Welte has submitted this change and it was merged.
Change subject: bsc: Add TC_unsol_ho_fail test case for unsolicited handover
failure
..
bsc: Add TC_unsol_ho_fail test case for unsolicited handover failure
Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6225
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd86b5505e1a4fee666287680a20dc235970be93
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6214
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63827aa3c42f77648ecad401b3cc4bae927b3b94
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6227
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib025ee51df54804e9a4241d4fa6107ce49270a5f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6226
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3bd71d77d03cb7eebabdf98ba0bfbafd24ec0ea
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Review at https://gerrit.osmocom.org/6226
bsc: Add TC_unsol_ho_fail test case for unsolicited handover failure
Change-Id: Ic3bd71d77d03cb7eebabdf98ba0bfbafd24ec0ea
---
M bsc/BSC_Tests.ttcn
M library/L3_Templates.ttcn
2 files changed, 47 insertions(+), 0 deletions(-)
git pull
Review at https://gerrit.osmocom.org/6227
bsc: Add TC_unsol_ass_compl / unsolicited assignment complete
Change-Id: Ib025ee51df54804e9a4241d4fa6107ce49270a5f
---
M bsc/BSC_Tests.ttcn
1 file changed, 33 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
Patch Set 1:
Can we get a +2 to this one? Otherwise osmo-gsm-tester is failing in one test
after it was re-enabled. It was verified that when this commit is used together
with 6914, test passes fine.
--
To view, visit https://gerrit.osmocom.org/6192
To unsubscribe, visit
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6216
to look at the new patch set (#2).
bsc: Change expectation in paging tests
When we page an unknown/unsupported CellIdentifier format, OsmoBSC
decides to page on all BTSs to be safe.
Review at https://gerrit.osmocom.org/6225
bsc: Add TC_classmark to test RR CLASSMARK -> BSSMAP CLASSMARK conversion
Related: OS#2902
Change-Id: Idd86b5505e1a4fee666287680a20dc235970be93
---
M bsc/BSC_Tests.ttcn
M bsc/MSC_ConnectionHandler.ttcn
M library/BSSMAP_Templates.ttcn
M
Review at https://gerrit.osmocom.org/6224
Simplify TS alloc: constify max dl slot func
Constify parameters of gprs_alloc_max_dl_slots_per_ms().
Change-Id: Ic90930d98560459eab0054cb9e1625cb99db61c8
Related: OS#2282
---
M src/gprs_rlcmac.h
M src/gprs_rlcmac_ts_alloc.cpp
2 files changed, 2
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6007
to look at the new patch set (#2).
cosmetic: remove spaces from pointer symbol
Change-Id: Id778181a40638bce15c6f085841c35c1895d2602
---
M include/osmocom/mgcp/mgcp_ep.h
1 file changed,
Review at https://gerrit.osmocom.org/6221
client: prohibit endpoint ids without @ character
The function mgcp_msg_gen() does only check if the user supplied
an endpoint name or not. The user may still supply an endpoint
name that does not contain the separator (@) character.
- Refuse to
Review at https://gerrit.osmocom.org/6219
client: Do not accept endpoint ids with wildcards in responses
When the client gets a specific endpoint identifier (Z) in a
MGCP response it just accepts the identifier even when it is
not specific (contsins wildcard characters). In those cases,
the
Review at https://gerrit.osmocom.org/6217
client: fix sdp parameter ordering
The parameter ordering of the client responses does not match the
ordering as proposed by by RFC2327, Chapter 6. SDP Specification
- reorder generated SDP parameters so that they match RFC2327
Change-Id:
Review at https://gerrit.osmocom.org/6218
protocol: check the packetization in local cx options
When the local connection options in an MDCX or CRCX request
are parsed, then the packetization interval is not checked.
- Check if the packetization is a multiple of 20ms
see also TTCN3 test:
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6006
to look at the new patch set (#2).
mgcp: fix use-after-free and add callback for endpoint cleanup
Since we will support multiple different types of endpoints in the
future, all these
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3930
to look at the new patch set (#11).
Simplify TS alloc: split USF/UL allocation
* move USF allocation into separate function
* document USF allocation
This allows to
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3934
to look at the new patch set (#10).
Simplify TS alloc: separate capacity computation
Move TRX capacity computation into separate function and document it.
Change-Id:
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3935
to look at the new patch set (#10).
Simplify TS alloc: move slot check into functions
Move timeslot applicability check outside of nested for loop into
separate functions
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3895
to look at the new patch set (#24).
TS alloc: expand tests log
* restructure code for easier reading
* use consistent formatting for output
* log essential allocation
Hello Harald Welte, Jenkins Builder, Holger Freyther,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3905
to look at the new patch set (#14).
Simplify TS alloc: move slot assignment
Move into separate functions:
* move timeslot reservation
* move UL timeslot
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3906
to look at the new patch set (#16).
Simplify TS alloc: split allocation
* generalize TS allocation and move it into separate function
* move single-slot allocation into
Hello Harald Welte, Jenkins Builder, Holger Freyther,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3929
to look at the new patch set (#12).
Simplify TS alloc: replace debug printer
Replace unreadable recursive debug printer with simpler functions.
Note:
Review at https://gerrit.osmocom.org/6214
BSC_Tests: fix f_pageing_helper() in case no paging was expected
We have to wait for sime time until some RSL paging command would have
arrived, rather than continuing too quickly.
Change-Id: I63827aa3c42f77648ecad401b3cc4bae927b3b94
---
M
Review at https://gerrit.osmocom.org/6216
bsc: Change expectation in paging tets
When we page an unknown/unsupported CellIdentifier format, OsmoBSC
decides to page on all BTSs to be safe. This way we have a chance of
making communication happen, rather than breaking it.
Change-Id:
Review at https://gerrit.osmocom.org/6215
BSC_Tests: Implement remaining missing paging tests
We now test all of the cell identification types specified in BSSMAP,
and also lists with a length != 1 entry.
Change-Id: I261f948d6054d0c90078c1dd0b2785a967b0a49b
---
M bsc/BSC_Tests.ttcn
M
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3935
to look at the new patch set (#9).
Simplify TS alloc: move slot check into functions
Move timeslot applicability check outside of nested for loop into
separate functions
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3913
to look at the new patch set (#11).
Simplify TS alloc: split off RX mask computation
Move computation of RX mask into separate function and document it. This
allows to
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3934
to look at the new patch set (#9).
Simplify TS alloc: separate capacity computation
Move TRX capacity computation into separate function and document it.
Change-Id:
Hello Harald Welte, Jenkins Builder, Holger Freyther,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3905
to look at the new patch set (#13).
Simplify TS alloc: move slot assignment
Move into separate functions:
* move timeslot reservation
* move UL timeslot
Harald Welte has submitted this change and it was merged.
Change subject: ggsn.c: cb_tun_ind: Don't drop packets targeting pdp ctx ll addr
..
ggsn.c: cb_tun_ind: Don't drop packets targeting pdp ctx ll addr
Change-Id:
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6200
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fc97f367ae615cdf0a9501f89419990c2fd4599
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: ggsn.c: cb_tun_ind: log dst addr of packet without pdp ctx
..
ggsn.c: cb_tun_ind: log dst addr of packet without pdp ctx
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: ggsn.c: cb_tun_ind: Convert ifelse to switch statement
..
ggsn.c: cb_tun_ind: Convert ifelse to switch statement
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: tests: null-terminate buffer
..
tests: null-terminate buffer
Initialize temporary buffer with 0 to make sure that it's
null-terminated.
Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6213
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icdde701839e35d3131605ea5a11882af21c8939a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6205
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67c04b056cc5c092d357abbb084b7665f59eaf3a
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: ggsn_tests: Add test case to validate packets forwarded vs
dropped
..
ggsn_tests: Add test case to validate packets forwarded vs dropped
New dependency
Harald Welte has submitted this change and it was merged.
Change subject: ggsn_tests: Add test to validate if different pdp ctx can talk
each other
..
ggsn_tests: Add test to validate if different pdp ctx can talk each other
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6158
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9c6043a6cd3b6622782ec7e7fcd2815101755ba
Gerrit-PatchSet: 5
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Patch Set 5:
as I wrote: "but there's no need to change it now, this is just a notice in
case you end up with this problem again."
--
To view, visit https://gerrit.osmocom.org/6158
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 1:
> Might make sense to permit cleanup_cb=NULL and not call it in that
> case
yes, makes sense. I have changed it now.
--
To view, visit https://gerrit.osmocom.org/6006
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6205
to look at the new patch set (#2).
ggsn_tests: Add test to validate if different pdp ctx can talk each other
It seems due to the current network configuration, pdp v4 ctx can talk
each
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6158
to look at the new patch set (#5).
ggsn_tests: Add test case to validate packets forwarded vs dropped
New dependency is required: titan.ProtocolModules.ICMP
It tests that ICMP echo
Max has submitted this change and it was merged.
Change subject: Simplify TS alloc: internalize TRX check
..
Simplify TS alloc: internalize TRX check
Move TRX check inside local tfi_find_free() wrapper to make main
algorithm
Max has submitted this change and it was merged.
Change subject: TS alloc: print suggested TRX on allocation errors
..
TS alloc: print suggested TRX on allocation errors
If TS allocation fails due to unavailable TFI, print TRX
Patch Set 4:
(1 comment)
https://gerrit.osmocom.org/#/c/6158/4/ggsn_tests/GGSN_Tests.ttcn
File ggsn_tests/GGSN_Tests.ttcn:
Line 1050: [] GTPU.receive(tr_GTPU_GPDU(g_peer_u, ?)) ->
value ud {
> the generally mroe elegant solution would be to "stack" a translation port
I
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6213
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icdde701839e35d3131605ea5a11882af21c8939a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/6213
tests: null-terminate buffer
Initialize temporary buffer with 0 to make sure that it's
null-terminated.
Change-Id: Icdde701839e35d3131605ea5a11882af21c8939a
Fixes: CID149362
---
M tests/CommonLibs/SocketsTest.cpp
1 file changed, 1 insertion(+), 1
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3895
to look at the new patch set (#22).
TS alloc: expand tests log
* restructure code for easier reading
* use consistent formatting for output
* log essential allocation
Hello Harald Welte, Jenkins Builder, Holger Freyther,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3929
to look at the new patch set (#10).
Simplify TS alloc: replace debug printer
Replace unreadable recursive debug printer with simpler functions.
Note:
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3931
to look at the new patch set (#8).
TS alloc: print suggested TRX on allocation errors
If TS allocation fails due to unavailable TFI, print TRX which was
suggested to
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3895
to look at the new patch set (#21).
TS alloc: expand tests log
* restructure code for easier reading
* use consistent formatting for output
* log essential allocation
Hello Harald Welte, Jenkins Builder, Holger Freyther,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3929
to look at the new patch set (#9).
Simplify TS alloc: replace debug printer
Replace unreadable recursive debug printer with simpler functions.
Note: the
Patch Set 5:
(1 comment)
https://gerrit.osmocom.org/#/c/3935/5/src/gprs_rlcmac_ts_alloc.cpp
File src/gprs_rlcmac_ts_alloc.cpp:
Line 712
> is it intentional that we loose those logging / debugging capabilities?
Yes: this code was always disabled anyway because it produce way too much load
on
90 matches
Mail list logo
