osmocom-bb[master]: Import gprsdecode utility from SRLabs

Patch Set 6: (3 comments) https://gerrit.osmocom.org/#/c/5992/6//COMMIT_MSG Commit Message: Line 2: Author: Max > I'm not sure if we should attribute max as author in git, if it's code orig Done https://gerrit.osmocom.org/#/c/5992/6/src/host/gprsdecode/gprs.c File

osmocom-bb[master]: Import gprsdecode utility from SRLabs

Patch Set 6: -Code-Review > Seems like 'authors' file was lost during update, as well as > 'copying' and 'news'. Unless it's intentional of course. The only (as I saw) project, known to use such files, is OsmoTRX. I am not sure they are really important here, moreover some of them are and will

[PATCH] libosmocore[master]: vty: fix 'logging print file' output

Review at https://gerrit.osmocom.org/6284 vty: fix 'logging print file' output In If1bd79026a3c680ccf7587d545d12f7759a998fc, an erratic logging output crept in for an earlier patch state and was merged by accident; fix 'logging print file (0|1|basename)' output. Add value string to map

[MERGED] osmo-mgw[master]: Turn libosmo-mgcp into local, non-installed library

Harald Welte has submitted this change and it was merged. Change subject: Turn libosmo-mgcp into local, non-installed library .. Turn libosmo-mgcp into local, non-installed library This is an internal library simmilar to

osmo-msc[master]: a_iface: correct data type for a.conn_id in gsm_subscriber_c...

Patch Set 2: > Would be nice to add some spec. reference explaining why it's > uint32. Its already merged, but to answer your question: its defined as uint32_t in sccp_helpers.h of libosmo-sccp -- To view, visit https://gerrit.osmocom.org/6191 To unsubscribe, visit

[ABANDON] osmo-ttcn3-hacks[master]: Fix regen_makefile warning

Max has abandoned this change. Change subject: Fix regen_makefile warning .. Abandoned -- To view, visit https://gerrit.osmocom.org/6276 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: abandon

[MERGED] osmo-msc[master]: mgcp: use osmo-mgw to switch rtp streams

Harald Welte has submitted this change and it was merged. Change subject: mgcp: use osmo-mgw to switch rtp streams .. mgcp: use osmo-mgw to switch rtp streams in the current implementation we still use osmo-bsc_mgcp, which has

osmo-mgw[master]: Turn libosmo-mgcp into local, non-installed library

Patch Set 2: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/6270/2/src/osmo-mgw/Makefile.am File src/osmo-mgw/Makefile.am: Line 11:$(LIBOSMOGSM_CFLAGS) \ > this seems non-related to the patch. it is related, like the other hunks. Currently, libosmo-mgcp.so carries a

[MERGED] osmo-ttcn3-hacks[master]: Don't symlink non-existent file

Harald Welte has submitted this change and it was merged. Change subject: Don't symlink non-existent file .. Don't symlink non-existent file Change-Id: I10309f07fb207c027703f0b43a478c152a029b6d --- M bsc-nat/gen_links.sh M

osmo-ttcn3-hacks[master]: Don't symlink non-existent file

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6275 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10309f07fb207c027703f0b43a478c152a029b6d Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: Fix regen_makefile warning

Patch Set 2: Code-Review-1 you cannot do this, as the first file must be the file of the executable you're building. So stating it twice is my hack to ensure this is the case, but it comes with the related warning. A proper solution would be to filter the list of files so that the

[MERGED] osmo-bsc[master]: Add stat items for the BTS's channel load average and T3122.

Harald Welte has submitted this change and it was merged. Change subject: Add stat items for the BTS's channel load average and T3122. .. Add stat items for the BTS's channel load average and T3122. In addition to logging the

osmo-bsc[master]: Add stat items for the BTS's channel load average and T3122.

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6277 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icace0176e8b1d23d7c7b4816f7c67c65312844fa Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmocom-bb[master]: l1ctl_proto.h: define burst indication messages

Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6237 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75e33c38accdf2a0af961c89836c5e7a3a056bda Gerrit-PatchSet: 4 Gerrit-Project: osmocom-bb Gerrit-Branch: master

[MERGED] osmocom-bb[master]: l1ctl_proto.h: define burst indication messages

Harald Welte has submitted this change and it was merged. Change subject: l1ctl_proto.h: define burst indication messages .. l1ctl_proto.h: define burst indication messages One burst indication message carries a single raw

osmocom-bb[master]: Import gprsdecode utility from SRLabs

Patch Set 6: (3 comments) let's fix the copyright statements and then get it merged. https://gerrit.osmocom.org/#/c/5992/6//COMMIT_MSG Commit Message: Line 2: Author: Max I'm not sure if we should attribute max as author in git, if it's code originally from

osmo-msc[master]: WIP: VTY: Add 'show connections' and 'show transactions' com...

Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/6050/1//COMMIT_MSG Commit Message: Line 18: Related: OS#2855 > cosmetic: is it related to https://osmocom.org/issues/2855? Done https://gerrit.osmocom.org/#/c/6050/1/src/libmsc/vty_interface_layer3.c File

osmo-msc[master]: mgcp: use osmo-mgw to switch rtp streams

Patch Set 22: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/4980 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieea9630358b3963261fa1993cf1f3b563ff23538 Gerrit-PatchSet: 22 Gerrit-Project: osmo-msc Gerrit-Branch: master

[PATCH] osmo-msc[master]: WIP: VTY: Add 'show connections' and 'show transactions' com...

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6050 to look at the new patch set (#2). WIP: VTY: Add 'show connections' and 'show transactions' commands It is quite important to have some way of runtime state introspection about the

[MERGED] osmo-bts[master]: Print much more information during 'show lchan'

Harald Welte has submitted this change and it was merged. Change subject: Print much more information during 'show lchan' .. Print much more information during 'show lchan' This adds printing of remote RTP IP/Port, LAPDm SAPI

[MERGED] osmo-trx[master]: Fix whitespace

Harald Welte has submitted this change and it was merged. Change subject: Fix whitespace .. Fix whitespace Change-Id: Icda84caa998614ce6c15d5118f8c5c1568ba9a79 --- M Transceiver52M/UHDDevice.cpp M Transceiver52M/USRPDevice.cpp

osmo-bts[master]: Print much more information during 'show lchan'

Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6281 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4bc47638b7b402aee9344dc912745a9929c37f4 Gerrit-PatchSet: 3 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-msc[master]: a_iface: correct data type for a.conn_id in gsm_subscriber_c...

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6191 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf14d7c9a547c4eeb873975e7dcddef223e7df46 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

osmo-bsc[master]: vty: print RTP IP of lchan if actually bound; print remote (...

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6283 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87840aa0f5b9c04d7736bf5f649142219853711a Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[MERGED] osmo-bsc[master]: vty: print RTP IP of lchan if actually bound; print remote (...

Harald Welte has submitted this change and it was merged. Change subject: vty: print RTP IP of lchan if actually bound; print remote (mgw) IP .. vty: print RTP IP of lchan if actually bound; print remote (mgw) IP Change-Id:

[MERGED] osmo-msc[master]: a_iface: correct data type for a.conn_id in gsm_subscriber_c...

Harald Welte has submitted this change and it was merged. Change subject: a_iface: correct data type for a.conn_id in gsm_subscriber_connection .. a_iface: correct data type for a.conn_id in gsm_subscriber_connection conn_id

osmo-trx[master]: Fix whitespace

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6274 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icda84caa998614ce6c15d5118f8c5c1568ba9a79 Gerrit-PatchSet: 1 Gerrit-Project: osmo-trx Gerrit-Branch: master

[PATCH] osmo-bts[master]: Print much more information during 'show lchan'

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6281 to look at the new patch set (#3). Print much more information during 'show lchan' This adds printing of remote RTP IP/Port, LAPDm SAPI information, MS Timing offset, propagation

[PATCH] osmo-bts[master]: vty: don't print "Bound IP / Port" if it isn't bound [yet]

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6282 to look at the new patch set (#2). vty: don't print "Bound IP / Port" if it isn't bound [yet] Change-Id: I28705b56582d334d568d98a371daa6bb9ef1f625 --- M src/common/vty.c 1 file

[PATCH] osmo-bts[master]: Print much more information during 'show lchan'

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6281 to look at the new patch set (#2). Print much more information during 'show lchan' This adds printing of remote RTP IP/Port, LAPDm SAPI information, MS Timing offset, propagation

[MERGED] osmo-bts[master]: Add 'show (bts|trx|ts|lchan)' commands

Harald Welte has submitted this change and it was merged. Change subject: Add 'show (bts|trx|ts|lchan)' commands .. Add 'show (bts|trx|ts|lchan)' commands This is more or less a 1:1 import from the BSC side commands. Having

[MERGED] osmo-bts[master]: gsm_lchan: remove unused member fields

Harald Welte has submitted this change and it was merged. Change subject: gsm_lchan: remove unused member fields .. gsm_lchan: remove unused member fields Change-Id: Icfc601e664ccf33078955e54b02315085cff20a8 --- M

osmo-msc[master]: a_iface: correct data type for a.conn_id in gsm_subscriber_c...

Patch Set 1: Code-Review+1 Would be nice to add some spec. reference explaining why it's uint32. -- To view, visit https://gerrit.osmocom.org/6191 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf14d7c9a547c4eeb873975e7dcddef223e7df46

osmocom-bb[master]: Import gprsdecode utility from SRLabs

Patch Set 6: Seems like 'authors' file was lost during update, as well as 'copying' and 'news'. Unless it's intentional of course. -- To view, visit https://gerrit.osmocom.org/5992 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

[PATCH] osmo-bsc[master]: vty: print RTP IP of lchan if actually bound; print remote (...

Review at https://gerrit.osmocom.org/6283 vty: print RTP IP of lchan if actually bound; print remote (mgw) IP Change-Id: I87840aa0f5b9c04d7736bf5f649142219853711a --- M src/libbsc/bsc_vty.c 1 file changed, 15 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc

osmo-bts[master]: vty: don't print "Bound IP / Port" if it isn't bound [yet]

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6282 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28705b56582d334d568d98a371daa6bb9ef1f625 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-bts[master]: Print much more information during 'show lchan'

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6281 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4bc47638b7b402aee9344dc912745a9929c37f4 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-bts[master]: Add 'show (bts|trx|ts|lchan)' commands

Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6278 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a596938849a9c84fe6fedcac5d7f71ee97af575 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-bsc[master]: gsm_data_shared.h: Remove unused sacch_deact member field

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6279 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I806b957b7f6fbbb1206d29ceeccd401c98c26990 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bts[master]: gsm_lchan: remove unused member fields

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6280 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icfc601e664ccf33078955e54b02315085cff20a8 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

[MERGED] osmo-bsc[master]: gsm_data_shared.h: Remove unused sacch_deact member field

Harald Welte has submitted this change and it was merged. Change subject: gsm_data_shared.h: Remove unused sacch_deact member field .. gsm_data_shared.h: Remove unused sacch_deact member field Change-Id:

[PATCH] osmo-bts[master]: Add 'show (bts|trx|ts|lchan)' commands

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6278 to look at the new patch set (#2). Add 'show (bts|trx|ts|lchan)' commands This is more or less a 1:1 import from the BSC side commands. Having the commands on the BTS side will allow

[PATCH] osmo-bts[master]: vty: don't print "Bound IP / Port" if it isn't bound [yet]

Review at https://gerrit.osmocom.org/6282 vty: don't print "Bound IP / Port" if it isn't bound [yet] Change-Id: I28705b56582d334d568d98a371daa6bb9ef1f625 --- M src/common/vty.c 1 file changed, 7 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts

[PATCH] osmo-bts[master]: Print much more information during 'show lchan'

Review at https://gerrit.osmocom.org/6281 Print much more information during 'show lchan' This adds print-out of remote RTP IP/Port, LAPDm SAPI information, MS Timing offset, propagation delay, encryption algorithm+state, loopback status and radio link failure counter to the "show lchan"

[PATCH] osmo-bts[master]: gsm_lchan: remove unused member fields

Review at https://gerrit.osmocom.org/6280 gsm_lchan: remove unused member fields Change-Id: Icfc601e664ccf33078955e54b02315085cff20a8 --- M include/osmo-bts/gsm_data_shared.h 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts

osmocom-bb[master]: Import gprsdecode utility from SRLabs

Patch Set 6: Code-Review+1 At this state it looks much better for me ;) Changed the code to use libosmocoding and avoid the code duplication (e.g. CRC, convolutional codes). Regression tests are passing. -- To view, visit https://gerrit.osmocom.org/5992 To unsubscribe, visit

[PATCH] osmocom-bb[master]: l1ctl_proto.h: define burst indication messages

Hello Max, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6237 to look at the new patch set (#4). l1ctl_proto.h: define burst indication messages One burst indication message carries a single raw burst, forwarded to the higher layers from

[PATCH] osmo-bts[master]: Add 'show (bts|trx|ts|lchan)' commands

Review at https://gerrit.osmocom.org/6278 Add 'show (bts|trx|ts|lchan)' commands This is more or less a 1:1 import from the BSC side commands. Having the commands on the BTS side will allow us to expose information that's not visible to the BSC [in upcoming, separate patches]. Change-Id:

osmo-trx[master]: Fix whitespace

Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/6274 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icda84caa998614ce6c15d5118f8c5c1568ba9a79 Gerrit-PatchSet: 1 Gerrit-Project: osmo-trx Gerrit-Branch: master

[PATCH] osmo-bsc[master]: Add stat items for the BTS's channel load average and T3122.

Review at https://gerrit.osmocom.org/6277 Add stat items for the BTS's channel load average and T3122. In addition to logging the current values of a BTS's channel load average and T3122 override, maintain stat items for these values. This allows for plotting these values over time, for

osmo-ttcn3-hacks[master]: Fix regen_makefile warning

Patch Set 2: Code-Review-1 This is likely an issue present in all different subdirs using the regen_makefile.sh stuff, so it makes more sense to uniform all of them and fix it the same way for all in one commit. -- To view, visit https://gerrit.osmocom.org/6276 To unsubscribe, visit

osmo-ttcn3-hacks[master]: Don't symlink non-existent file

Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/6275 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10309f07fb207c027703f0b43a478c152a029b6d Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

[PATCH] osmo-ttcn3-hacks[master]: Fix regen_makefile warning

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6276 to look at the new patch set (#2). Fix regen_makefile warning Having MSC_Tests.ttcn in call to regen-makefile.sh is redundant because it's included into *.ttcn mask which is part of

[PATCH] osmo-ttcn3-hacks[master]: Don't symlink non-existent file

Review at https://gerrit.osmocom.org/6275 Don't symlink non-existent file Change-Id: I10309f07fb207c027703f0b43a478c152a029b6d --- M bsc-nat/gen_links.sh M bsc/gen_links.sh M ggsn_tests/gen_links.sh M gprs_gb/gen_links.sh M hlr/gen_links.sh M mgw/gen_links.sh M msc/gen_links.sh M

osmo-mgw[master]: Turn libosmo-mgcp into local, non-installed library

Patch Set 2: (4 comments) https://gerrit.osmocom.org/#/c/6270/2/src/osmo-mgw/Makefile.am File src/osmo-mgw/Makefile.am: Line 11:$(LIBOSMOGSM_CFLAGS) \ this seems non-related to the patch. Line 28:$(LIBOSMOGSM_LIBS) \ this seems non-related to the patch.

[PATCH] osmo-pcu[master]: Simplify TS alloc: move slot check into functions

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3935 to look at the new patch set (#11). Simplify TS alloc: move slot check into functions Move timeslot applicability check outside of nested for loop into separate functions

[PATCH] osmo-pcu[master]: Simplify TS alloc: split off RX mask computation

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3913 to look at the new patch set (#13). Simplify TS alloc: split off RX mask computation Move computation of RX mask into separate function and document it. This allows to

[PATCH] osmo-pcu[master]: Simplify TS alloc: don't use PDCH for free TFI

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6223 to look at the new patch set (#2). Simplify TS alloc: don't use PDCH for free TFI Don't use PDCH from free TFI lookup routine. This allows for simpler function which can be moved to

[PATCH] osmo-pcu[master]: Simplify TS alloc: replace debug printer

Hello Harald Welte, Jenkins Builder, Holger Freyther, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3929 to look at the new patch set (#13). Simplify TS alloc: replace debug printer Replace unreadable recursive debug printer with simpler functions. Note:

[PATCH] osmo-trx[master]: Add support to set Rx/TxAntenna

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6238 to look at the new patch set (#2). Add support to set Rx/TxAntenna Change-Id: I1735e6ab05a05b0312d6d679b16ebd4a2260fa23 --- M Transceiver52M/UHDDevice.cpp M

[PATCH] osmo-trx[master]: Fix whitespace

Review at https://gerrit.osmocom.org/6274 Fix whitespace Change-Id: Icda84caa998614ce6c15d5118f8c5c1568ba9a79 --- M Transceiver52M/UHDDevice.cpp M Transceiver52M/USRPDevice.cpp M Transceiver52M/USRPDevice.h 3 files changed, 47 insertions(+), 48 deletions(-) git pull

osmo-mgw[master]: Turn libosmo-mgcp into local, non-installed library

Patch Set 2: Code-Review+1 > Patch Set 2: Commit message was updated. -- To view, visit https://gerrit.osmocom.org/6270 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba0a2c9c694e360356ac2ca584e97795281c6198 Gerrit-PatchSet: 2

osmo-trx[master]: Add support to set Rx/TxAntenna

Patch Set 1: > well, we can only consider merging it after you have tested it > successfully in some manual tests (maybe together with martin or > roh to check if the correct output/input is actually used on the RF > side). I'm reworking the commit now to improve/fix some stuff, but I can

osmo-trx[master]: Add support to set Rx/TxAntenna

Patch Set 1: well, we can only consider merging it after you have tested it successfully in some manual tests (maybe together with martin or roh to check if the correct output/input is actually used on the RF side). -- To view, visit https://gerrit.osmocom.org/6238 To unsubscribe, visit

gapk[master]: src/Makefile.am: fix osmo-gapk LDADD dependency

Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/6253 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3fdd1731bd372bbb42fe57981e757386e8ede0f0 Gerrit-PatchSet: 1 Gerrit-Project: gapk Gerrit-Branch: master

[MERGED] libosmocore[master]: GSUP: change osmo_gsup_encode() return type

Max has submitted this change and it was merged. Change subject: GSUP: change osmo_gsup_encode() return type .. GSUP: change osmo_gsup_encode() return type * match return type of osmo_gsup_encode() with osmo_gsup_decode() to

osmo-trx[master]: Add support to set Rx/TxAntenna

Patch Set 1: I agree, using the term TX/RX "path" sounds better to me, but I tried to stick to UHD terminology. > Adding more command-line arguments is in-line with the current > "architecture" but becomes more and more clumsy and cumbersom - at > some point we have to introduce the

osmo-pcu[master]: vty: add commands to show TBF of a certain kind

Patch Set 2: > > Could be one command with (all|pacch|...) > > Sure. What would be advantage of such approach? In case of separate > commands it's trivial 1-liner functions. If we use single command > with parameters than we have to check for parameter value using > switch or if ladder. A

osmo-trx[master]: Add support to set Rx/TxAntenna

Patch Set 1: I find "antenna" confusing, but apparently this is the wording the UHD uses. It's a an input or output port, or maybe connector of the board/device. Whether or not a user attaches an antenna to that (or a PA/LNA/duplexer/attenuator, coaxial distribution network, etc.) is

osmo-msc[master]: Wrap osmo_strlcpy() calls

Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6198 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67b482dedfa11237ac21894fc5930039e12434ab Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master

[MERGED] osmo-msc[master]: Wrap osmo_strlcpy() calls

Harald Welte has submitted this change and it was merged. Change subject: Wrap osmo_strlcpy() calls .. Wrap osmo_strlcpy() calls Using following semantic patch: @@ expression A, B, C; @@ - osmo_strlcpy(A, B, sizeof(A)); +

osmo-bts[master]: vty.c: Remove warning message

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6272 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie277dce00292c8f403b9a2b405efe4429e6af86a Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-bts[master]: octphy: octpkt.c: Remove unused static functions

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6271 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97c08b66d41ab5902a11a1e989e278c56cdee102 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

[MERGED] osmo-bts[master]: virtual: l1_if.c: Remove unneeded warning message

Harald Welte has submitted this change and it was merged. Change subject: virtual: l1_if.c: Remove unneeded warning message .. virtual: l1_if.c: Remove unneeded warning message Commit 5eb17e28acdd6fba22a1f2e60f4d55aaef18b47a

[MERGED] osmo-bts[master]: octphy: octpkt.c: Remove unused static functions

Harald Welte has submitted this change and it was merged. Change subject: octphy: octpkt.c: Remove unused static functions .. octphy: octpkt.c: Remove unused static functions Change-Id:

[MERGED] osmo-bts[master]: bts-trx: scheduler_trx.c: Fix missing header

Harald Welte has submitted this change and it was merged. Change subject: bts-trx: scheduler_trx.c: Fix missing header .. bts-trx: scheduler_trx.c: Fix missing header It is required for bts_shutdown used in trx_fn_timer_cb,

[MERGED] osmo-bts[master]: vty.c: Remove warning message

Harald Welte has submitted this change and it was merged. Change subject: vty.c: Remove warning message .. vty.c: Remove warning message This warning was included in commit 6d7b78bde165f39dcd9033f0c5386f5699801233 from 2011,

[MERGED] osmo-bts[master]: l1sap.c: l1sap_tch_rts_ind: Remove unused variables

Harald Welte has submitted this change and it was merged. Change subject: l1sap.c: l1sap_tch_rts_ind: Remove unused variables .. l1sap.c: l1sap_tch_rts_ind: Remove unused variables Commit

osmo-bts[master]: Remove unused variables

Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6248 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3fec7e4b337f3ea4d8cd79f4e7261babc34911cb Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master

[MERGED] osmo-bts[master]: Remove unused variables

Harald Welte has submitted this change and it was merged. Change subject: Remove unused variables .. Remove unused variables Change-Id: I3fec7e4b337f3ea4d8cd79f4e7261babc34911cb --- M src/common/l1sap.c M

[MERGED] osmo-bts[master]: gsm_pchan2chan_nr: move warning to pragma message and track ...

Harald Welte has submitted this change and it was merged. Change subject: gsm_pchan2chan_nr: move warning to pragma message and track issue .. gsm_pchan2chan_nr: move warning to pragma message and track issue Take the chance

osmo-bts[master]: virtual: l1_if.c: Remove unneeded warning message

Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6273 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45fe40e3377eac999d1dac5356678195381d94ca Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

[MERGED] osmo-bsc[master]: Make "waiting indicator" of IMMEDIATE ASSIGN REJECT dynamic.

Harald Welte has submitted this change and it was merged. Change subject: Make "waiting indicator" of IMMEDIATE ASSIGN REJECT dynamic. .. Make "waiting indicator" of IMMEDIATE ASSIGN REJECT dynamic. The IMMEDIATE ASSIGN REJECT

osmo-bsc[master]: Make "waiting indicator" of IMMEDIATE ASSIGN REJECT dynamic.

Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6211 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57e38f6d6ba3b23cc6e1f9520b90261dbb1f1cec Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[PATCH] osmo-bsc[master]: Make "waiting indicator" of IMMEDIATE ASSIGN REJECT dynamic.

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6211 to look at the new patch set (#2). Make "waiting indicator" of IMMEDIATE ASSIGN REJECT dynamic. The IMMEDIATE ASSIGN REJECT message contains a wait indicator which tells an MS

osmo-bsc[master]: Make "waiting indicator" of IMMEDIATE ASSIGN REJECT dynamic.

Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/6211/1/src/libbsc/abis_rsl.c File src/libbsc/abis_rsl.c: Line 1791: /* Set all request references and wait indications to the same value. > it might make sense to state explicitly here that the spec requires entries I'll add a

osmocom-bb[master]: Import gprsdecode utility

Patch Set 5: Code-Review-1 (1 comment) > I'll leave it up to vadim. Once vadim is happy, let me know for > some final review and hopefully +2 I'll rewrite the code to use libosmocoding, because I have some experience with it and don't want to see the code duplication. The main idea is to use

osmo-trx[master]: Add support to set Rx/TxAntenna

Patch Set 1: > Regarding to the ws fixes, they are definitely great. > But unrelated to the commit at all. I would prefer > to see them in a separate change... Yes I am planning to do it this week, I pushed it here for comments before leaving to catch my flight for FOSDEM :) -- To view,

[PATCH] osmo-msc[master]: Wrap osmo_strlcpy() calls

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6198 to look at the new patch set (#2). Wrap osmo_strlcpy() calls Using following semantic patch: @@ expression A, B, C; @@ - osmo_strlcpy(A, B, sizeof(A)); + OSMO_STRLCPY_ARRAY(A, B);

[PATCH] osmo-bts[master]: vty.c: Remove warning message

Review at https://gerrit.osmocom.org/6272 vty.c: Remove warning message This warning was included in commit 6d7b78bde165f39dcd9033f0c5386f5699801233 from 2011, and nowadays I only see this command used in osmo-bts, so I think we most probably drop it as it doesn't make sense anymore.

[PATCH] osmo-bts[master]: Remove unused variables

Hello Vadim Yanitskiy, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6248 to look at the new patch set (#2). Remove unused variables Change-Id: I3fec7e4b337f3ea4d8cd79f4e7261babc34911cb --- M src/common/l1sap.c M

[PATCH] osmo-bts[master]: octphy: octpkt.c: Remove unused static functions

Review at https://gerrit.osmocom.org/6271 octphy: octpkt.c: Remove unused static functions Change-Id: I97c08b66d41ab5902a11a1e989e278c56cdee102 --- M src/osmo-bts-octphy/octpkt.c 1 file changed, 0 insertions(+), 32 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts

[MERGED] libosmocore[master]: utils: add helper wrapper for osmo_strlcpy()

Max has submitted this change and it was merged. Change subject: utils: add helper wrapper for osmo_strlcpy() .. utils: add helper wrapper for osmo_strlcpy() Add wrapper for osmo_strlcpy() which uses sizeof() to automatically

osmo-bts[master]: Remove unused variables

Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/6248/1/src/common/rsl.c File src/common/rsl.c: Line 1251 > The Patch looks ok to me, but this line must stay. Its a fix for a nullpoin Hey thanks for pointing it out, I think this change ended inside the patch while playing with git

[PATCH] osmo-mgw[master]: protocol: prohibit wildcarded requests for MDCX and DLCX

Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6260 to look at the new patch set (#4). protocol: prohibit wildcarded requests for MDCX and DLCX When a wildcarded request is made with a DLCX or MDCX command the MGW will

osmo-mgw[master]: client: add an optional FSM interface

Patch Set 10: (8 comments) > Waiting for feedback on dlcx in cleanup question, looks fine > otgherwise Hmm. I have answered. I wonder why gerrit did not flush the draft messages... Hopefully it works this time.

libosmocore[master]: utils: add helper wrapper for osmo_strlcpy()

Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6197 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03d0d3d32a8d572ad573d03c603e14cdc27a3f7b Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master

osmo-mgw[master]: client: add an optional FSM interface

Patch Set 10: Code-Review+1 Waiting for feedback on dlcx in cleanup question, looks fine otgherwise -- To view, visit https://gerrit.osmocom.org/5881 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

[PATCH] libosmocore[master]: utils: add helper wrapper for osmo_strlcpy()

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6197 to look at the new patch set (#2). utils: add helper wrapper for osmo_strlcpy() Add wrapper for osmo_strlcpy() which uses sizeof() to automatically determine buffer's size and use it

[MERGED] osmo-mgw[master]: ep: move endpoint struct and define to mgcp_ep.h

Harald Welte has submitted this change and it was merged. Change subject: ep: move endpoint struct and define to mgcp_ep.h .. ep: move endpoint struct and define to mgcp_ep.h The endpoint and the define that computes the

  1   2   >