[PATCH] libosmocore[master]: add gsm0808_{enc,dec}_cell_id

2018-04-12 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7789 to look at the new patch set (#3). add gsm0808_{enc,dec}_cell_id Clarify semantics and micro-optimise for the case of single Cell Identifer IEs. Test in gsm0808_test.c So far we have

[PATCH] libosmocore[master]: add osmo_cgi_name()

2018-04-12 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7786 to look at the new patch set (#2). add osmo_cgi_name() This will be used by cell idenitifier list code, like upcoming neighbor_ident VTY in osmo-bsc and regression tests. Change-Id:

[PATCH] libosmocore[master]: test_gsm0808_enc_dec_cell_id_list_lac(): validate encoded bytes

2018-04-12 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7790 test_gsm0808_enc_dec_cell_id_list_lac(): validate encoded bytes Change-Id: I81b1ffbe6a5ec566c112492c2cbaf99c018c45bb --- M tests/gsm0808/gsm0808_test.c M tests/gsm0808/gsm0808_test.ok 2 files changed, 9 insertions(+), 8 deletions(-) git pull

[PATCH] libosmocore[master]: test_gsm0808_enc_dec_cell_id_list_lac(): populate all LACs

2018-04-12 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7791 test_gsm0808_enc_dec_cell_id_list_lac(): populate all LACs Change-Id: I7535166a2827c03a954fe72d5d99217e4f25868f --- M tests/gsm0808/gsm0808_test.c M tests/gsm0808/gsm0808_test.ok 2 files changed, 4 insertions(+), 4 deletions(-) git pull

[PATCH] libosmocore[master]: add gsm0808_cell_id_list_add() to combine two cell identifie...

2018-04-12 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7787 add gsm0808_cell_id_list_add() to combine two cell identifier lists This will be used by the upcoming neighbor_ident API in osmo-bsc, where the vty interface allows composing neihbor BSS cell identifier lists, and we want to allow adding individual

[PATCH] libosmocore[master]: add tlv_parse2(), capable of multiple instances of the same IE

2018-04-12 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7788 add tlv_parse2(), capable of multiple instances of the same IE Allow passing multiple struct tlv_parsed in an array, to allow parsing as many repeated IEs as are expected by the caller. >From tlv_parse(), call tlv_parse2() with dec_multiple = 1 to

[PATCH] libosmocore[master]: add gsm0808_{enc,dec}_cell_id

2018-04-12 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7789 add gsm0808_{enc,dec}_cell_id Clarify semantics and micro-optimise for the case of single Cell Identifer IEs. Test in gsm0808_test.c So far we have gsm0808_enc_cell_id_list2(), but there also exist instances of single Cell Identifiers (3GPP TS 48.008

[PATCH] libosmocore[master]: add osmo_cgi_name()

2018-04-12 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7786 add osmo_cgi_name() Change-Id: Iebc5cdf61b697b1603900993fc265af3eca0cedf --- M include/osmocom/gsm/gsm23003.h M src/gsm/gsm23003.c M src/gsm/libosmogsm.map 3 files changed, 22 insertions(+), 0 deletions(-) git pull

[MERGED] osmo-msc[master]: msc conn ref counts: log human readable list of conn owners

2018-04-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: msc conn ref counts: log human readable list of conn owners .. msc conn ref counts: log human readable list of conn owners Change-Id:

osmo-msc[master]: refactor VLR FSM result handling

2018-04-12 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7709 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27bf8d68737ff1f8dc6d11fb1eac3d391aab0cb1 Gerrit-PatchSet: 3 Gerrit-Project: osmo-msc Gerrit-Branch: master

libosmo-netif[master]: jibuf: Add initial implementation of Jitter Buffer

2018-04-12 Thread Harald Welte
Patch Set 1: Code-Review-1 (5 comments) https://gerrit.osmocom.org/#/c/7773/1/include/osmocom/netif/jibuf.h File include/osmocom/netif/jibuf.h: Line 1: #ifndef _JIBUF_H_ we genearlly use "#pragma once" these days. Line 21: struct jibuf { all new data structures and symbols of osmocom

libosmo-netif[master]: tests: jibuf_tool: Initial commit

2018-04-12 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7774 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92307c8b1483dd488339771462290aae0ae5689a Gerrit-PatchSet: 1 Gerrit-Project: libosmo-netif Gerrit-Branch: master

[MERGED] libosmo-netif[master]: osmux: osmux_xfrm_output_pull: Improve checks and log of mal...

2018-04-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmux: osmux_xfrm_output_pull: Improve checks and log of malformed packets .. osmux: osmux_xfrm_output_pull: Improve checks and log of malformed packets

libosmo-netif[master]: osmux: osmux_xfrm_output_pull: Improve checks and log of mal...

2018-04-12 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7783 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I143805bb5ee9f5e3ada46114e380a03ede80df9f Gerrit-PatchSet: 1 Gerrit-Project: libosmo-netif Gerrit-Branch: master

libosmo-netif[master]: tests: osmo-pcap-test: Fix pcap includes not found in old ve...

2018-04-12 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7785 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I824671a415eb3f35f480c934b9780ff13510011a Gerrit-PatchSet: 1 Gerrit-Project: libosmo-netif Gerrit-Branch: master

[MERGED] libosmo-netif[master]: tests: osmo-pcap-test: Fix pcap includes not found in old ve...

2018-04-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: tests: osmo-pcap-test: Fix pcap includes not found in old versions .. tests: osmo-pcap-test: Fix pcap includes not found in old versions pcap/dlt.h

osmo-bsc[master]: fix handling of state changes in acc ramping

2018-04-12 Thread Pau Espin Pedrol
Patch Set 3: Code-Review-1 (5 comments) https://gerrit.osmocom.org/#/c/7784/3/src/libbsc/acc_ramp.c File src/libbsc/acc_ramp.c: Line 182: if (trx_is_usable(trx)) /* cross-check with operational state */ As discussed a few mins ago, when coming from S_NM_STATECHG_OPER

[ABANDON] osmo-ttcn3-hacks[master]: */regen_makefile.sh: drop multiple naming of main ttcn file

2018-04-12 Thread Neels Hofmeyr
Neels Hofmeyr has abandoned this change. Change subject: */regen_makefile.sh: drop multiple naming of main ttcn file .. Abandoned -- To view, visit https://gerrit.osmocom.org/7771 To unsubscribe, visit

osmo-hlr[master]: rewrite subscriber_update_notify() without calls into luop

2018-04-12 Thread Stefan Sperling
Patch Set 2: (6 comments) https://gerrit.osmocom.org/#/c/7743/1/src/hlr.c File src/hlr.c: Line 76:if (peer_len < 0) { > heh, I wasn't actually aware that we keep the GSUP conn peer info in a tlv Yes, now done when we receive a location update. Line 89:

[PATCH] osmo-hlr[master]: rewrite subscriber_update_notify() without calls into luop

2018-04-12 Thread Stefan Sperling
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7743 to look at the new patch set (#2). rewrite subscriber_update_notify() without calls into luop This function relied on implementation details of the luop code. Port what is necessary

Build failed in Jenkins: master-asn1c ยป a1=default,a2=default,a3=default,osmocom-master-debian9 #89

2018-04-12 Thread jenkins
See -- [...truncated 2.08 KB...] + ./configure checking build system type... x86_64-unknown-linux-gnu checking host

[PATCH] libosmo-netif[master]: tests: osmo-pcap-test: Fix pcap includes not found in old ve...

2018-04-12 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7785 tests: osmo-pcap-test: Fix pcap includes not found in old versions pcap/dlt.h only exists on newer versions of libpcap. On older versions, same defines are available in pcap/bpf.h, which in newer versions include pcap/dlt.h, so we are always fine

osmo-hlr[master]: rewrite subscriber_update_notify() without calls into luop

2018-04-12 Thread Neels Hofmeyr
Patch Set 1: (8 comments) This review touches on various topics that are not strictly related to this, especially determining the cn_domain. What I'd like to improve in this patch the most: would it not be easy to factor out the common parts instead of code dup and copy FIXME code around?

[PATCH] osmo-bsc[master]: fix handling of state changes in acc ramping

2018-04-12 Thread Stefan Sperling
fix handling of state changes in acc ramping Take both the operative and administrative states into account when deciding whether to start ACC ramping, and examine old/new state values to avoid triggering ramping for a no-op state change. This requires a fix to gsm_trx_lock_rf(): This function

[PATCH] osmo-bsc[master]: fix handling of state changes in acc ramping

2018-04-12 Thread Stefan Sperling
fix handling of state changes in acc ramping Take both the operative and administrative states into account when deciding whether to start ACC ramping, and examine old/new state values to avoid triggering ramping for a no-op state change. This requires a fix to gsm_trx_lock_rf(): This function

[PATCH] osmo-bsc[master]: fix handling of state changes in acc ramping

2018-04-12 Thread Stefan Sperling
Review at https://gerrit.osmocom.org/7784 fix handling of state changes in acc ramping Take both the operative and administrative states into account when deciding whether to start ACC ramping, and examine old/new state values to avoid triggering ramping for a no-op state change. This

libosmo-netif[master]: jibuf: Add initial implementation of Jitter Buffer

2018-04-12 Thread Pau Espin Pedrol
Patch Set 1: Code-Review-1 Pushed in here as a side effect (wrong branch). Can be reviewed, open for comments, but still shouldn't be merged until further testing is done. -- To view, visit https://gerrit.osmocom.org/7773 To unsubscribe, visit https://gerrit.osmocom.org/settings

[ABANDON] libosmo-netif[master]: osmux: osmux_xfrm_output_pull: Improve checks and log of mal...

2018-04-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has abandoned this change. Change subject: osmux: osmux_xfrm_output_pull: Improve checks and log of malformed packets .. Abandoned -- To view, visit https://gerrit.osmocom.org/7782 To unsubscribe, visit

[PATCH] libosmo-netif[master]: osmux: osmux_xfrm_output_pull: Improve checks and log of mal...

2018-04-12 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7783 osmux: osmux_xfrm_output_pull: Improve checks and log of malformed packets Change-Id: I143805bb5ee9f5e3ada46114e380a03ede80df9f Related: SYS#4182 --- M src/osmux.c 1 file changed, 11 insertions(+), 5 deletions(-) git pull

[PATCH] libosmo-netif[master]: jibuf: Estimate src clock skew

2018-04-12 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7781 jibuf: Estimate src clock skew Change-Id: Ifae633d53107417a8e2f9b0f200d2711db72d199 --- M include/osmocom/netif/jibuf.h M src/jibuf.c M tests/jibuf/jibuf_test.c M tests/jibuf/jibuf_test.ok M tests/jibuf/jibuf_tool.c M tests/jibuf/jitter.plt 6 files

[PATCH] libosmo-netif[master]: tests: jibuf_tool: Add seq.plt

2018-04-12 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7780 tests: jibuf_tool: Add seq.plt Change-Id: I37bb3ab372b7ad7c3c1d09c8134827c932bf8bf8 --- A tests/jibuf/seq.plt 1 file changed, 50 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/80/7780/1 diff --git

[PATCH] libosmo-netif[master]: osmux: osmux_xfrm_output_pull: Improve checks and log of mal...

2018-04-12 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7782 osmux: osmux_xfrm_output_pull: Improve checks and log of malformed packets Related: SYS#4182 Change-Id: I7dc3aa2b699a783d86aa9a9452b9e74084d7a97f --- M src/osmux.c 1 file changed, 11 insertions(+), 5 deletions(-) git pull

[PATCH] libosmo-netif[master]: jibuf: Add initial implementation of Jitter Buffer

2018-04-12 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7773 jibuf: Add initial implementation of Jitter Buffer Change-Id: I9688ba9c4d5b733b9f29d0f15f73750f9271ef55 --- M include/osmocom/netif/Makefile.am A include/osmocom/netif/jibuf.h M src/Makefile.am A src/jibuf.c M tests/Makefile.am A

[PATCH] libosmo-netif[master]: tests: jibuf_tool: Improve jibuf_test to read pcaps

2018-04-12 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7775 tests: jibuf_tool: Improve jibuf_test to read pcaps Change-Id: I7a13c823fb70e0adbc5fa0726fd66b15dc40014e Signed-off-by: Pau Espin Pedrol --- M tests/Makefile.am M tests/jibuf/jibuf_tool.c M tests/jibuf/jitter.plt 3 files changed,

[PATCH] libosmo-netif[master]: tests: jibuf_tool: Add parameters to control size of buffer

2018-04-12 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/ tests: jibuf_tool: Add parameters to control size of buffer Change-Id: I8a7fa39985f8d197e24c32cab80299aba2d03087 --- M tests/jibuf/jibuf_tool.c 1 file changed, 14 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif

[PATCH] libosmo-netif[master]: tests: jibuf_tool: Initial commit

2018-04-12 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7774 tests: jibuf_tool: Initial commit Change-Id: I92307c8b1483dd488339771462290aae0ae5689a --- M tests/Makefile.am A tests/jibuf/jibuf_tool.c A tests/jibuf/jitter.plt 3 files changed, 417 insertions(+), 1 deletion(-) git pull

[PATCH] libosmo-netif[master]: jibuf: Take RTP marker into account

2018-04-12 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7778 jibuf: Take RTP marker into account Change-Id: Ie142acfb45650e0af775f58226fd191beaf8178e --- M src/jibuf.c M tests/jibuf/jibuf_test.c M tests/jibuf/jibuf_test.ok M tests/jibuf/jibuf_tool.c 4 files changed, 90 insertions(+), 5 deletions(-) git pull

[PATCH] libosmo-netif[master]: jibuf: re-sync clock out of sync timestamps

2018-04-12 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7779 jibuf: re-sync clock out of sync timestamps Change-Id: I33556b33d7549654442d9bdd7f31128792506652 --- M src/jibuf.c M tests/jibuf/jibuf_test.c M tests/jibuf/jibuf_test.ok M tests/jibuf/jibuf_tool.c 4 files changed, 152 insertions(+), 7 deletions(-)

[PATCH] libosmo-netif[master]: tests: jibuf_tool: Add OSMUX support

2018-04-12 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7776 tests: jibuf_tool: Add OSMUX support Change-Id: I0f02da0329e6739ff340d31113161bb520b1b760 --- M tests/jibuf/jibuf_tool.c 1 file changed, 42 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/76/7776/1

osmo-bsc[master]: only trigger acc ramping if trx 0 is usable and unlocked

2018-04-12 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7772 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I054829a936f0aa1e3fa34fad6466a1cd6150e307 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-ci[master]: jobs: gerrit-osmo-ttcn3-hacks: Make deps before cleaning

2018-04-12 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7406 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07fee78bba5b07c7f3f4359869e00ef2583e0769 Gerrit-PatchSet: 3 Gerrit-Project: osmo-ci Gerrit-Branch: master

[MERGED] osmo-bsc[master]: only trigger acc ramping if trx 0 is usable and unlocked

2018-04-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: only trigger acc ramping if trx 0 is usable and unlocked .. only trigger acc ramping if trx 0 is usable and unlocked Starting an ACC ramping process

osmo-pcu[master]: tbf: add frame number to log output

2018-04-12 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7730 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a744dc5cd7c1de1baea13fffac026c83d091429 Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcu Gerrit-Branch: master

[ABANDON] osmo-pcu[master]: tbf: hex output of tbf data in log

2018-04-12 Thread dexter
dexter has abandoned this change. Change subject: tbf: hex output of tbf data in log .. Abandoned Its probably not a good idea to clog up the log with hexdumps. -- To view, visit https://gerrit.osmocom.org/7731 To

osmo-bsc[master]: only trigger acc ramping if trx 0 is usable and unlocked

2018-04-12 Thread Stefan Sperling
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/7772/1/src/libbsc/acc_ramp.c File src/libbsc/acc_ramp.c: Line 267: if (trx0 && trx_is_usable(trx0) && trx0->mo.nm_state.administrative == NM_STATE_UNLOCKED) { > I know that we are then enabling ramping when we receive the

[MERGED] osmo-msc[master]: libmsc/ussd: don't overwrite rc if decoding failed

2018-04-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: libmsc/ussd: don't overwrite rc if decoding failed .. libmsc/ussd: don't overwrite rc if decoding failed Change-Id:

osmo-mgw[master]: stats: use libosmocore rate counter for in/out_stream.err_ts...

2018-04-12 Thread Harald Welte
Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/7555/1/include/osmocom/mgcp/mgcp_internal.h File include/osmocom/mgcp/mgcp_internal.h: Line 207: struct rate_ctr_group_desc rate_ctr_group_desc; the rate_ctr_group_desc and rate_ctr_desc should be global data (if not

osmo-ci[master]: jobs: gerrit-osmo-ttcn3-hacks: Make deps before cleaning

2018-04-12 Thread Pau Espin Pedrol
Patch Set 3: ping. Around 2 weeks without review. -- To view, visit https://gerrit.osmocom.org/7406 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07fee78bba5b07c7f3f4359869e00ef2583e0769 Gerrit-PatchSet: 3 Gerrit-Project: osmo-ci

osmo-trx[master]: jenkins.sh: change qemu-img default location to $HOME/qemu-i...

2018-04-12 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6909 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56f314d78c0ca968b1fef9a91ecd540a7cc8fa86 Gerrit-PatchSet: 1 Gerrit-Project: osmo-trx Gerrit-Branch: master

[MERGED] osmo-trx[master]: jenkins.sh: change qemu-img default location to $HOME/qemu-i...

2018-04-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: jenkins.sh: change qemu-img default location to $HOME/qemu-img instead of /opt/qemu-img .. jenkins.sh: change qemu-img default location to

docker-playground[master]: jenkins-common: move workspace to /tmp/jenkins when build ou...

2018-04-12 Thread Harald Welte
Patch Set 1: I don't mind, but I'm also not sure this is what users want? Opinions, please -- To view, visit https://gerrit.osmocom.org/7721 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a139ef2d23dd8115191e51e86ef0346cb97e4cf

docker-playground[master]: Makefile: use $USER/image when depending on a generated image

2018-04-12 Thread Harald Welte
Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/7720 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied42c3e1de9a2ffaca22ba4cd02e6a398e48e97d Gerrit-PatchSet: 2 Gerrit-Project: docker-playground Gerrit-Branch: master

[MERGED] docker-playground[master]: Makefile: use $USER/image when depending on a generated image

2018-04-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Makefile: use $USER/image when depending on a generated image .. Makefile: use $USER/image when depending on a generated image Te make scripts will

[MERGED] docker-playground[master]: add .gitreview

2018-04-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: add .gitreview .. add .gitreview Allows `git review` to automatic setup gerrit Change-Id: I179c02d38496bf3d408020db7f0baf79ee064705 --- A .gitreview 1

[MERGED] osmo-gsm-manuals[master]: jenkins.sh: add hostkey for osmocom.org:48

2018-04-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: jenkins.sh: add hostkey for osmocom.org:48 .. jenkins.sh: add hostkey for osmocom.org:48 Otherwise it will depend on a setting this up in a seperate

osmo-hlr[master]: rewrite subscriber_update_notify() without calls into luop

2018-04-12 Thread Harald Welte
Patch Set 1: leaving this to neels. -- To view, visit https://gerrit.osmocom.org/7743 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06c43ece2b48dc63d599000eb6d6d51e08963067 Gerrit-PatchSet: 1 Gerrit-Project: osmo-hlr Gerrit-Branch:

osmo-ttcn3-hacks[master]: */regen_makefile.sh: drop multiple naming of main ttcn file

2018-04-12 Thread Harald Welte
Patch Set 2: Code-Review-1 > Is there any reason why the main file should be listed first? > Couldn't see any adverse effects in running the BSC tests without > that. At least when I started the TTCN-3 developments, there was. This is why I implemented the regen_makefile the way they are.

osmo-bsc[master]: only trigger acc ramping if trx 0 is usable and unlocked

2018-04-12 Thread Pau Espin Pedrol
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/7772/1/src/libbsc/acc_ramp.c File src/libbsc/acc_ramp.c: Line 267: if (trx0 && trx_is_usable(trx0) && trx0->mo.nm_state.administrative == NM_STATE_UNLOCKED) { I know that we are then enabling ramping when we receive the

[MERGED] osmo-bsc[master]: trigger acc ramping on state-changed-event reports

2018-04-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: trigger acc ramping on state-changed-event reports .. trigger acc ramping on state-changed-event reports Trigger ACC ramping not only when an

osmo-bsc[master]: trigger acc ramping on state-changed-event reports

2018-04-12 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7770 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I097a113a3a63de02bcb8277020beb59cf485b176 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-ttcn3-hacks[master]: */regen_makefile.sh: drop multiple naming of main ttcn file

2018-04-12 Thread Pau Espin Pedrol
Patch Set 2: > Is there any reason why the main file should be listed first? > Couldn't see any adverse effects in running the BSC tests without > that. I had the same question while moving stuff to the build/ dir in https://gerrit.osmocom.org/#/c/7405/ If it's not needed, then +1 for me

[PATCH] osmo-bsc[master]: trigger acc ramping on state-changed-event reports

2018-04-12 Thread Stefan Sperling
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/7770 to look at the new patch set (#2). trigger acc ramping on state-changed-event reports Trigger ACC ramping not only when an Administrative State Change ACK is received from a BTS, but

osmo-bsc[master]: trigger acc ramping on state-changed-event reports

2018-04-12 Thread Stefan Sperling
Patch Set 1: > Please also test with osmo-bts A sysmobts reports TRX lock/unlock only via Change Administrative State ACK. Its State Changed Event Reports only contain information about operational and availability states (as we would expect from reading the GSM spec). Unlike the nanobts, a

[PATCH] osmo-bsc[master]: only trigger acc ramping if trx 0 is usable and unlocked

2018-04-12 Thread Stefan Sperling
Review at https://gerrit.osmocom.org/7772 only trigger acc ramping if trx 0 is usable and unlocked Starting an ACC ramping process while TRX 0 is unusable or locked is pointless. For instance, after loading a config with 'rf_locked 1' for trx 0, the ramping process was started as soon as the